Kayıtlar (commit) · 482d7ce61b423600b41b459eb26a2cc221cd0acf · LibreOffice / core

13 Ara, 2016 18 kayıt (commit)

Caolán McNamara Kas 25, 2016 yazdı

because that works under wayland out of the box and gtk3 uses it already

Change-Id: Iefaac31e325534a81a5389f752804af917c1baef
Reviewed-on: https://gerrit.libreoffice.org/31213Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

482d7ce6

Don't leave WW8AnchorConvResult::m_bConverted uninitialized · 178e38dd

Stephan Bergmann Ara 13, 2016 yazdı

Presumably inadvertently dropped from d505b5d8
"add relative to tablecell as state".  Caused e.g. CppunitTest_sw_globalfilter
to fail under ASan/UBSan with

> sw/source/filter/ww8/wrtw8esh.cxx:2682:21: runtime error: load of value 152, which is not a valid value for type 'bool'
>     #0 0x7f7494a13f8b in WinwordAnchoring::ConvertPosition(SwFormatHoriOrient&, SwFormatVertOrient&, SwFrameFormat const&) sw/source/filter/ww8/wrtw8esh.cxx:2682:21
>     #1 0x7f7494a388e2 in WinwordAnchoring::SetAnchoring(SwFrameFormat const&) sw/source/filter/ww8/wrtw8esh.cxx:2703:32
>     #2 0x7f7494a3ad15 in SwEscherEx::WriteFrameExtraData(SwFrameFormat const&) sw/source/filter/ww8/wrtw8esh.cxx:2830:23
>     #3 0x7f7494a2b00b in SwBasicEscherEx::WriteGrfFlyFrame(SwFrameFormat const&, unsigned int) sw/source/filter/ww8/wrtw8esh.cxx:1737:5
>     #4 0x7f7494a361d4 in SwEscherEx::WriteFlyFrame(DrawObj const&, unsigned int&, std::__debug::vector<DrawObj*, std::allocator<DrawObj*> >&) sw/source/filter/ww8/wrtw8esh.cxx:2854:28
>     #5 0x7f7494a33a33 in SwEscherEx::SwEscherEx(SvStream*, WW8Export&) sw/source/filter/ww8/wrtw8esh.cxx:2346:36
>     #6 0x7f7494a24b3b in WW8Export::CreateEscher() sw/source/filter/ww8/wrtw8esh.cxx:1510:25
>     #7 0x7f7494c33c40 in WW8Export::StoreDoc1() sw/source/filter/ww8/wrtww8.cxx:2950:5
>     #8 0x7f7494c3eb83 in WW8Export::ExportDocument_Impl() sw/source/filter/ww8/wrtww8.cxx:3304:5
>     #9 0x7f7494c39335 in MSWordExportBase::ExportDocument(bool) sw/source/filter/ww8/wrtww8.cxx:3139:5
>     #10 0x7f7494c45150 in SwWW8Writer::WriteStorage() sw/source/filter/ww8/wrtww8.cxx:3468:17
>     #11 0x7f752cb38d3b in StgWriter::Write(SwPaM&, SotStorage&, rtl::OUString const*) sw/source/filter/writer/writer.cxx:512:22
>     #12 0x7f752cb33863 in Writer::Write(SwPaM&, SvStream&, rtl::OUString const*) sw/source/filter/writer/writer.cxx:255:23
>     #13 0x7f7494c45ad7 in SwWW8Writer::Write(SwPaM&, SfxMedium&, rtl::OUString const*) sw/source/filter/ww8/wrtww8.cxx:3485:33
>     #14 0x7f752c80c3d0 in SwWriter::Write(tools::SvRef<Writer>&, rtl::OUString const*) sw/source/filter/basflt/shellio.cxx:867:28
>     #15 0x7f752ccfcd6c in SwDocShell::ConvertTo(SfxMedium&) sw/source/uibase/app/docsh.cxx:756:27
>     #16 0x7f75048bddd4 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) sfx2/source/doc/objstor.cxx:1542:19
>     #17 0x7f75048d83c6 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet&) sfx2/source/doc/objstor.cxx:2813:39
>     #18 0x7f75048d5c07 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) sfx2/source/doc/objstor.cxx:2683:9
>     #19 0x7f7504897ea5 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) sfx2/source/doc/objserv.cxx:310:19
>     #20 0x7f750498e0ce in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) sfx2/source/doc/sfxbasemodel.cxx:3030:46
>     #21 0x7f7504993862 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/doc/sfxbasemodel.cxx:1666:13
>     #22 0x7f753767c657 in Test::testLinkedGraphicRT() sw/qa/extras/globalfilter/globalfilter.cxx:170:20

Change-Id: Ic1d7731b80a14751b3cc1dd0c009bfdb43b722c2

178e38dd

-Werror,-Wunused-macros · de7922ad
Stephan Bergmann Ara 13, 2016 yazdı
```
Change-Id: Idc81dd30502a1968f2f65386575cac1e029f8c64
```
de7922ad
Reuse existing sal.osl log area · 58fc7351
Stephan Bergmann Ara 13, 2016 yazdı
```
Change-Id: Ib1fc80c79355322489b7ebd37cbbbbb6614ec67a
```
58fc7351
tdf#104573 - Assertion failed: SolarMutex not locked · 722f4e1d
Noel Grandin Ara 13, 2016 yazdı
```
Change-Id: I91d95e73a7e0831f6667f440dd43567ac55b0529
```
722f4e1d
cui.screenshot: Show full path when failing to create it · 36569a87
Samuel Mehrbrodt Ara 13, 2016 yazdı
```
Change-Id: Ic5196e90d7a25665cf9b5a2b039492195b0f00c2
```
36569a87
fix mac build after OSL_TRACE->SAL changes (2) · 10ae3090
Noel Grandin Ara 13, 2016 yazdı
```
Change-Id: I978e45207cd9ba96d487da92a51aaab24258855b
```
10ae3090
fix mac build after OSL_TRACE->SAL changes · 1569c87a
Noel Grandin Ara 13, 2016 yazdı
```
Change-Id: I811d4b4be5ed20a90f405900b9f8a81b5381dd7c
```
1569c87a
loplugin:sallogareas · cb92af91
Stephan Bergmann Ara 13, 2016 yazdı
```
Change-Id: I25f793d88a87d94925026fc3de97d02086a0c855
```
cb92af91
tdf#104573 - Assertion failed: SolarMutex not locked · f04ec99f
Noel Grandin Ara 13, 2016 yazdı
```
Change-Id: Ie46f0e2b60b99aea1c322c7891a41a2e7603c9e9
```
f04ec99f

tdf#46941 docx: don't balance columns before page-break-section · ede1a83e

Justin Luth Ara 10, 2016 yazdı

Pleasantly surprised to see we already don't balance before
regular page-breaks or at the end of the document. This adds
not balancing before a page-break-section.

Change-Id: Ifedff5cc45b154a005f13b3212154c443727e286
Reviewed-on: https://gerrit.libreoffice.org/31826Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

ede1a83e

SafeMode: Restart goes into safe mode again · 0fda52cc

Samuel Mehrbrodt Ara 12, 2016 yazdı

Looks like the XRestartManager keeps all command line arguments when
restarting, so it also keeps --safe-mode.

Solution is to add a flag file when restarting from safe mode,
to prevent going into safe mode again.

Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808
Reviewed-on: https://gerrit.libreoffice.org/31913Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

0fda52cc

fix windows build after OSL_TRACE->SAL changes · 19650d0e
Noel Grandin Ara 13, 2016 yazdı
```
Change-Id: I345343f84f66299e8b91b31af0290ed0c622bf8d
```
19650d0e
OSL_TRACE->SAL in avmedia..canvas · 3a705ab4
Noel Grandin Ara 13, 2016 yazdı
```
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
```
3a705ab4

OSL_TRACE->SAL in chart2..oox · c3586b68

Noel Grandin Ara 12, 2016 yazdı

Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

c3586b68

OSL_TRACE->SAL in framework..sal · a005fbed

Noel Grandin Ara 12, 2016 yazdı

Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9
Reviewed-on: https://gerrit.libreoffice.org/31903Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

a005fbed

OSL_TRACE->SAL in sc..scripting · 81f2a9f4

Noel Grandin Ara 12, 2016 yazdı

Change-Id: I389d8cb733a5ee24d3119a1ebac5a5b70daff04e
Reviewed-on: https://gerrit.libreoffice.org/31900Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

81f2a9f4

accessibility: cleanup AccessibleBrowseBoxBase implementation · ba6b35fc

Arnaud Versini Ara 12, 2016 yazdı

Change-Id: I5c9b96e2ebd2ac98dfa610346c1da89fbf56e2d2
Reviewed-on: https://gerrit.libreoffice.org/31916Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

ba6b35fc

12 Ara, 2016 22 kayıt (commit)

Calc function tests - move text function to new dir · 08fa2e93

Zdeněk Crhonek Ara 12, 2016 yazdı

Change-Id: I3a47c0e90e93050419326303c175cdc2adef6796
Reviewed-on: https://gerrit.libreoffice.org/31925Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

08fa2e93

dbaccess: fix testCloneMovesPlusDeletions test · ae8bd426

Michael Stahl Ara 12, 2016 yazdı

JunitTest_dbaccess_complex spuriously fails 1% of the time with:

1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet)
java.lang.AssertionError: moving to the next record after |deleteRow| and clone moves failed
    at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756)

The problem is that line RowSet.java:750 deleteRow() manages to delete
the last row in the set, because the positionRandom() is tricked to
position itself on the last row (which it tries not to do), becuase the
RowSet is currently positioned past-the-end on a deleted row and the
ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the
result in this special case.

Funnily both the ORowSetBase::impl_getRowCount() and the test using
positionRandom() were added in CWS rowsetdel.  Yay for randomized
tests!

Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e

ae8bd426

Fix lossage with --disable-cairo-canvas · b5f0c823
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: I9e822cfc1447fcd49c80c56df8ba37959555396a
```
b5f0c823

tdf#104540: AccessibleEventNotifier AccessibleBase (editeng) · b5ae4ccf

Julien Nabet Ara 12, 2016 yazdı

See https://bugs.documentfoundation.org/attachment.cgi?id=129537 for bt
For the remind, it follows a replace of OSL_ENSURE by an assert, see:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8228227168a7eb3ebf14629bec87f01536c23970

Change-Id: Id05eeb6e6669232e9b5cc2ef2989827fef3025d0
Reviewed-on: https://gerrit.libreoffice.org/31918Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

b5ae4ccf

Resolves: tdf#101588, do not prevent color de-selection tdf#96382 follow-up · 429be969

Eike Rathke Ara 12, 2016 yazdı

Comparing colors to determine whether to set one in the result item set does
not work if the color previously was set before SaveValue() was called
unconditionally even for the "undetermined" color state. Actually we want to
know whether the user selected a color instead.

Change-Id: I508f791684ebd79ba4af9cb654f9aa0bb25bff5d

429be969

Add rules to gitignore · b17b413e

Jaskaran Singh Ara 11, 2016 yazdı

Rule for ctags: Sublime generated(or otherwise) ctags look like
sc/abc/xyz/tags. The present rule cannot look after tags which
are more than 1 directory deep. Hence this change.

Other rules added : Jetbrains Clion, cscope, sublime text specific

Change-Id: I1dbbe4904f3d15bbf198cd372591b464efb3896a
Reviewed-on: https://gerrit.libreoffice.org/31874Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>

b17b413e

Don’t return false for blank glyphs · 04a77bfa

Khaled Hosny Ara 12, 2016 yazdı

CTFontCreatePathForGlyph() will return NULL for blank glyphs causing
CoreTextStyle::GetGlyphOutline() to return false which propagated as
error all the way to OutputDevice::GetTextOutlines() causing it to
needlessly enter into fallback code. Other implementations just return
true and an empty polygon here.

Change-Id: Ib20ebff00f7cb3aae22f1c6b4c3a0e9d7a429987
Reviewed-on: https://gerrit.libreoffice.org/31902Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

04a77bfa

Prevent use of ORowSetValue with sal_Bool as TINYINT · 385f6240

Stephan Bergmann Ara 12, 2016 yazdı

sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of
ORowSetValue with sal_Bool instead of bool, apparently intending to treat the
value as a boolean, actually treated it as a TINYINT. (See e.g. recent
7b0c57b2 "some compilers don't like implicit
bool-to-ORowSetValue conversion".)

Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the
m_uInt8 union member can probably go away, too.

Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3
Reviewed-on: https://gerrit.libreoffice.org/31909Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

385f6240

Updated core · 8845ccc1

tagezi Ara 04, 2016 yazdı

Project: help 47ad5a2f2102740bda4cf02dcd73562da79f67a9

tdf#100836 "Starting the LibreOffice Software With Parameters" help update

rewritten cmdHelp in accordance with the attached document in bug tdf#100836

Change-Id: I6061dab2ed83a2be0653fbbd422e3193386d9d98
Reviewed-on: https://gerrit.libreoffice.org/31595Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

8845ccc1

-Werror,-Wimplicit-fallthrough · dfafaeb9
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: I7ea9c1af7568ce37f29df14f8dc4345031c20eb8
```
dfafaeb9

tdf#97361: Changed naming convention to Python type, object factories implemented · 9d67a587

n5xgdh Ara 04, 2016 yazdı

Change-Id: Id42e9a2e2cfd7c95140411123e8702dfdb4054da
Reviewed-on: https://gerrit.libreoffice.org/31676Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

9d67a587

tdf104532 handle constraints for NEGBINOM.DIST correctly. · ccbb0dd8

Winfried Donkers Ara 09, 2016 yazdı

Also changed variable names for easier understanding of their meaning.

Change-Id: Iab558d7d1d9533f2a0c42e3d5f4acecead2e818e
Reviewed-on: https://gerrit.libreoffice.org/31807Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

ccbb0dd8

Revert "loplugin:refcounting" · ae9b5144

Tor Lillqvist Ara 12, 2016 yazdı

Bah, the reverted change actually of course breaks the compilation, I
had missed that accidentally. More intrusive chnages are needed to
change css::uno::Reference to rtl::Reference, also in parameters to
constructors and other calls here.

This reverts commit 073f8cdb.

Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f

ae9b5144

loplugin:stringconstant · 78f3faa1
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: I5bf8adf86da9d2e9c53341cdbc94aba05557abfc
```
78f3faa1

Whitelist aLogger, in FormulaLogger& FormulaLogger::get() · 2da2cfcb

Tor Lillqvist Ara 12, 2016 yazdı

To avoid this:

sc/source/core/tool/formulalogger.cxx:55:26: error: bad static variable causes crash on shutdown [loplugin:badstatics]
    static FormulaLogger aLogger;
    ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
sc/inc/formulalogger.hxx:42:31: note: ... due to this member of 'FormulaLogger' [loplugin:badstatics]
    const ScFormulaCellGroup* mpLastGroup = nullptr;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
sc/inc/formulacell.hxx:66:20: note: ... due to this member of 'ScFormulaCellGroup' [loplugin:badstatics]
    ScFormulaCell *mpTopCell;
    ~~~~~~~~~~~~~~~^~~~~~~~~
sc/inc/formulacell.hxx:114:21: note: ... due to this member of 'ScFormulaCell' [loplugin:badstatics]
    ScDocument*     pDocument;
    ~~~~~~~~~~~~~~~~^~~~~~~~~
sc/inc/document.hxx:312:27: note: ... due to this member of 'ScDocument' [loplugin:badstatics]
    VclPtr<SfxPrinter>    pPrinter;
    ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~

Change-Id: I533e45f655ca928a801188aa48ee818d89a962ac

2da2cfcb

loplugin:staticmethods · 34580050
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe
```
34580050
loplugin:unreffun and loplugin:externandnotdefined · 45566e7c
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3
```
45566e7c
loplugin:override · 3d17a408
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: I7ef42d66a0ffbbd8f2754bd4aba0e77659c9ae83
```
3d17a408
loplugin:nullptr · 22166c75
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: I6ab405e7e9a0c8ac3a323fd2484e334c500280ae
```
22166c75
loplugin:unnecessaryoverride · 00d3aaa2
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: I45d7e14cef0058c4bfca4a3466e31d64e29bdfae
```
00d3aaa2
loplugin:unreffun · dfc643a5
Tor Lillqvist Ara 12, 2016 yazdı
```
Change-Id: If538d5d5347f58e18869cab2b687af26a39a89eb
```
dfc643a5
loplugin:staticmethods · b472cced
Stephan Bergmann Ara 12, 2016 yazdı
```
Change-Id: Ic8e00ab8961811044c26eb237f283617ddeb5cb6
```
b472cced