Shape text has two kind of spacing inside the shape's bounding box: the
shape-level margin and the paragraph-level one. Only the second was
handled in the tx algorithm so far, add support for the first.

The margins taken from constraints were way large by default: the only
explanation I found for that is that SmartArt layout sometimes
calculates in MMs, sometimes in Points, and the ratio between the two is
exactly the Impress / PowerPoint margin. So assume that indeed that unit
difference is the reason for the smaller in-PowerPoint margin values and
do the same on our side.

Change-Id: I6f1e54301e2e9b33a7e721be34244d968cccf42d
Reviewed-on: https://gerrit.libreoffice.org/68453Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

since

commit c600817e
Date:   Mon Feb 25 15:34:13 2019 +0200

    Make SdAbstractDialogFactory::Create() do its job also on non-DESKTOP

Change-Id: I95ff8ed3dc81ec542ac76d5f5bbd7582391c84a5

Change-Id: I2de32f700125fc8306c16fe4963ef76f87b0034c
Reviewed-on: https://gerrit.libreoffice.org/68435Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

use size groups to align things rather than forcing homogenous cols

Change-Id: I4a1496f15663c4dcbcd6aaf3ea7901c9c7b170d2
Reviewed-on: https://gerrit.libreoffice.org/68427
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - Relate Python & Basic examples together
    
    Change-Id: Ib6abffdfb2f83688eb84f94553f44b3f10dc33c2
    Reviewed-on: https://gerrit.libreoffice.org/68388
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

...and change connectivity/source/parse/sqlflex.l license header from using
(unusual, anyway) // comments to using /* */ comment, so that it can go before
Flex's opening %{

Change-Id: I371890e937cc5055405c17226dd87ba1694688aa
Reviewed-on: https://gerrit.libreoffice.org/68433
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Exporting to svg a selected object of a chart does not work.
In the chart case the selected object for the current document is
always the chart itself, not an internal chart object.
Moreover the exporting action cause the exported object to be selected
again. So you try to selected the chart legend and you end up with the
whole chart selected again.

Change-Id: Ib4aa91afd592909ad354ca373dc03298547f9fb5
Reviewed-on: https://gerrit.libreoffice.org/68347
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Fixes CVE-2019-1559, plus a couple low-severity CVEs.

Change-Id: Icb6849ca5f33cb1169ce303505b2e32636e3b25b
Reviewed-on: https://gerrit.libreoffice.org/68430
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I30225124e44e8a6290270ecba5024f36508817d3
Reviewed-on: https://gerrit.libreoffice.org/68428
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Now that we have ParamClass::ReferenceOrRefArray and supporting
functions use it as parameter classification and it is set at the
called function in array/matrix context, use it as indicator when
to return the reference list array and when to return the result
matrix.

Change-Id: I1fd6001f51530b0d1cfd61320f1cd58521c4fa40
Reviewed-on: https://gerrit.libreoffice.org/68426Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: I4468a3a8d036ca4894ba7977f6654244552464aa
Reviewed-on: https://gerrit.libreoffice.org/68423
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I3277a341137b1b404ad9839431b5cc39a88fcbe1
Reviewed-on: https://gerrit.libreoffice.org/68425
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Also additions were needed in include/sfx2/msg.hxx
to avoid build breakage

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I259ff10aaa5d044d4b11f9041174765d5a5f7dc7
Reviewed-on: https://gerrit.libreoffice.org/68364
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Refactor the code and reuse WriteAnimationTarget to export
the target element for the condition element in stCondLst
and endCondLst.

Add testTdf123557 to make sure import-export-import works.

As SdOOXMLExportTest2::testTdf90627 no longer produce corupt
pptx that has endCondLst without Cond element, make the
xpath more specific about what is testing.

Update schema because drawooo:enhanced-path incluced in the
test case.

Change-Id: If5d64f5c23aa2652cfa72471f9f7886c7dd956eb
Reviewed-on: https://gerrit.libreoffice.org/68211
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I1ffe56ada6caed305fd2dbd5fb838e6a7ab3c2e2
Reviewed-on: https://gerrit.libreoffice.org/68408Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

...after ce2792ed "use C++11 exception
rethrowing"

Change-Id: I7a5cf53daa833cd398e520f67bf4bc5f36b21989
Reviewed-on: https://gerrit.libreoffice.org/68422
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I1ed43bab00a5bc456032410ccf32b3fd64cc970c
Reviewed-on: https://gerrit.libreoffice.org/68419
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia59b2a6136e2e56bf6c43a84e3cb6268471278a5
Reviewed-on: https://gerrit.libreoffice.org/68410
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

like
   bool Foo::bar() {
       b = Super::bar();
       return b;
   }

Change-Id: I5e4c8005a3da7d7487c9039c35dcbb1d17e65bd7
Reviewed-on: https://gerrit.libreoffice.org/68418Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I72085b130dede835f3fc75cb1335eb3b0c0d9b2e
Reviewed-on: https://gerrit.libreoffice.org/68409
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I20acdccd1faa7b8edf7a5786be124ae063ebca67
Reviewed-on: https://gerrit.libreoffice.org/68405
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id4fbe6e16bb63e3df2768ce38161847ea6ff7eec
Reviewed-on: https://gerrit.libreoffice.org/68406
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: I94420e19a6ef12aee78f83ea7b1ac54433be0160
Reviewed-on: https://gerrit.libreoffice.org/68399
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I21385a37a5e2107069919250dd35812ac5972422
Reviewed-on: https://gerrit.libreoffice.org/68411
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This first step only affects GTK3, later we will extend the support
to other platforms.

Note that these images are derived from the OSX PNG files, not the header-file
encoded data we currently use for gtk/gtk3.

Also rename the files to more useful names.

Change-Id: Ia13a3f2ac35b06672aff724f4cf5bdcd823f6342
Reviewed-on: https://gerrit.libreoffice.org/67528
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I103bcc2f21741d0a52a0bdf053fdbddf5a3e9ea0
Reviewed-on: https://gerrit.libreoffice.org/68387Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

since
  commit c4a91f14
  Date:   Mon Feb 11 17:32:44 2019 +0000
  weld SdInsertPagesObjsDlg

Change-Id: I9644c492d02e930592fd568c15f2f87d12f4f038
Reviewed-on: https://gerrit.libreoffice.org/68386Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id6ac35fefa5c3e1f64c222713791e849b3cb4d34
Reviewed-on: https://gerrit.libreoffice.org/68379Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

fields private

Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27
Reviewed-on: https://gerrit.libreoffice.org/68302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ida6deb31f393d9c7457e41f2047ee364aa95ad2e
Reviewed-on: https://gerrit.libreoffice.org/68415
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Destroy Qt5Frame after all events are received.
Update Qt5Object to use delayed destruction too.

Change-Id: I07c7251e097ad56f3616f325fdc394d00fec4f4f
Reviewed-on: https://gerrit.libreoffice.org/68316
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This change fixes clipping and drawing issues
for document recovery window and other modal windows.

Change-Id: I005254d4cd2598f4f2d02ba7e7bbf7388affe36c
Reviewed-on: https://gerrit.libreoffice.org/68307
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I2476cbabbb3625ab0d562218102fbbcfbb08f4e6
Reviewed-on: https://gerrit.libreoffice.org/68404
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: I872fdb2d6d4c6279b6d4dc8f38e1153fcd919f22
Reviewed-on: https://gerrit.libreoffice.org/68395
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...as instead of the original shared document, a temporary copy (with a file URL
denoting a temporary directory, like <file:///tmp/lulmhoxl.tmp/0.ods>) is opened
in that case.

Change-Id: I415f5a0ec44ee06f7ca98495f0e8f032ba93e05c
Reviewed-on: https://gerrit.libreoffice.org/68391
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd
Reviewed-on: https://gerrit.libreoffice.org/68378
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The snake algorithm in PowerPoint seem to interpret spacing as follows:
if you have N elements, then there should be the requested amount of
spacing between the elements, and also double amount of spacing around
the actual list of elements.

With this, the SmartArt and the title shape in the bugdoc no longer
overlaps.

Change-Id: I5d6885b434bfaff9de9aac595a298a5346524e19
Reviewed-on: https://gerrit.libreoffice.org/68397Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

RTF is a bit simplistic compared to the others, but at least
we can handle the Environment situation similarly.

Change-Id: I87bc389373275d19f1229e11ffd742836a0fd498
Reviewed-on: https://gerrit.libreoffice.org/66966
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ic580df179c6aa1dedc866cf0882c124d5b13fcb3
Reviewed-on: https://gerrit.libreoffice.org/68360
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Change-Id: Ie07147c9d6af469ed1088148dd8b9bdb64ae8590
Reviewed-on: https://gerrit.libreoffice.org/68362
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>