Kaydet (Commit) 19240f62 authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:unusedfields look for classes where we can make all the..

fields private

Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27
Reviewed-on: https://gerrit.libreoffice.org/68302
Tested-by: Jenkins
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 60c7725a
......@@ -31,8 +31,8 @@ typedef std::vector< css::uno::WeakReference< css::accessibility::XAccessible >
class VCLXAccessibleHeaderBar : public VCLXAccessibleComponent
{
public:
VclPtr<HeaderBar> m_pHeadBar;
public:
virtual ~VCLXAccessibleHeaderBar() override;
VCLXAccessibleHeaderBar( VCLXWindow* pVCLXindow );
......
......@@ -34,9 +34,9 @@ class VCLXAccessibleTextComponent : public VCLXAccessibleComponent,
public ::comphelper::OCommonAccessibleText,
public VCLXAccessibleTextComponent_BASE
{
protected:
OUString m_sText;
protected:
void SetText( const OUString& sText );
virtual void ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent ) override;
......
......@@ -37,7 +37,7 @@ public:
virtual OUString getInnerName() const override;
protected:
private:
DataSeriesPointWrapper* m_pDataSeriesPointWrapper;
OUString m_aInnerAreaTypeName;
OUString m_aInnerLineTypeName;
......
......@@ -117,11 +117,10 @@ protected:
virtual void SAL_CALL disposing(
const css::lang::EventObject& Source ) override;
protected:
private:
css::uno::Reference< css::uno::XComponentContext > m_xContext;
css::uno::Reference< css::util::XURLTransformer > m_xURLTransformer;
private:
typedef std::map< OUString, ::comphelper::OInterfaceContainerHelper2* >
tListenerMap;
......
......@@ -211,6 +211,29 @@ for d in protectedAndPublicDefinitionSet:
canBePrivateSet.add((clazz + " " + definitionToTypeMap[d], srcLoc))
# --------------------------------------------------------------------------------------------
# "all fields in class can be made private" analysis
# --------------------------------------------------------------------------------------------
potentialClasses = set()
excludedClasses = set()
potentialClassesSourceLocationMap = dict()
matchClassName = re.compile(r"(\w+)::")
for d in protectedAndPublicDefinitionSet:
clazz = d[0]
if d in touchedFromOutsideSet:
excludedClasses.add(clazz)
else:
potentialClasses.add(clazz)
potentialClassesSourceLocationMap[clazz] = definitionToSourceLocationMap[d]
allFieldsCanBePrivateSet = set()
for d in (potentialClasses - excludedClasses):
sourceLoc = potentialClassesSourceLocationMap[d]
# when the class is inside a compile unit, assume that the compiler can figure this out for itself, much less interesting to me
if not ".cxx" in sourceLoc:
allFieldsCanBePrivateSet.add((d, sourceLoc))
# sort the results using a "natural order" so sequences like [item1,item2,item10] sort nicely
def natural_sort_key(s, _nsre=re.compile('([0-9]+)')):
return [int(text) if text.isdigit() else text.lower()
......@@ -222,6 +245,7 @@ tmp2list = sorted(writeonlySet, key=lambda v: natural_sort_key(v[1]))
tmp3list = sorted(canBePrivateSet, key=lambda v: natural_sort_key(v[1]))
tmp4list = sorted(readonlySet, key=lambda v: natural_sort_key(v[1]))
tmp5list = sorted(onlyUsedInConstructorSet, key=lambda v: natural_sort_key(v[1]))
tmp6list = sorted(allFieldsCanBePrivateSet, key=lambda v: natural_sort_key(v[1]))
# print out the results
with open("compilerplugins/clang/unusedfields.untouched.results", "wt") as f:
......@@ -245,5 +269,9 @@ with open("compilerplugins/clang/unusedfields.only-used-in-constructor.results",
for t in tmp5list:
f.write( t[1] + "\n" )
f.write( " " + t[0] + "\n" )
with open("compilerplugins/clang/unusedfields.report-all-can-be-private", "wt") as f:
for t in tmp6list:
f.write( t[1] + "\n" )
f.write( " " + t[0] + "\n" )
......@@ -58,7 +58,7 @@ protected:
explicit Node(const Node & other);
virtual ~Node() override;
private:
int layer_;
int finalized_;
};
......
......@@ -18,7 +18,6 @@ namespace connectivity
{
class Catalog: public ::connectivity::sdbcx::OCatalog
{
protected:
css::uno::Reference< css::sdbc::XConnection >
m_xConnection;
......
......@@ -37,11 +37,10 @@ namespace connectivity
public css::sdbc::XBatchExecution,
public css::lang::XServiceInfo
{
XSQLDA* m_pSqlda;
protected:
virtual ~OStatement() override {}
XSQLDA* m_pSqlda;
public:
// a constructor, which is required for returning objects:
explicit OStatement( Connection* _pConnection)
......
......@@ -24,9 +24,9 @@ namespace connectivity
*/
class Users: public ::connectivity::sdbcx::OCollection
{
protected:
css::uno::Reference< css::sdbc::XDatabaseMetaData >
m_xMetaData;
protected:
// OCollection
virtual void impl_refresh() override;
......
......@@ -76,9 +76,9 @@ namespace connectivity
class OOO_DLLPUBLIC_FILE OOperandRow : public OOperand
{
sal_uInt16 m_nRowPos;
protected:
OValueRefRow m_pRow;
protected:
OOperandRow(sal_uInt16 _nPos, sal_Int32 _rType);
public:
virtual const ORowSetValue& getValue() const override;
......@@ -230,8 +230,6 @@ namespace connectivity
class OOO_DLLPUBLIC_FILE OOp_LIKE : public OBoolOperator
{
public:
protected:
const sal_Unicode cEscape;
public:
......
......@@ -59,8 +59,8 @@ namespace connectivity
class OUserExtend : public OHSQLUser,
public OUserExtend_PROP
{
protected:
OUString m_Password;
protected:
// OPropertyArrayUsageHelper
virtual ::cppu::IPropertyArrayHelper* createArrayHelper() const override;
// OPropertySetHelper
......
......@@ -59,8 +59,8 @@ namespace connectivity
class OUserExtend : public OMySQLUser,
public OUserExtend_PROP
{
protected:
OUString m_Password;
protected:
// OPropertyArrayUsageHelper
virtual ::cppu::IPropertyArrayHelper* createArrayHelper() const override;
// OPropertySetHelper
......
......@@ -102,7 +102,7 @@ namespace connectivity
}
protected:
private:
// Data attributes
......
......@@ -87,7 +87,6 @@ class CuiVclAbstractDialog_Impl : public VclAbstractDialog
class CuiAbstractController_Impl : public VclAbstractDialog
{
protected:
std::unique_ptr<weld::DialogController> m_xDlg;
public:
explicit CuiAbstractController_Impl(std::unique_ptr<weld::DialogController> p)
......@@ -108,7 +107,6 @@ class CuiAbstractSfxDialog_Impl : public SfxAbstractDialog
class CuiAbstractSingleTabController_Impl : public SfxAbstractDialog
{
protected:
std::unique_ptr<SfxSingleTabDialogController> m_xDlg;
public:
explicit CuiAbstractSingleTabController_Impl(std::unique_ptr<SfxSingleTabDialogController> p)
......@@ -135,7 +133,6 @@ class CuiAbstractTabDialog_Impl : public SfxAbstractTabDialog
class CuiAbstractTabController_Impl : public SfxAbstractTabDialog
{
protected:
std::shared_ptr<SfxTabDialogController> m_xDlg;
public:
explicit CuiAbstractTabController_Impl(std::unique_ptr<SfxTabDialogController> p)
......@@ -155,7 +152,6 @@ public:
class SvxDistributeDialog;
class AbstractSvxDistributeDialog_Impl: public AbstractSvxDistributeDialog
{
protected:
std::unique_ptr<SvxDistributeDialog> m_xDlg;
public:
explicit AbstractSvxDistributeDialog_Impl(std::unique_ptr<SvxDistributeDialog> p)
......@@ -214,7 +210,6 @@ class AbstractThesaurusDialog_Impl : public AbstractThesaurusDialog
class AbstractHyphenWordDialog_Impl: public AbstractHyphenWordDialog
{
protected:
std::unique_ptr<SvxHyphenWordDialog> m_xDlg;
public:
explicit AbstractHyphenWordDialog_Impl(std::unique_ptr<SvxHyphenWordDialog> p)
......@@ -227,7 +222,6 @@ public:
class FmShowColsDialog;
class AbstractFmShowColsDialog_Impl : public AbstractFmShowColsDialog
{
protected:
std::unique_ptr<FmShowColsDialog> m_xDlg;
public:
explicit AbstractFmShowColsDialog_Impl(std::unique_ptr<FmShowColsDialog> p)
......@@ -241,7 +235,6 @@ public:
class SvxZoomDialog;
class AbstractSvxZoomDialog_Impl : public AbstractSvxZoomDialog
{
protected:
std::unique_ptr<SvxZoomDialog> m_xDlg;
public:
explicit AbstractSvxZoomDialog_Impl(std::unique_ptr<SvxZoomDialog> p)
......@@ -282,7 +275,6 @@ public:
class SvxScriptSelectorDialog;
class AbstractScriptSelectorDialog_Impl : public AbstractScriptSelectorDialog
{
protected:
std::unique_ptr<SvxScriptSelectorDialog> m_xDlg;
public:
explicit AbstractScriptSelectorDialog_Impl(std::unique_ptr<SvxScriptSelectorDialog> p)
......@@ -322,7 +314,6 @@ class AbstractURLDlg_Impl :public AbstractURLDlg
class SvxSearchSimilarityDialog;
class AbstractSvxSearchSimilarityDialog_Impl :public AbstractSvxSearchSimilarityDialog
{
protected:
std::unique_ptr<SvxSearchSimilarityDialog> m_xDlg;
public:
explicit AbstractSvxSearchSimilarityDialog_Impl(std::unique_ptr<SvxSearchSimilarityDialog> p)
......@@ -339,7 +330,6 @@ public:
class SvxJSearchOptionsDialog;
class AbstractSvxJSearchOptionsDialog_Impl : public AbstractSvxJSearchOptionsDialog
{
protected:
std::unique_ptr<SvxJSearchOptionsDialog> m_xDlg;
public:
explicit AbstractSvxJSearchOptionsDialog_Impl(std::unique_ptr<SvxJSearchOptionsDialog> p)
......@@ -352,7 +342,6 @@ public:
class AbstractSvxTransformTabDialog_Impl : public AbstractSvxTransformTabDialog
{
protected:
std::shared_ptr<SvxTransformTabDialog> m_xDlg;
public:
explicit AbstractSvxTransformTabDialog_Impl(SvxTransformTabDialog* p)
......@@ -371,7 +360,6 @@ public:
class AbstractSvxCaptionDialog_Impl : public AbstractSvxCaptionDialog
{
protected:
std::shared_ptr<SvxCaptionTabDialog> m_xDlg;
public:
explicit AbstractSvxCaptionDialog_Impl(std::unique_ptr<SvxCaptionTabDialog> p)
......@@ -391,7 +379,6 @@ public:
class FmInputRecordNoDialog;
class AbstractFmInputRecordNoDialog_Impl :public AbstractFmInputRecordNoDialog
{
protected:
std::unique_ptr<FmInputRecordNoDialog> m_xDlg;
public:
explicit AbstractFmInputRecordNoDialog_Impl(std::unique_ptr<FmInputRecordNoDialog> p)
......@@ -406,7 +393,6 @@ public:
class SvxNewDictionaryDialog;
class AbstractSvxNewDictionaryDialog_Impl :public AbstractSvxNewDictionaryDialog
{
protected:
std::unique_ptr<SvxNewDictionaryDialog> m_xDlg;
public:
explicit AbstractSvxNewDictionaryDialog_Impl(std::unique_ptr<SvxNewDictionaryDialog> p)
......@@ -420,8 +406,6 @@ public:
class SvxNameDialog;
class AbstractSvxNameDialog_Impl :public AbstractSvxNameDialog
{
protected:
std::unique_ptr<SvxNameDialog> m_xDlg;
public:
explicit AbstractSvxNameDialog_Impl(std::unique_ptr<SvxNameDialog> p)
: m_xDlg(std::move(p))
......@@ -435,6 +419,7 @@ public:
virtual void SetHelpId( const OString& ) override ;
virtual void SetText( const OUString& rStr ) override ;
private:
std::unique_ptr<SvxNameDialog> m_xDlg;
Link<AbstractSvxNameDialog&,bool> aCheckNameHdl;
DECL_LINK(CheckNameHdl, SvxNameDialog&, bool);
};
......@@ -444,8 +429,6 @@ class SvxObjectTitleDescDialog;
class AbstractSvxObjectNameDialog_Impl : public AbstractSvxObjectNameDialog
{
protected:
std::unique_ptr<SvxObjectNameDialog> m_xDlg;
public:
explicit AbstractSvxObjectNameDialog_Impl(std::unique_ptr<SvxObjectNameDialog> p)
: m_xDlg(std::move(p))
......@@ -456,13 +439,13 @@ public:
virtual void SetCheckNameHdl(const Link<AbstractSvxObjectNameDialog&,bool>& rLink) override;
private:
std::unique_ptr<SvxObjectNameDialog> m_xDlg;
Link<AbstractSvxObjectNameDialog&,bool> aCheckNameHdl;
DECL_LINK(CheckNameHdl, SvxObjectNameDialog&, bool);
};
class AbstractSvxObjectTitleDescDialog_Impl :public AbstractSvxObjectTitleDescDialog
{
protected:
std::unique_ptr<SvxObjectTitleDescDialog> m_xDlg;
public:
explicit AbstractSvxObjectTitleDescDialog_Impl(std::unique_ptr<SvxObjectTitleDescDialog> p)
......@@ -476,7 +459,6 @@ public:
class AbstractSvxMultiPathDialog_Impl : public AbstractSvxMultiPathDialog
{
protected:
std::unique_ptr<SvxMultiPathDialog> m_xDlg;
public:
explicit AbstractSvxMultiPathDialog_Impl(std::unique_ptr<SvxMultiPathDialog> p)
......@@ -517,7 +499,6 @@ class FmSearchDialog;
struct FmFoundRecordInformation;
class AbstractFmSearchDialog_Impl :public AbstractFmSearchDialog
{
protected:
std::unique_ptr<FmSearchDialog> m_xDlg;
public:
explicit AbstractFmSearchDialog_Impl(std::unique_ptr<FmSearchDialog> p)
......@@ -532,7 +513,6 @@ public:
class AbstractGraphicFilterDialog_Impl : public AbstractGraphicFilterDialog
{
protected:
std::unique_ptr<GraphicFilterDialog> m_xDlg;
public:
explicit AbstractGraphicFilterDialog_Impl(std::unique_ptr<GraphicFilterDialog> p)
......@@ -546,7 +526,6 @@ public:
class SvxAreaTabDialog;
class AbstractSvxAreaTabDialog_Impl : public AbstractSvxAreaTabDialog
{
protected:
std::shared_ptr<SvxAreaTabDialog> m_xDlg;
public:
explicit AbstractSvxAreaTabDialog_Impl(std::unique_ptr<SvxAreaTabDialog> p)
......@@ -564,7 +543,6 @@ public:
class AbstractInsertObjectDialog_Impl : public SfxAbstractInsertObjectDialog
{
protected:
std::unique_ptr<InsertObjectDialog_Impl> m_xDlg;
public:
explicit AbstractInsertObjectDialog_Impl(std::unique_ptr<InsertObjectDialog_Impl> p)
......@@ -579,7 +557,6 @@ public:
class AbstractPasteDialog_Impl : public SfxAbstractPasteDialog
{
protected:
std::unique_ptr<SvPasteObjectDialog> m_xDlg;
public:
explicit AbstractPasteDialog_Impl(std::unique_ptr<SvPasteObjectDialog> p)
......@@ -608,8 +585,6 @@ public:
class SvxPostItDialog;
class AbstractSvxPostItDialog_Impl :public AbstractSvxPostItDialog
{
private:
std::unique_ptr<SvxPostItDialog> m_xDlg;
public:
AbstractSvxPostItDialog_Impl(std::unique_ptr<SvxPostItDialog> pDlg)
: m_xDlg(std::move(pDlg))
......@@ -628,6 +603,7 @@ public:
virtual void HideAuthor() override;
virtual std::shared_ptr<weld::Dialog> GetDialog() override;
private:
std::unique_ptr<SvxPostItDialog> m_xDlg;
Link<AbstractSvxPostItDialog&,void> aNextHdl;
Link<AbstractSvxPostItDialog&,void> aPrevHdl;
DECL_LINK(NextHdl, SvxPostItDialog&, void);
......@@ -637,7 +613,6 @@ private:
class PasswordToOpenModifyDialog;
class AbstractPasswordToOpenModifyDialog_Impl : public AbstractPasswordToOpenModifyDialog
{
protected:
std::unique_ptr<PasswordToOpenModifyDialog> m_xDlg;
public:
explicit AbstractPasswordToOpenModifyDialog_Impl(std::unique_ptr<PasswordToOpenModifyDialog> p)
......@@ -653,7 +628,6 @@ public:
class SvxCharacterMap;
class AbstractSvxCharacterMapDialog_Impl : public SfxAbstractDialog
{
protected:
std::unique_ptr<SvxCharacterMap> m_xDlg;
public:
explicit AbstractSvxCharacterMapDialog_Impl(std::unique_ptr<SvxCharacterMap> p)
......@@ -674,7 +648,6 @@ class AbstractScreenshotAnnotationDlg_Impl : public AbstractScreenshotAnnotation
class SignatureLineDialog;
class AbstractSignatureLineDialog_Impl : public AbstractSignatureLineDialog
{
protected:
std::unique_ptr<SignatureLineDialog> m_xDlg;
public:
......
......@@ -74,10 +74,10 @@ private:
DECL_LINK( ImplPreviewTimeoutHdl, Timer *, void );
DECL_LINK( ImplModifyHdl, LinkParamNone*, void);
protected:
CuiGraphicPreviewWindow maPreview;
std::unique_ptr<weld::CustomWeld> mxPreview;
protected:
const Link<LinkParamNone*,void>& GetModifyHdl() const { return maModifyHdl; }
const Size& GetGraphicSizePixel() const { return maPreview.GetGraphicSizePixel(); }
......
......@@ -23,7 +23,6 @@
class FmInputRecordNoDialog : public weld::GenericDialogController
{
public:
std::unique_ptr<weld::SpinButton> m_xRecordNo;
public:
......
......@@ -108,12 +108,12 @@ private:
std::unique_ptr<weld::Button> m_xOkButton; ///< The OK button
std::unique_ptr<weld::Button> m_xCancelButton; ///< The Cancel button
std::unique_ptr<weld::Button> m_vResultList[MAX_RESULTS]; ///< List of buttons to show search results
::rtl::Reference< SearchAndParseThread > m_pSearchThread;
::rtl::Reference< GetPersonaThread > m_pGetPersonaThread;
public:
explicit SelectPersonaDialog(weld::Window *pParent);
virtual ~SelectPersonaDialog() override;
::rtl::Reference< SearchAndParseThread > m_pSearchThread;
::rtl::Reference< GetPersonaThread > m_pGetPersonaThread;
OUString GetSelectedPersona() const;
void SetProgress( const OUString& );
......
......@@ -455,7 +455,6 @@ namespace dbaccess
,public ORowSetBase
,public ::comphelper::OPropertyArrayUsageHelper < ORowSetClone >
{
protected:
ORowSet* m_pParent;
sal_Int32 m_nFetchDirection;
sal_Int32 m_nFetchSize;
......
......@@ -35,10 +35,9 @@ namespace dbaccess
public css::sdb::XColumn,
public css::sdb::XColumnUpdate
{
protected:
css::uno::Reference < css::sdbc::XRow > m_xRow;
css::uno::Reference < css::sdbc::XRowUpdate > m_xRowUpdate;
protected:
virtual ~ODataColumn() override;
public:
ODataColumn (const css::uno::Reference < css::sdbc::XResultSetMetaData >& _xMetaData,
......
......@@ -84,11 +84,11 @@ class OComponentDefinition :public OContentHelper
,public OComponentDefinition_BASE
,public ::comphelper::OPropertyArrayUsageHelper< OComponentDefinition >
{
protected:
rtl::Reference< OColumns > m_xColumns;
rtl::Reference<OColumnPropertyListener> m_xColumnPropertyListener;
bool m_bTable;
protected:
virtual ~OComponentDefinition() override;
virtual void SAL_CALL disposing() override;
......
......@@ -39,7 +39,6 @@ namespace dbaccess
public css::sdbcx::XColumnsSupplier,
public css::lang::XServiceInfo
{
protected:
std::unique_ptr<OColumns> m_pColumns;
css::uno::Reference< css::sdbc::XParameters > m_xAggregateAsParameters;
......
......@@ -37,7 +37,6 @@ namespace dbaui
class OConnectionTabPageSetup : public OConnectionHelper
{
friend class VclPtr<OConnectionTabPageSetup>;
protected:
std::unique_ptr<weld::Label> m_xHelpText;
std::unique_ptr<weld::Label> m_xHeaderText;
......
......@@ -55,9 +55,6 @@ namespace dbaui
class OTextConnectionPageSetup : public OConnectionTabPageSetup
{
public:
std::unique_ptr<weld::Widget> m_xSubContainer;
std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
virtual bool FillItemSet ( SfxItemSet* _rCoreAttrs ) override;
static VclPtr<OGenericAdministrationPage> CreateTextTabPage(TabPageParent pParent, const SfxItemSet& _rAttrSet );
OTextConnectionPageSetup(TabPageParent pParent, const SfxItemSet& _rCoreAttrs);
......@@ -69,9 +66,10 @@ namespace dbaui
virtual void fillControls(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
virtual void fillWindows(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
bool checkTestConnection() override;
private:
DECL_LINK(ImplGetExtensionHdl, OTextConnectionHelper*, void);
std::unique_ptr<weld::Widget> m_xSubContainer;
std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
};
// OLDAPConnectionPageSetup
......@@ -255,15 +253,6 @@ namespace dbaui
virtual bool FillItemSet ( SfxItemSet* _rCoreAttrs ) override;
static VclPtr<OGenericAdministrationPage> CreateFinalDBTabPageSetup( vcl::Window* pParent, const SfxItemSet& _rAttrSet);
VclPtr<FixedText> m_pFTFinalHeader;
VclPtr<FixedText> m_pFTFinalHelpText;
VclPtr<RadioButton> m_pRBRegisterDataSource;
VclPtr<RadioButton> m_pRBDontregisterDataSource;
VclPtr<FixedText> m_pFTAdditionalSettings;
VclPtr<CheckBox> m_pCBOpenAfterwards;
VclPtr<CheckBox> m_pCBStartTableWizard;
VclPtr<FixedText> m_pFTFinalText;
OFinalDBPageSetup(vcl::Window* pParent, const SfxItemSet& _rCoreAttrs);
virtual ~OFinalDBPageSetup() override;
virtual void dispose() override;
......@@ -277,6 +266,15 @@ namespace dbaui
virtual void implInitControls(const SfxItemSet& _rSet, bool _bSaveValue) override;
virtual void fillControls(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
virtual void fillWindows(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
private:
VclPtr<FixedText> m_pFTFinalHeader;
VclPtr<FixedText> m_pFTFinalHelpText;
VclPtr<RadioButton> m_pRBRegisterDataSource;
VclPtr<RadioButton> m_pRBDontregisterDataSource;
VclPtr<FixedText> m_pFTAdditionalSettings;
VclPtr<CheckBox> m_pCBOpenAfterwards;
VclPtr<CheckBox> m_pCBStartTableWizard;
VclPtr<FixedText> m_pFTFinalText;
};
} // namespace dbaui
......
......@@ -51,8 +51,6 @@ namespace dbaui
*/
class OCommonBehaviourTabPage : public OGenericAdministrationPage
{
protected:
OCommonBehaviourTabPageFlags m_nControlFlags;
std::unique_ptr<weld::Label> m_xOptionsLabel;
......@@ -244,8 +242,6 @@ namespace dbaui
OTextDetailsPage(TabPageParent pParent, const SfxItemSet& rCoreAttrs);
std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
protected:
virtual ~OTextDetailsPage() override;
virtual void dispose() override;
......@@ -256,6 +252,7 @@ namespace dbaui
virtual void fillWindows(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
private:
std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
};
} // namespace dbaui
......
......@@ -29,7 +29,6 @@ namespace dbaui
class OCommentUndoAction : public SfxUndoAction
{
protected:
OUString m_strComment; // undo, redo comment
public:
......
......@@ -34,9 +34,8 @@ class BaseCommandEnv
css::task::XInteractionHandler,
css::ucb::XProgressHandler >
{
protected:
css::uno::Reference< css::task::XInteractionHandler> m_forwardHandler;
protected:
void handle_(bool approve,
css::uno::Reference< css::task::XInteractionRequest> const & xRequest );
public:
......
......@@ -67,7 +67,6 @@ class SfxGrabBagItem;
// bEdge: Attribute will not expand, if you want to expand just on the edge
class EditCharAttrib
{
protected:
const SfxPoolItem* pItem;
sal_Int32 nStart;
......
......@@ -65,7 +65,6 @@ namespace dbp
class OMaybeListSelectionPage : public OControlWizardPage
{
protected:
VclPtr<RadioButton> m_pYes;
VclPtr<RadioButton> m_pNo;
VclPtr<ListBox> m_pList;
......
......@@ -49,7 +49,6 @@ namespace dbp
typedef ::svt::OWizardPage OControlWizardPage_Base;
class OControlWizardPage : public OControlWizardPage_Base
{
protected:
VclPtr<FixedText> m_pFormDatasourceLabel;
VclPtr<FixedText> m_pFormDatasource;
VclPtr<FixedText> m_pFormContentTypeLabel;
......
......@@ -53,7 +53,6 @@ namespace pcr
,public ImplInspectorModel_Base
,public ImplInspectorModel_PBase
{
protected:
std::unique_ptr< InspectorModelProperties > m_pProperties;
protected:
......
......@@ -160,13 +160,14 @@ class CGMFList
sal_uInt32 nCharSetCount;
::std::vector< std::unique_ptr<FontEntry> >
aFontEntryList;
sal_uInt32 nFontsAvailable;
void ImplDeleteList();
public:
CGMFList();
~CGMFList();
sal_uInt32 nFontsAvailable;
FontEntry* GetFontEntry( sal_uInt32 );
void InsertName( sal_uInt8 const * pSource, sal_uInt32 nSize );
void InsertCharSet( CharSetType, sal_uInt8 const * pSource, sal_uInt32 nSize );
......
......@@ -54,11 +54,11 @@ public:
class DXFBlocks {
public:
DXFBlock * pFirst;
// list of blocks, READ ONLY!
public: