According to the OOXML standard, <w:cr> (carriage return –
Unicode character 000D) is equivalent to a break
with null type and clear attributes, so we handle it as
a <w:br/>, instead of endOfParagraph, fixing
losing table paragraphs and tables containing <w:cr/>.

Note: It seems, MSO cannot handle carriage return characters
in table cells correctly. It shows squares (unknown
characters) without line break there. Copying this text to
a non-table paragraph in MSO, we get the correct layout with
line breaks. Copying this text with carriage return characters
back to a table cell, we get squares again. With this LO fix,
it will be possible to fix the bad tables edited by MS Word
by using LO, because LibreOffice import/export converts all
<w:cr>s to <w:br>s (as before, but now without destroying
the structure of the tables).

Change-Id: Iee42f71e9a00531353582e7127c2c212ea0890d0
Reviewed-on: https://gerrit.libreoffice.org/60585
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

...since 88582ebe "weld SdCharDlg"

Change-Id: Id6069271806e1a19688debf045169890e557cc66
Reviewed-on: https://gerrit.libreoffice.org/60645
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...after 27463197 "clang-tidy bugprone-copy-
constructor-init" made e.g. the SfxStyleSheetBase copy ctor (in
svl/source/items/style.cxx) use the copy instead of the default ctor for its
OWeakTypeObject sub-object

Change-Id: I7deec4ea2f968587ba1dc03e33206cecfa3f8df5
Reviewed-on: https://gerrit.libreoffice.org/60644
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...because loplugin:constfields is wrapped in

  #if !defined _WIN32 //TODO, #include <sys/file.h>

Change-Id: I9b2a72ecd31f561c71be5a74a752344c24d40f26
Reviewed-on: https://gerrit.libreoffice.org/60598
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

* Update helpcontent2 from branch 'master'
  - tdf#115254 Some branch bookmarks are'nt working 31
    
    Module cui
    
    Change-Id: I3f9dc6e469b04f0e86c426c907a8213fe351b8c4
    Reviewed-on: https://gerrit.libreoffice.org/60636
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Import time before:

12.192 seconds

After:

5.836 seconds (47.87% of baseline) for me.

Change-Id: Ifd650addaae3fe25b45cf0fd452f78372e60c467
Reviewed-on: https://gerrit.libreoffice.org/60591Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: I2219e81ed03a92ea5ff4cff3e494a7c483d16cec
    Reviewed-on: https://gerrit.libreoffice.org/60634
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: I7cae6b3f31b10efc72884bce4bda7bf6b380cbc2
Reviewed-on: https://gerrit.libreoffice.org/60597
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I825230daf223ff94ab1dbc19d81d478fbf464f56
Reviewed-on: https://gerrit.libreoffice.org/60596
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I14040fd236d399bfce6c4e6e6927a00aabe5b2c5
Reviewed-on: https://gerrit.libreoffice.org/60595
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This will guarantee SfxItemSet existence

Change-Id: Ia969b5391c7b20d3a2bbba4376a16fcaadccb9d4
Reviewed-on: https://gerrit.libreoffice.org/60563
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: Ibb1e11eb438607d26ebd06e7fb160cf850915d5b
Reviewed-on: https://gerrit.libreoffice.org/60555
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

it's useless since
commit c30e0cd9
Date:   Wed Apr 10 11:33:37 2002 +0000

    #97886# remove unnecessary page border offset

Change-Id: I89c7d4514ff212c62c6e681739ff3dfe0f04f633
Reviewed-on: https://gerrit.libreoffice.org/60553
Tested-by: Jenkins
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: Iefe6c616dc5f6bd525ed9708785846626f43c9b6
Reviewed-on: https://gerrit.libreoffice.org/60579
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If0c072c0a0a1548034dca37258f72294536ec566
Reviewed-on: https://gerrit.libreoffice.org/60578
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7b80ba0b2c85b191d5a7bec44d22293eb772d925
Reviewed-on: https://gerrit.libreoffice.org/60575Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I3211d2c8c35320a2e924cfe8bb561c315db4ef5e
Reviewed-on: https://gerrit.libreoffice.org/60534
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Id9c78651d3eb315bf2e982eef48ef24071bfc79b
Reviewed-on: https://gerrit.libreoffice.org/60550
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3e183d2cc0b0372b961b295801887bc4aadeb3b3
Reviewed-on: https://gerrit.libreoffice.org/60574Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This allows signing ooxml when an older default ODF version
has been configured.

Change-Id: I8e44caa2795c1da445895dd68d8cc60370c5747c
Reviewed-on: https://gerrit.libreoffice.org/60560
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Id3f164a5b5016fd7f1e33a0cb9e94ee84c1df6e5
Reviewed-on: https://gerrit.libreoffice.org/60566
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie6582b324d4c7feb8dbc7cac852b2c52358a052a
Reviewed-on: https://gerrit.libreoffice.org/60547
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ice26d1fd2ad97a6959c6916fef428777efea9c2d
Reviewed-on: https://gerrit.libreoffice.org/60500
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Since there is no way to retrieve the embedded native file dialog
from the Qt5 platfor abstraction, force the dialog in non-native
mode. This drops the 2nd option dialog completely.

While at it implement handling of the optional combo boxes in the
dialog.

Change-Id: I8d11e929a5f3b142dc0f5653fcc576231a1b0392
Reviewed-on: https://gerrit.libreoffice.org/60569
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I64c5ff89bedcee0d955e4aa12035302e413d0c02
Reviewed-on: https://gerrit.libreoffice.org/60567Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

* Update helpcontent2 from branch 'master'
  - DB help content clean-up
    
    Change-Id: Id5a3f2bd17d4e6a159fe6322eb9cec8012cc9d51
    Reviewed-on: https://gerrit.libreoffice.org/60487
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I7bde5987a51949d60174335327652186e0ad8998
Reviewed-on: https://gerrit.libreoffice.org/60559Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I51150783d0e624ae33efdd36857c2e26fb970ae0
Reviewed-on: https://gerrit.libreoffice.org/60558Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Ia0a19736dfd4500bb17b04c072710f8ee8744031
Reviewed-on: https://gerrit.libreoffice.org/60526
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I22d2d545a6201cbb89d430c65f66e0fea8794d83
Reviewed-on: https://gerrit.libreoffice.org/60541Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

accidentally introduced with
   commit 23f9d2b0
    match_colorKeyword should be using static const lookup table

Change-Id: I64c85504af6edba9f5e6a20b20ef245d43fd611b

Also fixes a bug where signing was aborted after saving as docx.

Change-Id: Ic42b7de2400be0bc55da03b017a545ceaedef9f9
Reviewed-on: https://gerrit.libreoffice.org/60480
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ie7f00ed4aef5318a525a526d0377bb7952bdd5a0
Reviewed-on: https://gerrit.libreoffice.org/60499
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I89164a9bc4710d9a90d415c2369c2cde3857c778
Reviewed-on: https://gerrit.libreoffice.org/60552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9fe9c042a4990c6399765819f6b8e80c17dba9d2
Reviewed-on: https://gerrit.libreoffice.org/60551
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    namespace { struct S2: S1 { int f() { return 1; } }; }
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    namespace { int f(S2 s) { return s.f(); } }
  }
  int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...showing that print_node etc. are actually unused

Change-Id: Ife7faf53dc2487a7ee0cfbe131a761ea18104945
Reviewed-on: https://gerrit.libreoffice.org/60538
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Use range-based loop or replace with STL functions.

Change-Id: Ic94c7e292f44d460038d3ca99c7e4cc02958d8a3
Reviewed-on: https://gerrit.libreoffice.org/60549
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...moving notdotdot to include.c (and some other decls to def.h)

Change-Id: I5d05988aca3daed978c2302380f69d1373081571
Reviewed-on: https://gerrit.libreoffice.org/60537
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Hopefully this fixes the problem, which is being incorrect version written
for the font in MSI (1.0.0.0), and comparing with installed one (1.3), the
font is removed and not reinstalled.

Change-Id: Iee675e2c2b3f29c76e35dcf41bbcce9b6181bf62
Reviewed-on: https://gerrit.libreoffice.org/60548
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>