loplugin:simplifyconstruct (clang-cl)

Change-Id: I7cae6b3f31b10efc72884bce4bda7bf6b380cbc2
Reviewed-on: https://gerrit.libreoffice.org/60597
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

connectivity/source/drivers/ado/ADatabaseMetaDataResultSet.cxx

@@ -53,7 +53,6 @@ ODatabaseMetaDataResultSet::ODatabaseMetaDataResultSet(ADORecordset* _pRecordSet
     ,OPropertySetHelper(ODatabaseMetaDataResultSet_BASE::rBHelper)
     ,m_pRecordSet(_pRecordSet)
     ,m_aStatement(nullptr)
-    ,m_xMetaData(nullptr)
     ,m_nRowPos(0)
     ,m_bWasNull(false)
     ,m_bEOF(false)

connectivity/source/drivers/ado/ADriver.cxx

@@ -215,7 +215,7 @@ Reference< XTablesSupplier > SAL_CALL ODriver::getDataDefinitionByConnection( co
 
     }
 
-    Reference< XTablesSupplier > xTab = nullptr;
+    Reference< XTablesSupplier > xTab;
     if(pConnection)
     {
         WpADOCatalog aCatalog;

connectivity/source/drivers/ado/AResultSet.cxx

@@ -74,7 +74,6 @@ OResultSet::OResultSet(ADORecordset* _pRecordSet,OStatement_Base* pStmt) :  ORes
                         ,m_pRecordSet(_pRecordSet)
                         ,m_pStmt(pStmt)
                         ,m_xStatement(*pStmt)
-                        ,m_xMetaData(nullptr)
                         ,m_nRowPos(0)
                         ,m_bEOF(false)
                         ,m_bOnFirstAfterOpen(false)
@@ -85,8 +84,6 @@ OResultSet::OResultSet(ADORecordset* _pRecordSet) : OResultSet_BASE(m_aMutex)
                         ,OPropertySetHelper(OResultSet_BASE::rBHelper)
                         ,m_pRecordSet(_pRecordSet)
                         ,m_pStmt(nullptr)
-                        ,m_xStatement(nullptr)
-                        ,m_xMetaData(nullptr)
                         ,m_nRowPos(0)
                         ,m_bEOF(false)
                         ,m_bOnFirstAfterOpen(false)

embeddedobj/source/msole/olemisc.cxx

@@ -107,7 +107,6 @@ OleEmbeddedObject::OleEmbeddedObject( const uno::Reference< lang::XMultiServiceF
 // this constructor let object be initialized from clipboard
 OleEmbeddedObject::OleEmbeddedObject( const uno::Reference< lang::XMultiServiceFactory >& xFactory )
 : m_pOleComponent( nullptr )
-, m_pInterfaceContainer( nullptr )
 , m_bReadOnly( false )
 , m_bDisposed( false )
 , m_nObjectState( -1 )

embedserv/source/embed/docholder.cxx

@@ -1205,7 +1205,7 @@ css::uno::Reference< css::awt::XWindow> SAL_CALL DocumentHolder::getContainerWin
     if(m_xContainerWindow.is())
         return m_xContainerWindow;
 
-    uno::Reference<awt::XWindow> xWin(nullptr);
+    uno::Reference<awt::XWindow> xWin;
 
     uno::Reference<awt::XToolkit2> xToolkit = awt::Toolkit::create( comphelper::getComponentContext(m_xFactory) );
 

vcl/win/gdi/salfont.cxx

@@ -620,7 +620,6 @@ WinFontFace::WinFontFace( const FontAttributes& rDFS,
 :   PhysicalFontFace( rDFS ),
     mnId( 0 ),
     mbFontCapabilitiesRead( false ),
-    mxUnicodeMap( nullptr ),
     meWinCharSet( eWinCharSet ),
     mnPitchAndFamily( nPitchAndFamily ),
     mbAliasSymbolsHigh( false ),

winaccessibility/source/UAccCOM/EnumVariant.h

@@ -45,8 +45,7 @@ class ATL_NO_VTABLE CEnumVariant :
 public:
     CEnumVariant()
             :m_lLBound(0),
-            pUNOInterface(nullptr),
-            m_pXAccessibleSelection(nullptr)
+            pUNOInterface(nullptr)
     {
         m_lCurrent = m_lLBound;
     }

winaccessibility/source/service/AccObjectWinManager.cxx

@@ -399,7 +399,7 @@ int AccObjectWinManager::UpdateAccSelection(XAccessible* pXAcc)
     if(pAccObj==nullptr)
         return 0;
 
-    Reference<XAccessible> pRChild = nullptr;
+    Reference<XAccessible> pRChild;
     AccObject* pAccChildObj = nullptr;
     int selectNum= pRSelection->getSelectedAccessibleChildCount();
 

xmlsecurity/source/xmlsec/mscrypt/xmlsecuritycontext_mscryptimpl.cxx

@@ -76,8 +76,6 @@ class XMLSecurityContext_MSCryptImpl : public ::cppu::WeakImplHelper<
 };
 
 XMLSecurityContext_MSCryptImpl::XMLSecurityContext_MSCryptImpl()
-    ://m_pKeysMngr( NULL ) ,
-     m_xSecurityEnvironment( nullptr )
 {
 }