- 25 Eyl, 2018 6 kayıt (commit)
-
-
Arkadiy Illarionov yazdı
Use range-based loop or replace with STL functions. Change-Id: I2af2d739d55a0bf480bb6e9d57b49dd16806af30 Reviewed-on: https://gerrit.libreoffice.org/60734 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Miklos Vajna yazdı
Deciding when to and when not to deduplicate repeated direct formatting of paragraph / character properties is stricky, this bug is about a case when deduplication should happen and did not, since commit 1970a686 (tdf#113408 RTF import style dedup: separate paragraph and character handling, 2017-10-31). Especially that deduplication works in both directions: it should remove properties which are duplicated and also should insert explicit default values for not repeated properties. Fix the problem by making the getDefaultSPRM() aware of the context (which style type it deals with), and then by making sure that only default properties relevant for the given style type are inserted. Change-Id: I35b6599cc47fa51b8754fd921c61a3b31a283547 Reviewed-on: https://gerrit.libreoffice.org/60946Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
-
Rizal Muttaqin yazdı
Change-Id: Iee80ba5e1dab7d36798dc3e9dcbae3dfc86e86a0
-
Rizal Muttaqin yazdı
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b7
-
Markus Mohrhard yazdı
Change-Id: Iec5e591f51ab13efa4b014b82df213e91eb5b793 Reviewed-on: https://gerrit.libreoffice.org/60949 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
-
Markus Mohrhard yazdı
Change-Id: Icac79eb1c0c47388f96d37d2921c81fb6c848607 Reviewed-on: https://gerrit.libreoffice.org/60948 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
-
- 24 Eyl, 2018 19 kayıt (commit)
-
-
Adolfo Jayme Barrientos yazdı
Change-Id: I766ae652ef08c865eb5faa0f2d53220ccb00c828
-
andreas kainz yazdı
Change-Id: I1e8c28f477602c7578ca7e40bd7d14550dc1aaf8 Reviewed-on: https://gerrit.libreoffice.org/60930 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b Reviewed-on: https://gerrit.libreoffice.org/60943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Jan-Marek Glogowski yazdı
Regression from commit 221b0ab1 ("WIN use Reschedule instead of own dispatch loops"). This limit the maximum reschedule loops as the original code did. There is still a busy loop when opening the print dialog, as it was before the patch, but this at least gets printing started. Change-Id: If867329b82b13c898bb15b08584244084488a66c Reviewed-on: https://gerrit.libreoffice.org/60310 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
-
Adolfo Jayme Barrientos yazdı
Change-Id: I6a2bcdd8403494490a44c11179bf87411f73d32a
-
Stephan Bergmann yazdı
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
Change-Id: I4132e02ce9a4eb509a2e70a705068102f95ffd3e Reviewed-on: https://gerrit.libreoffice.org/60937 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
icons are off by default so not usually seen Change-Id: I6076fd87250fc4595d279c830e14779147b7857a Reviewed-on: https://gerrit.libreoffice.org/60935Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Stephan Bergmann yazdı
Change-Id: I021b378b2ae001a38c8f84a71e90ec4f14c905e6 Reviewed-on: https://gerrit.libreoffice.org/60928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Jan-Marek Glogowski yazdı
This way we don't have to search the whole list for a higher priority event, if an immediate Task is found. This probably helps bugs like tdf#119724 and tdf#119428. Change-Id: Ic5685193d1bedb6996cf46f0ee2cba42190ff7cc Reviewed-on: https://gerrit.libreoffice.org/60572 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
-
Stephan Bergmann yazdı
Change-Id: I3a52b0e2517cfd88f661dde2b01b2e6bc6913ba2 Reviewed-on: https://gerrit.libreoffice.org/60927 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
andreas kainz yazdı
Change-Id: Id8a920054c5b6f560ff2b26ce39c2a99574ad680 Reviewed-on: https://gerrit.libreoffice.org/60929 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Stephan Bergmann yazdı
...avoiding conditional blocks and variables (that need careful #if'ing to avoid them being either undefined or unused depending on NDEBUG and OSL_DEBUG_LEVEL combintaion) Change-Id: Ica9fe3857694f5c0a6e9079dfff05f2e0554b781 Reviewed-on: https://gerrit.libreoffice.org/60926 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
...as they appear to only be called from within this .cxx. (And <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> documents that STDAPI expands to a return type of HRESULT, among further decoration.) Change-Id: I4994e6e6f8fe0466f9aa9b4c9cf2c20bd718fa05 Reviewed-on: https://gerrit.libreoffice.org/60925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I85fa703ebe73987822f85ff722f02627751937ec Reviewed-on: https://gerrit.libreoffice.org/60909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I6ade72ed19b63b7f68c8f58c57bb409eab55e55c Reviewed-on: https://gerrit.libreoffice.org/60919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Miklos Vajna yazdı
... SwRedlineExtraData_FormatColl and SwRedlineExtraData_FormattingChanges. Change-Id: I7dedf293ba06879985d4652e073642d5a15d97ca Reviewed-on: https://gerrit.libreoffice.org/60922Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
-
Rizal Muttaqin yazdı
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b6 Reviewed-on: https://gerrit.libreoffice.org/60920 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
- 23 Eyl, 2018 8 kayıt (commit)
-
-
andreas kainz yazdı
open calc and impress and drop down graphic menu Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b5 Reviewed-on: https://gerrit.libreoffice.org/60778 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Adolfo Jayme Barrientos yazdı
* Update helpcontent2 from branch 'master' - tdf#108890 Chapter Numbering button “Format” renamed “Load/Save” Change-Id: Iec39885663c838dfaf112c1a4a99bcde7b9f9036
-
Caolán McNamara yazdı
Change-Id: Id6dad66b3c55e5b3049f57e65c857db5abce50b1 Reviewed-on: https://gerrit.libreoffice.org/60901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I770dad005779e7bf347221afad46633371f17a07 Reviewed-on: https://gerrit.libreoffice.org/60908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
heiko tietze yazdı
Renamed to Load/Save according discussion on BZ Change-Id: I7444ffc6b2d6158542357364fd6a282a1684a33d Reviewed-on: https://gerrit.libreoffice.org/60876 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
-
Thorsten Behrens yazdı
Add missing header after 60a23d5d Change-Id: Ic24a78db3b425966e49fec96160d10670f68dea4
-
Xisco Fauli yazdı
Regression from c57f10b6, where I disabled the master background in Impress but not in Draw, and both share some common code. Besides, disable master background in draw as well. Follow-up of bug tdf#111306 Change-Id: I772382b5ed8eff3a35d001ea498810613137d172 Reviewed-on: https://gerrit.libreoffice.org/60913 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
-
Noel Grandin yazdı
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
- 22 Eyl, 2018 7 kayıt (commit)
-
-
Stephan Bergmann yazdı
bdade7e3 "tdf#105444 DOCX import: don't put extra paragraphs in comments" caused > /home/sbergman/lo2/core/writerfilter/source/dmapper/DomainMapper_Impl.cxx:441:22: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > (sizeof(SAL_NEWLINE_STRING)-1 == 2 && xCursor->getString() == "\n")) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ now with sufficiently new Clang, and the code looks reasonable, and there's no apparent way to avoid such false positives in the plugin. (It could check for a sub-expression of the problematic expression being an object-like macro, but SAL_NEWLINE_STRING could just as well be a variable instead of a macro. That variable would need to be defined in some #if to have different values on different platforms, so the plugin could theoretically check for such conditional inclusion, but it's not clear whether that's worth it and would even be a useful heuristic to not produce neither too many false positives nor too many false negatives.) So just disable the plugin for good. Change-Id: I85dc8573735ccac4e19be20ab7443cbaa85a3164 Reviewed-on: https://gerrit.libreoffice.org/60907 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Muhammet Kara yazdı
Change-Id: I7610e890a8b49c50bf23ed07daa5517c33edcb8d Reviewed-on: https://gerrit.libreoffice.org/60897 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
-
Caolán McNamara yazdı
Change-Id: If7cd5e7157419c5d3b3a7ff834613e7f6489047c Reviewed-on: https://gerrit.libreoffice.org/60900Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Lionel Elie Mamane yazdı
We first try to prepare the statement and get metadata information. That's fine. Some DB engines/drivers will not give column information on an unexectured prepared statement. In that case, first try to execute the statement with all parameters set to NULL, which is likely to succeed. If not, keep "execute the raw SQL indiscriminately" as a last resort. I'm not sure it will ever be useful, though. Change-Id: I76b5fd6b2059e96fabe9a611c8e3ed115acfc964 Reviewed-on: https://gerrit.libreoffice.org/60884 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
-
Caolán McNamara yazdı
no warning in glade about it, though there is for other such things that don't exist in the targetted version Change-Id: Ib1522aaf9709b94274db378678314dc945048d97 Reviewed-on: https://gerrit.libreoffice.org/60899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Stephan Bergmann yazdı
buovjaga reported on IRC that his build (implicitly --without-system-harfbuzz --without-system-icu) failed to link e.g. Library_vclplug_gtk3 due to harfbuzz missing symbols from ICU, like > /usr/bin/ld: /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/.libs/libharfbuzz.a(libharfbuzz_la-hb-icu.o): in function `hb_icu_unicode_decompose_compatibility(hb_unicode_funcs_t*, unsigned int, unsigned int*, void*)': > /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/hb-icu.cc:334: undefined reference to `unorm2_getNFKDInstance_62' [...] It is not clear to me why Library_vclplug_gtk3 would actually use libharfbuzz.a's hb_icu_unicode_decompose_compatibility (and for e.g. my builds, it apparently doesn't), but in general libharfbuzz.a does depend on some symbols from icuuc, so it is correct to add icuuc to the link when linking against harfbuzz. (And "gb_LinkTarget_use_external,...,icuuc" conveniently only adds libs for linking, and does not add C/C++ include file paths, which would not be wanted here.) (<https://gerrit.libreoffice.org/#/c/60882/> "Revert 'Add more more dependencies to VCL makefiles'" was a false start trying to address the above issue.) Change-Id: Ic8bcfa2aab185f8a9487d7787b4f22068e7cb481 Reviewed-on: https://gerrit.libreoffice.org/60898 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I171150342e04bee6efd97f36f769a2c3d1db4bd7 Reviewed-on: https://gerrit.libreoffice.org/60887Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-