unwind ItemWrapperHelper

Change-Id: I171150342e04bee6efd97f36f769a2c3d1db4bd7
Reviewed-on: https://gerrit.libreoffice.org/60887Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cui/source/tabpages/align.cxx

@@ -32,7 +32,6 @@
 #include <svx/dlgutil.hxx>
 #include <sfx2/app.hxx>
 #include <sfx2/module.hxx>
-#include <sfx2/itemconnect.hxx>
 #include <svl/cjkoptions.hxx>
 #include <svl/languageoptions.hxx>
 #include <svx/flagsdef.hxx>

cui/source/tabpages/border.cxx

@@ -42,7 +42,6 @@
 #include <svl/intitem.hxx>
 #include <svl/ilstitem.hxx>
 #include <svl/int64item.hxx>
-#include <sfx2/itemconnect.hxx>
 #include <sal/macros.h>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 
@@ -374,8 +373,8 @@ SvxBorderTabPage::SvxBorderTabPage(TabPageParent pParent, const SfxItemSet& rCor
 
         mbHorEnabled = pBoxInfo->IsHorEnabled();
         mbVerEnabled = pBoxInfo->IsVerEnabled();
-        mbTLBREnabled = sfx::ItemWrapperHelper::IsKnownItem( rCoreAttrs, SID_ATTR_BORDER_DIAG_TLBR );
-        mbBLTREnabled = sfx::ItemWrapperHelper::IsKnownItem( rCoreAttrs, SID_ATTR_BORDER_DIAG_BLTR );
+        mbTLBREnabled = rCoreAttrs.GetItemState(GetWhich(SID_ATTR_BORDER_DIAG_TLBR)) != SfxItemState::UNKNOWN;
+        mbBLTREnabled = rCoreAttrs.GetItemState(GetWhich(SID_ATTR_BORDER_DIAG_BLTR)) != SfxItemState::UNKNOWN;
 
         if(pBoxInfo->IsDist())
         {

include/sfx2/tabdlg.hxx

@@ -374,8 +374,6 @@ protected:
 public:
     void                SetTabDialog(SfxTabDialog* pDialog);
     void                SetDialogController(SfxTabDialogController* pDialog);
-protected:
-    void                AddItemConnection( sfx::ItemConnectionBase* pConnection );
 public:
     virtual             ~SfxTabPage() override;
     virtual void        dispose() override;

sfx2/source/dialog/tabdlg.cxx

@@ -32,7 +32,6 @@
 #include <sfx2/ctrlitem.hxx>
 #include <sfx2/bindings.hxx>
 #include <sfx2/sfxdlg.hxx>
-#include <sfx2/itemconnect.hxx>
 #include <sfx2/viewsh.hxx>
 #include <uitest/sfx_uiobject.hxx>
 #include <unotools/viewoptions.hxx>
@@ -51,7 +50,6 @@ using namespace ::com::sun::star::uno;
 struct TabPageImpl
 {
     bool                        mbStandard;
-    sfx::ItemConnectionArray    maItemConn;
     VclPtr<SfxTabDialog>        mxDialog;
     SfxTabDialogController*     mpDialogController;
     css::uno::Reference< css::frame::XFrame > mxFrame;
@@ -213,15 +211,13 @@ void SfxTabPage::dispose()
     TabPage::dispose();
 }
 
-bool SfxTabPage::FillItemSet( SfxItemSet* rSet )
+bool SfxTabPage::FillItemSet( SfxItemSet* )
 {
-    return pImpl->maItemConn.DoFillItemSet( *rSet, GetItemSet() );
+    return false;
 }
 
-void SfxTabPage::Reset( const SfxItemSet* rSet )
+void SfxTabPage::Reset( const SfxItemSet* )
 {
-    pImpl->maItemConn.DoApplyFlags( rSet );
-    pImpl->maItemConn.DoReset( rSet );
 }
 
 void SfxTabPage::ActivatePage( const SfxItemSet& )
@@ -327,11 +323,6 @@ void SfxTabPage::ChangesApplied()
 {
 }
 
-void SfxTabPage::AddItemConnection( sfx::ItemConnectionBase* pConnection )
-{
-    pImpl->maItemConn.AddConnection( pConnection );
-}
-
 void SfxTabPage::SetTabDialog(SfxTabDialog* pDialog)
 {
     pImpl->mxDialog = pDialog;