On Windows, UTF-8 is never current locale encoding; so using 8-bit
strings will always fail for paths containing characters outside
of current codepage.
Also fix leaks caused by failing to release its result: previously
it could return either result of getenv (that shouldn't get freed),
or an allocated string, but never got freed; now the result is
always allocated and properly freed.

Change-Id: I8b255dea20040eec0572de2b34280749fe8f071c
Reviewed-on: https://gerrit.libreoffice.org/42743Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

This reverts commit b55d8661 which
was a trial attemp to fix a regression from tdf#91260.

Not reverting my jenkins comment that "Actually, I think that
the regression commit ought to be fully reverted. It "fixes" such
a strange situation and seems to have a lot of unintended
repercussions. Just look at tdf#91260 and see all of the
additional patches."

Change-Id: I6852f6d494f48f68eefc39019c44f2cbd96ec5a5
Reviewed-on: https://gerrit.libreoffice.org/42827Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

The rotation is already applied to the child shapes and must not be
added to the group.

Change-Id: Ic564cbcf31a81a248878f0179fdd21144f076b61
Reviewed-on: https://gerrit.libreoffice.org/42765Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

The code in DelFullPara() returns early if it can't move the rPam
out of the to-be-deleted paragraph, but it only checks that the point
of the rPam is outside; it then rather pointlessly assigns the 0
index in the node where the mark is, which leaves the mark on the
to-be-deleted paragraph.

In this modern day and age, after much technological progress,
DeleteMark() actually does unregister its SwIndex, so just do that.

Change-Id: Ia1643cf0b976857809ee4130efdec37ce831fdef

Change-Id: Ifea7653435743bb652afa68d734ed553b04606d7
Reviewed-on: https://gerrit.libreoffice.org/42804Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I82566e2f2ad479c392f06ae7149e3781c0338e50
Reviewed-on: https://gerrit.libreoffice.org/41630Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

similar to

commit 35bac83e
Date:   Mon Aug 7 19:24:37 2017 +0100

    ofz#2877: crash in SVTB16Short

Change-Id: Idc2ca89647a5e17484effaca49afce349b98f0a3
Reviewed-on: https://gerrit.libreoffice.org/42622Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4de6d9d781b2f2313d8fd338b34dcb31434efe91
Reviewed-on: https://gerrit.libreoffice.org/41638Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib1eacda7e4cdf1d0238532f4e38059a9c30556ac
Reviewed-on: https://gerrit.libreoffice.org/41626Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id682c1078359db2e2883b71977efedc79235017c
Reviewed-on: https://gerrit.libreoffice.org/42805Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

BTE was 2 bytes in word 7- but 4 bytes in word 8+

Change-Id: I24007d26fccc5edc104320bd2eb8f9c62399c988
Reviewed-on: https://gerrit.libreoffice.org/41623Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id633b031d2856dab49bbedc6faf45670a3762c51
Reviewed-on: https://gerrit.libreoffice.org/42801Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id54a6ef74059885728c1dffec10d67c9f56ba684
Reviewed-on: https://gerrit.libreoffice.org/42797Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Prior to commit 9920a0bf
the style could only contain the default of NONE. So when
a position was specified, it was always paired with
HoriOrient == NONE. So it never caused problems until
that commit when the Frame's style orientation started
overriding the unset paragraph default.

When a position is specified, that needs to be paired with an
orientation of NONE in order to take effect.

Change-Id: Iab0057810270ba708a8855c2ec6db291cef17cfb
Reviewed-on: https://gerrit.libreoffice.org/42499Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I9aaefa47399f35d563c1a4df364512dd29db41ce
Reviewed-on: https://gerrit.libreoffice.org/42817Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

...without also accidentally affecting any upstream Clang 9.0

Change-Id: Ie52413e2e53a2ce01f55b97677fe9878d498b076
Reviewed-on: https://gerrit.libreoffice.org/42809Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

CppunitTest_sc_subsequent_export_test would run into that as below, so better
find a more suitable encoding here (similar to what RTFDocumentImpl::getEncoding
in writerfilter/source/rtftok/rtfdocumentimpl.cxx does to "Guess based on
locale").

> rtl::OUStringToOString(rtl::OUString const&, unsigned short, unsigned int) at include/rtl/ustring.hxx:3662
> XclExpHyperlink::XclExpHyperlink(XclExpRoot const&, SvxURLField const&, ScAddress const&) at sc/source/filter/excel/xecontent.cxx:370
> XclExpHyperlinkHelper::ProcessUrlField(SvxURLField const&) at sc/source/filter/excel/xehelper.cxx:307
> (anonymous namespace)::lclCreateFormattedString(XclExpRoot const&, EditEngine&, XclExpHyperlinkHelper*, unsigned short, unsigned short) at sc/source/filter/excel/xehelper.cxx:471
> XclExpStringHelper::CreateCellString(XclExpRoot const&, EditTextObject const&, ScPatternAttr const*, XclExpHyperlinkHelper&, unsigned short, unsigned short) at sc/source/filter/excel/xehelper.cxx:583
> XclExpLabelCell::XclExpLabelCell(XclExpRoot const&, XclAddress const&, ScPatternAttr const*, unsigned int, EditTextObject const*, XclExpHyperlinkHelper&) at sc/source/filter/excel/xetable.cxx:708
> XclExpCellTable::XclExpCellTable(XclExpRoot const&) at sc/source/filter/excel/xetable.cxx:2569
> ExcTable::FillAsTableXml() at sc/source/filter/excel/excdoc.cxx:589
> ExcDocument::ReadDoc() at sc/source/filter/excel/excdoc.cxx:771
> XclExpXmlStream::exportDocument() at sc/source/filter/excel/xestream.cxx:1113
> oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at oox/source/core/filterbase.cxx:495
> oox::xls::ExcelFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sc/source/filter/oox/excelfilter.cxx:169
> SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2380
> SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1500
> SfxObjectShell::DoSaveAs(SfxMedium&) at sfx2/source/doc/objstor.cxx:1889
> ScBootstrapFixture::saveAndReload(ScDocShell*, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags) at sc/qa/unit/helper/qahelper.cxx:669
> ScBootstrapFixture::saveAndReload(ScDocShell*, int) at sc/qa/unit/helper/qahelper.cxx:691
> ScExportTest::testTdf111876() at sc/qa/unit/subsequent_export-test.cxx:438
[...]

Change-Id: Ia8a07336bc6fc39573676c227a551fbfe50a519e
Reviewed-on: https://gerrit.libreoffice.org/42789Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Use stock button for OK and identation fixes.
Followup changes to:
40209456

Change-Id: I3fe2f2f9a4528d38086db453d7ea71f7ac8b7a9a
Reviewed-on: https://gerrit.libreoffice.org/42800Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Fails without commit 9480ff6a (EPUB
export: implement link support, 2017-08-17).

Change-Id: Icee6ac04ff77d0e9ff66ca1f925d6973b4b342a2
Reviewed-on: https://gerrit.libreoffice.org/42786Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

changed tar backup path

Change-Id: I4a1701d856bcdf6f20d3d869f1ba84a18c67b278

Added README with instruction on how to build for
the different platforms, updated iOS files corresponding

Change-Id: I8a85f808841d682bc09f1e3b039192e342ecc484

...instead of once for each class derived from CollectionsTestBase (as listed in
pyuno/PythonTest_pyuno_pytests_testcollections.mk), causing the

  assert(!pSVData->maDeInitHook.IsSet());

in Application::setDeInitHook (vcl/source/app/svapp.cxx) to fire.

This is probably far from being idiomatic Python code...

Change-Id: I8cd1470c085b16b7b82468a308cfd1dead2db034

Change-Id: Id454ed0efbb90cfe3ece0bdedf51f385962ee357

... in SwFrameFormat::Modify().

Change-Id: I3b7ea1493277d8d705bdf77c50fdff49872bac05

Styles don't have anchors, only frames have anchors.

When using "New Style from Selection", clear the RES_ANCHOR from
the style item set.

Also, don't insert it in SwFramePage::DeactivatePage().

This was always broken and reportedly crashes since commit
e07feb94

Change-Id: I9320dbbcae980dfa0b00459b8cd808553d1a04f4

Change-Id: Id8f863963cb2f34d81f2ad82353caaa2d03d59be
Reviewed-on: https://gerrit.libreoffice.org/42807Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I55a92512ad9e1508c49ee3149394196f5be5f162
Reviewed-on: https://gerrit.libreoffice.org/42784Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7ab055f301785a73d189e58465056ac4b2e8b494
Reviewed-on: https://gerrit.libreoffice.org/42783Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Reduce potential confusion with the global tools namespace. Will
hopefully make it possible to remove the annoying initial :: when
referring to the global tools namespace. Unless we have even more
tools subnamespaces somewhere.

Thorsten said it was OK.

Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996
Reviewed-on: https://gerrit.libreoffice.org/42644Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I77d92e7adc9af5c88ca1930c25a0585713f9e0d3
Reviewed-on: https://gerrit.libreoffice.org/42788Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The logical follow-up on commit 6d1c8a43.

Also complete inlined templates, so no need for explicit export, which
actually can break the non-pch build on Windows.

Change-Id: Ifebd7608673bba9f3530c01be30bab6414a66976

Change-Id: I2f910194c541cb0b882c69d03b02749ef9b93d29
Reviewed-on: https://gerrit.libreoffice.org/42777Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The values were not converted to the right unit. Also the
spcPts attribute means an exact value not a minimum one.

Change-Id: Ia49683e66153611e96a830f821e3a2487adec505
Reviewed-on: https://gerrit.libreoffice.org/42763Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Just focus on the content, no formatting yet.

Change-Id: I109f049bafae6a20d6b617f3be6a9c4f237e782b
Reviewed-on: https://gerrit.libreoffice.org/42785Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

This moves the logic into SwEditShell next to
the exiting paragraph metadata infrastructure.

Change-Id: I6c12bfca3d2e1b2bc8697f03f4de1b7c3e14b95a
Reviewed-on: https://gerrit.libreoffice.org/42742Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I244a3fc7899b3269cfdc76172f5dd57a2b987373
Reviewed-on: https://gerrit.libreoffice.org/42741Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I5c307db7ef1c5980c9ae7706ae95970b5705ab58
Reviewed-on: https://gerrit.libreoffice.org/42740Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I9fc01072373dac0cade7b30c3654827bd82d78cc
Reviewed-on: https://gerrit.libreoffice.org/42739Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: Iebd50de0abecb80a4de38257fa2eea10b81962b7
Reviewed-on: https://gerrit.libreoffice.org/42738Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: I3a5f201f9ed28452ee7392cb30aebf21955f3620
Reviewed-on: https://gerrit.libreoffice.org/42737Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>