Change-Id: Ia6558039da010b0f6d8385e9791c0abc2ef75eba
Reviewed-on: https://gerrit.libreoffice.org/73665Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8ecc08d3ef42b9f7cc501017e0e169bde2196317
Reviewed-on: https://gerrit.libreoffice.org/73654
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

after
    commit a46a2577
    Date:   Wed Jun 5 15:24:04 2019 +0200
    improve empty tools::Rectangle (width)

Change-Id: I496d92712aa7627f7d6932d7d01f70a68a1ee781
Reviewed-on: https://gerrit.libreoffice.org/73657Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e
Reviewed-on: https://gerrit.libreoffice.org/73626
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

This is nominally a regression from commit
af11abf3 (SwViewShell::ImplEndAction:
still paint directly when non-double-buffering, 2015-09-01), but that
just uncovered an already existing problem introduced earlier in commit
2b26c179 (tdf#92577 sw rendercontext:
paint transparent from controls conditionally, 2015-07-06).

Given that the first commit (as a side-effect) solved the problem the
second commit tried to solve, it's safe to just revert this.

(Sadly we have no way to test incremental paints with a reasonable
amount of effort, so no testcase.)

Change-Id: Ia59efbf45a0cd5af3580914e1dcee74d89068f03
Reviewed-on: https://gerrit.libreoffice.org/73647Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Without this, the vcl's AboutDialog conflicts with the AboutDialog from
cui during linking of liblo-native-code.so.

Change-Id: Ie6e5ddd52bb7bdee1c7d53c37ea566d7ce6c9385
Reviewed-on: https://gerrit.libreoffice.org/73613
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Ifdafc97c8616da5d844a1ade7694265a833e8f53
Reviewed-on: https://gerrit.libreoffice.org/73598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Drop all GStreamer 0.10 support according to
ESC decision of 2019-06-06.

GStreamer 0.10 is obsolete and no longer needed,
superseded by GStreamer 1.0 which is available in
baseline (RHEL 7 or CentOS 7) and all relevant distros.

Change-Id: Ic317eba04d2c17e141acc983f37fbfa4301c9f3f
Reviewed-on: https://gerrit.libreoffice.org/73619
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

This is the width part, the height part will come next.

Instead of storing "empty" as a special value (which is easy to get
wrong, eg. some image filters pass in that special value, expecting it
to be a valid width), just use separate boolean values for width and
height empty.

Also lots of code was calling GetBottom() or GetRight() on an
empty rectangle, getting back that magic value and doing calculations
on it, resulting in completely bogus data.

So
(1) make the various Rectangle methods do something reasonable
    when the empty flags are set
(2) fix various other code to handle empty better
(3) assert when code accesses Bottom or Right and the empty flag
    is set.

Change-Id: I1163378cd2773dd8b386210f83400bb6b4701069
Reviewed-on: https://gerrit.libreoffice.org/73564
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Except source/svdde/* which is WIN-specific

Also recheck include/svl

Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe
Reviewed-on: https://gerrit.libreoffice.org/73630
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

By using the now working btlr direction of the underlying fly frame,
instead of the character-level workaround.

Change-Id: I3024e3348a30c72f461032b03b88c210f25eb75a
Reviewed-on: https://gerrit.libreoffice.org/73628
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Quikee agreed that they aren't really useful. Doing even the simplest
things causes such a huge amount of logging that it is questionable
whether anybody could have any use of it.

Parts of it might be useful to restore later, if need arises. Like the
mnContextStackDepth logging in vcl/inc/quartz/CGHelpers.hxx.

Change-Id: If635e6492a50e5955c56c54fa310e7c0ab2986ae
Reviewed-on: https://gerrit.libreoffice.org/73639
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I0037cf0a59189862ad502bfbdb00580ed7378fe4
Reviewed-on: https://gerrit.libreoffice.org/70393
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4b4f0d6c96d85d050110ff39db2cc06bb1d666c2
Reviewed-on: https://gerrit.libreoffice.org/70690Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iec0824418063fa4d146d9d48f3c74561fc0c5a67
Reviewed-on: https://gerrit.libreoffice.org/73631
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If9d52bd769d96865a3fbfdda1f339bbd0f8c3ca3
Reviewed-on: https://gerrit.libreoffice.org/73633
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie9174d46b3936ee19a7d1e70f85af6fed2c0c6d4
Reviewed-on: https://gerrit.libreoffice.org/73637Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I577cecc9b5c73a999b0e38478adf71c527210619
Reviewed-on: https://gerrit.libreoffice.org/73635
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Icbfc9276e09f2d50647c4e800b6d688d978b875b
Reviewed-on: https://gerrit.libreoffice.org/73632
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I1ed7280266fc2612ca1286c129a614c51aba3571
Reviewed-on: https://gerrit.libreoffice.org/73636
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4cfc98ab3be0c789274978ec6b26f981ad627494
Reviewed-on: https://gerrit.libreoffice.org/73634
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

A search with git grep ".uno:ToolsMacroEdit" showed that the entry isn't
used anywhere (also .uno:BasicIDEAppear provides a similar functionality).

Change-Id: Ib97f4ebd6707d82f9077dd2f4e6c05e537f8154d
Reviewed-on: https://gerrit.libreoffice.org/73582
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ie4d9858e5b4b3e55ab08416fb9338d2df34ee5e1
Reviewed-on: https://gerrit.libreoffice.org/73627
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: Id9a188fc46d800212ff583a233f06553bf1b4596
Reviewed-on: https://gerrit.libreoffice.org/73591
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Iadd17df97f374752097c8cad4b82735a4c77f923
Reviewed-on: https://gerrit.libreoffice.org/73343
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>

Change-Id: I7566c158330bab77589d422c61c64210727ab835
Reviewed-on: https://gerrit.libreoffice.org/73625
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

to another when importing Powerpoint ppt file

regression from
    commit 4245454d
    Date:   Wed Feb 28 15:50:29 2018 +0200
    loplugin:useuniqueptr in SdrPowerPointImport

Change-Id: I5f415dfa1f6125629b9f3be1d799cb596c64c605
Reviewed-on: https://gerrit.libreoffice.org/73602Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Comming back to my initial, known broken implementation from
2017-11 (see commit 1426437b ("QT5 implement some mouse
handling")), which just works with mouse scroll wheels.

This just fixes angleDelta() based scrolling. An additional
patch might be needed, if some driver just uses pixelDelta()
values, but Qt explicitly states: "On X11 the pixelDelta()
value is driver specific and unreliable, use angleDelta()
instead.", so we'll do just that for now.

Change-Id: I1be5f9392ed475aea7ab4d965a07e1e3c2574fe7
Reviewed-on: https://gerrit.libreoffice.org/73614
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

This avoids the issue that build breaks when both gtk3
and gstreamer-0.10 are enabled, caused by commit
34bbf192
("Drop extra define ENABLE_GTKSINK").

gstreamer-0.10 related code will be removed in
a subsequent step according to ESC decision (no longer
needed).

Change-Id: Ief07a797a3e52229da0ff7b23478108aac900841
Reviewed-on: https://gerrit.libreoffice.org/73608
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Otherwise the gradient won't be commited to the Metafile, as
mbOutputClipped will be true, because the output device will
have just one pixel size.

Change-Id: I73084eb715ee6313f6478eded24feb9abfc411f3
Reviewed-on: https://gerrit.libreoffice.org/73423
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This was originally just about getting rid of the resource leak.
Turned out to include a little refactoring to hide most of the
UnoDialog member variables.

* use cppu::component_getFactoryHelper
* free leaked createPeer resources in destructor

Change-Id: I45449c49e32af4935908b801ed9bd9732af944d3
Reviewed-on: https://gerrit.libreoffice.org/73565
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Originally I tried to implement the gtk3 way by shoving all key
input in some way through the QInputMethod. But that turned out
to be impossible, because all the nice input event filtering is
privately hidden in the platform abstraction. And it took me
much longer to realize that gtk3 is doing this.

Still the delivered code point in the KeyEvent is correct, so
this simply uses ExtTextInput events for non-code key events,
if LO has enabled input method support for a frame.

Change-Id: Ia9bb6baf013cf790deecb9675f8309e32294e982
Reviewed-on: https://gerrit.libreoffice.org/73322
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: Ibd4bd34fc73f80aea7aaf2a5e524cf877822ee6b
Reviewed-on: https://gerrit.libreoffice.org/73587
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Iaef795ee48f590ed2cd0ba1c47dcc703172d8677
Reviewed-on: https://gerrit.libreoffice.org/73597
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6a5068106d0f243646cf12ec676dff60a04922ee
Reviewed-on: https://gerrit.libreoffice.org/73596
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Idd69b37ff0dc85dc96349c4e85fc5d4a93597e62
Reviewed-on: https://gerrit.libreoffice.org/73601
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

It seems like Writer default values for table positioning
differ from OOXML spec. if nothing is given.
So write them anyway during export.

Change-Id: If5bf77de71b457a826be8f1559212e7d06c5237c
Reviewed-on: https://gerrit.libreoffice.org/73402
Tested-by: Jenkins
Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de>

...it was added as float with eb560651
"tdf#101854 Move to CommonSalLayout removed faux bold in macos", but that causes
loplugin:implicitboolconversion warnings, and was probably just a typo.

Change-Id: Ib35c5b001f0a77befa17e7bbb6447129e36a42ba
Reviewed-on: https://gerrit.libreoffice.org/73590Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins

The hit area of the radio buttons was not calculated correctly, so
sometimes when you hit the radio button at the "wrong" place,
nothing happened. This fixes the hit area to correctly cover the
radio button and the text.

Another issue was that the ios theme size of the radio button was
not defined correctly (32px instead of 26px), which increased the
error when calculating the hit are even more. The height of the
radio button should be the same as defined in the definition.xml,
and not bigger (or smaller).

Change-Id: I4b03f36ca9d9c82bd6dc442bd6e06af938c62bdd
Reviewed-on: https://gerrit.libreoffice.org/73592
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

* Update helpcontent2 from branch 'master'
  - tdf#68103 Mark differences between Draw and Impress
    
    Although the 2 modules share a common kernel, the nomeclature,
    menus and master pages/slides are different.
    
    Change-Id: Id4282b2ebaf48a57b753ff0cefa228c3f3bdc644
    Reviewed-on: https://gerrit.libreoffice.org/73578
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>