A Writer image has an underlying SdrObject, but GetSdrObjectFromXShape()
won't work for it, also we can't an sw SdrObject into an XShape because
SvxDrawPage::CreateShape() has no idea how to handle sw's
SdrInventor::Swg inventor.

Fix the problem by just getting the Graphic of the Writer image and
improve GraphicExportFilter to be able to work with just a Graphic as
well.

Change-Id: I3c9b3005366fcc87815597a27df3cb8a99a8876c
Reviewed-on: https://gerrit.libreoffice.org/54527Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ic5831e56d4528dcc1ad78e00569ad1d58272aeeb
Reviewed-on: https://gerrit.libreoffice.org/54514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I81483a4d23523650cd9098794dd6101253b88e1c
Reviewed-on: https://gerrit.libreoffice.org/54546Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: I20ee1662310f33831757015659a70d3ffd855b3e
Reviewed-on: https://gerrit.libreoffice.org/54508Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Target of this change is to get rid of the SVGFilter
in current LO which is based on the standard-ODF importer
using it's functionality by passing in/handing over
temporary created XML-Stream-Data.

First step is to alternatively import the given SVG
file to a newly created Document and to strip the
existing Filter-Code.

Adding the first prototype of the changed import. It
is capable of importing the given SVG to the created
Draw/Impress document. It adds the SVG which gets imported
by SVGIO as GraphicObject. It adapts sizes and positions of
Page and GraphicObject to have a smooth import.

Adding stripping of SVGFilter and used ressources. Done
as deep as possible, hopefully all places found.

Adapted now to create an Impress document. Also added needed
adaptions to PageSize(s), including layout and PresObj stuff
to make all MasterPages/LayoutPages work correctly.

Added reaction on empty SVG. This is needed since the
PageSize is adapted to the Graphic. With empty Graphic
a Size(0,0) results and this goes wrong.

Change-Id: Ia364a5783bee7dadcbe91e700efbabc121cf98f9
Reviewed-on: https://gerrit.libreoffice.org/54096Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

if it wants a DbFilterControl, just take a DbFilterControl

Change-Id: I43f08062be1c6c7c052c43de912a81afe409c928
Reviewed-on: https://gerrit.libreoffice.org/54523Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

regression from
   commit 3d44b720
   loplugin:useuniqueptr in SfxItemPool_Impl
where I accidentally removed some fallback code.

Note that this does not fix the underlying bug where some pool is not
correctly set up.

Also, this only fixes the bug that I introduced in the above commit,
another bug in the same area has subsequently been introduced, causing
a crash in a different area when performing this operation.

Change-Id: Iaae3b0dc82c740b498e3735273820647ef28fd01
Reviewed-on: https://gerrit.libreoffice.org/54522Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

for signature line signing

Change-Id: Iac4f3a248af53bdbf159e6e8d656e1dcbc3aacbf
Reviewed-on: https://gerrit.libreoffice.org/54473Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I9d4a70d8ae2f5247901c584dc05405665eac065b
Reviewed-on: https://gerrit.libreoffice.org/54525Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1bc78b61a50f909ceb4c79e9dc9425306d41e617
Reviewed-on: https://gerrit.libreoffice.org/54534Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I03ef6f1994e8e1a801e4515586a6a73d3748f13b
Reviewed-on: https://gerrit.libreoffice.org/54528Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I483a3b7895cdcb10ef9d6dacf167ed0f8db7e723
Reviewed-on: https://gerrit.libreoffice.org/54432Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I8da7228de5a1a9b7637c8c43ffd79f5f044bc788
Reviewed-on: https://gerrit.libreoffice.org/54521Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  e819fccbbc0fd5430f5d99e575f648a89a97007e

Fix misplaced tag in line

Honor DTD.

Change-Id: I5a00eb158b4d6da91cd85728d5d73c1f14547bed
Reviewed-on: https://gerrit.libreoffice.org/54507Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I963c4a8d0afa44d235cf8271b1515c67299cbe94

Change-Id: Ie433a336f9cd5133aefbe4ef88d214b5f5c63a0a
Reviewed-on: https://gerrit.libreoffice.org/54182Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and fix leak of HelpListener_Impl in SfxHelpWindow_Impl

Change-Id: I7450be10c8deaf63b7c7f1f4359b4eaf0083bdd4
Reviewed-on: https://gerrit.libreoffice.org/54451Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia3e00ccdc89aaf7b5546a0b346d174814fcea97d
Reviewed-on: https://gerrit.libreoffice.org/54518Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

the various part of PlaceEditDialog are unusual in binding multiple things to a
set of shared widgets with a bunch of multiple LINKS to the same things and
using the most recent one shown to displace the previous handlers

End up with multiple notifications in the gtk3 case, rework this to have
a single owner of the widgets so it can do what it wants to do.

Change-Id: I65826a69ce2f1d4279f6e8091a518777fcfeca07
Reviewed-on: https://gerrit.libreoffice.org/54496Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I26fd88c7579e4a7bd1a46ab41fe82f5c9d760ddf

Change-Id: I539df7d7ddddb6dd9811ac93fc7445b12e1119ae
Reviewed-on: https://gerrit.libreoffice.org/54490Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

I think this is theoretical and in practice this dialog never appears
anymore

Change-Id: I1c29432ecf0df215c686c228326183d9a3a422d3
Reviewed-on: https://gerrit.libreoffice.org/54489Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

For some reason, on macOS, when this is being invoked through the
shortcut, Application::AnyInput( VclInputFlags::KEYBOARD ) returns
true, so the code thinks that there is more keyboard input and won't
call UpdateTokenArray(), which sets m_pTokenArray.

I think that optmisation is questionable, especially as the exact
semantics of our event loop API, like Application::AnyInput(), is
under-defined and probably can and will change in various minor ways
when people work on improving it on the Mac (and perhaps other
platforms, too).

(The event loop etc certainly needs improvement on the Mac. Consider
the "WindowServer grows to tens of gigabytes when running make check"
issue which is closely related. Unfortunately nobody has come up with
a simple fix for that yet, exactly because we use our event loop
related APIs in so imaginative ways all over the code, and fixing one
thing usually breaks another.)

Change-Id: I865d46e5ee69609ad58bc915ff949e0f3602d8f5
Reviewed-on: https://gerrit.libreoffice.org/54448Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Using an ECDSA key but writing RSA URIs would fail later in libxmlsec.

Also fix up CppunitTest_xmlsecurity_signing (env vars were set too
late), so that the new testcase actually fails without the fix.

Change-Id: I9e584844d5cd046952b2f19130aeaa5a765bfc0a
Reviewed-on: https://gerrit.libreoffice.org/54400Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
with minimal fallout management

Change-Id: I5574c9ccac02977c9cde01e24534f82dd9ec82be
Reviewed-on: https://gerrit.libreoffice.org/54409Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

OpenGLContext::prepareForYield() assumed that in case we have a current
context, then it's the last one, but that's not the case for chart windows
since commit 78b100ec (only init the OpenGL
context if we need it, 2016-06-07), which creates an OpenGLContext instance
(which is then the last one in the context list) but explicitly doesn't
initialize it (so that it would become the current one).

Fix the problem by resetting not the last but the last current context.

Change-Id: Ie0e96927473290590cd6333e5cdcb7daa009431b
Reviewed-on: https://gerrit.libreoffice.org/54495Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I11d874caad9174fb1a70121f1772e117753ee519
Reviewed-on: https://gerrit.libreoffice.org/54503Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Also, turn some specific overly generic languages that LO doesn't
recognize in this context into the country-specific ones that the
dictionary (probably) is for. Skip some odd locales LO doesn't know in
this context. In particular, what the system calls the "en" dictionary
is for "en_US", and "nb" is for "nb_NO". The "es" one probably is for
"es_ES".

Also, skip some language-country combinations that LO doesn't
recognize in this context. In partiular, "en_JP" and "en_SG".

Change-Id: I29450775a263bdc03fd43849380f66e6ffffd09b
Reviewed-on: https://gerrit.libreoffice.org/54476Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I4f96c813ed4dd5ebc396b397e3c9c578f96f5619
Reviewed-on: https://gerrit.libreoffice.org/54515Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

That block of code at the top of the file started out as

  #include "precompiled_svl.hxx"

  #ifdef WNT
  # include <prewin.h>
  # include <postwin.h>
  # undef ERROR
  #endif

in d2a16264 "Initial unit test skeleton, copied
and modified from sc", so assume the leftover #undef is unnecessary cargo-cult
by now.

Change-Id: I39637518d1507352b1eb2ed19168013d9fe635ac
Reviewed-on: https://gerrit.libreoffice.org/54499Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I28d0260531132216c5f0bd187d400ed47cc43326
Reviewed-on: https://gerrit.libreoffice.org/54498Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

To make sure they are loaded correctly for most common graphic
formats.

Change-Id: Id121df0ddc763a299c5714cadd0d61740876e3dd
Reviewed-on: https://gerrit.libreoffice.org/54467Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

For table shape we used OWN_ATTR_BITMAP as the identifier for the
"RepalcementGraphic" property, but that is not really correct.
More correct would be to use OWN_ATTR_REPLACEMENT_GRAPHIC, which
name reflects exactly what the property is for and doesn't conflict
with OWN_ATTR_BITMAP which is used for the "Bitmap" property.

Change-Id: Ic76318addf8f53391f41251fe9d99dba57308165
Reviewed-on: https://gerrit.libreoffice.org/54466Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

For main document window we use logic coordinates, but
for dialog / floating windows we use pixels. Use a different
method name to make it clear which unit we use in the code.

Change-Id: I7aee7a03013d24e1a2e37072e224e7d4e7830f02
Reviewed-on: https://gerrit.libreoffice.org/54500Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I6f96abdd4d85c8dfed8bf83e1b2a30192a54bd2d
Reviewed-on: https://gerrit.libreoffice.org/54494Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Trying to chase the culprit.

Change-Id: Iec5e6b3b38b4c0e7cd224cc861d4303a1eb04c4c
Reviewed-on: https://gerrit.libreoffice.org/54491Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Don't know yet how that could had happened, but the sample
document has a bad ActiveSplitRange value that doesn't match
HorizontalSplitMode and VerticalSplitMode.

* sanitize the value when reading view settings
* prevent writing such value to help versions that don't sanitize

Change-Id: I1b450c7b8102148a24d545ff7568f725d7492a6a

after 64931362. Remove stray (void)dummy;

Change-Id: I73cdcfc04116c4c070e3dda80c25cc9ca52eab95

It will be needed for a later change in online code.

Change-Id: Ic8f898b78ccaaaec849a1894b5e70fb730d70d6d
Reviewed-on: https://gerrit.libreoffice.org/54443Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I1f52e1f9ff3fedf8996f72e671400c2549e74dfe
Reviewed-on: https://gerrit.libreoffice.org/54488Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>