This is a follow-up of ed5450f2 where the
check for the HasView has been removed.  Turns out that there are conditions
when this really can happen, leading to crashes in the LOK searching.

Unfortunately I did not manage to find a reliable reproducer to create a
unit test :-( - so I suspect this commit might be more a workaround than a
root cause fix.  Would be great to find out the exact conditions leading to
the situation when the EditEngine does not contain the EditView, and evaluate
this fix against that - but that's hard without a reliable reproducer.

A unit test for this fix is missing from the same reason.  The unit test from
ed5450f2 still passes.

Change-Id: I1cca7219817119d27a224b35efb660a84d35b8fa

Change-Id: Idf7bd4c80f9dc1fb9f93859e1e1106dd620d2311
Reviewed-on: https://gerrit.libreoffice.org/35511Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Removed old comment cruft
* clean up some indentation

Change-Id: I0ddbd66aec0f27d7563dc4c2cfa2e095a48cda46
Reviewed-on: https://gerrit.libreoffice.org/35134Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I0b83a79e143180901ce2ae4ef02ff8b65cfb0694
Reviewed-on: https://gerrit.libreoffice.org/35529Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

gcc >= 5 and clang have builtins for this
msvc has safeint.h and functions in the msl::utilties namespace
otherwise fall back to certs demo implementations

Change-Id: I6001a278c24b0be4b381d933d256f01f91ead55d
Reviewed-on: https://gerrit.libreoffice.org/35505Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib7ddcdc822e8b08b4e1c3e282a3fe2f691a71569

Change-Id: Ia02c5e09c9ca9f5d0e6b0c0eb66283057ff8c1cc

To join a thread, the mutex must be released - another thread
in pushTask() could add a new thread to maWorkers at that point,
which must of course not be deleted.

Avoid the problem by transferring ownership of the to-be-deleted
threads to the calling thread.

(regression from bdaa13a8)

Change-Id: I9d4fcfe4cb46a336586b5663934a12d47b2d8ccb

Always _WIN32 is defined, even in Win64. So the check must be to _WIN64 and then to _WIN32.
Hope no more lines like this in code.
Can you test programs with SDK 64 Bit?

Change-Id: I769d9277e6ff931ca7d5d61d412b81c191d97083

_WIN32 is also defined on 64-bit Windows so reorder these ifdefs.

Should i be surprised that this breaks several dbaccess tests
for me but all tinderboxes are green?

(regression from 9143dd4e)

Change-Id: Id917952d3135768355af711688ff70bf6c019a6e

Change-Id: Idfd2a6d68fecfb5a473938a74a9020f76fbc2c4b

... from a DOS style 8.3 path, for whatever reason.  Special case DEVENV
variable so it uses long path.

Change-Id: I03bb20a8f35cd116edd33ec91178f9deddbc4257

... which is unlikely to contain the strings "gdb" or "lldb".

(regression from c38a4d9c)

Change-Id: I355069ec512232898b246d2b0bf8912831f0c80a

Moved entitlements to correct group

Change-Id: I6ab95b823fc4a4b8781b27d51ecb8d994f477dca

...after a3240995 "xmlsecurity PDF signing: only
write incremental xref in an incremental update" inserted the 'if' before the
'while (!rStream.IsEof())'

Change-Id: Ib527894031f356c3d6df40b70259469ef4c338de

...that would implicitly be sign extended (for plain char only if it is signed),
so non-ASCII char values would trigger the isUnicodeCodePoint assert.

Change-Id: Iaf8024ad509e64525558e882fe3fd078cfb4ea91
Reviewed-on: https://gerrit.libreoffice.org/35523Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Adding support for using IOS Settings
The idea is to move the LO settings into here, and let the
user manipulate some of the fields.

Change-Id: Ifbd1adc6aa395d7822bcec968f267bb85929bff3
Reviewed-on: https://gerrit.libreoffice.org/35528Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>

...to give them internal linkage in both C and C++.  Of those definitions that
were not marked as static:

* Those that had not been marked as inline had external linkage in both C and
  C++, so would have caused ODR violations were LibreOfficeKitInit.h included in
  multiple translation units.

* Those that had been marked as inline lacked an external defintion in C.
  (Which 3f02b2aa "LOK init: avoid non-inline
  function definition in header file" had apparently faied to take into
  account.)

(IOS_SWIFTCBRIDGE introduced in 028ef474
"LibreOfficeKitInit.h modified to avoid ODR" becomes unnecessary again.)

Change-Id: Ibb8033cdbac87b20fa0e3b203b99571c1a7e7234
Reviewed-on: https://gerrit.libreoffice.org/35491Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The PDF code in xmlsecurity served two purposes:

- a generic PDF tokenizer
- signature verification

The first purpose is useful to have in VCL, so the PDF export code can
use it as well when it comes to PDF image handling.

This commit just moves most of the PDF code to VCL, it does not touch
the PDF export code yet. With this, also the somewhat odd xmlsecurity
dependency of CppunitTest_vcl_pdfexport can be removed as well.

Change-Id: I6fe8294ed5c4aa4d79f4b2ddef80a4d1c9d566cc
Reviewed-on: https://gerrit.libreoffice.org/35513Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ia82936daeb5db8fb45e818e516bb37fb527d858d
Reviewed-on: https://gerrit.libreoffice.org/35524Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>

Change-Id: I5eb0758f84495a8410260f61ff645a086efb1ca7

...as the former is less of an MT nightmare (nl_langinfo_l can only conflict
with calls to nl_langinfo in other threads, not with calls to nl_langinfo_l in
other threads, so since this was the last remaining use of nl_langinfo in LO
itself after a7cdba3a "Use nl_langinfo_l with an
explicitly created locale" things should be safer now; also, setlocale was an
MT problem, of course, inadequately atempted to be addressed with that
aLocaleMutex).

Hopefully, all relevant platforms that support nl_langinfo also support
nl_langinfo_l (where both are POSIX).

Change-Id: I28a18bc4ffa930e3f2e949634dae161377e2911c

(where empty string arg to newlocale, per SUSv4, means "an implementation-
defined native environment.  This correspons to the value of the associated
environment variables, LC_* and LANG") instead of relying on whatever setlocale
would be in effect here.

Also, nl_langinfo_l is less of an MT nightmare than nl_langinfo, which is of
benefit once the last remaining use of nl_langinfo in sal/osl/unx/nlsupport.cxx
will also have been changed to nl_langinfo_l.

loplugin:nullptr needs a little hack, as SUSv4 locale_t could be anything from
an integer type to a pointer type.

Change-Id: Ic35dcbc2e0a4f650694b48df12470dd89476dff5

Change-Id: I2dab376d87804521aed6b6bd41ad7762830fa349
Reviewed-on: https://gerrit.libreoffice.org/35467Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib59c7886017247977b916a8e140853fb8310582f
Reviewed-on: https://gerrit.libreoffice.org/35514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

as an argument, not from the top of the stack.
Because no token belongs to groups TG::Limit and TG::Power at
the same time, we can replace TokenInGroup() with direct comparison
with each group.

Change-Id: I44882ab40f59c4de1c0e2cbbdc354e43de926ab1
Reviewed-on: https://gerrit.libreoffice.org/35500Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: I6c09900aa95a01330b5bedf12f3e4a7a03e5a620
Reviewed-on: https://gerrit.libreoffice.org/35517Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ibd2625ba40cafdb07a2fcb5b2cfdd0e5f9e72b94
Reviewed-on: https://gerrit.libreoffice.org/35516Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I0ad8d63a2dda2da3c58a626ccf9d60085c1521d5
Reviewed-on: https://gerrit.libreoffice.org/35515Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Signature verification code depends on sax and xmloff, but the rest of
the PDF tokenizer could be otherwise moved down to lower layers without
problems.

Change-Id: Ieca57279e9517935821c1d34f217fd10548035ef
Reviewed-on: https://gerrit.libreoffice.org/35512Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Added iCloud document support to fileManager

Change-Id: I7c8f78b6b148926398b170ee8a32d3c09413205f
Reviewed-on: https://gerrit.libreoffice.org/35503Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>

Change-Id: I6b7fc9d06a49613cc6fe247b44c56f36935082fa
Reviewed-on: https://gerrit.libreoffice.org/35282Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This takes a different approach than commit
9899ffd2.

Change the ThreadPool to automatically shutdown and join all threads
whenever waitUntilDone() is called.  Then start the threads again
in pushTask().

Because the ThreadPool is meant to be used synchronously with
waitUntilDone() called after adding all required tasks, this should
obviate the need to call shutdown() before process exit, as
there won't be any threads running at that point.

Change-Id: I2b8e639004a94cf05ccb4522aa1f0d3dac88a936
Reviewed-on: https://gerrit.libreoffice.org/35510Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Possibility to add multiple context containers.
Each container should have name "ContextContainer"
or "ContextContainerX" where X >= 1

Change-Id: Ie689ebde624f766b11d96370d6b108018f9130c9
Reviewed-on: https://gerrit.libreoffice.org/35506Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>

Change-Id: I610d3637f4a4520ef4eefed29851727f519de02c

setlocale has the drawbacks that it is racy and that it sets global state, so
better avoid it.  The way LC_ALL, LC_CTYPE, LANG are honoured is as suggested by
SUSv4, then falling back to "C".

Change-Id: I606ecc01d37a0a9067a90e6dcce098009094493c

Change-Id: Ida509af3632bf6dccc139c770bd3cbdee7b71fca

unused in LO itself since 73bda505 "ditched
rtl::OLocale"

Change-Id: I6fd713f4771d7a7a397ef08002d1b9d754417f67

Change-Id: I2785b1d98307a19666ad3aabf3bbaff19a9d0a6e