- 18 May, 2018 17 kayıt (commit)
-
-
Noel Grandin yazdı
and fix leak of HelpListener_Impl in SfxHelpWindow_Impl Change-Id: I7450be10c8deaf63b7c7f1f4359b4eaf0083bdd4 Reviewed-on: https://gerrit.libreoffice.org/54451Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: Ia3e00ccdc89aaf7b5546a0b346d174814fcea97d Reviewed-on: https://gerrit.libreoffice.org/54518Tested-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
the various part of PlaceEditDialog are unusual in binding multiple things to a set of shared widgets with a bunch of multiple LINKS to the same things and using the most recent one shown to displace the previous handlers End up with multiple notifications in the gtk3 case, rework this to have a single owner of the widgets so it can do what it wants to do. Change-Id: I65826a69ce2f1d4279f6e8091a518777fcfeca07 Reviewed-on: https://gerrit.libreoffice.org/54496Reviewed-by:
-
Stephan Bergmann yazdı
Change-Id: I26fd88c7579e4a7bd1a46ab41fe82f5c9d760ddf
-
Caolán McNamara yazdı
Change-Id: I539df7d7ddddb6dd9811ac93fc7445b12e1119ae Reviewed-on: https://gerrit.libreoffice.org/54490Tested-by:
-
Caolán McNamara yazdı
I think this is theoretical and in practice this dialog never appears anymore Change-Id: I1c29432ecf0df215c686c228326183d9a3a422d3 Reviewed-on: https://gerrit.libreoffice.org/54489Reviewed-by:
-
Tor Lillqvist yazdı
For some reason, on macOS, when this is being invoked through the shortcut, Application::AnyInput( VclInputFlags::KEYBOARD ) returns true, so the code thinks that there is more keyboard input and won't call UpdateTokenArray(), which sets m_pTokenArray. I think that optmisation is questionable, especially as the exact semantics of our event loop API, like Application::AnyInput(), is under-defined and probably can and will change in various minor ways when people work on improving it on the Mac (and perhaps other platforms, too). (The event loop etc certainly needs improvement on the Mac. Consider the "WindowServer grows to tens of gigabytes when running make check" issue which is closely related. Unfortunately nobody has come up with a simple fix for that yet, exactly because we use our event loop related APIs in so imaginative ways all over the code, and fixing one thing usually breaks another.) Change-Id: I865d46e5ee69609ad58bc915ff949e0f3602d8f5 Reviewed-on: https://gerrit.libreoffice.org/54448Tested-by:
Tor Lillqvist <tml@collabora.com>
-
Miklos Vajna yazdı
Using an ECDSA key but writing RSA URIs would fail later in libxmlsec. Also fix up CppunitTest_xmlsecurity_signing (env vars were set too late), so that the new testcase actually fails without the fix. Change-Id: I9e584844d5cd046952b2f19130aeaa5a765bfc0a Reviewed-on: https://gerrit.libreoffice.org/54400Tested-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here with minimal fallout management Change-Id: I5574c9ccac02977c9cde01e24534f82dd9ec82be Reviewed-on: https://gerrit.libreoffice.org/54409Tested-by:
-
Miklos Vajna yazdı
OpenGLContext::prepareForYield() assumed that in case we have a current context, then it's the last one, but that's not the case for chart windows since commit 78b100ec (only init the OpenGL context if we need it, 2016-06-07), which creates an OpenGLContext instance (which is then the last one in the context list) but explicitly doesn't initialize it (so that it would become the current one). Fix the problem by resetting not the last but the last current context. Change-Id: Ie0e96927473290590cd6333e5cdcb7daa009431b Reviewed-on: https://gerrit.libreoffice.org/54495Tested-by:
-
Miklos Vajna yazdı
Change-Id: I11d874caad9174fb1a70121f1772e117753ee519 Reviewed-on: https://gerrit.libreoffice.org/54503Tested-by:
-
Tor Lillqvist yazdı
Also, turn some specific overly generic languages that LO doesn't recognize in this context into the country-specific ones that the dictionary (probably) is for. Skip some odd locales LO doesn't know in this context. In particular, what the system calls the "en" dictionary is for "en_US", and "nb" is for "nb_NO". The "es" one probably is for "es_ES". Also, skip some language-country combinations that LO doesn't recognize in this context. In partiular, "en_JP" and "en_SG". Change-Id: I29450775a263bdc03fd43849380f66e6ffffd09b Reviewed-on: https://gerrit.libreoffice.org/54476Tested-by:
-
Andrea Gelmini yazdı
Change-Id: I4f96c813ed4dd5ebc396b397e3c9c578f96f5619 Reviewed-on: https://gerrit.libreoffice.org/54515Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by:
-
Stephan Bergmann yazdı
That block of code at the top of the file started out as #include "precompiled_svl.hxx" #ifdef WNT # include <prewin.h> # include <postwin.h> # undef ERROR #endif in d2a16264 "Initial unit test skeleton, copied and modified from sc", so assume the leftover #undef is unnecessary cargo-cult by now. Change-Id: I39637518d1507352b1eb2ed19168013d9fe635ac Reviewed-on: https://gerrit.libreoffice.org/54499Reviewed-by:
Stephan Bergmann <sbergman@redhat.com> Tested-by:
-
Stephan Bergmann yazdı
Change-Id: I28d0260531132216c5f0bd187d400ed47cc43326 Reviewed-on: https://gerrit.libreoffice.org/54498Tested-by:
-
Tomaž Vajngerl yazdı
To make sure they are loaded correctly for most common graphic formats. Change-Id: Id121df0ddc763a299c5714cadd0d61740876e3dd Reviewed-on: https://gerrit.libreoffice.org/54467Tested-by:
Tomaž Vajngerl <quikee@gmail.com>
-
Tomaž Vajngerl yazdı
For table shape we used OWN_ATTR_BITMAP as the identifier for the "RepalcementGraphic" property, but that is not really correct. More correct would be to use OWN_ATTR_REPLACEMENT_GRAPHIC, which name reflects exactly what the property is for and doesn't conflict with OWN_ATTR_BITMAP which is used for the "Bitmap" property. Change-Id: Ic76318addf8f53391f41251fe9d99dba57308165 Reviewed-on: https://gerrit.libreoffice.org/54466Tested-by:
-
- 17 May, 2018 23 kayıt (commit)
-
-
Tamás Zolnai yazdı
For main document window we use logic coordinates, but for dialog / floating windows we use pixels. Use a different method name to make it clear which unit we use in the code. Change-Id: I7aee7a03013d24e1a2e37072e224e7d4e7830f02 Reviewed-on: https://gerrit.libreoffice.org/54500Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by:
-
Tamás Zolnai yazdı
Change-Id: I6f96abdd4d85c8dfed8bf83e1b2a30192a54bd2d Reviewed-on: https://gerrit.libreoffice.org/54494Reviewed-by:
-
Eike Rathke yazdı
Trying to chase the culprit. Change-Id: Iec5e6b3b38b4c0e7cd224cc861d4303a1eb04c4c Reviewed-on: https://gerrit.libreoffice.org/54491Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by:
-
Eike Rathke yazdı
Don't know yet how that could had happened, but the sample document has a bad ActiveSplitRange value that doesn't match HorizontalSplitMode and VerticalSplitMode. * sanitize the value when reading view settings * prevent writing such value to help versions that don't sanitize Change-Id: I1b450c7b8102148a24d545ff7568f725d7492a6a
-
Rene Engelhard yazdı
after 64931362. Remove stray (void)dummy; Change-Id: I73cdcfc04116c4c070e3dda80c25cc9ca52eab95
-
Tamás Zolnai yazdı
It will be needed for a later change in online code. Change-Id: Ic8f898b78ccaaaec849a1894b5e70fb730d70d6d Reviewed-on: https://gerrit.libreoffice.org/54443Tested-by:
-
Caolán McNamara yazdı
Change-Id: I1f52e1f9ff3fedf8996f72e671400c2549e74dfe Reviewed-on: https://gerrit.libreoffice.org/54488Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I69676dd437caefca63805e86f4707527183f622f Reviewed-on: https://gerrit.libreoffice.org/54487Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ia220d01a20df5aa20839155391ac5e46cfe172c1 Reviewed-on: https://gerrit.libreoffice.org/54486Reviewed-by:
-
Caolán McNamara yazdı
document, with meta:generator of "opxml2odf - Version KO 0.1" has a styles.xml xmlns of... xmlns:ofo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" instead of the usual xmlns:fo=... use the importer namespace map to get the importers namespace prefix for the fastparser namespace uri for the token Change-Id: Ib633009f6c2b7dae5a3ceb1c921adfff84e21150 Reviewed-on: https://gerrit.libreoffice.org/52720Reviewed-by:
-
Luboš Luňák yazdı
The ocStyle token is only in the RPN tokens, the raw tokens array contains only ocName, so it's necessary to check also RPN tokens. Prevents a crash with tdf#91220/1 because of ScInterpreter::ScStyle() causing a SfxBroadcaster::Broadcast() call. Change-Id: I7fa04114b698918569014322c721751ab3d8c62f Reviewed-on: https://gerrit.libreoffice.org/54326Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
-
Stephan Bergmann yazdı
...that ignore the out-parameter integral part Change-Id: I05f07c1a8909023232f8aecf75ea5541d4eb81ca Reviewed-on: https://gerrit.libreoffice.org/54474Reviewed-by:
-
Armin Le Grand yazdı
Someone removed maPageObjectSize in PageObjectLayouter and replaced it with the local var aPageObjectSize. This workms in principle, but was forgotten in one line where maFocusIndicatorBoundingBox gets set. Since the incoming rPageObjectWindowSize only has one value set (width or height) and the other one gets set in the call to CalculatePreviewBoundingBox, the whole layouting/visualization of SlideSorter and SlideView in Draw/Impress was broken. Fixed that - please be more careful with those changes in the future - take a look at the app where you do changes. Change-Id: I6bd9f8b11e7ebc7b880e465b80b813f5e2173c8c
-
Tor Lillqvist yazdı
Change-Id: I219226060ebf4b8b86c8f0487fc679f22f73812a Reviewed-on: https://gerrit.libreoffice.org/54468Reviewed-by:
-
Tor Lillqvist yazdı
Change-Id: I68dfd0832747c7c319e40ee28a4461623e95102f Reviewed-on: https://gerrit.libreoffice.org/54482Reviewed-by:
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Removal proposals are dealt with here, and a bit of fallout management. Change-Id: If2d73998c3d3d9fea50420688818cd7fe0f0a27c Reviewed-on: https://gerrit.libreoffice.org/54463Tested-by:
-
Mike Kaganski yazdı
Change-Id: I391ea52f5137975073a674ac1ad380277fe99846 Reviewed-on: https://gerrit.libreoffice.org/54381Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Reviewed-by:
Rene Engelhard <rene@debian.org> Tested-by:
-
Zdeněk Crhonek yazdı
Change-Id: If7ea2fd921c2e673f76ecb79188dc5dcb4cba442 Reviewed-on: https://gerrit.libreoffice.org/54447Tested-by:
Zdenek Crhonek <zcrhonek@gmail.com>
-
Tamás Zolnai yazdı
For example: Character dialog -> Highlighting or Character dialog -> Font. Change-Id: I0d1269cdb9d4f482caea27b23ae204351f7dac23 Reviewed-on: https://gerrit.libreoffice.org/54446Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I4c68bc92fa90ca4a9723f2664549f34b50213bfb Reviewed-on: https://gerrit.libreoffice.org/54471Reviewed-by:
-
Serge Krot yazdı
Change-Id: Ia2b8a1376f4f2b4e790598255ae69fb6ee92d23d Reviewed-on: https://gerrit.libreoffice.org/54423Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by:
-
Miklos Vajna yazdı
Change-Id: I639381781745493a9320cdf4a7a0be61f09446c7 Reviewed-on: https://gerrit.libreoffice.org/54469Reviewed-by:
-
Vasily Melenchuk yazdı
Created mailmerge output document was not using current printer settings, which can be taken not only from settings, but overriden by currently opened template. Change-Id: Ic127dcbfbe8f1e80073b06ecb399100344f4c01d Reviewed-on: https://gerrit.libreoffice.org/54358Reviewed-by:
-
