1. 01 Şub, 2019 1 kayıt (commit)
  2. 31 Ock, 2019 39 kayıt (commit)
    • Muhammet Kara's avatar
      Support bitmap PDF export for Redaction · 51af3179
      Muhammet Kara yazdı
      * Add a new parameter IsRedactMode (SID_IS_REDACT_MODE) to .uno:ExportDirectToPDF
      * Make sure the new param makes it into PDFExport as part of FilterData
      * Hijack the metafile before being sent to ImplExportPage(), convert to bitmap, and replace the original
      * Add a new entry to GenericCommands.xcu to make our button with param visible
      
      * Nitpick: For things to be included in the bitmap conversion,
                 they need to be added to the metafile before the conversion
                 in PDFExport::ExportSelection(). Things added after that point
                 (inside ImplExportPage() for example) will not be bitmapped/pixelized
      
      Change-Id: Iec7020917da920a968ea969b98e53f17eadaa275
      Reviewed-on: https://gerrit.libreoffice.org/67108
      Tested-by: Jenkins
      Reviewed-by: 's avatarMuhammet Kara <muhammet.kara@collabora.com>
      51af3179
    • andreas kainz's avatar
      Sifr icons: add 32px cmd svg icons · fb95d74f
      andreas kainz yazdı
      Change-Id: I619dbbf059f335f685789ad6afb679a8c55a25e5
      Reviewed-on: https://gerrit.libreoffice.org/67212
      Tested-by: Jenkins
      Reviewed-by: 's avatarandreas_kainz <kainz.a@gmail.com>
      fb95d74f
    • Stephan Bergmann's avatar
      Allow CXX_X86_BINARY to be passed into autogen.sh · a6c22d4e
      Stephan Bergmann yazdı
      This is necessary for building with clang-cl, where $CXX_X86_BINARY needs to
      match $CXX (i.e., both invoke clang-cl) so that the compiler switches (which
      have been determined based on the nature of $CXX, i.e., are Clang-specific when
      $CXX is clang-cl) passed to $CXX_X86_BINARY are actually understood by it.
      (Building extensions/source/scanner/twain32shim.cxx failed with "cl : Command
      line error D8021 : invalid numeric argument '/Wendif-labels'".)
      
      For now, my local clang-cl build will just pass a suitable CXX_X86_BINARY
      similar to the passed CXX (but with --target=i686-pc-windows-msvc -arch:SSE
      instead of --target=x86_64-pc-windows-msvc) into autogen.sh.
      
      Change-Id: Id958525f97e1d16f17af49e0b0288c1018885749
      Reviewed-on: https://gerrit.libreoffice.org/67228
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      a6c22d4e
    • Stephan Bergmann's avatar
      Fix compilerplugins/clang/test/useuniqueptr.cxx for clang-cl · 4d3571a3
      Stephan Bergmann yazdı
      ...where it failed with
      
      > error: 'error' diagnostics expected but not seen:
      >   File C:/lo-clang/core/compilerplugins/clang/test/useuniqueptr.cxx Line 266: rather manage this var with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr]
      >   File C:/lo-clang/core/compilerplugins/clang/test/useuniqueptr.cxx Line 275: rather manage this member with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr]
      
      apparently due to differences in how some std types are implemented.
      
      Change-Id: Ib81ed1a1da867359e7f22bb6fb6ceb3e610e2b41
      Reviewed-on: https://gerrit.libreoffice.org/67226
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      4d3571a3
    • Stephan Bergmann's avatar
      tdf#121780: com.sun.star.comp.sfx2.BackingComp needs to be registered always · dbc92eab
      Stephan Bergmann yazdı
      ...instead of never (as there is no handling of
      org/openoffice/Office/ProtocolHandler-start.xcu in
      officecfg/Configuration_officecfg.mk).  That install:module="start" included in
      d930cefb "Startcenter: Refresh RecentDocsView
      when select 'Clear list' menu option" was probably misguided cargo-cult-copying
      from (meaningful) install:module="impress" that were already present in
      officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu.
      
      Change-Id: I03ed0cf84b576597a7b88ee6627a12cedbca4960
      Reviewed-on: https://gerrit.libreoffice.org/67224
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      dbc92eab
    • Miklos Vajna's avatar
      Related: tdf#116371 RTF export: handle rotation of SwGrfNode · d8cf61f3
      Miklos Vajna yazdı
      This is similar to commit b226383a
      (tdf#116371: export rotation of SwGrfNode, 2019-01-26), just this is for
      RTF, not DOCX.
      
      Make sure we don't test the ODT import result as it's done already in
      CppunitTest_sw_ooxmlexport13.
      
      Change-Id: Iaf2d3011c45f3459e920f679683b1a45de42efe7
      Reviewed-on: https://gerrit.libreoffice.org/67218Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      Tested-by: Jenkins
      d8cf61f3
    • László Németh's avatar
      tdf#79197 enable comment of a selected change · 9cb5b06e
      László Németh yazdı
      with cursor position at the end of the change,
      ie. now using "Next Track Change" not only
      select the next track change, but it enables
      the icon "Insert Track Change Comment" and the
      menu item "Edit->Track Changes->Comment...",
      and it's possible to add comments as expected.
      
      Change-Id: I21318e70614d1285dd6fd90d8a7cc707fc0b5757
      Reviewed-on: https://gerrit.libreoffice.org/67216
      Tested-by: Jenkins
      Reviewed-by: 's avatarLászló Németh <nemeth@numbertext.org>
      9cb5b06e
    • Xisco Fauli's avatar
      tdf#123089: expand menulist horizontally · 50b14658
      Xisco Fauli yazdı
      Change-Id: I578883c9eaf02b919fe2a7128d4255ab2a1cd2b8
      Reviewed-on: https://gerrit.libreoffice.org/67222Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: Jenkins
      Reviewed-by: 's avatarXisco Faulí <xiscofauli@libreoffice.org>
      50b14658
    • Noel Grandin's avatar
      flatten desktopdetector code · 4a79cef8
      Noel Grandin yazdı
      Change-Id: I9a7ee90fc0b8427ba237ebd8feb2c2467f6847d5
      Reviewed-on: https://gerrit.libreoffice.org/67169Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      Tested-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      Tested-by: Jenkins
      4a79cef8
    • Xisco Fauli's avatar
      tdf#123050: catch object does not have a key labeled 'theme_data' · 45a0f217
      Xisco Fauli yazdı
      json::document_error: node::child: this object does not have a key labeled 'theme_data'
      
      Change-Id: Ic4daf53cff4e3e25b83393cb92957bf60cd5a92c
      Reviewed-on: https://gerrit.libreoffice.org/67161
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      45a0f217
    • Zdeněk Crhonek's avatar
      uitest add test for Impress / find and replace dialog · e364c8c3
      Zdeněk Crhonek yazdı
      Change-Id: Id3479e790c9a1faf7ce3e0b542900c8875aac653
      Reviewed-on: https://gerrit.libreoffice.org/67213
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      e364c8c3
    • Zdeněk Crhonek's avatar
      uitest for bug tdf#96432 · d7852df4
      Zdeněk Crhonek yazdı
      Change-Id: I9afe5656f3a5b14527ca70633fb5ec5a99615e82
      Reviewed-on: https://gerrit.libreoffice.org/67207
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      d7852df4
    • andreas kainz's avatar
      NB: add print to grouped_compact file drop down menu · 37f7b39e
      andreas kainz yazdı
      Change-Id: I8e6eab164ee864eb56d2ba7184a5587a18d5353a
      Reviewed-on: https://gerrit.libreoffice.org/67130
      Tested-by: Jenkins
      Reviewed-by: 's avatarandreas_kainz <kainz.a@gmail.com>
      37f7b39e
    • Gülşah Köse's avatar
      tdf#115549 Enable handling background object. · 6d7d1fe6
      Gülşah Köse yazdı
      Change-Id: Ibb9c01d83572259b812981aa6229e9aa9b7c60f3
      Signed-off-by: 's avatarGülşah Köse <gulsah.kose@collabora.com>
      Reviewed-on: https://gerrit.libreoffice.org/67215Reviewed-by: 's avatarMarco Cecchetti <mrcekets@gmail.com>
      Tested-by: 's avatarMarco Cecchetti <mrcekets@gmail.com>
      6d7d1fe6
    • Szymon Kłos's avatar
      tdf#122198 don't remove db after close · a4ac1a93
      Szymon Kłos yazdı
      Change-Id: Ib652174148e6997c1aabe0251a62612f28243d6e
      Reviewed-on: https://gerrit.libreoffice.org/67200Reviewed-by: 's avatarSzymon Kłos <szymon.klos@collabora.com>
      Tested-by: 's avatarSzymon Kłos <szymon.klos@collabora.com>
      a4ac1a93
    • Michael Stahl's avatar
      libnumbertext: try to remove some odd stuff from ExternalProject.mk · 67411db4
      Michael Stahl yazdı
      Why do we need this?
      
      Change-Id: I662402731de9b5c56d05730d31ae59606484ec97
      Reviewed-on: https://gerrit.libreoffice.org/67210
      Tested-by: Jenkins
      Reviewed-by: 's avatarLászló Németh <nemeth@numbertext.org>
      67411db4
    • Zdeněk Crhonek's avatar
      uitest for bug tdf#123013 · 2bb6cbed
      Zdeněk Crhonek yazdı
      Change-Id: I1a2248b167718293af0c8a7aa8be27dc0d3a99cd
      Reviewed-on: https://gerrit.libreoffice.org/67211
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      2bb6cbed
    • Miklos Vajna's avatar
      CppunitTest_sw_ooxmlexport4: testTdf81345_045Original depends on fonts · cb32d787
      Miklos Vajna yazdı
      I'm not sure about the exact details, but this started to fail on one
      machine for me, and not on an other one. Simply mass-copying all .ttf
      fonts from the good machine's ~/.fonts directory to the bad machine made
      the test succeed.
      
      So annotate the test as poor by explicitly not running this when bundled
      fonts are not available.
      
      Change-Id: I42358aee08b3decd942fe93de6ff4f198f7bf63a
      Reviewed-on: https://gerrit.libreoffice.org/67206Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      Tested-by: Jenkins
      cb32d787
    • Tamas Bunth's avatar
      tdf#121069, tdf#121469 migrate special characters · 2ec13411
      Tamas Bunth yazdı
      dbahsql: Decode UTF8 characters stored as unicode code point values in
      schema file.
      
      Change-Id: I90db2345a6de9bee7aae8ae6a7c046a03eebc0a7
      Reviewed-on: https://gerrit.libreoffice.org/67197
      Tested-by: Jenkins
      Reviewed-by: 's avatarTamás Bunth <btomi96@gmail.com>
      2ec13411
    • Zdeněk Crhonek's avatar
      uitest for bug tdf#107494 · 1c2691f0
      Zdeněk Crhonek yazdı
      Change-Id: I78857cc47222a1ac81eff134b3cb570bd113ffb1
      Reviewed-on: https://gerrit.libreoffice.org/67202
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      1c2691f0
    • Stephan Bergmann's avatar
      loplugin:unusedfileds is no-op on Windows, so don't run its test there · 8949f98d
      Stephan Bergmann yazdı
      But nevertheless, make sure that the variables m_bar9/10 used in combination
      with css::uno::Any have UNO-compatible type.
      
      Change-Id: I241d8b5d37de60b00b5bfdc69e642872b28e8ee2
      Reviewed-on: https://gerrit.libreoffice.org/67201
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      8949f98d
    • Caolán McNamara's avatar
      be more lenient wrt patched epm · 8fbad2f6
      Caolán McNamara yazdı
      commit c3ab3df9
      Date:   Thu Oct 14 09:53:40 2010 +0200
      
      changed the configure.ac to require "Patched by Libreoffice", which was
      possibly an error
      
      Change-Id: I6f8e302baeed054f36b54f8bfb6f5cad826ee788
      Reviewed-on: https://gerrit.libreoffice.org/67199
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      8fbad2f6
    • Jim Jagielski's avatar
      Fix confusing message... if EPM is patched, be sure to log that · ec35e973
      Jim Jagielski yazdı
      (cherry picked from commit e774041e)
      
      Change-Id: Ie21b6a4a20199e4c7b7ef891719916db4ffba545
      Reviewed-on: https://gerrit.libreoffice.org/67198
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      ec35e973
    • Matthias Seidel's avatar
      Removed whitespace, fixed typos · 2a53f2b5
      Matthias Seidel yazdı
      (cherry picked from commit fef41649)
      
      Change-Id: I0a8f766fb5255628ea58679acca5c6b5fcefe2b1
      Reviewed-on: https://gerrit.libreoffice.org/67196
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      2a53f2b5
    • Matthias Seidel's avatar
      Removed whitespace · ec17ddd3
      Matthias Seidel yazdı
      (cherry picked from commit e50d4c88)
      
      Change-Id: Ib5fbbd250fbfa9db5f3df36277f81ffa999632d7
      Reviewed-on: https://gerrit.libreoffice.org/67195
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      ec17ddd3
    • Stephan Bergmann's avatar
      weld::TreeView::get_selected_index returns int · 5617d1e5
      Stephan Bergmann yazdı
      With Clang -fsanitize=implicit-signed-integer-truncation during
      UITest_calc_tests3:
      
      > cui/source/tabpages/numfmt.cxx:1714:31: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535
      >  #0 in SvxNumberFormatTabPage::SetCategory(unsigned short) at cui/source/tabpages/numfmt.cxx:1714:31
      >  #1 in SvxNumberFormatTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/numfmt.cxx:531:9
      >  #2 in SfxTabDialogController::CreatePages() at sfx2/source/dialog/tabdlg.cxx:1964:32
      >  #3 in SfxTabDialogController::Start_Impl() at sfx2/source/dialog/tabdlg.cxx:2038:5
      >  #4 in SfxTabDialogController::runAsync(std::shared_ptr<SfxTabDialogController> const&, std::function<void (int)> const&) at sfx2/source/dialog/tabdlg.cxx:2077:18
      >  #5 in ScAbstractTabController_Impl::StartExecuteAsync(VclAbstractDialog::AsyncContext&) at sc/source/ui/attrdlg/scdlgfact.cxx:699:12
      >  #6 in VclAbstractDialog::StartExecuteAsync(std::function<void (int)> const&) at include/vcl/abstdlg.hxx:73:16
      >  #7 in ScTabViewShell::ExecuteCellFormatDlg(SfxRequest&, rtl::OString const&) at sc/source/ui/view/tabvwsha.cxx:550:11
      >  #8 in ScCellShell::Execute(SfxRequest&) at sc/source/ui/view/cellsh3.cxx:359:36
      >  #9 in SfxStubScCellShellExecute(SfxShell*, SfxRequest&) at workdir/SdiTarget/sc/sdi/scslots.hxx:7275:1
      >  #10 in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) at include/sfx2/shell.hxx:207:35
      >  #11 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) at sfx2/source/control/dispatch.cxx:355:20
      >  #12 in SfxDispatcher::PostMsgHandler(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) at sfx2/source/control/dispatch.cxx:1092:17
      >  #13 in void std::__invoke_impl<void, void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(std::__invoke_memfun_deref, void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/invoke.h:73:14
      >  #14 in std::__invoke_result<void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >::type std::__invoke<void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/invoke.h:95:14
      >  #15 in void std::_Bind<void (SfxDispatcher::* (SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::__call<void, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&, 0ul, 1ul>(std::tuple<std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&>&&, std::_Index_tuple<0ul, 1ul>) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/functional:400:11
      >  #16 in void std::_Bind<void (SfxDispatcher::* (SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::operator()<std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >, void>(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/functional:482:17
      >  #17 in std::_Function_handler<void (std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), std::_Bind<void (SfxDispatcher::* (SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)> >::_M_invoke(std::_Any_data const&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/std_function.h:300:2
      >  #18 in std::function<void (std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::operator()(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) const at lib/gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/std_function.h:690:14
      >  #19 in SfxHintPoster::DoEvent_Impl(void*) at sfx2/source/notify/hintpost.cxx:46:9
      >  #20 in SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) at sfx2/source/notify/hintpost.cxx:43:1
      >  #21 in Link<void*, void>::Call(void*) const at include/tools/link.hxx:84:45
      >  #22 in ImplHandleUserEvent(ImplSVEvent*) at vcl/source/window/winproc.cxx:1932:30
      >  #23 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2485:13
      >  #24 in SalFrame::CallCallback(SalEvent, void const*) const at vcl/inc/salframe.hxx:285:29
      >  #25 in SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx:284:22
      >  #26 in non-virtual thunk to SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx
      >  #27 in SalUserEventList::DispatchUserEvents(bool) at vcl/source/app/salusereventlist.cxx:110:17
      >  #28 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:423:19
      >  #29 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:441:48
      >  #30 in Application::Yield() at vcl/source/app/svapp.cxx:505:5
      >  #31 in Application::Execute() at vcl/source/app/svapp.cxx:422:9
      >  #32 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1621:17
      
      Change-Id: I5b6aba4c4b832cea4209e3adc1c079e3fdd34924
      Reviewed-on: https://gerrit.libreoffice.org/67194
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      5617d1e5
    • Mike Kaganski's avatar
      const_cast is not needed here · b7e89cd6
      Mike Kaganski yazdı
      Change-Id: Ifdc1b9006fb325f14ce7623d9a28acc41a067167
      Reviewed-on: https://gerrit.libreoffice.org/67193
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      b7e89cd6
    • Michael Weghorn's avatar
      tdf#123077 gtk3_kde5: Set KFileWidget's custom widget only once · 30cc54a4
      Michael Weghorn yazdı
      Since the event filter is only used to set the custom
      widget in the KFileWidget, it can and needs to be removed
      again once this has been done; which also avoids crashes.
      
      (s. https://gerrit.libreoffice.org/#/c/67185/ for more
      infos, where the same thing is done for kde5)
      
      Change-Id: I5c719fb17510916b4730ed5c00bb638df2f183e3
      Reviewed-on: https://gerrit.libreoffice.org/67184
      Tested-by: Jenkins
      Reviewed-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
      30cc54a4
    • Miklos Vajna's avatar
      CppunitTest_writerfilter_rtftok: use CPPUNIT_TEST_FIXTURE() · 2e1a2898
      Miklos Vajna yazdı
      Change-Id: I16e0c1adf854c3a2fa8d945724270d2d87461b39
      Reviewed-on: https://gerrit.libreoffice.org/67192Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      Tested-by: Jenkins
      2e1a2898
    • Michael Weghorn's avatar
      tdf#123077 kde5: Set KFileWidget's custom widget only once · 68b15aee
      Michael Weghorn yazdı
      Since the event filter is only used to set the custom
      widget in the KFileWidget, it can be removed again
      once this has been done.
      
      Previously, events could cause 'fileWidget->setCustomWidget()'
      to be called multiple times, which resulted in a crash.
      (The fact that calling 'KfileWidget::setCustomWidget()'
      multiple times causes a crash could also be easily be
      reproduced by just duplicating the call.)
      
      Basically the same will be done for the gtk3_kde5 case,
      but in a separate commit to simplify backporting.
      
      Change-Id: Ic463c44d8a95f44ce09924893d682f402ad7ed3d
      Reviewed-on: https://gerrit.libreoffice.org/67185
      Tested-by: Jenkins
      Reviewed-by: 's avatarKatarina Behrens <Katarina.Behrens@cib.de>
      68b15aee
    • Caolán McNamara's avatar
      misleading and unnecessary fall through comments · 42da02bd
      Caolán McNamara yazdı
      Change-Id: I6309a484c3411bc1151ff2ccd276d70600854021
      Reviewed-on: https://gerrit.libreoffice.org/67191
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      42da02bd
    • Stephan Bergmann's avatar
      loplugin:unnecessaryparen (clang-cl) · 553fcbbb
      Stephan Bergmann yazdı
      Change-Id: I0cd14e0ace9c9d2fcd880477b0485295e3010b71
      Reviewed-on: https://gerrit.libreoffice.org/67138
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      553fcbbb
    • Arkadiy Illarionov's avatar
      Simplify containers iterations in sc/source/core/[o-t]* · 8da8cc3c
      Arkadiy Illarionov yazdı
      Use range-based loop or replace with STL functions
      
      Change-Id: I3ecd9e92b9690e416b4a6c8f3830346ea23c5882
      Reviewed-on: https://gerrit.libreoffice.org/67182
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      8da8cc3c
    • Noel Grandin's avatar
      loplugin:flatten in starmath · 8a722c08
      Noel Grandin yazdı
      Change-Id: Iaadd8af404e3eee5ebd49846a02a33735e9c18ba
      Reviewed-on: https://gerrit.libreoffice.org/67170
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      8a722c08
    • Caolán McNamara's avatar
      Related: tdf#122780 skip GetTextWidth() when we don't need the result · 07ec9edc
      Caolán McNamara yazdı
      Change-Id: I1919d3da162e05ea6fec6269a53344b0625338e9
      Reviewed-on: https://gerrit.libreoffice.org/67174
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      07ec9edc
    • Caolán McNamara's avatar
      tdf#115941 use max of scrollbar and statusbar height for record locater · 50547d35
      Caolán McNamara yazdı
      Change-Id: I639fd1c593e7cc440de5d2038562e64eab1a5af6
      Reviewed-on: https://gerrit.libreoffice.org/67164
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      50547d35
    • Zdeněk Crhonek's avatar
      uitest for classification dialog · d87bf779
      Zdeněk Crhonek yazdı
      Change-Id: I0338cc64790535ddf26c841f11d5ffdcaa0567ca
      Reviewed-on: https://gerrit.libreoffice.org/67158
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      d87bf779
    • Zdeněk Crhonek's avatar
      uitest test for Find replace - find similarity · f053a87d
      Zdeněk Crhonek yazdı
      Change-Id: I8ee0a99f80a51ad8938481d19c283feb9abc5a95
      Reviewed-on: https://gerrit.libreoffice.org/67177
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      f053a87d
    • Stephan Bergmann's avatar
      Don't add snap point < MINZOOM · a89f535d
      Stephan Bergmann yazdı
      ...as happens e.g. during JunitTest_forms_unoapi_1 when nFac is 0 (MINZOOM is
      20), which then causes with Clang -fsanitize=implicit-signed-integer-truncation:
      
      > svx/source/stbctrls/zoomsliderctrl.cxx:137:24: runtime error: implicit conversion from type 'int' of value -20 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65516 (16-bit, unsigned)
      >  #0 in SvxZoomSliderControl::Zoom2Offset(unsigned short) const at svx/source/stbctrls/zoomsliderctrl.cxx:137:24
      >  #1 in SvxZoomSliderControl::StateChanged(unsigned short, SfxItemState, SfxPoolItem const*) at svx/source/stbctrls/zoomsliderctrl.cxx:211:41
      >  #2 in SfxStatusBarControl::statusChanged(com::sun::star::frame::FeatureStateEvent const&) at sfx2/source/statbar/stbitem.cxx:283:13
      >  #3 in SfxDispatchController_Impl::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) at sfx2/source/control/unoctitm.cxx:859:16
      >  #4 in SfxOfficeDispatch::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) at sfx2/source/control/unoctitm.cxx:247:16
      >  #5 in svt::StatusbarController::bindListener() at svtools/source/uno/statusbarcontroller.cxx:467:38
      >  #6 in svt::StatusbarController::update() at svtools/source/uno/statusbarcontroller.cxx:178:5
      >  #7 in framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > >::operator()(std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> >&) const at framework/source/uielement/statusbarmanager.cxx:72:34
      >  #8 in framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > > std::for_each<__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > >, std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > >, std::bidirectional_iterator_tag>, framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > > >(__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > >, std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > >, std::bidirectional_iterator_tag>, __gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > >, std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > >, std::bidirectional_iterator_tag>, framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > >) at gcc/x86_64-pc-linux-gnu/9.0.1/../../../../include/c++/9.0.1/bits/stl_algo.h:3866:2
      >  #9 in framework::StatusBarManager::UpdateControllers() at framework/source/uielement/statusbarmanager.cxx:272:9
      >  #10 in framework::StatusBarManager::FillStatusBar(com::sun::star::uno::Reference<com::sun::star::container::XIndexAccess> const&) at framework/source/uielement/statusbarmanager.cxx:513:5
      >  #11 in framework::StatusBarWrapper::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) at framework/source/uielement/statusbarwrapper.cxx:123:40
      >  #12 in framework::MenuBarFactory::CreateUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::ui::XUIElement> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at framework/source/uifactory/menubarfactory.cxx:160:12
      >  #13 in (anonymous namespace)::StatusBarFactory::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/uifactory/statusbarfactory.cxx:73:5
      >  #14 in non-virtual thunk to (anonymous namespace)::StatusBarFactory::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/uifactory/statusbarfactory.cxx
      >  #15 in (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/uifactory/uielementfactorymanager.cxx:441:39
      >  #16 in non-virtual thunk to (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/uifactory/uielementfactorymanager.cxx
      >  #17 in framework::LayoutManager::implts_createElement(rtl::OUString const&) at framework/source/layoutmanager/layoutmanager.cxx:705:50
      >  #18 in framework::LayoutManager::implts_createStatusBar(rtl::OUString const&) at framework/source/layoutmanager/layoutmanager.cxx:822:44
      >  #19 in framework::LayoutManager::createElement(rtl::OUString const&) at framework/source/layoutmanager/layoutmanager.cxx:1472:13
      >  #20 in framework::LayoutManager::requestElement(rtl::OUString const&) at framework/source/layoutmanager/layoutmanager.cxx:1597:13
      >  #21 in SfxWorkWindow::UpdateStatusBar_Impl() at sfx2/source/appl/workwin.cxx:1456:29
      >  #22 in SfxWorkWindow::UpdateObjectBars_Impl2() at sfx2/source/appl/workwin.cxx:1225:5
      >  #23 in SfxWorkWindow::UpdateObjectBars_Impl() at sfx2/source/appl/workwin.cxx:1083:5
      >  #24 in SfxDispatcher::Update_Impl(bool) at sfx2/source/control/dispatch.cxx:1216:19
      >  #25 in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) at sfx2/source/view/sfxbasecontroller.cxx:1250:50
      >  #26 in SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/sfxbasecontroller.cxx:528:13
      >  #27 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) at sfx2/source/view/frmload.cxx:595:18
      >  #28 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:712:13
      >  #29 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1149:37
      >  #30 in framework::LoadEnv::startLoading() at framework/source/loadenv/loadenv.cxx:383:20
      >  #31 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:169:14
      >  #32 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:620:12
      >  #33 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx
      >  #34 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
      >  #35 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
      >  #36 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13
      >  #37 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:236:13
      
      Change-Id: I6875aa9cee8bd24231872c857be83b0d152a8dff
      Reviewed-on: https://gerrit.libreoffice.org/67178
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      a89f535d