- 17 May, 2019 1 kayıt (commit)
-
-
Todor Balabanov yazdı
Change-Id: Ie5590535d013aa2f747dd034fa2fcd2ae5c3956b Reviewed-on: https://gerrit.libreoffice.org/72226 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
- 16 May, 2019 39 kayıt (commit)
-
-
Stephan Bergmann yazdı
Apparently, at least for many builds there is am additional mouseExited/ mouseEntered event pair (making mouseEnteredEventsIntercepted = 2 and mouseExitedEventsIntercepted = 1) initiated by the xToolkitRobot.mousePress(xMouseEvent2) when the mouse pointer moves from the "Standard" window to the "writer_edit" sub-window. This needs further investigation. Change-Id: Iecebdb8db2b0d0a051072ff1a20ac00e4dfcb06c Reviewed-on: https://gerrit.libreoffice.org/72433Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
...by waiting for all events to be processed before the listeners are removed Change-Id: I1aa4f6c43de97a567877a499c4c8fb51ef53eeea Reviewed-on: https://gerrit.libreoffice.org/72432Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
Change-Id: I6872684292b4e7ef04f4c590012f1af25243f22f Reviewed-on: https://gerrit.libreoffice.org/72426Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
-
Armin Le Grand yazdı
Cause of error is that former operator= for SfxPoolItem copies all but the WhichID from the source, so being quite (and dangerously) dfferent from Clone() method. There were quite some places (and will be) that use that from my POV 'hidden' functionality by creating an Item with the target-WhichID and then using operator= to assign data from an Item with different WhichID Change-Id: Ia7e78d6d1b8b34c9c34e936db10cc850928531d5 Reviewed-on: https://gerrit.libreoffice.org/72399 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
-
andreas kainz yazdı
Change-Id: I003d68d6f97feb773c3b6590d385a58c98311755 Reviewed-on: https://gerrit.libreoffice.org/72281 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Zdeněk Crhonek yazdı
Change-Id: I7e347a1ce77f24855ad3e6c1c23f0308122501ba Reviewed-on: https://gerrit.libreoffice.org/72392 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
-
Miklos Vajna yazdı
This is similar to what was fixed in commit 9ecc9e39112fdd2b55004a0c43eb8c3ceee2e540 (Related: tdf#120287 sw layout, TabOverMargin: fix too wide tab portion, 2018-10-05), but here the problem was that we decided to start a new line when there was still enough space in the compat option case. Change-Id: I61900044a175cd14b3cdc5d36d2fa50d45c304e3 Reviewed-on: https://gerrit.libreoffice.org/72405Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Stephan Bergmann yazdı
...which fixes an issue encountered when compiling with Clang against trunk libstdc++ (which contains pre-C++17-only code that triggers <https://bugs.llvm.org/show_bug.cgi?id=41896> "Bogus 'error: no return statement in constexpr function' when void return type is 'templated'") Change-Id: I33368996c8ac8cf32893ba1b631ace2a606dafb1 Reviewed-on: https://gerrit.libreoffice.org/72409 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Samuel Mehrbrodt yazdı
Event listeners are added once VCLXWindow::SetWindow is called. This never happened for the document content window. So we need to call Window::GetComponentInterface which will create an XWindowPeer and then call UnoWrapper::SetWindowInterface which calls VCLXWindow::SetWindow. After that, event listeners are registered so that we can deliver events. Change-Id: I2ed01f1ab20d87fedc4803bdbd96f5ef14d40043 Reviewed-on: https://gerrit.libreoffice.org/71948 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Noel Grandin yazdı
because it took a loooong time staring at the code to figure it out Change-Id: Ia8f3b835cd7d18737e4b0ffe1aa67ad001822d82 Reviewed-on: https://gerrit.libreoffice.org/72395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - Remove now useless <switchinline> Change-Id: If7c9ddda50735d349f59c3d8f138177c8fbd6de0 Reviewed-on: https://gerrit.libreoffice.org/72384 Tested-by: Jenkins Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
-
Caolán McNamara yazdı
Change-Id: Ia6ecd04b81abb751bd7159ca8432c00f97ab5e2d Reviewed-on: https://gerrit.libreoffice.org/72407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Luboš Luňák yazdı
Again, normally starts container search from the beginning, so without caching this is quadratic. Change-Id: I3bb1ff40a326eb46780e45d3e3934773a7b77d06 Reviewed-on: https://gerrit.libreoffice.org/72406 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
David Tardon yazdı
Change-Id: I9d0a7e782b1bd5955cb524153b8a7bdea9e174e7
-
Tor Lillqvist yazdı
The below commit message is relevant for the behaviour fixed by this change in the Collabora branch cp-6.0 (or core) and collabora-online-4 (of online). The behaviour here in master is broken in different ways, though, and I am not entirely sure whether this change fixes anything here. But let's apply it here, too, for consistency. Until recently we had managed without them on iOS, but that changed with the recent "Unipoll" work, I think. (Without this change, the iOS app now runs into assertion failures early on. But note that this change is not enough to make it work fully again.) Change-Id: I09d25326ba73ce897da5c91f30530f5b3d5fd272
-
Michael Stahl yazdı
Change-Id: Ie56197b3f4a90b8f9510a1c29d0388f5f70e1d16 Reviewed-on: https://gerrit.libreoffice.org/72408Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
-
Stephan Bergmann yazdı
see <https://github.com/llvm/llvm-project/commit/ 76b9027f352a83c13c98820724071c5e3bea6232> "[c++20] Add support for explicit(bool), as described in P0892R2." Change-Id: Ia8a6902a64ab3377328fd5e3ed57246d214176f2 Reviewed-on: https://gerrit.libreoffice.org/72335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Luboš Luňák yazdı
Again, mdds starts container search always from the beginning, so iterating over it is quadratic. Making a large selection triggers VclQt5Clipboard::setContents(), which calls this. Change-Id: Ic027ff7c5507b41d42b9561cd099e01b50055adb Reviewed-on: https://gerrit.libreoffice.org/72367 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
Luboš Luňák yazdı
Again, unless given a hint, mdds always starts a search from the beginning of the container, so iterating over a column becomes quadratic. Shows when selecting (the title of) a large column with different value types, e.g. in tdf#120558, which triggers setting the selection from VclQt5Clipboard::setContents(), which calls this. Change-Id: Ida009c5ddf18ccdc8dff88c15530cc7e33ce80e7 Reviewed-on: https://gerrit.libreoffice.org/72366 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
Luboš Luňák yazdı
Once more, mdds always searches from the start of the container, so iterating is quadratic. Change-Id: I8f8f3b5aad5c3342a10c21df3ad2d0d3fcaea8ad Reviewed-on: https://gerrit.libreoffice.org/72368 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
Luboš Luňák yazdı
My previous commit has disabled setting non-text for selection, so this workaround is no longer needed (and it very much looks like a workaround, I see no good reason for never putting images in the clipboard). This reverts commit c8b0c382. Change-Id: I0206211e3ff0adcb89f8ca5410831a428e71fb51 Reviewed-on: https://gerrit.libreoffice.org/72370 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
Tor Lillqvist yazdı
When exiting from a document in the iOS app, the Application::Quit() would post an ImplQuitMsg user event that would however not be handled for that document. Instead, it would be handled by the next document opened and thus the code would immediately stop editing the document, causing grief. Change-Id: Id24c843b3f329673035da55f53c2134265fce003
-
Tor Lillqvist yazdı
It seems to be held after soffice_main() returns for the first document opened, but not subsequent ones, for some reason. So acquire it an extra time to be able to use Application::ReleaseSolarMutex()... Without this, when opening a subsequent document, the loleaflet loading progress bar just hangs. Change-Id: I4e4e7b814f0dba836b790b6f68470aab54f8bbb9
-
Tor Lillqvist yazdı
There was a problem in the iOS app where a callback was done passing a registered mpPollClosure that pointed to the mainKit variable in lokit_main() even though that variable had already gone out of scope and been destructed. Introduce unregisterPollCallbacks(), which just sets the mpPollClosure pointer to null. That means no callbacks should be done any more. It does not mean that Unipoll would not be active. Change isUnipoll() to look at whether the mpPollCallback pointer has been set or not. Change-Id: I5d5527c0ef097682679371dc642f8896ff05450d Reviewed-on: https://gerrit.libreoffice.org/72283Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
-
Noel Grandin yazdı
This takes the opening time from 55s to 48s for me. Change-Id: Ia60fff33e9948e0bd6906c82b48aa30f8b2551bb Reviewed-on: https://gerrit.libreoffice.org/72394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I861d3f0fa15ee3b7e0e830c4fac2e5794ea4071b Reviewed-on: https://gerrit.libreoffice.org/72213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Andreas Heinisch yazdı
Change-Id: Iaf64451c92f3465751032dde9c283141e548b3ca Reviewed-on: https://gerrit.libreoffice.org/72228 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Jens Carl yazdı
Replace vim modeline with Python specific one to avoid problems with tabs and spaces, and also make code more pythonic. Change-Id: Ia0959787ceea740b5c97f500c60ef423fbed0651 Reviewed-on: https://gerrit.libreoffice.org/72375 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Noel Grandin yazdı
saves about 0.5s out of a 43s load And remove the comment in EndListeningAll, SfxBroadcaster::RemoveListener doesn't have any weird side-effects any more Change-Id: Id7c8ac1bed8ff3487cb8f977990d8fac351d7f03 Reviewed-on: https://gerrit.libreoffice.org/72396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Mike Kaganski yazdı
Change-Id: I60f7bbb2921b242396b4620077ca30e12a0d3b4b Reviewed-on: https://gerrit.libreoffice.org/72393 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-
Xisco Fauli yazdı
Change-Id: I13cd8734f843b734826535f55c60d67625cd9e79 Reviewed-on: https://gerrit.libreoffice.org/71902Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
-
Caolán McNamara yazdı
Change-Id: Ib6f27574b8a45b29d6887d268f2e291314c796bf Reviewed-on: https://gerrit.libreoffice.org/72382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Idbb734a44289d7ecead84f3c4ac2bc1ebc44ef40 Reviewed-on: https://gerrit.libreoffice.org/72381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ideb0f4066629dec0c6375a01897c0c8d6e2ff524 Reviewed-on: https://gerrit.libreoffice.org/72380Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I16c46b6640a349b886fe934f5634f2ba79d64887 Reviewed-on: https://gerrit.libreoffice.org/71934 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
-
Miklos Vajna yazdı
Change-Id: I4e4e0b56306a6e0e1b61f432e487a47d700e5e9f Reviewed-on: https://gerrit.libreoffice.org/72379 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
-
Jens Carl yazdı
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Ib286a2151fe19a91b4e9db8db9f92ac0d5264d36 Reviewed-on: https://gerrit.libreoffice.org/72330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Andrea Gelmini yazdı
Change-Id: I6f7a40e8fefe09f9799927853b66dcae6c7a31d1 Reviewed-on: https://gerrit.libreoffice.org/72388Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
-
Andrea Gelmini yazdı
Change-Id: I38249b6ceeea7d59a23a6a4b841877724a343b78 Reviewed-on: https://gerrit.libreoffice.org/72390 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-