Kayıtlar (commit) · 4b42fd7e9516fbbd8a92d97680524f32dd260fb2 · LibreOffice / core

24 May, 2018 28 kayıt (commit)

tdf#115284: Unify LibreOffice and system full-screen concepts on macOS · 4b42fd7e

Tor Lillqvist May 23, 2018 yazdı

Also tdf#76476, and probably more.

Make it so that when a window is in full-screen mode from
LibreOffice's point of view, it is also full-screen from the system's
point of view, and vice versa.

All three ways to enter and leave full-screen mode can now be used
with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full
Screen" menu entry, and the green bubble on the title bar.

Don't disable/deactivate/etc menus while in full-screen mode. The menu
auto-hides so there is no harm in having it function normally.

Don't display the floating toolbar with a single "Full Screen" button
in it as the way to leave full-screen mode. Instead, the same three
ways that can be used to enter full-screen mode work to leave it, too.

Sadly I could not figure out a way to set a window properly to
full-screen at the point where a document window is created and set to
be the same size as that kind of document window was the previous time
it was open in LibreOffice. Thus don't save state for full-screen
windows as we can't properly restore them. At least not for macOS. It
is not good to just restore them as non-full-screened but still at the
size they had when full-screen.

One irritating glitch remains, and I was unable to fix that properly:
I now prevent closing the document window that is in full-screen mode.
Otherwise, if it is closed, the full-screen mode remains even if no
window is open there; the desktop is completely black. Moving the
cursor to the top edge, the LibreOffice menu is there, though. I tried
to fix that but with no fully satisfying result. (Some attempts even
lead to crashes, so just disabling closing is better than crashing at
least.)

Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f
Reviewed-on: https://gerrit.libreoffice.org/54760Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

4b42fd7e

Updated core · 3259f917

Olivier Hallot May 23, 2018 yazdı

Project: help  31d3025c0610319fd545b52f41211f86530eedec

tdf#117752 HID for table background in Writer

Change-Id: Iba29f40457261d833c01c53ca3d9f530887fb0b6
Reviewed-on: https://gerrit.libreoffice.org/54714Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

3259f917

Updated core · 83963ecd

Christian Lohmaier May 24, 2018 yazdı

Project: translations  ed31445a5c607b49bf71cd37055578de6785cb85

update translations for master/6.1 beta1

Change-Id: Ib85491aac55698f0db45945f3fbaa332e8ec25dc

83963ecd

rework custom widget welding to enable inheritence · eeaf6dee

Caolán McNamara May 22, 2018 yazdı

Change-Id: I0d391b3fe9d2d610ae41e2a03cd2e195a866e103
Reviewed-on: https://gerrit.libreoffice.org/54681Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

eeaf6dee

tdf#117706 Multi-select copying rows between sheets broken · c10928e7

Noel Grandin May 24, 2018 yazdı

regression from

   commit 6529cd54
   don't use heap for elements in ScRangeList

where I converted some loop variables from pointers to refs, forgetting
to assigning to a ref is quite different from assigning to a pointer

Change-Id: I4a365006317d16a24cbb1b43994906a0d4b4d424
Reviewed-on: https://gerrit.libreoffice.org/54756Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

c10928e7

xmlsecurity: Ask current datetime only once · b4960947

Takeshi Abe May 23, 2018 yazdı

... and pass it as the sole argument to XMLSignatureHelper::SetDateTime().

Change-Id: I7f3e8dc90bb34ca347a1ad5a79717a338af3bed9
Reviewed-on: https://gerrit.libreoffice.org/54706Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

b4960947

tdf#117670: migration Firebird, deal with multiword column · 9082e374

Julien Nabet May 18, 2018 yazdı

by changing parsing process a bit

Change-Id: I77c06ba218e9bc0d241dbff10f76860d0ca5ed44
Reviewed-on: https://gerrit.libreoffice.org/54542Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

9082e374

Resolves: tdf#117737 combobox menu misplaced if wrap-width set · aed4d485

Caolán McNamara May 24, 2018 yazdı

so use ellipsize instead and set the height to one single line

Change-Id: Icb124669410c041880ce468f3cf56fdb4bc1c9f1
Reviewed-on: https://gerrit.libreoffice.org/54751Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

aed4d485

revert accidentially committed part · 2624869b
Rene Engelhard May 24, 2018 yazdı
```
Change-Id: I778feac0b50390f59a3621279636f8b09ed3def2
```
2624869b

apparmor: allow also /usr/lib{,32,64}/jvm/**/bin/java · 66597c10

Rene Engelhard May 24, 2018 yazdı

since /usr/lib{,32,64}/jvm/**/jre/bin/java doesn't exist since OpenJDK 9

Change-Id: Ic9c052a756ba4a93595595da98148ff22169d333

66597c10

tdf117333 dbahsql: Chain SQLExceptions · 434ba18a

Tamas Bunth May 22, 2018 yazdı

Change-Id: Ic24d79f39d9cc36cf229c7410e1f96c4c3d316f9
Reviewed-on: https://gerrit.libreoffice.org/54671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

434ba18a

libreofficekit: Run gla11y on gtv.ui · 63f5e757

Samuel Thibault May 04, 2018 yazdı

Change-Id: I1bb2be7d3636b70018276eb3d6b23ba7ace6e62a
Reviewed-on: https://gerrit.libreoffice.org/53926Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

63f5e757

Properly handle language-specific parts of --with-help=html media/ sub-tree · 4a89e3fe

Stephan Bergmann May 24, 2018 yazdı

...that previously ended up in language-independent parts of installation sets.

The structure of that media/ tree doesn't allow to directly mis-use the existing
AllLangPackage machinery (which expects the language to be encoded in the first
pathname segment within the tree; and which is already mis-used for the
helpcontent2/AllLangPackage_html_lang.mk parts).

So introduce gb_AllLangPackage_add_files_for_lang that allows to specify the
language explicitly, independent of where it is encoded in the pathname (if at
all).  The underlying gb_AllLangPackage_add_file sets a
gb_AllLangPackage_ALLDIRS that is used by `make packageinfo`, which may need
further fixing by anybody actually using that target; see the mail thread
starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-May/080242.html>
"Broken --with-help=html `make packageinfo`".

All files in $(SRCDIR)/helpcontent2/source/media/ must now explicitly be listed
in either helpcontent2/Package_html_media.mk (for the language-independent
files) or helpcontent2/AllLangPackage_html_media_lang.mk (for the language-
specific files).  Also note the two TODOs in
helpcontent2/AllLangPackage_html_media_lang.mk.

What is not quite right yet is that content from
helpcontent2/AllLangPackage_html_lang.mk and
helpcontent2/AllLangPackage_html_media_lang.mk is ending up in both per-language
helpcontent installation sets (as intended, via the instructions in
helpcontent2/CustomTarget_html.mk) and per-language languagepack installation
sets (which is unintended).  This needs to be fixed with a follow-up commit.

This is the core part of a commit spanning core and helpcontent2.

Change-Id: Ib29e52cf8a3ca7bcd234a8f6919c8eac6157cdbf

4a89e3fe

Updated core · 9146dc88

Stephan Bergmann May 24, 2018 yazdı

Project: help  33551e7fd85aa327f76bb343a3740bceb162bbfa

Properly handle language-specific parts of --with-help=html media/ sub-tree

...that previously ended up in language-independent parts of installation sets.

The structure of that media/ tree doesn't allow to directly mis-use the existing
AllLangPackage machinery (which expects the language to be encoded in the first
pathname segment within the tree; and which is already mis-used for the
helpcontent2/AllLangPackage_html_lang.mk parts).

So introduce gb_AllLangPackage_add_files_for_lang that allows to specify the
language explicitly, independent of where it is encoded in the pathname (if at
all).  The underlying gb_AllLangPackage_add_file sets a
gb_AllLangPackage_ALLDIRS that is used by `make packageinfo`, which may need
further fixing by anybody actually using that target; see the mail thread
starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-May/080242.html>
"Broken --with-help=html `make packageinfo`".

All files in $(SRCDIR)/helpcontent2/source/media/ must now explicitly be listed
in either helpcontent2/Package_html_media.mk (for the language-independent
files) or helpcontent2/AllLangPackage_html_media_lang.mk (for the language-
specific files).  Also note the two TODOs in
helpcontent2/AllLangPackage_html_media_lang.mk.

What is not quite right yet is that content from
helpcontent2/AllLangPackage_html_lang.mk and
helpcontent2/AllLangPackage_html_media_lang.mk is ending up in both per-language
helpcontent installation sets (as intended, via the instructions in
helpcontent2/CustomTarget_html.mk) and per-language languagepack installation
sets (which is unintended).  This needs to be fixed with a follow-up commit.

This is the helpcontent2 part of a commit spanning core and helpcontent2.

Change-Id: Ie7916b75eee0dde3106e784d19e99fde5bb93195
Reviewed-on: https://gerrit.libreoffice.org/54749Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

9146dc88

member can be a ref instead of a pointer · 482ac12a
Caolán McNamara May 23, 2018 yazdı
```
Change-Id: Idb0c27933b42f3aef65f0bce098f9bd7a81dc034
```
482ac12a
ScTabViewShell is never optional · 4f75ad50
Caolán McNamara May 23, 2018 yazdı
```
Change-Id: I9f42fd6179c0a64cc14a051ca7c9e2ed9300f5c8
```
4f75ad50

coverity#704702 Dereference after null check · 8f1a64bb

Caolán McNamara May 23, 2018 yazdı

Change-Id: I876ffc1511b2115562039b97961c28d7b30e2c06
Reviewed-on: https://gerrit.libreoffice.org/54730Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

8f1a64bb

coverity#1435749 silence Uncaught exception · 47c830d2
Caolán McNamara May 23, 2018 yazdı
```
and

coverity#1399120 Uncaught exception

Change-Id: If411cd6a392636c6ac99f1ae330b16611b24df93
```
47c830d2
coverity#1435748 silence Unchecked return value · 67a3ad8a
Caolán McNamara May 23, 2018 yazdı
```
Change-Id: Iba303276f9c9564eb4afe2a9238b009dc8bbc9d3
```
67a3ad8a

reduce some unnecessary ScRangeList copying · 95e6c264

Noel Grandin May 23, 2018 yazdı

and reduce unnecessary work in ScRangeList

Change-Id: I0ee767fe28571f75f8a2ff980cea27c97c9797dc
Reviewed-on: https://gerrit.libreoffice.org/54705Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

95e6c264

[Pardus] tdf#92685 Add insert page count option to header menu · 2a93d2a4

Gulsah Kose May 23, 2018 yazdı

This patch is sponsored by ULAKBIM/Pardus project.

Change-Id: I5ecca4f58ec0ecf6a639153b52a4424af1966820
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/54687Tested-by: Jenkins <ci@libreoffice.org>

2a93d2a4

tdf#42949 Fix IWYU warnings in sd/inc/* · 23d51ad9

Gabor Kelemen May 21, 2018 yazdı

Found with bin/find-unneeded-includes
Removal proposals are dealt with here
With fallout management as necessary

Change-Id: Iaef9eec626334c480dd5a2def63bb476350ceebb
Reviewed-on: https://gerrit.libreoffice.org/54617Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

23d51ad9

EPUB export: fix gla11y warnings · bb893767

Miklos Vajna May 23, 2018 yazdı

Change-Id: I4d2ca93ff01e27ee3400adab230cb8679aacdaa9
Reviewed-on: https://gerrit.libreoffice.org/54727Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

bb893767

Fix typo · 451a76ec

Andrea Gelmini May 23, 2018 yazdı

Change-Id: I0635a5f4f02a1de222656133bca1ff2da8ce59f6
Reviewed-on: https://gerrit.libreoffice.org/54711Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

451a76ec

Add FullScreen bit to WindowStateState · 232103d0

Tor Lillqvist May 23, 2018 yazdı

FullScreen in this context means a top-level window that is both
full-screen from the desktop environment's perspective (which
depending on the desktop environment might simply mean that it is as
large as possible to fill its screen, leaving any system menus etc
visible), *and* is in LibreOffice's full-screen mode (with no toolbars
or other UI elements except the document contents visible).

Not yet used, will be used in follow-up commits.

Change-Id: Ia6f86e0d2a7c5a621c6f19d897d3b17ba6bfb8b4
Reviewed-on: https://gerrit.libreoffice.org/54733Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

232103d0

Calc threading : Check for "self" references... · 25cc0ab3

Dennis Francis May 15, 2018 yazdı

...on indirect dependencies too.

Here a self reference to any formula-group
means if there are any references in a formula
(of the formula-group itself or any of its dependencies)
that points to any element inside the formula-group.
If there are any self-references, then that formula-group
can't be computed in parallel.

For example, with this patch we can detect the following case:-
  Suppose the formula-group that we want to check is:
  "=(F2+G2-10)*10.0" spanning A2:A100. Let the formula-group
  starting at F2 be "=A1*0.1-10". The indirect dependency
  formula-group starting at F2, references back the elements of
  our original formula-group at A2. This makes the F.G at
  A2 unsafe for parallel computation.

Concretly, this patch fixes a recalc crash on tdf#63638/1

Change-Id: I7b999a34571b191d2f70da6a3831f78b24a6b0a7
Reviewed-on: https://gerrit.libreoffice.org/54433Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

25cc0ab3

Remove unnecessary include · 1d16a256

Muhammet Kara May 23, 2018 yazdı

Change-Id: I660bc8efd441e9fc5b6f83f69dc632a26add193b
Reviewed-on: https://gerrit.libreoffice.org/54712Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

1d16a256

revert tdf#76817 ooxmlimport: connect Heading to existing numbers · 8d42de21

Justin Luth May 12, 2018 yazdı

tdf#50774 has an example document which was broken by 6.1 commit
8e9e705d.

Reverting does a couple of things:
-go back to previous behaviour (right or wrong) - no regression.
-gives an opportunity to find documents broken by reverting -
i.e. it will give an indication as to which state has more broken
docs. Can be re-visited in 6.2.
-gives me an option to escape from this horrible mess without causing
a regression in a production release of LO.

Change-Id: Ib594b76d5533a0c4807cf70ef706c107e52cddcf
Reviewed-on: https://gerrit.libreoffice.org/54293Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

8d42de21

23 May, 2018 12 kayıt (commit)

tdf#117481 Breeze Add dbaccess icons for base sidebar · 6fecbff9

andreas kainz May 23, 2018 yazdı

Change-Id: I5174261484c64a6f223c4a2e197d0e042c3581e3
Reviewed-on: https://gerrit.libreoffice.org/54737Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

6fecbff9

tdf#117629 Fix FontWork UNO API/SdrPage settings · d541c454

Armin Le Grand May 23, 2018 yazdı

Change-Id: Id4da3ac2ff9f8bba382512cfafbca323d1002137
Reviewed-on: https://gerrit.libreoffice.org/54722Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

d541c454

tdf#117481 Elementary: Add dbaccess icons for base sidebar · 748215da

andreas kainz May 23, 2018 yazdı

Change-Id: Ia4e2b0bb7b31671a50acf6659ea3ca83c3dfcb39
Reviewed-on: https://gerrit.libreoffice.org/54736Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

748215da

Remove leftover "#undef DEBUG" · 7d353794

Stephan Bergmann May 23, 2018 yazdı

...which might have had a purpose in the past, but look unused today.  (DEBUG is
defined in solenv/gbuild/gbuild.mk iff dbglevel >= 2, and `make
Library_xsec_xmlsec dbglevel=2` doesn't run into any problems for me with the
undefs removed.)

Change-Id: I7f941e8c2d454f4206fb17bc791247606ffe6309
Reviewed-on: https://gerrit.libreoffice.org/54718Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

7d353794

deb#899380 apparmor: fix gpg encryption hang trying to lock random_seed · 8615efe6

Rene Engelhard May 23, 2018 yazdı

Change-Id: Ib9fb7652922dcc8364567953d17d7cae8ad170a7
Reviewed-on: https://gerrit.libreoffice.org/54726Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>

8615efe6

forward more a11y stuff for native drawing area widget · 30d43a7e

Caolán McNamara May 23, 2018 yazdı

Change-Id: Ic5529a73e317fb652944155fabc889b693447355
Reviewed-on: https://gerrit.libreoffice.org/54704Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

30d43a7e

actually add AC_MSG_CHECKING/_RESULTs for --enable/disable-postgresql-sdbc · a4c83a91

Rene Engelhard May 23, 2018 yazdı

Change-Id: I6b02998db5624960ba78ce8b1b0356601a80fc5e
Reviewed-on: https://gerrit.libreoffice.org/54721Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>

a4c83a91

Fix typo · 72b8f0b8

Andrea Gelmini May 23, 2018 yazdı

Change-Id: Ie9501a1cb9f8c2a747b92eb74c120816b49148d8
Reviewed-on: https://gerrit.libreoffice.org/54709Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

72b8f0b8

tdf#104086 cui: enable OpenGL when ignoring its blacklist · 8118a5d2

Miklos Vajna May 23, 2018 yazdı

"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it
make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that
case. But the UI suggested that enabling ignore doesn't enable OpenGL
itself.

Fix this by auto-checking the parent UI widget when enabling the
blacklist.

Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e
Reviewed-on: https://gerrit.libreoffice.org/54720Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

8118a5d2

sw: prefix members of SwScriptInfo · eded5821
Michael Stahl May 23, 2018 yazdı
```
Change-Id: I1272d53d602052b09101bed8cf0fb4a19fecf52d
```
eded5821

sw: fix max->min in SwTextNode::GetScalingOfSelectedText() · e9d95865

Michael Stahl May 23, 2018 yazdı

(regression from b1ac01de)

Change-Id: Ic2e835f19aaa4e9b26741c409515fc8d26cab1d3
Reviewed-on: https://gerrit.libreoffice.org/54707Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

e9d95865

colibre_svg: add links.txt from colibre · 933c1a04

Tomaž Vajngerl May 23, 2018 yazdı

Change-Id: Ic248ce1a05f740df111a9f507c099965fdc48d35
Reviewed-on: https://gerrit.libreoffice.org/54716Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

933c1a04