Kaydet (Commit) 8118a5d2 authored tarafından Miklos Vajna's avatar Miklos Vajna

tdf#104086 cui: enable OpenGL when ignoring its blacklist

"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it
make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that
case. But the UI suggested that enabling ignore doesn't enable OpenGL
itself.

Fix this by auto-checking the parent UI widget when enabling the
blacklist.

Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e
Reviewed-on: https://gerrit.libreoffice.org/54720Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
Tested-by: 's avatarJenkins <ci@libreoffice.org>
üst eded5821
......@@ -659,6 +659,8 @@ OfaViewTabPage::OfaViewTabPage(vcl::Window* pParent, const SfxItemSet& rSet)
#endif
m_pForceOpenGL->SetToggleHdl(LINK(this, OfaViewTabPage, OnForceOpenGLToggled));
// Set known icon themes
OUString sAutoStr( m_pIconStyleLB->GetEntry( 0 ) );
m_pIconStyleLB->Clear();
......@@ -736,6 +738,13 @@ IMPL_LINK_NOARG( OfaViewTabPage, OnAntialiasingToggled, CheckBox&, void )
}
#endif
IMPL_LINK_NOARG(OfaViewTabPage, OnForceOpenGLToggled, CheckBox&, void)
{
if (m_pForceOpenGL->IsChecked())
// Ignoring the opengl blacklist implies that opengl is on.
m_pUseOpenGL->Check();
}
VclPtr<SfxTabPage> OfaViewTabPage::Create( TabPageParent pParent, const SfxItemSet* rAttrSet )
{
return VclPtr<OfaViewTabPage>::Create(pParent.pParent, *rAttrSet);
......
......@@ -121,6 +121,7 @@ private:
#if defined( UNX )
DECL_LINK( OnAntialiasingToggled, CheckBox&, void );
#endif
DECL_LINK(OnForceOpenGLToggled, CheckBox&, void);
void UpdateOGLStatus();
public:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment