- 22 Eki, 2018 20 kayıt (commit)
-
-
Caolán McNamara yazdı
for... "The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression" subcases, where the args are already bool Change-Id: Ica8b5c4974c513f7f7ad8acf17ca931e85ebc8af Reviewed-on: https://gerrit.libreoffice.org/62146 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: I2ac33db8d265f1af1c8fc8def2d3a45c5be37741 Reviewed-on: https://gerrit.libreoffice.org/62154 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
V571 The 'pNew' condition was already verified in line 47. Change-Id: Ib6b6a48f8c565ee28bbbaa8846f549639b6291be Reviewed-on: https://gerrit.libreoffice.org/62159 Tested-by: Jenkins Reviewed-by:
Xisco Faulí <xiscofauli@libreoffice.org>
-
Caolán McNamara yazdı
Change-Id: Ida759ae9fce3d384b19e41683bdcd796eb158efe Reviewed-on: https://gerrit.libreoffice.org/62147 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V560 A part of conditional expression is always true: (nHintStart >= nStartIdx) V509 The 'dynamic_cast' operator should be located inside the try..catch block, as it could potentially generate an exception. Raising exception inside the destructor is illegal. V560 A part of conditional expression is always true: pHint. Change-Id: Icfb9a2961f5db034fd19f4665fe3ceaae6232350 Reviewed-on: https://gerrit.libreoffice.org/62039 Tested-by: Jenkins Reviewed-by:Michael Stahl <Michael.Stahl@cib.de>
-
Armin Le Grand yazdı
Change-Id: I5ba0504265f5692614a8db0117883528bd4bfc0b Reviewed-on: https://gerrit.libreoffice.org/62000 Tested-by: Jenkins Reviewed-by:
Armin Le Grand <Armin.Le.Grand@cib.de>
-
Mike Kaganski yazdı
Follow-up of commit f4103a42 Change-Id: I4562386d3151875dff8e9eddf31c4af3333cefb7 Reviewed-on: https://gerrit.libreoffice.org/61245 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
andreas kainz yazdı
and final tab review Change-Id: Ia91398f65486f09fccce19b3b1a568f96844cd24 Reviewed-on: https://gerrit.libreoffice.org/62164 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Xisco Fauli yazdı
V571 The 'pArgs' condition was already verified in line 47. Change-Id: Id63eb556610ec457864e44b7d3f49e46f133e5a9 Reviewed-on: https://gerrit.libreoffice.org/62162 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
V571 The 'SwKeyState::KeyToView != eFlyState' condition was already verified in line 1723. Change-Id: I4fb5d7a5e50822985ca753706d4cdb1693439118 Reviewed-on: https://gerrit.libreoffice.org/62161 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
V571 The '!pNumRule' condition was already verified in line 2092. Change-Id: I2fc040e9c3053b351b99eb123285ef05f20813f5 Reviewed-on: https://gerrit.libreoffice.org/62160 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
V571 The 'pColumn->GetWidthOption()' condition was already verified in line 1033. Change-Id: I5bc11bceddc8090f41bf86b45f880ceea3dfb204 Reviewed-on: https://gerrit.libreoffice.org/62158 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
V571 The 'mpView' condition was already verified in line 417. Change-Id: I64d522412f1f627ab04a29f90b33177ef726eb58 Reviewed-on: https://gerrit.libreoffice.org/62157 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
V571 The 'bOk' condition was already verified in line 1553. Change-Id: I19a30071ebfc1937d03f2fdfcbfc12017e3e835e Reviewed-on: https://gerrit.libreoffice.org/62156 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
V571 The 'mpViewShell' condition was already verified in line 887. Change-Id: I90e8beee2f66936122824e403ae82aebceb3adc4 Reviewed-on: https://gerrit.libreoffice.org/62155 Tested-by: Jenkins Reviewed-by:
-
Arkadiy Illarionov yazdı
Use range-based loop or replace with STL functions. Change-Id: I3cdb0f89523008199af1550de164a52b75c52ba5 Reviewed-on: https://gerrit.libreoffice.org/62088 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Samuel Mehrbrodt yazdı
There are cases where the extension registration becomes invalid (empty rdb files) which leads to extensions not starting up, although installed and active. Syncing extension repos on startup fixes that. The performance impact is negligible (1ms in my measurements). Change-Id: I10475ce6a054b43c4591b17a8486648ca6a30068 Reviewed-on: https://gerrit.libreoffice.org/61943 Tested-by: Jenkins Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Mike Kaganski yazdı
V668 There is no sense in testing the 'pProgress' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ida8c103e5f08d380e5c2de5bc5d269597bd32e30 Reviewed-on: https://gerrit.libreoffice.org/62151 Tested-by: Jenkins Reviewed-by: -
Noel Grandin yazdı
Change-Id: Ief773b661a8378a10db56943b32127c7a2c86d11 Reviewed-on: https://gerrit.libreoffice.org/62037 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ie9f36eb0e00aaee34a27f136ed903f8f87e52dcc Reviewed-on: https://gerrit.libreoffice.org/61916 Tested-by: Jenkins Reviewed-by:
-
- 21 Eki, 2018 20 kayıt (commit)
-
-
Christian Lohmaier yazdı
Change-Id: If6dedb58b6918d9815c47f898a8b19eb9c0d5681
-
Christian Lohmaier yazdı
Change-Id: Ibafa81b412036e98fa9ab047fc8e204660eae120
-
Christian Lohmaier yazdı
* Update translations from branch 'master' - update translations for 6.2.0 alpha1 also add Lower Sorbian and force-fix errors using pocheck Change-Id: I616de90d5159504de836211412a2266296b2f624 -
Rizal Muttaqin yazdı
Change-Id: Ib3c5a5a09eff26acabf64e4cbc2e7019ca3264e7 Reviewed-on: https://gerrit.libreoffice.org/62142 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression. V668 There is no sense in testing the 'pCTLOptions' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. The latter is apparently error in our condition, since the || turned it into unconditional execution, but _xISC must be a valid reference inside the block, since it's dereferenced there in all code paths. Change-Id: I7fbbb1c4b54503db50e8eabd2666cbcd05758103 Reviewed-on: https://gerrit.libreoffice.org/62153 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V668 There is no sense in testing the 'hdo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ic889dcba4e9d77a6dd27dd1603ed37d39e9fe581 Reviewed-on: https://gerrit.libreoffice.org/62152 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V668 There is no sense in testing the 'pClipDoc' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V560 A part of conditional expression is always true: pDoc. V560 A part of conditional expression is always true: pMergeFlagAttr. V560 A part of conditional expression is always true: pMergeFlag. Change-Id: Ief75a140cca58fe458dc3c1fd18a9bbaa1ea39cb Reviewed-on: https://gerrit.libreoffice.org/62143 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V668 There is no sense in testing the 'pBackgroundPropertiesPtr' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I728ffa74ec5e1f1f428224c79bd17c53b3ad3829 Reviewed-on: https://gerrit.libreoffice.org/62150 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V1004 The 'pDocShell' pointer was used unsafely after it was verified against nullptr. Check lines: 258, 561. V668 There is no sense in testing the 'pFrameView' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I768d3f56dbd5edd070da9d989ab2d85c4b8e868f Reviewed-on: https://gerrit.libreoffice.org/62149 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V668 There is no sense in testing the 'pPor' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I58d553fc59606f54013246f23a1b18a4ab673aac Reviewed-on: https://gerrit.libreoffice.org/62148 Tested-by: Jenkins Reviewed-by: -
Caolán McNamara yazdı
Change-Id: Ibe61e593b7f0fb3abc033132450ce620ee3294c9 Reviewed-on: https://gerrit.libreoffice.org/62136 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ib3c5a5a09eff26acabf64e4cbc2e7019ca3264e6 Reviewed-on: https://gerrit.libreoffice.org/62098 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: If95854af5072c9e693bec4011cdcd6c041dffdf3 Reviewed-on: https://gerrit.libreoffice.org/62094 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V668 There is no sense in testing the 's' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V1029 Numeric Truncation Error. Result of the 'size' function is written to the 16-bit variable. Change-Id: I8e0598e892ca160ac074bccfed87c14367a3b46a Reviewed-on: https://gerrit.libreoffice.org/62139 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V668 There is no sense in testing the 'mpTheme' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V1004 The 'mpFont' pointer was used unsafely after it was verified against nullptr. Check lines: 879, 881. Change-Id: I47627de2cd98d3bb36e1ced7346ebe9177c21e65 Reviewed-on: https://gerrit.libreoffice.org/62141 Tested-by: Jenkins Reviewed-by: -
Caolán McNamara yazdı
Change-Id: I455fc328a0b9aa3af3e37e9a9fa86ecba97dc5a4 Reviewed-on: https://gerrit.libreoffice.org/62099 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I3a2585c605ba9cb83f47fafc93653b36ab4104fc Reviewed-on: https://gerrit.libreoffice.org/62135 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V668 There is no sense in testing the 'pEffect' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I979915efb406d3173e03b4f47883e01fe0ca5d2d Reviewed-on: https://gerrit.libreoffice.org/62140Reviewed-by: -
Caolán McNamara yazdı
Change-Id: Id81e01bd8a082e6bb4eda2f9e8bae1818389941f Reviewed-on: https://gerrit.libreoffice.org/62102Reviewed-by:
-
Mike Kaganski yazdı
V668 There is no sense in testing the 'pDest' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I17773f92ed73359e925ad779d171ec99727f7905 Reviewed-on: https://gerrit.libreoffice.org/62133 Tested-by: Jenkins Reviewed-by:
-
