Kaydet (Commit) 89aefcb8 authored tarafından Mike Kaganski's avatar Mike Kaganski

tdf#120703 (PVS): redundant nullptr check

V668 There is no sense in testing the 'pBackgroundPropertiesPtr' pointer
     against null, as the memory was allocated using the 'new' operator.
     The exception will be generated in the case of memory allocation error.

Change-Id: I728ffa74ec5e1f1f428224c79bd17c53b3ad3829
Reviewed-on: https://gerrit.libreoffice.org/62150
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
üst ebab5c3c
......@@ -109,9 +109,7 @@ ContextHandlerRef PPTShapeGroupContext::onCreateContext( sal_Int32 aElementToken
pBackgroundPropertiesPtr->moFillType = XML_solidFill;
pBackgroundPropertiesPtr->maFillColor.setSrgbClr(0xFFFFFF);
}
if ( pBackgroundPropertiesPtr ) {
pShape->getFillProperties().assignUsed( *pBackgroundPropertiesPtr );
}
pShape->getFillProperties().assignUsed( *pBackgroundPropertiesPtr );
}
pShape->setModelId(rAttribs.getString( XML_modelId ).get());
return new PPTShapeContext( *this, mpSlidePersistPtr, mpGroupShapePtr, pShape );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment