- 12 Ara, 2016 40 kayıt (commit)
-
-
Tor Lillqvist yazdı
To avoid this: sc/source/core/tool/formulalogger.cxx:55:26: error: bad static variable causes crash on shutdown [loplugin:badstatics] static FormulaLogger aLogger; ~~~~~~~~~~~~~~~~~~~~~^~~~~~~ sc/inc/formulalogger.hxx:42:31: note: ... due to this member of 'FormulaLogger' [loplugin:badstatics] const ScFormulaCellGroup* mpLastGroup = nullptr; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sc/inc/formulacell.hxx:66:20: note: ... due to this member of 'ScFormulaCellGroup' [loplugin:badstatics] ScFormulaCell *mpTopCell; ~~~~~~~~~~~~~~~^~~~~~~~~ sc/inc/formulacell.hxx:114:21: note: ... due to this member of 'ScFormulaCell' [loplugin:badstatics] ScDocument* pDocument; ~~~~~~~~~~~~~~~~^~~~~~~~~ sc/inc/document.hxx:312:27: note: ... due to this member of 'ScDocument' [loplugin:badstatics] VclPtr<SfxPrinter> pPrinter; ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ Change-Id: I533e45f655ca928a801188aa48ee818d89a962ac
-
Tor Lillqvist yazdı
Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe
-
Tor Lillqvist yazdı
Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3
-
Tor Lillqvist yazdı
Change-Id: I7ef42d66a0ffbbd8f2754bd4aba0e77659c9ae83
-
Tor Lillqvist yazdı
Change-Id: I6ab405e7e9a0c8ac3a323fd2484e334c500280ae
-
Tor Lillqvist yazdı
Change-Id: I45d7e14cef0058c4bfca4a3466e31d64e29bdfae
-
Tor Lillqvist yazdı
Change-Id: If538d5d5347f58e18869cab2b687af26a39a89eb
-
Stephan Bergmann yazdı
Change-Id: Ic8e00ab8961811044c26eb237f283617ddeb5cb6
-
Caolán McNamara yazdı
Change-Id: I44a03f557d7a7aafeb17e5d662797203f975672f
-
Miklos Vajna yazdı
Change-Id: If35981bce951dfab4a784d4cb54ac911249572ed
-
Caolán McNamara yazdı
Change-Id: I4437484192016db7ce72614ae07c5a7d1bd9ec5b
-
Caolán McNamara yazdı
Change-Id: I17146905c93162977effe9179c844ba691320d35
-
Laurent Balland-Poirier yazdı
Format "%.2f" is not optimal for large or small values. Format "%g" should be prefered. Change-Id: I92899d80564b9000b1f3e049221c456f8e1176a9 Reviewed-on: https://gerrit.libreoffice.org/31445Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Despite being a 32-bit architecture, m68k has a basic alignment of 16-bit for historic reasons. On m68k, SAL_TYPES_ALIGNMENT8 is therefore equal to 2 and we need to cover this case in the static asserts as well. Change-Id: I4c756af25d57e5d49209697f6e678ef71a5845aa Reviewed-on: https://gerrit.libreoffice.org/31878Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Arnaud Versini yazdı
Remove useless class NameContainerImpl. Change-Id: I3066abea69ed68d597aeecdd6b3ec7264f7ebe9c Reviewed-on: https://gerrit.libreoffice.org/31830Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8 Reviewed-on: https://gerrit.libreoffice.org/31898Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4
-
Caolán McNamara yazdı
Change-Id: Ib0106c3b88cf54e54aaf784bb526480a1c745a1f
-
Michael Meeks yazdı
This reverts commit cc020974. Need to improve the solution here a little I think.
-
Bjoern Michaelsen yazdı
Change-Id: I02a3a46d2222b8bfe955eb17ca655d36d9155b48 Reviewed-on: https://gerrit.libreoffice.org/31867Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
-
Bjoern Michaelsen yazdı
Change-Id: I9759a0f21641b6f5ba5e456e5c45ac28238ca672 Reviewed-on: https://gerrit.libreoffice.org/31866Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
-
Bjoern Michaelsen yazdı
Change-Id: I76e9d317dabeefcdf53468a89f3a6130279993f3 Reviewed-on: https://gerrit.libreoffice.org/31865Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
-
Bjoern Michaelsen yazdı
Change-Id: Ie7127668aceade312c68ed3d7f3398fbaf5e8df7 Reviewed-on: https://gerrit.libreoffice.org/31864Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
-
Bjoern Michaelsen yazdı
Change-Id: I49c448c454f9bb820c3b9afa3825c58cb2dab978 Reviewed-on: https://gerrit.libreoffice.org/31863Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
-
Bjoern Michaelsen yazdı
Change-Id: Iad8b5ff731c9d53f0f015a95387a00993a4a31f8 Reviewed-on: https://gerrit.libreoffice.org/31862Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
-
Caolán McNamara yazdı
Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4
-
Caolán McNamara yazdı
Change-Id: I5b7c6992e92e4d096b8230774ed8f4bfaaad5831
-
Mike Kaganski yazdı
Failing to do that leads to write-past-end-of-document, drawing loss and SAXParseException if the drawing is part of a footnote. A unit test is included. Change-Id: Ie7d8263dc72dfef1e9827cc0579a5eaaf5819410 Reviewed-on: https://gerrit.libreoffice.org/31871Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Noel Grandin yazdı
to bring up File Open... dialog we need to hold the SolarMutex when doing VclPtr ref-counting Change-Id: I843f2a243acaf73db1f6557df23475fe5bb12131 Reviewed-on: https://gerrit.libreoffice.org/31892Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: Ifceb60ee9f1f5e0ba5fd68d88a0358b5400008ee
-
Caolán McNamara yazdı
Change-Id: Ibb24dea2464c2e0bba289f08bba053efe6fe57fc
-
Caolán McNamara yazdı
Change-Id: Ia8c601475bea142faad9c1f1e9b797d0ebc13679
-
Caolán McNamara yazdı
and coverity#1397044 Unchecked return value Change-Id: I193bd676e417c35450efa91cb5773c78c998b63f
-
Caolán McNamara yazdı
Change-Id: I7f8988a7cf5f3d815a20cac249b3753d732994e1
-
Caolán McNamara yazdı
Change-Id: Ie33ef6565cadcddb59c1d78a63aec666e8693f87
-
Caolán McNamara yazdı
Change-Id: I37c49aa568646e44c05f5feec537d344a2440b91
-
Noel Grandin yazdı
This appears to be a consequence of my change commit 942716fe convert EID constants to typed_flags in that change I made a "fix": @@ -689,20 +687,20 @@ void EventMultiplexer::Implementation::CallListeners (EventMultiplexerEvent& rEv ListenerList::const_iterator iListenerEnd (aCopyListeners.end()); for (; iListener!=iListenerEnd; ++iListener) { - if ((iListener->second && rEvent.meEventId)) + if (iListener->second & rEvent.meEventId) iListener->first.Call(rEvent); } } which causes this bug. I should have noticed that my "fix" indicates that the event filtering part of this multiplexing code was never working, and since no-one has ever complained about, lets just remove all of this unnecessary complexity. Change-Id: Id71613d4fd5817ee1358705059e4ce63d57573ad Reviewed-on: https://gerrit.libreoffice.org/31894Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
and coverity#1397055 Inferred misuse of enum copy and paste error from the other converted call site I bet Change-Id: I63701db153c5fd424374a95dd757d9fd7a8bc216
-
Caolán McNamara yazdı
regression from... commit b894104a Date: Thu Dec 8 00:43:09 2016 +0200 Pass GlyphItem around We have this nice structure that contains (almost) all the information we need, so pass it around instead of passing separate fragments of said information. presumably this is the correct fix given the context of the other changes Change-Id: I8518e739b1caa00ea5ae1569282e98810462d4c3
-
Stephan Bergmann yazdı
...containing replacements for global operator new/delete (that can be linked into executables), but which is no longer used. The mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2012-March/028690.html> "operator new no longer routes through rtl_AllocMemory in libsalcpprt under gbuild link rules" has the details of how this was used on some platforms (but not on others) before the switch to gbuild, and has been "lost" ever since---but apparently a loss not mourned much over the years. For the SDK, c5f97428 "INTEGRATION: CWS jsc3: #i62434# copy libsalcpprt.a" added the library (under Linux) and 6db9c5af "INTEGRATION: CWS jsc3: #i62434# extend link options for executbales to link libsalcpprt.a, LINUX only" added its use to odk/settings/settings.mk, but fc0ca57f "INTEGRATION: CWS jsc21" removed that use again (for no documented reason). So this is an incompatible change, but unlikely to actually affect any users of the SDK. Change-Id: Ia38b4c439f21fca3f5d9af7d1a34054e992054e9 Reviewed-on: https://gerrit.libreoffice.org/31810Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-