- 27 Tem, 2018 40 kayıt (commit)
-
-
Stephan Bergmann yazdı
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. Change-Id: I4b3833ceb9da0a83be45c808f163dfad97f9c946 Reviewed-on: https://gerrit.libreoffice.org/58164 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Muhammet Kara yazdı
It is no longer needed for the cases where oly the static methods are called Change-Id: I869b824c53ef1a8db07f4ca7f0aa9e678e16a7ac Reviewed-on: https://gerrit.libreoffice.org/58162 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
Change-Id: If90828e508178dfaaee51f88cf52ada0aec5970c Reviewed-on: https://gerrit.libreoffice.org/58120 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Id3009a4b038175625cf8be419deb5ef8a9998850 Reviewed-on: https://gerrit.libreoffice.org/58110 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Id297a513f3313e10531f0ccd99a16277e4e37fa1 Reviewed-on: https://gerrit.libreoffice.org/58111 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I597ef6d75d1c21cdc15a91bf7f549bc14c851506 Reviewed-on: https://gerrit.libreoffice.org/58086 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...by removing explicitly user-provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non-deleted in the future. (Even if a dtor was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already inline, so why bother with a non-inline dtor.) Change-Id: Ic8c24977a68d33a0051a74617fb4b4dcc2b664df Reviewed-on: https://gerrit.libreoffice.org/58094 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. (For LIBO_INTERNAL_ONLY.) Change-Id: I9da48559b083bdec9b1b4014634f6f3bfb1c3de3 Reviewed-on: https://gerrit.libreoffice.org/58107 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I2bad74a8f103e9dc68c8e0d0e6315697068d2f6d Reviewed-on: https://gerrit.libreoffice.org/58135 Tested-by: Jenkins Reviewed-by:
-
Zdeněk Crhonek yazdı
Change-Id: I43c7f2d350e54ae00b03e4498f05f59bcfd16337 Reviewed-on: https://gerrit.libreoffice.org/57952 Tested-by: Jenkins Reviewed-by:
Zdenek Crhonek <zcrhonek@gmail.com>
-
Noel Grandin yazdı
look for OUString being appended to in a loop, better to use OUStringBuffer to accumulate the results. Change-Id: Ia36e06e2781a7c546ce9cbad62727aa4c5f10c4b Reviewed-on: https://gerrit.libreoffice.org/58092 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I086a809b6541041b627daa93f9a08be2a9218550 Reviewed-on: https://gerrit.libreoffice.org/58117 Tested-by: Jenkins Reviewed-by:
-
Eike Rathke yazdı
The emperor Akihito will abdicate on 2019-04-30. The next emperor will be Naruhito, but so far neither the new era name (Heisei for Akihito) nor its abbreviation or a Unicode character are determined. At least introduce the new era with some dummy names (Naruhito,Na,N). Change-Id: I8c0af390ca0408ac259e47e7eaf2e49b5889c9ba Reviewed-on: https://gerrit.libreoffice.org/58142Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by: Jenkins
-
Eike Rathke yazdı
Change-Id: I50debd5be2e0d4db0b5c57676d03ec33a2c38737 Reviewed-on: https://gerrit.libreoffice.org/58128Reviewed-by:
-
Eike Rathke yazdı
Change-Id: I4c6299e9b6890eb22f50586ceb5788057527e88c Reviewed-on: https://gerrit.libreoffice.org/58124Reviewed-by:
-
Eike Rathke yazdı
... so using it in SUMPRODUCT() and other ForceArray context works as expected. Change-Id: I60197301edcd2c24f8cb0c5fcf4dc4699d9a6165 Reviewed-on: https://gerrit.libreoffice.org/58118Reviewed-by:
-
Eike Rathke yazdı
Obtaining the usual matrix for iterated scalar values doesn't work here because we don't want the formulas' results but whether there are formulas at the referenced positions. Change-Id: I7912f9019d21b803ca327cb022df2014d3cc5c5a Reviewed-on: https://gerrit.libreoffice.org/58115Reviewed-by:
-
Luboš Luňák yazdı
Triggered by 710aeefd2 ("make opencl also use approximate add and sub"), OpenCL doesn't actually get used to check these because it's not used for single formulas, but it looks like handling of imprecise doubles is not checked anywhere, so add a test. Change-Id: I7a73af508d6ea5f141397ebf11f246cf0a622fed Reviewed-on: https://gerrit.libreoffice.org/58068 Tested-by: Jenkins Reviewed-by:Luboš Luňák <l.lunak@collabora.com>
-
Luboš Luňák yazdı
Code basically taken from rtl::math::approxAdd() and friends. Without this OpenCL will sometimes not get results as 0 because of rounding errors (sc/qa/.../linest.fods with minimum formula size disabled). Change-Id: Ib66f5eb1c6aeb9c95047406de1442b388ccc7f5f Reviewed-on: https://gerrit.libreoffice.org/57911 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com>
-
Justin Luth yazdı
Introduced in LO 4.0 in a mass copy of compat settings in commit 355d25ea Change-Id: I0d95941ff2815a43e571be1a6a0dbab1d12185d6 Reviewed-on: https://gerrit.libreoffice.org/57991 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Luboš Luňák yazdı
All these calls first entered the whole array into the cache and only then filled it up with values. If that failed, the values stayed in the cache and could be reused by something else. Testcase is sc/qa/.../linest.fods, where the error in X19 prevents caching of that column for the formula in AA24:AA28. Since currently ScFormulaCell::InterpretFormulaGroup() calls InterpretFormulaGroupOpenCL() twice, the first ScGroupTokenConverter::convert() call cached the incomplete column and then failed, and the second call simply reused the value. But this could presumably happen for multiple formulas using data in the same column as well, even without the double call. Change-Id: Iaa55671936fe61f72dfa35940db8deaf27d1c22d Reviewed-on: https://gerrit.libreoffice.org/57912 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. Change-Id: Ib10659fbd430b96edbad67e779ce4c12b7eeaa5d Reviewed-on: https://gerrit.libreoffice.org/58054 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I88c941832a0d682ea4b6028c28edd48cf5df38f7 Reviewed-on: https://gerrit.libreoffice.org/58093 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
no logic change intended Change-Id: Ic4d54965033e518195ef8e76ddec7feca14970c2 Reviewed-on: https://gerrit.libreoffice.org/58125 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I21cc4af40429fa3ef4284d6c0ea592b05bf36620 Reviewed-on: https://gerrit.libreoffice.org/58121Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ib489ebf55d3a18d2af6f34b3f6128231d6d7758c Reviewed-on: https://gerrit.libreoffice.org/58090 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Idca4bfaaa9f127eae87ae879e2131aed747ce4b3 Reviewed-on: https://gerrit.libreoffice.org/58089 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I8e1a7897777111c225e42ebcf81e67face6b29b9 Reviewed-on: https://gerrit.libreoffice.org/58114 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ie98da9b53e952c2fb1f8f91e4b9489060114c366 Reviewed-on: https://gerrit.libreoffice.org/58113 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I28b2cd46bf40011f5f813784bd5c182f18ee103f Reviewed-on: https://gerrit.libreoffice.org/58112 Tested-by: Jenkins Reviewed-by:
-
Markus Mohrhard yazdı
Change-Id: I115590658708bafc7c7778612251ad7eb716b30b Reviewed-on: https://gerrit.libreoffice.org/58150 Tested-by: Jenkins Reviewed-by:
Markus Mohrhard <markus.mohrhard@googlemail.com>
-
Miklos Vajna yazdı
Change-Id: I2a4bdcf506720f266344378cdcc71975de4293e0 Reviewed-on: https://gerrit.libreoffice.org/58146 Tested-by: Jenkins Reviewed-by:
-
Muhammet Kara yazdı
Leftover from 8d3d04ef Change-Id: I4ab7c7eccc8165bdfadba792f2ef8ccf1e52c1c3 Reviewed-on: https://gerrit.libreoffice.org/58138 Tested-by: Jenkins Reviewed-by:
Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by:
-
Muhammet Kara yazdı
and the corresponding include for SvtMiscOptions Introduced in 20bb2e70 Leftover from 026e2623 Change-Id: Ibe232045be2396f4a9761d5537b4cc3c9b7af6e1 Reviewed-on: https://gerrit.libreoffice.org/58137 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
SfxPoolItem has the curious design of non-deleted copy ctor and deleted copy assignment op. Many derived classes then provide a non-deleted assignment op, apparently more or less on an as-needed basis. But some of those user-provided assignment ops are actually unused (and their presence causes -Werror=deprecated-copy with GCC trunk towards GCC 9 when the---implicitly- defined---copy ctor of the derived class is used), so remove them. In some cases that would still cause -Werror=deprected-copy because of a user-declared dtor, so in those cases explicitly default all the copy/move functions (some of which will then be implicitly defined as deleted). Change-Id: If0d9f1a9f3954263a39ffd27ba895d6202afa307 Reviewed-on: https://gerrit.libreoffice.org/58133 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc.; and by removing explicitly user- provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non- deleted in the future. (Even if such a user-provided function was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already include, so why bother with non-inline functions.) Change-Id: I1c470ef87e95b22e406099a4e6816693edab2e03 Reviewed-on: https://gerrit.libreoffice.org/58131 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. There appears to be no good reason for these classes to have a deleted copy assignment op, so just change that to implicitly-defined, too. Change-Id: I65fb6ea78a13b7b3d237529613c0489c8cf50614 Reviewed-on: https://gerrit.libreoffice.org/58119 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
and fix scanForFiles to return false on error Change-Id: I246e906de9985947be421d361340874c94a2102d Reviewed-on: https://gerrit.libreoffice.org/58085 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. (For LIBO_INTERNAL_ONLY, in cppumaker- genered code.) Change-Id: Ia13d945c10600f5793a3247f85a464170ede483d Reviewed-on: https://gerrit.libreoffice.org/58116 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ib32fb5ddc04df1c090f9d7b319e4ff9be0c285f9 Reviewed-on: https://gerrit.libreoffice.org/58007 Tested-by: Jenkins Reviewed-by:
-
