Remove unused local variable aImageProvider

It is no longer needed for the cases where
oly the static methods are called

Change-Id: I869b824c53ef1a8db07f4ca7f0aa9e678e16a7ac
Reviewed-on: https://gerrit.libreoffice.org/58162
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

dbaccess/source/ui/app/AppDetailPageHelper.cxx

@@ -582,8 +582,6 @@ void OAppDetailPageHelper::createTablesPage(const Reference< XConnection>& _xCon
 
 OUString OAppDetailPageHelper::getElementIcons(ElementType _eType)
 {
-    ImageProvider aImageProvider;
-
     sal_Int32 nDatabaseObjectType( 0 );
     switch(_eType )
     {
@@ -603,7 +601,6 @@ void OAppDetailPageHelper::createPage(ElementType _eType,const Reference< XNameA
     OSL_ENSURE(E_TABLE != _eType,"E_TABLE isn't allowed.");
 
     OString sHelpId;
-    ImageProvider aImageProvider;
     Image aFolderImage;
     switch( _eType )
     {

dbaccess/source/ui/browser/unodatbr.cxx

@@ -2004,7 +2004,6 @@ void SbaTableQueryBrowser::implAddDatasource(const OUString& _rDbName, Image& _r
     if (_rTableName.isEmpty())
         _rTableName = DBA_RES(RID_STR_TABLES_CONTAINER);
 
-    ImageProvider aImageProvider;
     if (!_rQueryImage)
         _rQueryImage = ImageProvider::getFolderImage( DatabaseObject::QUERY );
     if (!_rTableImage)

dbaccess/source/ui/control/tabletree.cxx

@@ -79,7 +79,6 @@ VCL_BUILDER_FACTORY_CONSTRUCTOR(OTableTreeListBox, 0)
 
 void OTableTreeListBox::implSetDefaultImages()
 {
-    ImageProvider aImageProvider;
     SetDefaultExpandedEntryBmp(  ImageProvider::getFolderImage( DatabaseObject::TABLE ) );
     SetDefaultCollapsedEntryBmp( ImageProvider::getFolderImage( DatabaseObject::TABLE ) );
 }