Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8
Reviewed-on: https://gerrit.libreoffice.org/31898Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4

Change-Id: Ib0106c3b88cf54e54aaf784bb526480a1c745a1f

This reverts commit cc020974.

Need to improve the solution here a little I think.

Change-Id: I02a3a46d2222b8bfe955eb17ca655d36d9155b48
Reviewed-on: https://gerrit.libreoffice.org/31867Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I9759a0f21641b6f5ba5e456e5c45ac28238ca672
Reviewed-on: https://gerrit.libreoffice.org/31866Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I76e9d317dabeefcdf53468a89f3a6130279993f3
Reviewed-on: https://gerrit.libreoffice.org/31865Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Ie7127668aceade312c68ed3d7f3398fbaf5e8df7
Reviewed-on: https://gerrit.libreoffice.org/31864Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: I49c448c454f9bb820c3b9afa3825c58cb2dab978
Reviewed-on: https://gerrit.libreoffice.org/31863Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Iad8b5ff731c9d53f0f015a95387a00993a4a31f8
Reviewed-on: https://gerrit.libreoffice.org/31862Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4

Change-Id: I5b7c6992e92e4d096b8230774ed8f4bfaaad5831

Failing to do that leads to write-past-end-of-document, drawing
loss and SAXParseException if the drawing is part of a footnote.

A unit test is included.

Change-Id: Ie7d8263dc72dfef1e9827cc0579a5eaaf5819410
Reviewed-on: https://gerrit.libreoffice.org/31871Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

to bring up File Open... dialog

we need to hold the SolarMutex when doing VclPtr ref-counting

Change-Id: I843f2a243acaf73db1f6557df23475fe5bb12131
Reviewed-on: https://gerrit.libreoffice.org/31892Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifceb60ee9f1f5e0ba5fd68d88a0358b5400008ee

Change-Id: Ibb24dea2464c2e0bba289f08bba053efe6fe57fc

Change-Id: Ia8c601475bea142faad9c1f1e9b797d0ebc13679

and

coverity#1397044 Unchecked return value

Change-Id: I193bd676e417c35450efa91cb5773c78c998b63f

Change-Id: I7f8988a7cf5f3d815a20cac249b3753d732994e1

Change-Id: Ie33ef6565cadcddb59c1d78a63aec666e8693f87

Change-Id: I37c49aa568646e44c05f5feec537d344a2440b91

This appears to be a consequence of my change

    commit 942716fe
    convert EID constants to typed_flags

in that change I made a "fix":
    @@ -689,20 +687,20 @@ void
EventMultiplexer::Implementation::CallListeners (EventMultiplexerEvent&
rEv
         ListenerList::const_iterator iListenerEnd
(aCopyListeners.end());
         for (; iListener!=iListenerEnd; ++iListener)
         {
    -        if ((iListener->second && rEvent.meEventId))
    +        if (iListener->second & rEvent.meEventId)
             iListener->first.Call(rEvent);
         }
     }

which causes this bug.

I should have noticed that my "fix" indicates that the event filtering
part of this multiplexing code was never working, and since no-one has
ever complained about, lets just remove all of this unnecessary
complexity.

Change-Id: Id71613d4fd5817ee1358705059e4ce63d57573ad
Reviewed-on: https://gerrit.libreoffice.org/31894Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and

coverity#1397055 Inferred misuse of enum

copy and paste error from the other converted call site I bet

Change-Id: I63701db153c5fd424374a95dd757d9fd7a8bc216

regression from...

commit b894104a
Date:   Thu Dec 8 00:43:09 2016 +0200

    Pass GlyphItem around

    We have this nice structure that contains (almost) all the information
    we need, so pass it around instead of passing separate fragments of said
    information.

presumably this is the correct fix given the context of the other changes

Change-Id: I8518e739b1caa00ea5ae1569282e98810462d4c3

...containing replacements for global operator new/delete (that can be linked
into executables), but which is no longer used.  The mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2012-March/028690.html>
"operator new no longer routes through rtl_AllocMemory in libsalcpprt under
gbuild link rules" has the details of how this was used on some platforms (but
not on others) before the switch to gbuild, and has been "lost" ever since---but
apparently a loss not mourned much over the years.

For the SDK, c5f97428 "INTEGRATION: CWS jsc3:
#i62434# copy libsalcpprt.a" added the library (under Linux) and
6db9c5af "INTEGRATION: CWS jsc3: #i62434# extend
link options for executbales to link libsalcpprt.a, LINUX only" added its use to
odk/settings/settings.mk, but fc0ca57f
"INTEGRATION: CWS jsc21" removed that use again (for no documented reason).  So
this is an incompatible change, but unlikely to actually affect any users of the
SDK.

Change-Id: Ia38b4c439f21fca3f5d9af7d1a34054e992054e9
Reviewed-on: https://gerrit.libreoffice.org/31810Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51
Reviewed-on: https://gerrit.libreoffice.org/31875Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ieda3afdbdbcc8aa21f6584edc21738c4edb84000

and

coverity#1397040 Unchecked return value
coverity#1397047 Unchecked return value
coverity#1397049 Unchecked return value
coverity#1397050 Unchecked return value
coverity#1397051 Unchecked return value

Change-Id: Idf7dd7818b74c661a1f7a757f0bdc16e2d1d5c72

Looks like it was introduced by

    commit 19b34c00
    loplugin:passstuffbyref in svtools

and since it's windows only, probably some subtle mis-compilation.

Aron Budea tracked this one down.

Change-Id: I77e65ea8a1fb0003d6ff0f3b0f8019f275ff3462
Reviewed-on: https://gerrit.libreoffice.org/31893Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5bd58f94fbea3d59849f60f2096e5191dbb0d810

Move one header file to inc/

Change-Id: If8f4bfcf29464011fe68573e7d4e67900aacc2cd
Reviewed-on: https://gerrit.libreoffice.org/31891Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

This solves the problem of rows with too big minimal height causing
layout failure (the table just goes out of page, does not flow to
next page).

It does so with three steps:
1. Currently, a row with a minimum height that flows to next page
repeats whole min height on that (and possibly following) pages.
If this behaviour continued, then that would cause layout loop:
the row min height would be too high for the page, so it would
keep flowing to next pages (actually just go beyond the botom
because of layout failure). To mitigate this, the patch changes
the behaviour to measure total height of all frames of the row:
the function lcl_calcHeightOfRowBeforeThisFrame calculates the
total height of previous row frames for the same row, then in
places where we need to get min height, this value is subtracted
from row min total height. On following pages the min height of
frames will get less each time.

2. When the row is split, the possibility to split depends on if
the minimum height of the row fits into the vertical space left.
The minimum height is found as maxinum of two values: minimal
contents of the row (e.g., height of first line of text, or an
object, or lower table cell), and the minimum height setting.
As the minimum height setting should not prevent the cell to
flow, (it only should ensure that total height is no less), we
should not consider the setting when the split is performed
(we should be able to keep on first page as little as required).
To allow this, a new bool member introduced in SwRowFrame:
m_bIsInSplit, with its setter and getter. When it is true,
the routines that calculate min height ignore the min height
setting. It is set in lcl_RecalcSplitLine around lcl_RecalcRow
and SwRowFrame::Calc that decide if it's possible to keep part of
row's content on first page, and update table's height to fit
the rest of space.

3. It turns out, that if contents of the splitted cell has less
height than the min height setting, then following happens.
In SwTabFrame::Split, all rows below splitted one are moved to
follow flow table; then table frame's Shrink method used to shrink
the freed height. At this moment, still, the height of splitted
row is too high, and total height of table is too high. Then,
lcl_RecalcSplitLine is called, where row is first shrunk, and then
lcl_RecalcRow and SwRowFrame::Calc try to move contents and resize
the splitted row. They get the minimum height of content (we already
don't consider the min height setting), but then "last row will fill
the space in its upper" (see SwRowFrame::Format). Row returns its
previous size, table does not resize, it doesn't fit to page, and
split fails.
To try to fix that, I call SwTabFrame::Shrink in lcl_RecalcSplitLine
after lcl_ShrinkCellsAndAllContent before lcl_RecalcRow.

Unit test included.

Change-Id: I8422e43cff7d6b5955541ed3fe930779429ed55b
Reviewed-on: https://gerrit.libreoffice.org/31774Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

..in eaa7f301

Change-Id: I149ee4087dffe54fd63bacd3bb5aba67159fac72

Change-Id: Ib85895c21cef9baeccc468b476cbd8170ee4c9ce

Change-Id: I7c905255627fb5286378e077d52932e9b184f054
Reviewed-on: https://gerrit.libreoffice.org/31853Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: Ic8ed367a5774eb3a939163fb1c1fe9518c3d7d2d
Reviewed-on: https://gerrit.libreoffice.org/31855Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: Ic4463db8aeca6ae9a86f7b890f95eb73724c6a1b

Change-Id: Ie4b7d45d26fbd839f9afcd11a7ba4bff80ed54e8
Reviewed-on: https://gerrit.libreoffice.org/31854Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

This patch caused a regression that on creation of a new sheet
while there's an unfinished edit of a cell, by using "+" in bottom
left corner, that edit is committed to newly created sheet instead
of that in which it was performed.

Also, fixing original problem (tdf#42432), it forced the pending
edit on deleted page to go to an existing page, which could
overwrite existing data without being noticed (dataloss).

Reverting the patch does not reintroduce the original problem that
it intended to fix (a crash) in master.

Change-Id: I696a85ec9d08ebb3621ebdbce4d9f71eadcdb2c2
Reviewed-on: https://gerrit.libreoffice.org/31843Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Project: help  89416253fdd67a9334660238f2c23f0fdfb3a10e

fix emph tag

Change-Id: I5335a8dfce80fef6a59b102bac11a0017b4fff54