Kaydet (Commit) 5e380e89 authored tarafından Suleyman Poyraz's avatar Suleyman Poyraz

Ota B*ka Fıxme atmayın Allahınızı severseniz LUTFEN

FIXME staırlarını biraz temiz tutalım ki nerde hata var görelim değil mi
üst f2ddc350
......@@ -58,7 +58,7 @@ def get_firmware_package(firmware):
for fw in firmwares:
ctx.ui.info(" * {}".format(fw), noln = True)
try:
if fw.startswith("/"): # FIXME: why? why?
if fw.startswith("/"):
fw = fw[1:]
firmware = ctx.filesdb.search_file(fw)[0][0]
except:
......
......@@ -180,7 +180,7 @@ class LDD:
# search for the package name (i.e: inary sf /usr/lib/*.so )
# the library may not exist, thus adding an exception is welcome
try:
if obj_dump.startswith("/"): # FIXME: why? why?
if obj_dump.startswith("/"):
obj_dump = obj_dumpobj_dump[1:]
dependency_name = ctx.filesdb.search_file(obj_dump)[0][0]
except IndexError:
......
......@@ -403,7 +403,7 @@ def search_file(term):
>>> [("kvm", (["lib/modules/2.6.18.8-86/extra/kvm-amd.ko","lib/modules/2.6.18.8-86/extra/kvm-intel.ko"])),]
"""
if term.startswith("/"): # FIXME: why? why?
if term.startswith("/"):
term = term[1:]
return ctx.filesdb.search_file(term)
......
......@@ -188,7 +188,6 @@ class Command(object):
def die(self):
"""exit program"""
#FIXME: not called from anywhere?
ctx.ui.error(_('Command terminated abnormally.'))
sys.exit(-1)
......
......@@ -99,7 +99,7 @@ class MetaData(xmlfile.XmlFile, metaclass=autoxml.autoxml):
self.source.name = src.name
self.source.homepage = src.homepage
self.source.packager = src.packager
self.package.source = self.source # FIXME: I know that replication sucks here, but this is the easiest for now-- exa
self.package.source = self.source # FIXME: I know that replication sucks here, but this is the easiest for now
self.package.name = pkg.name
self.package.summary = pkg.summary
self.package.description = pkg.description
......
......@@ -35,7 +35,7 @@ def install_pkg_names(A, reinstall = False, extra = False):
installdb = inary.db.installdb.InstallDB()
packagedb = inary.db.packagedb.PackageDB()
A = [str(x) for x in A] #FIXME: why do we still get unicode input here? :/ -- exa
A = [str(x) for x in A] #FIXME: why do we still get unicode input here? :/
# A was a list, remove duplicates
A_0 = A = set(A)
......@@ -300,4 +300,3 @@ def plan_install_pkg_names(A):
order = G_f.topological_sort()
order.reverse()
return G_f, order
......@@ -335,7 +335,7 @@ def dir_size(_dir):
# installed size. Gettin a sum of all files' sizes if far from
# being true. Using 'du' command (like Debian does) can be a
# better solution :(.
# Not really, du calculates size on disk, this is much better -- exa
# Not really, du calculates size on disk, this is much better
if os.path.exists(_dir) and (not os.path.isdir(_dir) and not os.path.islink(_dir)):
#so, this is not a directory but file..
......@@ -610,7 +610,7 @@ def strip_file(filepath, fileinfo, outpath):
if ret:
ctx.ui.warning(_("objcopy (add-debuglink) command failed for file '{}'!").format(f))
if fileinfo == None:
if fileinfo == None:
ret, out, err = run_batch("file {}".format(filepath), ui_debug=False)
if ret:
ctx.ui.warning(_("file command failed with return code {0} for file: {1}").format(ret, filepath))
......
......@@ -32,8 +32,6 @@ def setup():
def build():
autotools.make()
# FIXME: package build stops right after checking even when no errors happen (probably
# due to SIGHUP in test). It is the duty of the packager to run tests by hand.
#def check():
# autotools.make("check")
......
......@@ -54,7 +54,6 @@ class AutoXmlTestCase(unittest.TestCase):
# test read
a.read('tests/lat.xml')
# print a FIXME: python 2.x bug likely
self.assert_(a.href.startswith('http://www.su'))
self.assertEqual(a.number, 911)
self.assertEqual(a.name, u'Inary Testers')
......@@ -67,7 +66,7 @@ class AutoXmlTestCase(unittest.TestCase):
self.assert_( util.any(lambda x:x.find('02012018')!=-1, la) )
a.write('/tmp/a.xml')
return
def testWriteRead(self):
a = self.Rat()
a.name = "Inary Testers"
......@@ -80,7 +79,7 @@ class AutoXmlTestCase(unittest.TestCase):
a.dreams = [ 'will', 'be', 'hero' ]
errs = a.errors()
if errs:
self.fail( 'We got a bunch of errors: ' + str(errs))
self.fail( 'We got a bunch of errors: ' + str(errs))
a.write('/tmp/rat1.xml')
a2 = self.Rat()
a2.read('/tmp/rat2.xml')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment