• Noel Grandin's avatar
    remove dead SwNoteURL · ed2ae3c3
    Noel Grandin yazdı
    According to:
    
    <mst_> noelgrandin: apparently this code exists so you can export a text
    
         frame as an image and then the urls in the text become
        image-map links
    
    which means that according to my analysis below, nobody has noticed the
    removal in 17 years :-)
    
    SwNoteURL::InsertURLNote was the last place that constructed an
    SwNoteURL and it was removed in
        commit bb7ade14
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Mar 7 13:42:58 2018 +0200
        loplugin:unusedmethods
    
    and SwNoteURL::InsertURLNote was dead because
       void SwTextPaintInfo::NotifyURL_( const SwLinePortion &rPor ) const
    was removed in
        commit 73139fe6
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Fri Jan 19 13:10:22 2018 +0200
        loplugin:unusedmethods
    
    and SwTextPaintInfo::NotifyURL_ was dead because
       void SwTextPaintInfo::NotifyURL( const SwLinePortion &rPor ) const
    was removed in
        commit be8c4145
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Fri Jan 19 09:13:03 2018 +0200
        loplugin:unusedmethods also check for functions returning bool
    
    and NotifyURL was dead because calls to it were removed in
        commit 1b666235
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Jan 3 09:08:52 2018 +0200
        loplugin:singlevalfields improve copy constructor check
    those calls were removed because the m_bURL field of SwFont was always
    false.
    
    tracing back, we find that m_bURL was called bURL before
        commit b4e2a13f
        Author: Miklos Vajna <vmiklos@collabora.co.uk>
        Date:   Mon Oct 26 08:55:17 2015 +0100
        sw: prefix members of SwFont
    
    and we find that a method
         void SwFont::SetURL(const bool)
    that modified bURL was removed in
        commit 407731c9
        Author: Noel Grandin <noel@peralex.com>
        Date:   Tue Jul 21 10:44:17 2015 +0200
        loplugin:unusedmethods sw
    
    and we find that calls to SetURL were removed in
        commit da7671e4
        Author: Andreas Martens <ama@openoffice.org>
        Date:   Thu Mar 15 14:59:12 2001 +0000
        Opt.(FME): The new attribute handler makes a lot of code superfluous
    
    which appears to be the root of the problem
    
    Change-Id: Id2362ce216c06bc8dcf71698695d708eb494af4e
    Reviewed-on: https://gerrit.libreoffice.org/51225Reviewed-by: 's avatarMichael Stahl <mstahl@redhat.com>
    Tested-by: 's avatarJenkins <ci@libreoffice.org>
    ed2ae3c3
Adı
Son kayıt (commit)
Son güncelleme
.git-hooks Loading commit data...
UnoControls Loading commit data...
accessibility Loading commit data...
android Loading commit data...
animations Loading commit data...
apple_remote Loading commit data...
avmedia Loading commit data...
basctl Loading commit data...
basegfx Loading commit data...
basic Loading commit data...
bean Loading commit data...
bin Loading commit data...
binaryurp Loading commit data...
bridges Loading commit data...
canvas Loading commit data...
chart2 Loading commit data...
cli_ure Loading commit data...
codemaker Loading commit data...
comphelper Loading commit data...
compilerplugins Loading commit data...
config_host Loading commit data...
configmgr Loading commit data...
connectivity Loading commit data...
cppcanvas Loading commit data...
cppu Loading commit data...
cppuhelper Loading commit data...
cpputools Loading commit data...
cui Loading commit data...
dbaccess Loading commit data...
desktop Loading commit data...
dictionaries @ d8d24118
distro-configs Loading commit data...
drawinglayer Loading commit data...
dtrans Loading commit data...
editeng Loading commit data...
embeddedobj Loading commit data...
embedserv Loading commit data...
emfio Loading commit data...
eventattacher Loading commit data...
extensions Loading commit data...
external Loading commit data...
extras Loading commit data...
filter Loading commit data...
forms Loading commit data...
formula Loading commit data...
fpicker Loading commit data...
framework Loading commit data...
helpcompiler Loading commit data...
helpcontent2 @ 05d4e9fb
hwpfilter Loading commit data...
i18nlangtag Loading commit data...
i18npool Loading commit data...
i18nutil Loading commit data...
icon-themes Loading commit data...
idl Loading commit data...
idlc Loading commit data...
include Loading commit data...
instsetoo_native Loading commit data...
io Loading commit data...
ios Loading commit data...
javaunohelper Loading commit data...
jurt Loading commit data...
jvmaccess Loading commit data...
jvmfwk Loading commit data...
l10ntools Loading commit data...
librelogo Loading commit data...
libreofficekit Loading commit data...
lingucomponent Loading commit data...
linguistic Loading commit data...
lotuswordpro Loading commit data...
m4 Loading commit data...
mysqlc Loading commit data...
nlpsolver Loading commit data...
o3tl Loading commit data...
odk Loading commit data...
offapi Loading commit data...
officecfg Loading commit data...
onlineupdate Loading commit data...
oovbaapi Loading commit data...
oox Loading commit data...
opencl Loading commit data...
osx Loading commit data...
package Loading commit data...
postprocess Loading commit data...
pyuno Loading commit data...
qadevOOo Loading commit data...
readlicense_oo Loading commit data...
registry Loading commit data...
remotebridges Loading commit data...
reportbuilder Loading commit data...
reportdesign Loading commit data...
ridljar Loading commit data...
sal Loading commit data...
salhelper Loading commit data...
sax Loading commit data...
sc Loading commit data...
scaddins Loading commit data...
sccomp Loading commit data...
schema Loading commit data...
scp2 Loading commit data...
scripting Loading commit data...
sd Loading commit data...
sdext Loading commit data...
setup_native Loading commit data...
sfx2 Loading commit data...
shell Loading commit data...
slideshow Loading commit data...
smoketest Loading commit data...
solenv Loading commit data...
soltools Loading commit data...
sot Loading commit data...
starmath Loading commit data...
stoc Loading commit data...
store Loading commit data...
svgio Loading commit data...
svl Loading commit data...
svtools Loading commit data...
svx Loading commit data...
sw Loading commit data...
swext Loading commit data...
sysui Loading commit data...
test Loading commit data...
testtools Loading commit data...
toolkit Loading commit data...
tools Loading commit data...
translations @ db79c922
ucb Loading commit data...
ucbhelper Loading commit data...
udkapi Loading commit data...
uitest Loading commit data...
unodevtools Loading commit data...
unoidl Loading commit data...
unoil Loading commit data...
unotest Loading commit data...
unotools Loading commit data...
unoxml Loading commit data...
ure Loading commit data...
uui Loading commit data...
vbahelper Loading commit data...
vcl Loading commit data...
winaccessibility Loading commit data...
wizards Loading commit data...
writerfilter Loading commit data...
writerperfect Loading commit data...
xmerge Loading commit data...
xmlhelp Loading commit data...
xmloff Loading commit data...
xmlreader Loading commit data...
xmlscript Loading commit data...
xmlsecurity Loading commit data...
.buckconfig Loading commit data...
.buckversion Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.gitreview Loading commit data...
BUCK Loading commit data...
COPYING Loading commit data...
COPYING.LGPL Loading commit data...
COPYING.MPL Loading commit data...
Library_merged.mk Loading commit data...
Makefile.fetch Loading commit data...
Makefile.gbuild Loading commit data...
Makefile.in Loading commit data...
README.Solaris Loading commit data...
README.cross Loading commit data...
README.md Loading commit data...
Repository.mk Loading commit data...
RepositoryExternal.mk Loading commit data...
RepositoryFixes.mk Loading commit data...
RepositoryModule_build.mk Loading commit data...
RepositoryModule_host.mk Loading commit data...
TEMPLATE.SOURCECODE.HEADER Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
config_host.mk.in Loading commit data...
config_host_lang.mk.in Loading commit data...
configure.ac Loading commit data...
download.lst Loading commit data...
g Loading commit data...
install-sh Loading commit data...
leak-suppress.txt Loading commit data...
lo.xcent.in Loading commit data...
logerrit Loading commit data...
sanitize-ubsan-blacklist Loading commit data...