• Stephan Bergmann's avatar
    Better fix for ThreadPool/ORequestThread life cycle · 2fa2660b
    Stephan Bergmann yazdı
    This is a follow up to d015384e "Fixed
    ThreadPool (and dependent ORequestThread) life cycle" that still had some
    problems:
    
    * First, if Bridge::terminate was first entered from the reader or writer
    thread, it would not join on that thread, so that thread could still be running
    during exit.
    
    That has been addressed by giving Bridge::dispose new semantics:  It waits until
    both Bridge::terminate has completed (even if that was called from a different
    thread) and all spawned threads (reader, writer, ORequestThread workers) have
    been joined.  (This implies that Bridge::dispose must not be called from such a
    thread, to avoid deadlock.)
    
    * Second, if Bridge::terminate was first entered from an ORequestThread, the
    call to uno_threadpool_dispose(0) to join on all such worker threads could
    deadlock.
    
    That has been addressed by making the last call to uno_threadpool_destroy wait
    to join on all worker threads, and by calling uno_threadpool_destroy only from
    the final Bridge::terminate (from Bridge::dispose), to avoid deadlock.  (The
    special semantics of uno_threadpool_dispose(0) are no longer needed and have
    been removed, as they conflicted with the fix for the third problem below.)
    
    * Third, once uno_threadpool_destroy had called uno_threadpool_dispose(0), the
    ThreadAdmin singleton had been disposed, so no new remote bridges could
    successfully be created afterwards.
    
    That has been addressed by making ThreadAdmin a member of ThreadPool, and making
    (only) those uno_ThreadPool handles with overlapping life spans share one
    ThreadPool instance (which thus is no longer a singleton, either).
    Additionally, ORequestThread has been made more robust (in the style of
    salhelper::Thread) to avoid races.
    
    Change-Id: I2cbd1b3f9aecc1bf4649e482d2c22b33b471788f
    2fa2660b
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
prj Loading commit data...
qa Loading commit data...
source Loading commit data...
util Loading commit data...
CppunitTest_cppu_qa_any.mk Loading commit data...
CppunitTest_cppu_qa_recursion.mk Loading commit data...
CppunitTest_cppu_qa_reference.mk Loading commit data...
CppunitTest_cppu_qa_unotype.mk Loading commit data...
CppunitTest_cppu_test_cppumaker.mk Loading commit data...
InternalUnoApi_cppu.mk Loading commit data...
Library_affine_uno.mk Loading commit data...
Library_cppu.mk Loading commit data...
Library_log_uno.mk Loading commit data...
Library_purpenvhelper.mk Loading commit data...
Library_unsafe_uno.mk Loading commit data...
Makefile Loading commit data...
Module_cppu.mk Loading commit data...
Package_inc.mk Loading commit data...
README Loading commit data...