• Noel Grandin's avatar
    tdf#120837 File saving at least 5 times slower · 319c57d2
    Noel Grandin yazdı
    The problem here is that we never actually hit the maExportGraphics
    cache in SvXMLGraphicHelper, even though we are passing the same image
    down repeatedly.
    
    There are two bugs here:
    
    (1) BitmapEx::operator== does not return true if we instantiate 2
    Graphic objects from the same XGraphic, so change it to use the more
    expensive operator==. To mitigate the cost, move the expensive checks to
    the bottom of the method.
    
    (2) in order to use an object in std::unordered_map, the object must
    implement an equality function and a hash function. If two objects are
    equal THEY MUST have the same hash value. Using the Impl* as the hash
    value does not satisfy that condition, so rather use the checksum, which
    does.
    
    After these fixes, the save time drops to less than a second.
    
    Also make the checksum method look more like the operator== method,
    and add a checksum calculation method for SVG data that more accurately
    reflects the underlying SVG data.
    
    Change-Id: I4ca0c7bee60b2efa6fe42301e582c7b278022b46
    Reviewed-on: https://gerrit.libreoffice.org/72615
    Tested-by: Jenkins
    Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
    319c57d2
Adı
Son kayıt (commit)
Son güncelleme
..
LibreOfficeKit Loading commit data...
android Loading commit data...
animations Loading commit data...
apple_remote Loading commit data...
avmedia Loading commit data...
basegfx Loading commit data...
basic Loading commit data...
canvas Loading commit data...
codemaker Loading commit data...
com/sun/star/uno Loading commit data...
comphelper Loading commit data...
connectivity Loading commit data...
cppcanvas Loading commit data...
cppu Loading commit data...
cppuhelper Loading commit data...
cppunittester Loading commit data...
dbaccess Loading commit data...
desktop Loading commit data...
drawinglayer Loading commit data...
editeng Loading commit data...
filter Loading commit data...
formula Loading commit data...
fpicker Loading commit data...
framework Loading commit data...
helpcompiler Loading commit data...
i18nlangtag Loading commit data...
i18nutil Loading commit data...
ios Loading commit data...
jvmaccess Loading commit data...
jvmfwk Loading commit data...
linguistic Loading commit data...
o3tl Loading commit data...
onlineupdate Loading commit data...
oox Loading commit data...
opencl Loading commit data...
osl Loading commit data...
package Loading commit data...
registry Loading commit data...
rtl Loading commit data...
sal Loading commit data...
salhelper Loading commit data...
sax Loading commit data...
sfx2 Loading commit data...
sot Loading commit data...
store Loading commit data...
svl Loading commit data...
svtools Loading commit data...
svx Loading commit data...
systools/win32 Loading commit data...
test Loading commit data...
toolkit Loading commit data...
tools Loading commit data...
typelib Loading commit data...
ucbhelper Loading commit data...
uno Loading commit data...
unoidl Loading commit data...
unotest Loading commit data...
unotools Loading commit data...
vbahelper Loading commit data...
vcl Loading commit data...
xmloff Loading commit data...
xmlreader Loading commit data...
xmlscript Loading commit data...
IwyuFilter_include.yaml Loading commit data...
default.rc Loading commit data...
postmac.h Loading commit data...
postwin.h Loading commit data...
premac.h Loading commit data...
prewin.h Loading commit data...
version.hrc Loading commit data...