• Stephan Bergmann's avatar
    Revert a fix that can never have worked in the first place? · 4b4a7c0d
    Stephan Bergmann yazdı
    clang-analyzer-deadcode.DeadStores finds that conditionally assigning
    
      eTok = SYMBOL
    
    inside the "if( SbiTokenizer::IsKws( eTok ) )" block is useless, as the directly
    following
    
      if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )
    
    will unconditionally assign into eTok again, without intermediate use of the old
    eTok value.
    
    Now, the conditional "eTok = SYMBOL" assignment was added as
    5d98ed5c "INTEGRATION: CWS ab12fixes: #118234#
    SbiExpression::Term(): Allow Input as symbol for action option compatible,"
    while the unconditional "eTok = eNextTok" assignment had followed that block
    ever since c25ec060 "initial import."
    
    The referenced "#118234#" was a Sun-internal bug and is no longer available, but
    it does very much look as if this alleged bugfix never worked in the first
    place.  So revert the code back to what it looked before
    5d98ed5c, for now.
    
    Change-Id: I1fe1178d2c5b0c0372da32b8dd0f2dfbdb22a1ae
    4b4a7c0d
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa Loading commit data...
source Loading commit data...
util Loading commit data...
AllLangResTarget_sb.mk Loading commit data...
CppunitTest_basic_coverage.mk Loading commit data...
CppunitTest_basic_enable.mk Loading commit data...
CppunitTest_basic_nested_struct.mk Loading commit data...
CppunitTest_basic_scanner.mk Loading commit data...
CppunitTest_basic_vba.mk Loading commit data...
Library_sb.mk Loading commit data...
Makefile Loading commit data...
Module_basic.mk Loading commit data...
README Loading commit data...