• Matúš Kukan's avatar
    fdo#80927: css.office.Quickstart should be single-instance service. · 98bb53a5
    Matúš Kukan yazdı
    Incorrectly converted in a384b21c
    where SFX_IMPL_ONEINSTANCEFACTORY was used.
    
    AFAICS it's the first converted single-instance service which implements
    css::lang::XInitialization. That's kind of strange but can do its job.
    
    sbergman@redhat.com:  Three things were necessary in order to not call the
    ~ShutdownIcon code too late during exit now:
    
    * Move the relevant code from ~ShutdownIcon to ShutdownIcon::disposing.
    
    * Add a dummy <singleton name="com.sun.star.office.theQuickstart"/> so the
      service manager will eventually dispose the (single) instance.
    
    * In
      cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments
      do not shortcut updateDisposeSingleton in that odd case of calling
      createInstanceWithArguments on an implementation that (effectively) is a
      singleton (as otherwise the service manager would still not dispose it).  It
      looks to me like that "return inst;" was an inadvertent leftover in
      874c4818 "Simplify service manager's tracking
      of singletons" and wasn't intended to serve some subtle purpose.
    
    Change-Id: Icd4d3168ec0bbb820b17ac321fe897ac9f9ce7fc
    98bb53a5
Adı
Son kayıt (commit)
Son güncelleme
..
inc/pch Loading commit data...
qa Loading commit data...
source Loading commit data...
test Loading commit data...
unotypes/cppuhelper/detail Loading commit data...
CppunitTest_cppuhelper_cppu_ifcontainer.mk Loading commit data...
CppunitTest_cppuhelper_cppu_unourl.mk Loading commit data...
CppunitTest_cppuhelper_qa_weak.mk Loading commit data...
InternalUnoApi_cppuhelper.mk Loading commit data...
Library_cppuhelper.mk Loading commit data...
Makefile Loading commit data...
Module_cppuhelper.mk Loading commit data...
README Loading commit data...
StaticLibrary_findsofficepath.mk Loading commit data...