• Caolán McNamara's avatar
    tdf#123470 textforwarder has stale view of SdrTextObj · f3312443
    Caolán McNamara yazdı
    When we save the document we get a SwXShape for the SdrObject and call
    getShapeText on it, which creates a TextForwarder for it. The SwXShape
    is temporary and is discarded afterwards. If we modify the text and
    save again we get a new SwXShape and a new TextForwarder.
    
    If a11y is active, then when the textbox is inserted a11y gets a SwXShape
    for the object and the SwXShape stays alive while the a11y view of the
    Sdrobject stays around.
    
    The SdrObject will keep a weak ref to the current SwXShape for it, so
    on save we get the already existing SwXShape instead of a new one. On the
    first save this is ok, as the TextForwarder is created on demand.
    
    On the second save, the problem is that the SvxTextEditSourceImpl of the
    TextForwarded was initially created without a SdrView so its in sort of a
    "snapshot" mode, so first time the text is queried, that sticks as the result.
    
    So a cached text forwarder cannot be trusted when its for a SdrTextObj
    that's being edited and HasView is false
    
    Change-Id: Ib3d500752f1876086ef1996885a2b86b581f5bc4
    Reviewed-on: https://gerrit.libreoffice.org/68457Reviewed-by: 's avatarMichael Stahl <Michael.Stahl@cib.de>
    Tested-by: Jenkins
    Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
    Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
    f3312443
Adı
Son kayıt (commit)
Son güncelleme
..
doc Loading commit data...
inc Loading commit data...
qa Loading commit data...
sdi Loading commit data...
source Loading commit data...
uiconfig/ui Loading commit data...
util Loading commit data...
AllLangMoTarget_svx.mk Loading commit data...
CppunitTest_svx_dialogs_test.mk Loading commit data...
CppunitTest_svx_unit.mk Loading commit data...
Executable_gengal.mk Loading commit data...
JunitTest_svx_unoapi.mk Loading commit data...
Library_svx.mk Loading commit data...
Library_svxcore.mk Loading commit data...
Library_textconversiondlgs.mk Loading commit data...
Makefile Loading commit data...
Module_svx.mk Loading commit data...
Package_gengal.mk Loading commit data...
README Loading commit data...
UIConfig_svx.mk Loading commit data...