• Ashod Nakashian's avatar
    LOK: Fix API for renderShapeSelection · ad5fb879
    Ashod Nakashian yazdı
    Unlike C++, C doesn't allow reference-to-pointer types,
    and we do have C code that wouldn't compile with ref-to-ptr.
    Had to change to ptr-to-ptr, which is the proper way of
    having output arrays.
    
    For the same reason, we cannot use new/delete, rather we
    must use malloc/free.
    
    Another (lesser) issue was that we used the renderShapeSelection
    API to echo back an array we give it as prefix. This made
    the API unecessarily complex (in undocumented ways) and
    forced the implementation to both worry about user-data
    and managing the input memory. This logic is best moved
    to the client and the API simply returns the output data.
    
    Speaking of returning data, the API now returns the size
    of the array it allocated and wrote to, so the client
    can do a simple check on the return value directly.
    
    Change-Id: Ida216c10d5b37efd1e0861e26b72cabb25c568e6
    ad5fb879
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa Loading commit data...
scripts Loading commit data...
source Loading commit data...
test/deployment Loading commit data...
uiconfig/ui Loading commit data...
unx/source Loading commit data...
util Loading commit data...
win32/source Loading commit data...
AllLangMoTarget_dkt.mk Loading commit data...
CppunitTest_desktop_app.mk Loading commit data...
CppunitTest_desktop_dialogs_test.mk Loading commit data...
CppunitTest_desktop_lib.mk Loading commit data...
CppunitTest_desktop_lokinit.mk Loading commit data...
CppunitTest_desktop_version.mk Loading commit data...
CustomTarget_desktop_unopackages_install.mk Loading commit data...
CustomTarget_soffice.mk Loading commit data...
Executable_minidump_upload.mk Loading commit data...
Executable_oosplash.mk Loading commit data...
Executable_quickstart.mk Loading commit data...
Executable_sbase.mk Loading commit data...
Executable_scalc.mk Loading commit data...
Executable_sdraw.mk Loading commit data...
Executable_simpress.mk Loading commit data...
Executable_smath.mk Loading commit data...
Executable_soffice_bin.mk Loading commit data...
Executable_soffice_com.mk Loading commit data...
Executable_soffice_exe.mk Loading commit data...
Executable_sweb.mk Loading commit data...
Executable_swriter.mk Loading commit data...
Executable_unoinfo.mk Loading commit data...
Executable_unopkg.mk Loading commit data...
Executable_unopkg_bin.mk Loading commit data...
Executable_unopkg_com.mk Loading commit data...
Extension_test-active.mk Loading commit data...
Extension_test-passive.mk Loading commit data...
GeneratedPackage_desktop_unopackages_install.mk Loading commit data...
Jar_active_java.mk Loading commit data...
Jar_passive_java.mk Loading commit data...
Library_active_native.mk Loading commit data...
Library_crashreport.mk Loading commit data...
Library_deployment.mk Loading commit data...
Library_deploymentgui.mk Loading commit data...
Library_deploymentmisc.mk Loading commit data...
Library_migrationoo2.mk Loading commit data...
Library_migrationoo3.mk Loading commit data...
Library_offacc.mk Loading commit data...
Library_passive_native.mk Loading commit data...
Library_sofficeapp.mk Loading commit data...
Library_spl.mk Loading commit data...
Library_unopkgapp.mk Loading commit data...
Makefile Loading commit data...
Module_desktop.mk Loading commit data...
Package_branding.mk Loading commit data...
Package_branding_custom.mk Loading commit data...
Package_sbase_sh.mk Loading commit data...
Package_scalc_sh.mk Loading commit data...
Package_scripts.mk Loading commit data...
Package_sdraw_sh.mk Loading commit data...
Package_simpress_sh.mk Loading commit data...
Package_smath_sh.mk Loading commit data...
Package_soffice_sh.mk Loading commit data...
Package_swriter_sh.mk Loading commit data...
Pagein_calc.mk Loading commit data...
Pagein_common.mk Loading commit data...
Pagein_draw.mk Loading commit data...
Pagein_impress.mk Loading commit data...
Pagein_writer.mk Loading commit data...
Pyuno_passive_python.mk Loading commit data...
README Loading commit data...
README.vars Loading commit data...
Rdb_passive_generic.mk Loading commit data...
Rdb_passive_platform.mk Loading commit data...
StaticLibrary_winlauncher.mk Loading commit data...
StaticLibrary_winloader.mk Loading commit data...
UIConfig_deployment.mk Loading commit data...
WinResTarget_quickstart.mk Loading commit data...
WinResTarget_sbase.mk Loading commit data...
WinResTarget_scalc.mk Loading commit data...
WinResTarget_sdraw.mk Loading commit data...
WinResTarget_simpress.mk Loading commit data...
WinResTarget_smath.mk Loading commit data...
WinResTarget_soffice.mk Loading commit data...
WinResTarget_sofficebin.mk Loading commit data...
WinResTarget_sweb.mk Loading commit data...
WinResTarget_swriter.mk Loading commit data...