• Stephan Bergmann's avatar
    fdo#46071: Do not hide windows based on nil "Visible" property · 9db74c61
    Stephan Bergmann yazdı
    This appears to be messy:  The /org.openoffice.Office.Views/WindowType
    configuration group template has both a nilable bool "Visible" property and a
    UserData/Data string property that encodes various things like geometry---but
    also visibility---in a string.
    
    Now, likely due to the problem that has meanwhile been fixed through
    f3f79cc9 "Resolves fdo#46074: Fix
    Partial::contains for paths that go past a leaf node," some
    registrymodification.xcu files in the wild contain such WindowType entries in
    "default" state, without a UserData/Data string and with a nil "Visible"
    property.
    
    The way SfxChildWindow::InitializeChildWinFactory_Impl and
    SvtViewOptions::IsVisible are implemented, they will always lead to an invisible
    window for such broken registrymodification.xcu data (as IsVisible unhelpfully
    returns false for a nil value, and InitializeChildWinFactory_Impl uses that
    value when there is no UserData/Data string).
    
    For the Math formula editor window (ID 30378) this means that it can disappear
    from the UI completely, as there appears to be no UI trigger for the user to
    show it in case it is hidden.
    
    The fix is to introdue SvtViewOptions::HasVisible (which only returns true if
    the property is not nil) and change InitializeChidlWinFactory_Impl to only use
    the value of IsVisible() if HasVisible() returns true.  This makes the code even
    more baroque, but this is a rather central, generic piece of code for all sorts
    of windows, so I do not want to break any other uses by e.g. changing IsVisible
    to return true for a nil property.
    
    Change-Id: Iae40075a7116a8aabd2d25aa9334709522e23d8f
    9db74c61
Adı
Son kayıt (commit)
Son güncelleme
..
accelcfg.hxx Loading commit data...
accessiblerelationsethelper.hxx Loading commit data...
accessiblestatesethelper.hxx Loading commit data...
atom.hxx Loading commit data...
bootstrap.hxx Loading commit data...
calendarwrapper.hxx Loading commit data...
caserotate.hxx Loading commit data...
charclass.hxx Loading commit data...
closeveto.hxx Loading commit data...
cmdoptions.hxx Loading commit data...
collatorwrapper.hxx Loading commit data...
compatibility.hxx Loading commit data...
componentresmodule.hxx Loading commit data...
configitem.hxx Loading commit data...
configmgr.hxx Loading commit data...
confignode.hxx Loading commit data...
configpaths.hxx Loading commit data...
configvaluecontainer.hxx Loading commit data...
datetime.hxx Loading commit data...
defaultoptions.hxx Loading commit data...
desktopterminationobserver.hxx Loading commit data...
digitgroupingiterator.hxx Loading commit data...
docinfohelper.hxx Loading commit data...
dynamicmenuoptions.hxx Loading commit data...
eventcfg.hxx Loading commit data...
eventlisteneradapter.hxx Loading commit data...
extendedsecurityoptions.hxx Loading commit data...
fltrcfg.hxx Loading commit data...
fontcfg.hxx Loading commit data...
fontcvt.hxx Loading commit data...
fontdefs.hxx Loading commit data...
fontoptions.hxx Loading commit data...
historyoptions.hxx Loading commit data...
idhelper.hxx Loading commit data...
internaloptions.hxx Loading commit data...
intlwrapper.hxx Loading commit data...
itemholderbase.hxx Loading commit data...
lingucfg.hxx Loading commit data...
linguprops.hxx Loading commit data...
localedatawrapper.hxx Loading commit data...
localfilehelper.hxx Loading commit data...
localisationoptions.hxx Loading commit data...
misccfg.hxx Loading commit data...
moduleoptions.hxx Loading commit data...
nativenumberwrapper.hxx Loading commit data...
numberformatcodewrapper.hxx Loading commit data...
options.hxx Loading commit data...
optionsdlg.hxx Loading commit data...
pathoptions.hxx Loading commit data...
printwarningoptions.hxx Loading commit data...
progresshandlerwrap.hxx Loading commit data...
readwritemutexguard.hxx Loading commit data...
saveopt.hxx Loading commit data...
searchopt.hxx Loading commit data...
securityoptions.hxx Loading commit data...
sharedunocomponent.hxx Loading commit data...
startoptions.hxx Loading commit data...
streamhelper.hxx Loading commit data...
streamsection.hxx Loading commit data...
streamwrap.hxx Loading commit data...
syslocale.hxx Loading commit data...
syslocaleoptions.hxx Loading commit data...
tempfile.hxx Loading commit data...
textsearch.hxx Loading commit data...
transliterationwrapper.hxx Loading commit data...
ucbhelper.hxx Loading commit data...
ucblockbytes.hxx Loading commit data...
ucbstreamhelper.hxx Loading commit data...
unotoolsdllapi.h Loading commit data...
useroptions.hxx Loading commit data...
viewoptions.hxx Loading commit data...
workingsetoptions.hxx Loading commit data...
xmlaccelcfg.hxx Loading commit data...