-
Tomaž Vajngerl yazdı
There is no need to check this in a test when we can do it directly in the header. static_assert will complain when compiling something that uses the header file instead of waiting that it finds a piece of code, where it is actually needed. The purpose of the test was the same (fail early). The main problem was that Color can be created and converted to sal_uInt32 string completely in compile time, so it can be used for "case" in a "switch" statement, which requires that in "case" it uses a constant. Normally this isn't possible unless we resolve and convert a Color to sal_uInt32 in compile time. This use-case is used somewhere in the code, but it takes a lot of (re)compiling to get to that piece of code, where it would eventually fail. Change-Id: I1f1f9b77c19a0e61f78ce703b380d98a569da833 Reviewed-on: https://gerrit.libreoffice.org/71060Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
60de1cb0
Adı |
Son kayıt (commit)
|
Son güncelleme |
---|---|---|
.. | ||
inc | ||
qa | ||
source | ||
CppunitTest_tools_config.mk | ||
CppunitTest_tools_test.mk | ||
CustomTarget_reversemap.mk | ||
Executable_bestreversemap.mk | ||
Library_tl.mk | ||
Makefile | ||
Module_tools.mk | ||
README | ||
StaticLibrary_ooopathutils.mk |