• Stephan Bergmann's avatar
    Remove *_Test product, so cppunittester can be NONE again · 359472b2
    Stephan Bergmann yazdı
    ...as per #libreoffice-dev IRC:
    
    Sep 19 10:32:24 <mst__> sberg, moggi  why the hell is that thing named
      "cppunit/cppunittester" and inside a subdir?  it's obstructing my attempt to
      put it in $(INSTDIR)/program
    Sep 19 10:33:28 <mst__> (... and if you wonder "wtf does it have to do with
      INSTDIR" you have never heard of awesome LibreOffice_Test installset.... not
      that i would know who needs it :)
    Sep 19 10:36:36 <sberg> mst__, it is in a subdir of solver/*/bin so that on
      Windows it would not accidentally have picked DLLs next to itself instead of
      the module-local DLLs it was supposed to test (back when we had module-local
      output trees)
    Sep 19 10:37:02 <mst__> sberg, ahh hysteric reasons then, /me renames it
    Sep 19 10:37:55 <tml> mst__, if nobody you know uses LibreOffice_Test, just kill
      it?
    Sep 19 10:38:59 <sberg> mst__, tml, LibreOffice_Test was conceived by pmladek
      and/or kendy, IIRC
    Sep 19 10:40:31 * kendy does not remember anything about it :-)
    Sep 19 10:42:17 <sberg> wasn't that something so users (or QA people?) could
      easily run the smoketest against an installation, to see whether the
      installation is any good at all, by installing that LibreOffice_Test alongside
      the installation proper?
    Sep 19 10:43:26 <sberg> mst__, ...and I'd unscientifically vote to kill it
    Sep 19 11:34:23 <pmladek> mst__, sberg: I have created the LibreOffice_Test
      package for one QA guy. He does not longer work on LO. I am not sure if anyone
      else started to use it. So, I think that it can be killed.
    
    Oct 17 18:18:07 <tml_> sberg: have you ever noticed that when you try to
      actually run instdir/unxmacxi/LibreOfficeDev.app , the system actually tries
      to run cppunittester inside the app bundle (it says so in the crash report)
      (it crashes because cppunittester requires a specialized DYLIB_LIBRARY_PATH
      apparently)
    Oct 17 18:19:29 <tml_> I suspect that the system when cppunittester as part of
      the build process is run from inside instdir (i.e. inside an app bundle) the
      system "caches" this false knowledge, and thinks that the executable of the
      app bundle is cppunittester...
    Oct 17 18:19:36 <sberg> tml_, no, never noticed; with "run
      instdir/unxmacxi/LibreOfficeDev.app" you mean calling "open
      instdir/unxmacxi/LibreOfficeDev.app"?  (I always call
      .app/Contenst/MacOS/program explicitly)
    Oct 17 18:19:52 <tml_> yes, I mean "open instdir/..."
    Oct 17 18:20:53 <tml_> some googling tells me that at least years ago, the
      CFBundleExecutable key in the Info.plist is ignored if it is manually changed,
      so I guess similar caching of mapping between an app bundle and which
      executable to actually run happens in this case
    Oct 17 18:23:17 <tml_> and last year somebody even claims "And while on Mountain
      Lion, CFBundleExecutable seems to be a no-op", which would be odd, surely
      there must be widely used apps that have several executables inside the MacOS
      directory; how would the system know which one to run when the app is run?
    Oct 17 18:24:38 <tml_> hmm, apparently the code that handles this might be open
      source even, http://www.opensource.apple.com/source/CF/CF-744.18/CFBundle.c
    Oct 17 18:25:52 <tml_> some mention of "caches" there yes, my guesses might be
      right
    Oct 17 18:27:05 <tml_> if I cp -R instdir/unxmacxi/LibreOffice.app foo.app and
      open foo.app, it works fine
    Oct 17 18:28:33 <tml_> anyway, I guess it would be cleaner to have cppunittester
      somewhere else even without this problem
    Oct 17 18:37:09 <sberg> tml_, yes, IIRC having cppunittester in instdir was a
      misguided mst decision, because that odd LibreOffice_Test product (that
      pmladek said nobody needs any longer anyway) includes it; I think consensus
      was to kill LibreOffice_Test and move cppunittester where all the other NONE
      executables are, but looks like nobody executed
    Oct 17 18:37:55 <tml_> ah ok, so mst should know what needs to be done? good, no
      need for me to try to hack this now then
    Oct 17 18:38:19 <sberg> tml_, I'll do the cleanup tomorrow, unless somebody
      beats me
    
    This removes smoketest/losmoketest et al along with the *_Test product, as they
    seem to not make sense without it anyway.  smoketest/Executable_libtest.mk
    appears to be a test that could also be run during the build, and only ended up
    in the *_Test product by accident, so I left it untouched for now.
    
    Change-Id: I8024472c909fe0a885eb08ef4d3777f8a9e1f7c8
    359472b2
Adı
Son kayıt (commit)
Son güncelleme
.git-hooks Loading commit data...
Mesa Loading commit data...
UnoControls Loading commit data...
accessibility Loading commit data...
android Loading commit data...
animations Loading commit data...
apple_remote Loading commit data...
avmedia Loading commit data...
basctl Loading commit data...
basebmp Loading commit data...
basegfx Loading commit data...
basic Loading commit data...
bean Loading commit data...
bin Loading commit data...
binaryurp Loading commit data...
bluez_bluetooth Loading commit data...
bridges Loading commit data...
canvas Loading commit data...
chart2 Loading commit data...
cli_ure Loading commit data...
codemaker Loading commit data...
comphelper Loading commit data...
compilerplugins Loading commit data...
config_host Loading commit data...
configmgr Loading commit data...
connectivity Loading commit data...
cppcanvas Loading commit data...
cppu Loading commit data...
cppuhelper Loading commit data...
cpputools Loading commit data...
crashrep Loading commit data...
cui Loading commit data...
dbaccess Loading commit data...
desktop Loading commit data...
dictionaries @ f1a4ecab
distro-configs Loading commit data...
drawinglayer Loading commit data...
dtrans Loading commit data...
editeng Loading commit data...
embeddedobj Loading commit data...
embedserv Loading commit data...
eventattacher Loading commit data...
extensions Loading commit data...
external Loading commit data...
extras Loading commit data...
filter Loading commit data...
firefoxos/sdremote Loading commit data...
forms Loading commit data...
formula Loading commit data...
fpicker Loading commit data...
framework Loading commit data...
helpcompiler Loading commit data...
helpcontent2 @ e4a53e8d
hwpfilter Loading commit data...
i18nlangtag Loading commit data...
i18npool Loading commit data...
i18nutil Loading commit data...
icon-themes Loading commit data...
idl Loading commit data...
idlc Loading commit data...
include Loading commit data...
instsetoo_native Loading commit data...
io Loading commit data...
ios Loading commit data...
javaunohelper Loading commit data...
jfreereport Loading commit data...
jpeg Loading commit data...
jurt Loading commit data...
jvmaccess Loading commit data...
jvmfwk Loading commit data...
l10ntools Loading commit data...
languagetool Loading commit data...
lcms2 Loading commit data...
libcdr Loading commit data...
libcmis Loading commit data...
libexttextcat Loading commit data...
liblangtag Loading commit data...
libmariadb Loading commit data...
libmspub Loading commit data...
libmwaw Loading commit data...
libodfgen Loading commit data...
liborcus Loading commit data...
librelogo Loading commit data...
libvisio Loading commit data...
libwpd Loading commit data...
libwpg Loading commit data...
libwps Loading commit data...
libxml2 Loading commit data...
libxmlsec Loading commit data...
libxslt Loading commit data...
lingucomponent Loading commit data...
linguistic Loading commit data...
lotuswordpro Loading commit data...
lpsolve Loading commit data...
m4 Loading commit data...
mdds Loading commit data...
more_fonts Loading commit data...
moz Loading commit data...
mysqlc Loading commit data...
mysqlcppconn Loading commit data...
mythes Loading commit data...
neon Loading commit data...
nlpsolver Loading commit data...
np_sdk Loading commit data...
nss Loading commit data...
o3tl Loading commit data...
odk Loading commit data...
offapi Loading commit data...
officecfg Loading commit data...
oovbaapi Loading commit data...
oox Loading commit data...
openldap Loading commit data...
openssl Loading commit data...
package Loading commit data...
padmin Loading commit data...
poppler Loading commit data...
postgresql Loading commit data...
postprocess Loading commit data...
psprint_config Loading commit data...
python3 Loading commit data...
pyuno Loading commit data...
qadevOOo Loading commit data...
readlicense_oo Loading commit data...
redland Loading commit data...
registry Loading commit data...
remotebridges Loading commit data...
reportbuilder Loading commit data...
reportdesign Loading commit data...
rhino Loading commit data...
ridljar Loading commit data...
rsc Loading commit data...
sal Loading commit data...
salhelper Loading commit data...
sane Loading commit data...
sax Loading commit data...
sc Loading commit data...
scaddins Loading commit data...
sccomp Loading commit data...
scp2 Loading commit data...
scripting Loading commit data...
sd Loading commit data...
sdext Loading commit data...
setup_native Loading commit data...
sfx2 Loading commit data...
shell Loading commit data...
slideshow Loading commit data...
smoketest Loading commit data...
solenv Loading commit data...
soltools Loading commit data...
sot Loading commit data...
starmath Loading commit data...
stoc Loading commit data...
store Loading commit data...
svgio Loading commit data...
svl Loading commit data...
svtools Loading commit data...
svx Loading commit data...
sw Loading commit data...
swext Loading commit data...
sysui Loading commit data...
test Loading commit data...
testtools Loading commit data...
tomcat Loading commit data...
toolkit Loading commit data...
tools Loading commit data...
touch Loading commit data...
translations @ 70db96bb
tubes Loading commit data...
twain Loading commit data...
ucb Loading commit data...
ucbhelper Loading commit data...
ucpp Loading commit data...
udkapi Loading commit data...
unixODBC Loading commit data...
unodevtools Loading commit data...
unoidl Loading commit data...
unoil Loading commit data...
unotest Loading commit data...
unotools Loading commit data...
unoxml Loading commit data...
ure Loading commit data...
uui Loading commit data...
vbahelper Loading commit data...
vcl Loading commit data...
vigra Loading commit data...
wizards Loading commit data...
writerfilter Loading commit data...
writerperfect Loading commit data...
xmerge Loading commit data...
xmlhelp Loading commit data...
xmloff Loading commit data...
xmlreader Loading commit data...
xmlscript Loading commit data...
xmlsecurity Loading commit data...
xsltml Loading commit data...
zlib Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.gitreview Loading commit data...
COPYING Loading commit data...
COPYING.LGPL Loading commit data...
COPYING.MPL Loading commit data...
Library_merged.mk Loading commit data...
Library_urelibs.mk Loading commit data...
Makefile.fetch Loading commit data...
Makefile.gbuild Loading commit data...
Makefile.in Loading commit data...
README.Android Loading commit data...
README.Code Loading commit data...
README.Solaris Loading commit data...
README.cross Loading commit data...
Repository.mk Loading commit data...
RepositoryExternal.mk Loading commit data...
RepositoryFixes.mk Loading commit data...
RepositoryModule_build.mk Loading commit data...
RepositoryModule_host.mk Loading commit data...
TEMPLATE.SOURCECODE.HEADER Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
config_host.mk.in Loading commit data...
configure.ac Loading commit data...
download.lst Loading commit data...
g Loading commit data...
install-sh Loading commit data...
lo.xcent.in Loading commit data...
logerrit Loading commit data...
unusedcode.README Loading commit data...
unusedcode.easy Loading commit data...
unusedcode.exclude Loading commit data...