• Noel Grandin's avatar
    remove dead SwNoteURL · ed2ae3c3
    Noel Grandin yazdı
    According to:
    
    <mst_> noelgrandin: apparently this code exists so you can export a text
    
         frame as an image and then the urls in the text become
        image-map links
    
    which means that according to my analysis below, nobody has noticed the
    removal in 17 years :-)
    
    SwNoteURL::InsertURLNote was the last place that constructed an
    SwNoteURL and it was removed in
        commit bb7ade14
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Mar 7 13:42:58 2018 +0200
        loplugin:unusedmethods
    
    and SwNoteURL::InsertURLNote was dead because
       void SwTextPaintInfo::NotifyURL_( const SwLinePortion &rPor ) const
    was removed in
        commit 73139fe6
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Fri Jan 19 13:10:22 2018 +0200
        loplugin:unusedmethods
    
    and SwTextPaintInfo::NotifyURL_ was dead because
       void SwTextPaintInfo::NotifyURL( const SwLinePortion &rPor ) const
    was removed in
        commit be8c4145
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Fri Jan 19 09:13:03 2018 +0200
        loplugin:unusedmethods also check for functions returning bool
    
    and NotifyURL was dead because calls to it were removed in
        commit 1b666235
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Jan 3 09:08:52 2018 +0200
        loplugin:singlevalfields improve copy constructor check
    those calls were removed because the m_bURL field of SwFont was always
    false.
    
    tracing back, we find that m_bURL was called bURL before
        commit b4e2a13f
        Author: Miklos Vajna <vmiklos@collabora.co.uk>
        Date:   Mon Oct 26 08:55:17 2015 +0100
        sw: prefix members of SwFont
    
    and we find that a method
         void SwFont::SetURL(const bool)
    that modified bURL was removed in
        commit 407731c9
        Author: Noel Grandin <noel@peralex.com>
        Date:   Tue Jul 21 10:44:17 2015 +0200
        loplugin:unusedmethods sw
    
    and we find that calls to SetURL were removed in
        commit da7671e4
        Author: Andreas Martens <ama@openoffice.org>
        Date:   Thu Mar 15 14:59:12 2001 +0000
        Opt.(FME): The new attribute handler makes a lot of code superfluous
    
    which appears to be the root of the problem
    
    Change-Id: Id2362ce216c06bc8dcf71698695d708eb494af4e
    Reviewed-on: https://gerrit.libreoffice.org/51225Reviewed-by: 's avatarMichael Stahl <mstahl@redhat.com>
    Tested-by: 's avatarJenkins <ci@libreoffice.org>
    ed2ae3c3
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa Loading commit data...
sdi Loading commit data...
source Loading commit data...
uiconfig Loading commit data...
util Loading commit data...
AllLangMoTarget_sw.mk Loading commit data...
CppunitTest_sw_dialogs_test.mk Loading commit data...
CppunitTest_sw_dialogs_test_2.mk Loading commit data...
CppunitTest_sw_docbookexport.mk Loading commit data...
CppunitTest_sw_filters_test.mk Loading commit data...
CppunitTest_sw_fodfexport.mk Loading commit data...
CppunitTest_sw_globalfilter.mk Loading commit data...
CppunitTest_sw_htmlexport.mk Loading commit data...
CppunitTest_sw_htmlimport.mk Loading commit data...
CppunitTest_sw_layout_test.mk Loading commit data...
CppunitTest_sw_macros_test.mk Loading commit data...
CppunitTest_sw_mailmerge.mk Loading commit data...
CppunitTest_sw_odfexport.mk Loading commit data...
CppunitTest_sw_odfimport.mk Loading commit data...
CppunitTest_sw_ooxmlencryption.mk Loading commit data...
CppunitTest_sw_ooxmlexport.mk Loading commit data...
CppunitTest_sw_ooxmlexport10.mk Loading commit data...
CppunitTest_sw_ooxmlexport11.mk Loading commit data...
CppunitTest_sw_ooxmlexport2.mk Loading commit data...
CppunitTest_sw_ooxmlexport3.mk Loading commit data...
CppunitTest_sw_ooxmlexport4.mk Loading commit data...
CppunitTest_sw_ooxmlexport5.mk Loading commit data...
CppunitTest_sw_ooxmlexport6.mk Loading commit data...
CppunitTest_sw_ooxmlexport7.mk Loading commit data...
CppunitTest_sw_ooxmlexport8.mk Loading commit data...
CppunitTest_sw_ooxmlexport9.mk Loading commit data...
CppunitTest_sw_ooxmlfieldexport.mk Loading commit data...
CppunitTest_sw_ooxmlimport.mk Loading commit data...
CppunitTest_sw_ooxmllinks.mk Loading commit data...
CppunitTest_sw_ooxmlw14export.mk Loading commit data...
CppunitTest_sw_rtfexport.mk Loading commit data...
CppunitTest_sw_rtfexport2.mk Loading commit data...
CppunitTest_sw_rtfexport3.mk Loading commit data...
CppunitTest_sw_rtfimport.mk Loading commit data...
CppunitTest_sw_tiledrendering.mk Loading commit data...
CppunitTest_sw_txtexport.mk Loading commit data...
CppunitTest_sw_uibase_unit.mk Loading commit data...
CppunitTest_sw_uiwriter.mk Loading commit data...
CppunitTest_sw_uwriter.mk Loading commit data...
CppunitTest_sw_ww8export.mk Loading commit data...
CppunitTest_sw_ww8export2.mk Loading commit data...
CppunitTest_sw_ww8import.mk Loading commit data...
CustomTarget_generated.mk Loading commit data...
JunitTest_sw_complex.mk Loading commit data...
JunitTest_sw_unoapi_1.mk Loading commit data...
JunitTest_sw_unoapi_2.mk Loading commit data...
JunitTest_sw_unoapi_3.mk Loading commit data...
JunitTest_sw_unoapi_4.mk Loading commit data...
Library_msword.mk Loading commit data...
Library_sw.mk Loading commit data...
Library_swd.mk Loading commit data...
Library_swui.mk Loading commit data...
Library_vbaswobj.mk Loading commit data...
Makefile Loading commit data...
Module_sw.mk Loading commit data...
PythonTest_sw_python.mk Loading commit data...
README Loading commit data...
UIConfig_sglobal.mk Loading commit data...
UIConfig_sweb.mk Loading commit data...
UIConfig_swform.mk Loading commit data...
UIConfig_swreport.mk Loading commit data...
UIConfig_swriter.mk Loading commit data...
UIConfig_swxform.mk Loading commit data...
UITest_writer_tests.mk Loading commit data...
ooxmlexport_setup.mk Loading commit data...