Kayıtlar (commit) · feddb8cb73db799e89b84ea8fd8c2057fdebca91 · LibreOffice / core

18 Eyl, 2017 26 kayıt (commit)

maPrimitiveColor in Shadow3DExtractingProcessor unused · feddb8cb

Noel Grandin Eyl 18, 2017 yazdı

since

    commit 9927e1ca
    Date:   Wed Aug 9 16:00:16 2006 +0000
    #i39532#

Change-Id: I1db3db2c4860d6ad71085cc3cfdeb202eec7e24a

feddb8cb

unused m_xAccInfo in AccessibleEditableTextPara · 2b5cb7c6

Noel Grandin Eyl 18, 2017 yazdı

since

    commit c23ab5ea
    Date:   Tue Nov 26 14:25:22 2013 +0000
    Integrate branch of IAccessible2

Change-Id: Id068fb0a49f5a1e79ca17fe66885cda558abe275

2b5cb7c6

remove unused aLocale from SvxNumRule · b3c77e46

Noel Grandin Eyl 18, 2017 yazdı

and fix usage site, regression from

    commit 41956321
    Date:   Sat Nov 24 18:54:09 2012 +0100
    get rid of Svx...Locale...() double conversion nonsense

Change-Id: Ic70abf5f52dce1db9cffd9c819e57f1a6c2a3df3

b3c77e46

unused menu extension supplier stuff · fe7032a3

Noel Grandin Eyl 18, 2017 yazdı

since

    commit 5298b1b3
    Date:   Mon Aug 8 11:48:55 2011 +0100
    callcatcher: ditch some more methods

Change-Id: I123081cbe7fe351ce6613a5e7491b11e133d1d29

fe7032a3

msCommandName in ControllerItem is unused · fc48a4cf

Noel Grandin Eyl 18, 2017 yazdı

ever since

    commit 1c5cae47
    Date:   Thu Apr 20 08:44:33 2017 +0200
    loplugin:unusedmethods

Change-Id: I7c02e8bf0ef377303dedf4e6690fd937f52a3605

fc48a4cf

msDescription in SvtRulerAccessible is unused · 3c695c5b

Noel Grandin Eyl 18, 2017 yazdı

ever since

    commit 2b12a5b8
    Date:   Mon Feb 10 09:29:34 2014 +0000
    the return of callcatcher

Change-Id: I62021793e5ca90cba9d2e6998f5ac30da33764f7

3c695c5b

aFocusRect in CheckBoxControl is unused · e6e619b3

Noel Grandin Eyl 18, 2017 yazdı

ever since

    commit ff09f8d6
    Date:   Thu Mar 27 13:40:07 2003 +0000
    MWS_SRX644: migrate branch mws_srx644 -> HEAD

Change-Id: I71905a95a86757be59abeee6140ef57516176a6a

e6e619b3

headString in SvTreeListBox is unused · cb315646

Noel Grandin Eyl 18, 2017 yazdı

ever since being added in

    commit b755fb8c
    Date:   Mon Nov 25 16:15:58 2013 +0000
    Integrate branch of IAccessible2

Change-Id: Iebb8d30d53cc08e7cc35d610f04db8ed6c853b70

cb315646

loplugin:unusedfields in SvxPixelCtl · fba231b2

Noel Grandin Eyl 18, 2017 yazdı

aLineColor is unused since

    commit fa1807ad
    Date:   Thu Aug 27 21:18:58 2015 +0300
    tdf#93558 Hardcode black text on white background

Change-Id: Idadfa926808568195256c7ea7ac92d71533fe9a9

fba231b2

loplugin:unusedfields in ResultSetColumnData · f1dda661

Noel Grandin Eyl 18, 2017 yazdı

ever since introduction in

    commit 24f26145
    Date:   Thu Jan 18 08:03:55 2001 +0000
    "#82177# - Added support for additional column data ( case-
sensitivity, ... )"

Change-Id: I593f7e2a3be7b6445c7975ff385b6ba0d35183b9

f1dda661

clang plugins: this test fails on 32-bit Linux · 1c92a7fa

Michael Stahl Eyl 18, 2017 yazdı

... where sal_uIntPtr and sal_uInt32 are both "unsigned long";
 disable test for now.

Change-Id: I8357bf425ab5d9166cd45ba5fb81ec6c1fac957a
error: 'error' diagnostics expected but not seen:
  File compilerplugins/clang/test/convertuintptr.cxx Line 15: cast from 'sal_uIntPtr' (aka 'unsigned {{.+}}') to 'sal_uInt32' (aka 'unsigned {{.+}}') [loplugin:convertuintptr]
  File compilerplugins/clang/test/convertuintptr.cxx Line 16: cast from 'sal_uIntPtr' (aka 'unsigned {{.+}}') to 'sal_uInt32' (aka 'unsigned {{.+}}') [loplugin:convertuintptr]

1c92a7fa

bridges: [loplugin:stringconstant] · 5581ab4a
Michael Stahl Eyl 18, 2017 yazdı
```
Change-Id: I07501ac3593cd5df713b74e04ea64d22365958b9
```
5581ab4a

tdf#109118 Added new buttons into Mail Merge toolbar · 2c60cc41

Serge Krot Eyl 15, 2017 yazdı

New buttons are:
- uno:ViewDataSourceBrowser
- uno:AddressBookSource

Change-Id: I03d475edc01885137cb792c0654e68861725e8ee
Reviewed-on: https://gerrit.libreoffice.org/42334Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>

2c60cc41

convert SvxDateFormat to scoped enum · 7d14555e

Noel Grandin Eyl 15, 2017 yazdı

And simplify the code in sd/headerfooterdlg, no
need for the complex encoding of date and time when we
can just index into a static array.

Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c
Reviewed-on: https://gerrit.libreoffice.org/42346Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

7d14555e

sal: -Werror,-Wsign-compare (32-bit) · 0083b336
Michael Stahl Eyl 18, 2017 yazdı
```
Change-Id: I204716eea112a1c99f6ac4df0d138c4c7d8b68e3
```
0083b336

use pkg-config --modversion to check for ICU version · 050b1d09

Rene Engelhard Eyl 18, 2017 yazdı

... since icu-config is removed at least in Debians icu 59.1 packages.
icu-i18n exists since exactly 4.6 (which we require anyway) so we can
remove that check, too

Change-Id: I28bd1509dcc2c52e22f91fb26421fcd585323b24

050b1d09

Translate German comments and debug strings (leftovers in dirs w... and x...) · 510b9557

Johnny_M Eyl 17, 2017 yazdı

Translates leftovers found using a custom regex in directories beginning with "w" and "x".

Additionally:
- A few corrections of previous translations

Change-Id: Ic30cf6792748a6bea8782a9a3711fa468b80bdaf
Reviewed-on: https://gerrit.libreoffice.org/42378Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

510b9557

svx: Assert that GetMarkedSdrObj() cannot be null here · 3af68b14

Takeshi Abe Eyl 17, 2017 yazdı

as such invalid ones have been removed already in advance.
This could come togeher with c0e9968b.

Change-Id: I914031390d13dd4ad91d2ead61db7f2d53c78004
Reviewed-on: https://gerrit.libreoffice.org/42365Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

3af68b14

Adapt external/nss/asan.patch.1 · 69e62bbe

Stephan Bergmann Eyl 18, 2017 yazdı

...to a52ca01f "nss: no rpath/origin flag for
Android (unused DT entry/DT_FLAGS warnings)"

Change-Id: I60e4ba1af572aa702a355e26dec58142209f8655

69e62bbe

Acknowledge that WinSalGraphicsImpl::drawPolyLine modifies pPtAry · 80363950

Stephan Bergmann Eyl 18, 2017 yazdı

Change-Id: Idde44857f8ace883cc759321c71e2ca7a4359334
Reviewed-on: https://gerrit.libreoffice.org/42406Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

80363950

tdf#109310 ooxmlexport: write Xnote character style · ac108117

Justin Luth Eyl 06, 2017 yazdı

LibreOffice will just ignore the defined style on import
(since that is statically defined by the footnote code).

Microsoft Office, however, requires the character style be
provided for the footnote number. It doesn't have any
built-in formatting for footnotes.

So, this patch is strictly for MSO's benefit.

Change-Id: I6631dd0eb697589cfd3c13d7838fe14c31a71bbf
Reviewed-on: https://gerrit.libreoffice.org/42035Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

ac108117

Michael Stahl Eyl 15, 2017 yazdı

ImplLogicToPixel() is called with ~LONG_MIN value, which comes from
SwView::StateTabWin() where we have:

(rr) p aTabCols
$12 = {
  nLeftMin = 1134,
  nLeft = 0,
  nRight = 4618,
  nRightMax = 9223372036854775807,
  bLastRowAllowedToChange = true,
  aData = std::__debug::vector of length 9, capacity 16 = {{
      nPos = 387,
      nMin = 0,
      nMax = 9223372036854775807,
      bHidden = false
    }, {

The problem is that the "aTabCols.GetRight() - rEntry.nMax"
becomes negative, which is probably wrong, so enforce a minimum of 0.

(regression from 4c60f722, which
 removed a cast of the value to sal_uInt16, which also didn't look
 right to me, but perhaps wouldn't cause this assert?)

Change-Id: Ia1aa2cd100ac25a8c34902cc992d54954fead284

79ceef1d

sw dbmgr: fix indent of these statements · 6fa56459
Miklos Vajna Eyl 18, 2017 yazdı
```
Change-Id: I4eae19f5a724c44ec382053ace2f3fcd586fd6f3
```
6fa56459

sw: prefix members of SwFormatFlyCnt · a577f6fb

Miklos Vajna Eyl 18, 2017 yazdı

Change-Id: I41c611d4babe227ce298ed8d6ba3d9e05da5a82b
Reviewed-on: https://gerrit.libreoffice.org/42404Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

a577f6fb

Put back some #include (needed for e.g. --disable-pch) · 74cd94a1

Stephan Bergmann Eyl 18, 2017 yazdı

...that had been removed too eagerly with
1f543b81 "osl/w32: don't use 8-bit string
functions"

Change-Id: I9d16cc5ff9b779457d8d70c7f206d5e684342c63

74cd94a1

improve unusedfields loplugin · 1ff0f0ba

Noel Grandin Eyl 18, 2017 yazdı

(*) IsPassedByNonConst was completely wrong, not even sure why it worked
before.
(*) treat a field passed to operator>>= as being written to, but not
read

Change-Id: Id3a5f2f35222986fe5edba3f5a58215a1815d401

1ff0f0ba

17 Eyl, 2017 14 kayıt (commit)

Use even more WIN32_LEAN_AND_MEAN · afeff910

Mike Kaganski Eyl 17, 2017 yazdı

Change-Id: I538fe5b41156366e0e87b3a93e58a3947afd18f5
Reviewed-on: https://gerrit.libreoffice.org/42398Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

afeff910

Removed duplicated include · 164f6ba4

Andrea Gelmini Eyl 17, 2017 yazdı

Change-Id: I38e3ecdf892f5e5212e4332868e5811c347d6978
Reviewed-on: https://gerrit.libreoffice.org/42400Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

164f6ba4

Fix typo · de3c5b21

Andrea Gelmini Eyl 17, 2017 yazdı

Change-Id: I0e9a89a3c611692e64b7faa0f460c3979c29bf91
Reviewed-on: https://gerrit.libreoffice.org/42348Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

de3c5b21

Julien Nabet Eyl 17, 2017 yazdı

Apply the same changes in GetProposals than GetSpellFailure

Change-Id: Id78966568833f29c21f44724974254218636597d
Reviewed-on: https://gerrit.libreoffice.org/42397Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

11fcdecb

detect corrupted job setup · dd586840

Caolán McNamara Eyl 17, 2017 yazdı

Change-Id: I0d3b4850c3d4c015a0a7e5d36d87113a749c7e0f
Reviewed-on: https://gerrit.libreoffice.org/42383Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

dd586840

protect against short file · 1ebf34c6

Caolán McNamara Eyl 17, 2017 yazdı

Change-Id: I20c6a6fb34485f42c2a828618e8918d8a441860a
Reviewed-on: https://gerrit.libreoffice.org/42389Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1ebf34c6

Updated core · 1cd8f0fa

Andras Timar Eyl 17, 2017 yazdı

Project: translations  db1be6fc22a2376bd591f94b0268817e4beb1464

Updated Slovenian translation

Change-Id: I9a5ce2c6cf300c520cb0ab8b33fb53fbc49da7dd

1cd8f0fa

valgrind: Conditional jump or move depends on uninitialised value · 64aa36e8

Caolán McNamara Eyl 17, 2017 yazdı

Conditional jump or move depends on uninitialised value(s)
at 0x4C3535E: strstr (vg_replace_strmem.c:1623)
by 0x4FCD9E59: SmFilterDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) (smdetect.cxx:102)
by 0x41A1A774: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1038)

Change-Id: I2f98fd3f7799f34cb5bd9242379ce6440645034d
Reviewed-on: https://gerrit.libreoffice.org/42381Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

64aa36e8

ofz: string has to be at least 5 chars long · 4025422a

Caolán McNamara Eyl 17, 2017 yazdı

Change-Id: I98c50a59c03fc886d50362b9c5dd8c84f60e0b62
Reviewed-on: https://gerrit.libreoffice.org/42379Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

4025422a

fix leak on exceptions · 64b7ff9f

Caolán McNamara Eyl 17, 2017 yazdı

Change-Id: I88201acb472dbdb2c3b49945b962c5f2689d3bae
Reviewed-on: https://gerrit.libreoffice.org/42376Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

64b7ff9f

ofz: fix leak on exception · 1b3fc6e2

Caolán McNamara Eyl 17, 2017 yazdı

 #0 0x600ca0 in operator new(unsigned long) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:82
 #1 0x4802b4b in xmlscript::DocumentHandlerImpl::pushPrefix(rtl::OUString const&, rtl::OUString const&) /src/libreoffice/xmlscript/source/xml_helper/xml_impctx.cxx:259:32
 #2 0x47ff026 in xmlscript::DocumentHandlerImpl::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmlscript/source/xml_helper/xml_impctx.cxx:480:17
 #3 0x7665a34 in xmlscript::XMLBasicImporterBase::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmlscript/source/xmlflat_imexp/xmlbas_import.cxx:537:25
 #4 0x4c2831f in XMLBasicImportContext::StartElement(com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmloff/source/script/xmlbasici.cxx:84:21
 #5 0x489c29b in SvXMLImport::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) /src/libreoffice/xmloff/source/core/xmlimp.cxx:728:15
 #6 0x4892ab7 in SvXMLImportContext::startUnknownElement(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /src/libreoffice/xmloff/source/core/xmlictxt.cxx:124:14
 #7 0x489ec2d in SvXMLImport::startUnknownElement(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /src/libreoffice/xmloff/source/core/xmlimp.cxx:889:15
 #8 0x86871f3 in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event*) /src/libreoffice/sax/source/fastparser/fastparser.cxx:445:27
 #9 0x86823f1 in sax_fastparser::FastSaxParserImpl::consume((anonymous namespace)::EventList&) /src/libreoffice/sax/source/fastparser/fastparser.cxx:960:25
 #10 0x86812f8 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /src/libreoffice/sax/source/fastparser/fastparser.cxx:784:26
 #11 0x489842e in SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&) /src/libreoffice/xmloff/source/core/xmlimp.cxx:464:15
 #12 0x837fb5d in filter::odfflatxml::OdfFlatXml::importer(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XDocumentHandler> const&, com::sun::star::uno::Sequence<rtl::OUString> const&) /src/libreoffice/filter/source/odfflatxml/OdfFlatXml.cxx:149:26

Change-Id: Ic4ba40dca088a333a1271e005a05bd3c6e7d70ac
Reviewed-on: https://gerrit.libreoffice.org/42375Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1b3fc6e2

valgrind: leak in fdo42771-1.fodt · 2729a1c9

Caolán McNamara Eyl 17, 2017 yazdı

at 0x4C2E1FC: operator new(unsigned long) (vg_replace_malloc.c:334)
by 0x148794C2: XMLParaContext::CreateChildContext(unsigned short, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) (txtparai.cxx:2167)
by 0x14517821: SvXMLImport::startElement(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XAttributeList> const&) (xmlimp.cxx:704)
by 0x14511B09: SvXMLImportContext::startUnknownElement(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlictxt.cxx:127)
by 0x145114AE: SvXMLImportContext::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlictxt.cxx:77)
by 0x14518654: SvXMLImport::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlimp.cxx:854)
by 0x463D934A: (anonymous namespace)::Entity::startElement((anonymous namespace)::Event*) (fastparser.cxx:456)
by 0x463DD799: sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) (fastparser.cxx:1205)
by 0x463D7956: call_callbackStartElement (fastparser.cxx:306)
by 0x13F667FF: xmlParseStartTag2 (parser.c:9793)
by 0x13F6D77C: xmlParseTryOrFinish (parser.c:11591)
by 0x13F6EF6A: xmlParseChunk (parser.c:12496)

Change-Id: I89a6a9035e7016d6d96a78e62dba42fb2f148258
Reviewed-on: https://gerrit.libreoffice.org/42372Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

2729a1c9

Replace some lists by vectors in dbaccess · e1e63bc2

Julien Nabet Eyl 17, 2017 yazdı

Change-Id: Ibf75bec826661fcff7d71e9e2f11884e498a299b
Reviewed-on: https://gerrit.libreoffice.org/42382Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

e1e63bc2

make freetype patch apply again · ba5b65e2

Caolán McNamara Eyl 17, 2017 yazdı

Change-Id: I5732a78774ac1e5d50212ab219646bf52797f173
Reviewed-on: https://gerrit.libreoffice.org/42380Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

ba5b65e2