Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia4424b2be84ece65305bb4e5bed505bed49ebda8
Reviewed-on: https://gerrit.libreoffice.org/72106
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I053dc3e8c5a5acc40e90db50c8b7d3c04feaa032
Reviewed-on: https://gerrit.libreoffice.org/72108
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In testUserFieldTypeLanguage the locale was set to de-DE
first then revert by calling SetLocaleConfigString with an
empty string when the test finished. Calling
SetLocaleConfigString with an empty string set the system
locale to the system default, which is not necessarily en-US
which is the default for unit tests.

Unfortunately it makes testTdf108021 fail because the
layouts in the testTdf108021 are different in en-US and
zh-TW locale in my environment. This locale-dependent layout
issue is tracked as tdf#125025 now.

Change-Id: I50ae2df5fb4624f94d070742c6189bf333370137
Reviewed-on: https://gerrit.libreoffice.org/71480
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I7f11f6b466cce85718ecf3d158f78962e756479f
Reviewed-on: https://gerrit.libreoffice.org/72111
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Hyperlink inserted to text box lost after export.

Change-Id: I796e54339292cb4a5e98de1ead6558d66587d353
Reviewed-on: https://gerrit.libreoffice.org/72033
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

...that has been dead ever since d49bc78f
"tdf#46723 - enable configmgr unit tests"

Change-Id: Ie7f8e6dc669f66798364f907dab65afdfe4f63c0
Reviewed-on: https://gerrit.libreoffice.org/72104
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie59a7ee3b95eafe2a2f743a76f8feb993c0c3daa
Reviewed-on: https://gerrit.libreoffice.org/72110
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

It's converted to QString anyway.

Change-Id: I5d9ccf05416dae603c195edc335d7b522dcf8c5d
Reviewed-on: https://gerrit.libreoffice.org/72102
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Solved by adding additional shape filling whole diagram.
MS PowerPoint does the same when converting SmartArt to shapes.

Background shape is also copied when loading from drawingML fallback,
appearently there is no background information.

Corrected SmartArt import tests, so that they are aware of extra shape.

Change-Id: I6154f8e1b34e5867ab582d6fc54459c7c93edbac
Reviewed-on: https://gerrit.libreoffice.org/72012
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

To test the patch , cherry pick this icon-patch first
https://gerrit.libreoffice.org/#/c/72082/

Change-Id: I706aee5695a2e275095832070382a9def4d89611
Reviewed-on: https://gerrit.libreoffice.org/72107Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I468108c74480e61215a85232421e8ce1a00e846d
Reviewed-on: https://gerrit.libreoffice.org/72058
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7bc0c6554b4d5e870a49740b2b7243d9a9246ca8
Signed-off-by: Aurimas Fišeras <aurimas@members.fsf.org>
Reviewed-on: https://gerrit.libreoffice.org/72063
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Icc3b4daa50305da0d74f63647c98b887df210a10
Reviewed-on: https://gerrit.libreoffice.org/72078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

not before vowels with a consonant sound so its a url not an url

Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2
Reviewed-on: https://gerrit.libreoffice.org/72062Reviewed-by: Jens Carl <j.carl43@gmx.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iccea3b686b02e03552fa5c836ee5a29103930d04
Reviewed-on: https://gerrit.libreoffice.org/72056
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Regression from
    commit 7282014e
    Date:   Fri Feb 1 15:15:16 2019 +0100
    tdf#50916 Makes numbers of columns dynamic.

Change-Id: Ibc96c36675d8b530b84f9680654f7d8a3b612d9c
Reviewed-on: https://gerrit.libreoffice.org/72053
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I04289589196ac69b31f75989d9252c79d03c890f
Reviewed-on: https://gerrit.libreoffice.org/71633
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Currently we detect a graphic format in a ImpPeekGraphicFormat
method, which is called when reading a graphic from a stream.
The code is quite convoluted and doesn't help with readability
of graphicfilter.cxx

Additionally there exists an detection code written for the UNO
class GraphicDescriptor, which duplicates the detection, but can
in addition also extract other metadata at the same time.

This introduces the initial implementation of GraphicFormatDetector
class. It will first replace the code in ImpPeekGraphicFormat
to detect the graphic format and then later also be extended to
do what the GraphicDescriptor is doing. But currently it only
duplicates the implementation of ImpPeekGraphicFormat.

The problem with both of the current solution is that there are
not any tests written. For the GraphicFormatDetector however the
approach is to add test cases to check the current implementation
and only then refactor the code.

Change-Id: Idb9d3859b4380e3f15237d97aff969ce81e631dd
Reviewed-on: https://gerrit.libreoffice.org/72086
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Replace OSL_VERIFY with if-statement and SAL_WARN.

Change-Id: Iafbd8869b97d098c2aa073a84850907b232c1eca
Reviewed-on: https://gerrit.libreoffice.org/72087
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I13c4916b951d36ea5e83e52c9c6e36df552bdfeb
Reviewed-on: https://gerrit.libreoffice.org/71961
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

The case when a fly frame was first constructed with one direction then
switched to btlr was already working.

The case when the direction is already set before the SwFlyFrame is
constructed was not, as SvxFrameDirection::Vertical_LR_BT was unhandled.

Change-Id: I97d15b3fc15ee116181718144dc9bccf8f31529f
Reviewed-on: https://gerrit.libreoffice.org/72077
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

...at which point MutexContainer becomes all-inline and need no longer be
OOO_DLLPUBLIC_CHARTTOOLS

Change-Id: I2f9c089a1189cc8c0fe5cf1760f62e71c5bb7f51
Reviewed-on: https://gerrit.libreoffice.org/72052
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I2bcfb87f687355a66a8a855b2858220cf1fefd39
Reviewed-on: https://gerrit.libreoffice.org/72043
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie4a5401e9f20e4fd5fe8a30ba21faffc2aa69010
Reviewed-on: https://gerrit.libreoffice.org/72085
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I8330d5817ac41a2a1e2d19714ca04b3e7830a7a5
Reviewed-on: https://gerrit.libreoffice.org/72083
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2520efb92e4aef399b684262e0b7daa72d212598
Reviewed-on: https://gerrit.libreoffice.org/72073
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia91e8d470729fff3f34e5f244a7e19359433a2ee
Reviewed-on: https://gerrit.libreoffice.org/72068
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id8d84ddebdb909583bfb136747374c0500c080e5
Reviewed-on: https://gerrit.libreoffice.org/72067
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie301b24043131f28d36d2a22a31d96220de791ae
Reviewed-on: https://gerrit.libreoffice.org/72082Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Turn standard button translatable.

Change-Id: I042846b0377adade66eb9bb8b4a3b3bef829a9f4
Reviewed-on: https://gerrit.libreoffice.org/72061
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Polar handles of preset custom shapes from OOXML import have shown
the error, that handles are jumping or not movable or direction of
handle movement was opposite to change of shape outline. Reason
was that for backwards calculation a single method was used. But
the meaning of the adjustment value is special to the handle and
thus the backwards calculation too.

Change-Id: Ia57b07ddc23efeb32ba569ce84d47b535e801750
Reviewed-on: https://gerrit.libreoffice.org/71831
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

since...

SOSAW080: Added first bunch of basic changes to helpers
commit dfefe448
Date:   Thu Mar 1 15:54:32 2018 +0100

Change-Id: I9feba16b5efdbec5c817bebf2772e2f2882bdfe9
Reviewed-on: https://gerrit.libreoffice.org/72054
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Otherwise the LOK notifiers won't be released (since LOK is not active),
and we leak vcl::Windows in GetLOKWindowsMap()::s_pLOKWindowsMap.

In dbgutil builds, this leads to an assertion failure if the sidebar is
active.

Change-Id: Idedb9578478ff4a9f2e17c0cfd203da6f007bdbd
Reviewed-on: https://gerrit.libreoffice.org/72065Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Ia3ad578f72fa82f0693c7eef34a43261e4efb878
Reviewed-on: https://gerrit.libreoffice.org/72060
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

* Update translations from branch 'master'
  - Updated Slovenian translation
    
    Change-Id: I225234d2e88989d0352be55860dcd1cd944dbcef
    

...no need for virtual dtor

Change-Id: I843e4bbb8bab3ed1eec55be2b937617175911162
Reviewed-on: https://gerrit.libreoffice.org/72049
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I028a34626f4e542d01f6ae7cd90fed5a24ad970d
Reviewed-on: https://gerrit.libreoffice.org/72044
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Replace OSL_VERIFY with if-statement and SAL_WARN.

Change-Id: Ibeef67f21dc9e18d3bc614cb838a6188bb58fff2
Reviewed-on: https://gerrit.libreoffice.org/72025
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

since

commit c2f1c68f
Date:   Fri Apr 19 23:15:53 2019 +0530

    tdf#122590: follow-up : import x14:cfRule priorities

Fix is to import the priorities for iconSet x14:cfRule too.

Thanks to Caolán McNamara for notifying me about the regression.

Change-Id: Ib5b703a6911ab6480d42ac1e004a144043d3ad24
Reviewed-on: https://gerrit.libreoffice.org/72035
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>