1. 27 Nis, 2015 10 kayıt (commit)
  2. 26 Nis, 2015 8 kayıt (commit)
  3. 25 Nis, 2015 22 kayıt (commit)
    • Michael Stahl's avatar
      sw: same treatment for SwCursor's fake "copy constructor" · c23dd470
      Michael Stahl yazdı
      Change-Id: Id627274ca6ad87e7e85b5ce64419ed68a5d4c9c3
      c23dd470
    • Michael Stahl's avatar
      sw: replace SwPaM's so-called "copy constructor" · bdf3c9bf
      Michael Stahl yazdı
      Make explict that it links the new SwPaM into a Ring, by adding a 2nd
      parameter for the Ring.
      
      Change-Id: I8ac0bb1a8bede8b67a3a8874cf805bd88aad2819
      bdf3c9bf
    • Michael Stahl's avatar
      rhbz#1205072: sw: resource mangement SNAFU caused by SwPaM copy ctor · c55599fd
      Michael Stahl yazdı
      SwPaM copy ctor has the surprising habit of linking the new one into the
      old one's Ring.  If you copy a shell cursor, *this* epic fail happens:
      
      ==948== Thread 6 SelectionManager:
      ==948== Invalid free() / delete / delete[] / realloc()
      ==948==    at 0x4A07CE9: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
      ==948==    by 0x222F542B: SwPaM::operator delete(void*, unsigned long) (in /libreoffice-4-3/instdir/program/libswlo.so)
      ==948==    by 0x2239E20E: SwPaM::~SwPaM() (pam.cxx:422)
      ==948==    by 0x22368630: CheckRange(SwCursor*) (crsrsh.cxx:111)
      ==948==    by 0x2236DECC: SwCrsrShell::UpdateCrsr(unsigned short, bool) (crsrsh.cxx:1397)
      ==948==    by 0x22369113: SwCrsrShell::EndAction(bool) (crsrsh.cxx:290)
      ==948==    by 0x2268971F: SwEditShell::EndAllAction() (edws.cxx:87)
      ==948==    by 0x2262BEF3: SwBaseLink::DataChanged(rtl::OUString const&, com::sun::star::uno::Any const&) (swbaslnk.cxx:274)
      ==948==    by 0x2262C78E: SwBaseLink::SwapIn(bool, bool) (swbaslnk.cxx:411)
      ==948==    by 0x227102EC: SwGrfNode::SwapIn(bool) (ndgrf.cxx:539)
      ==948==    by 0x227121BC: SwGrfNode::MakeCopy(SwDoc*, SwNodeIndex const&) const (ndgrf.cxx:999)
      ==948==    by 0x22610E4D: SwNodes::_CopyNodes(SwNodeRange const&, SwNodeIndex const&, bool, bool) const (nodes.cxx:1862)
      ==948==    by 0x225B98E0: SwDoc::CopyWithFlyInFly(SwNodeRange const&, int, SwNodeIndex const&, SwPaM const*, bool, bool, bool) const (ndcopy.cxx:1336)
      ==948==    by 0x224AC1FF: SwDoc::CopyLayoutFmt(SwFrmFmt const&, SwFmtAnchor const&, bool, bool) (doclay.cxx:446)
      ==948==    by 0x2294D2D4: SwTxtFlyCnt::CopyFlyFmt(SwDoc*) (atrflyin.cxx:130)
      ==948==    by 0x229A5B96: MakeTxtAttr(SwDoc&, SfxPoolItem&, int, int, CopyOrNew_t, SwTxtNode*) (thints.cxx:1060)
      ==948==    by 0x229A64E6: SwTxtNode::InsertItem(SfxPoolItem&, int, int, unsigned short) (thints.cxx:1224)
      ==948==    by 0x2298E536: SwTxtNode::CopyText(SwTxtNode*, SwIndex const&, SwIndex const&, int, bool) (ndtxt.cxx:1773)
      ==948==    by 0x2298DC08: SwTxtNode::CopyText(SwTxtNode*, SwIndex const&, int, bool) (ndtxt.cxx:1555)
      ==948==    by 0x225B4C9D: SwTxtNode::MakeCopy(SwDoc*, SwNodeIndex const&) const (ndcopy.cxx:286)
      ==948==    by 0x22610E4D: SwNodes::_CopyNodes(SwNodeRange const&, SwNodeIndex const&, bool, bool) const (nodes.cxx:1862)
      ==948==    by 0x223EF3C2: SwNodes::_Copy(SwNodeRange const&, SwNodeIndex const&, bool) const (ndarr.hxx:182)
      ==948==    by 0x225B5D8D: SwTableNode::MakeCopy(SwDoc*, SwNodeIndex const&) const (ndcopy.cxx:475)
      ==948==    by 0x22610ACA: SwNodes::_CopyNodes(SwNodeRange const&, SwNodeIndex const&, bool, bool) const (nodes.cxx:1790)
      ==948==    by 0x223EF3C2: SwNodes::_Copy(SwNodeRange const&, SwNodeIndex const&, bool) const (ndarr.hxx:182)
      ==948==    by 0x225CA663: SwSectionNode::MakeCopy(SwDoc*, SwNodeIndex const&) const (ndsect.cxx:1270)
      ==948==    by 0x22610BFC: SwNodes::_CopyNodes(SwNodeRange const&, SwNodeIndex const&, bool, bool) const (nodes.cxx:1817)
      ==948==    by 0x223EF3C2: SwNodes::_Copy(SwNodeRange const&, SwNodeIndex const&, bool) const (ndarr.hxx:182)
      ==948==    by 0x225CA663: SwSectionNode::MakeCopy(SwDoc*, SwNodeIndex const&) const (ndsect.cxx:1270)
      ==948==    by 0x22610BFC: SwNodes::_CopyNodes(SwNodeRange const&, SwNodeIndex const&, bool, bool) const (nodes.cxx:1817)
      ==948==    by 0x223EF3C2: SwNodes::_Copy(SwNodeRange const&, SwNodeIndex const&, bool) const (ndarr.hxx:182)
      ==948==    by 0x225CA663: SwSectionNode::MakeCopy(SwDoc*, SwNodeIndex const&) const (ndsect.cxx:1270)
      ==948==    by 0x22610BFC: SwNodes::_CopyNodes(SwNodeRange const&, SwNodeIndex const&, bool, bool) const (nodes.cxx:1817)
      ==948==    by 0x225B98E0: SwDoc::CopyWithFlyInFly(SwNodeRange const&, int, SwNodeIndex const&, SwPaM const*, bool, bool, bool) const (ndcopy.cxx:1336)
      ==948==    by 0x225B8F15: SwDoc::CopyImpl(SwPaM&, SwPosition&, bool, bool, SwPaM*) const (ndcopy.cxx:1239)
      ==948==    by 0x225B6EE0: SwDoc::CopyRange(SwPaM&, SwPosition&, bool) const (ndcopy.cxx:707)
      ==948==    by 0x22667E69: SwEditShell::_CopySelToDoc(SwDoc*, SwNodeIndex*) (edglss.cxx:244)
      ==948==    by 0x226C8400: SwFEShell::Copy(SwDoc*, rtl::OUString const*) (fecopy.cxx:214)
      ==948==    by 0x22DBF72B: (anonymous namespace)::lclOverWriteDoc(SwWrtShell&, SwDoc&) (swdtflvr.cxx:373)
      ==948==    by 0x22DBFBC6: SwTransferable::GetData(com::sun::star::datatransfer::DataFlavor const&, rtl::OUString const&) (swdtflvr.cxx:439)
      ==948==    by 0x7CB36C7: TransferableHelper::getTransferData2(com::sun::star::datatransfer::DataFlavor const&, rtl::OUString const&) (transfer.cxx:332)
      ==948==    by 0x7CB34B5: TransferableHelper::getTransferData(com::sun::star::datatransfer::DataFlavor const&) (transfer.cxx:306)
      ==948==    by 0x17A7E949: x11::SelectionManager::convertData(com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&, unsigned long, unsigned long, int&, com::sun::star::uno::Sequence<signed char>&) (X11_selection.cxx:655)
      ==948==    by 0x17A823CA: x11::SelectionManager::sendData(x11::SelectionAdaptor*, unsigned long, unsigned long, unsigned long, unsigned long) (X11_selection.cxx:1503)
      ==948==    by 0x17A82E03: x11::SelectionManager::handleSelectionRequest(XSelectionRequestEvent&) (X11_selection.cxx:1729)
      ==948==    by 0x17A8A08A: x11::SelectionManager::handleXEvent(_XEvent&) (X11_selection.cxx:3574)
      ==948==  Address 0x21e31a60 is on thread 6's stack
      ==948==  in frame #40, created by SwEditShell::_CopySelToDoc(SwDoc*, SwNodeIndex*) (edglss.cxx:158)
      
      (regression from 49505336)
      
      Change-Id: I3d0a288a83b4719dda7977b4898dea656ea67388
      c55599fd
    • Michael Stahl's avatar
      gbuild: CppunitTest: allow specifying arguments with CPPUNITTEST_ARGS · 1b6be726
      Michael Stahl yazdı
      Change-Id: Ied595f97c2a6501a7e80a378a474689c43ad60d9
      1b6be726
    • Michael Stahl's avatar
      sw: remove more SwAccessibleContext code that... · 77de4200
      Michael Stahl yazdı
      ... looks related to some non-existent "async loading" feature.
      
      Change-Id: I99eaad92ce7f98e65c491e9862bed505ce1aa9fc
      77de4200
    • Michael Stahl's avatar
      sw: remove SwAccessibleDocument XEventListener buggy dead code · 1d2244ec
      Michael Stahl yazdı
      This was added with IA2, but evidently it's dead - the listener is never
      registered at the broadcaster.  Also the first of the events it is
      listening for does not exist, and the others are actually called
      "OnLoadFinished" and "OnLayoutFinished".
      
      Also remove the "isIfAsynLoad" [sic] member.
      
      Change-Id: Ib261c193289e415af91b3097c525e90ef051f824
      1d2244ec
    • Michael Stahl's avatar
      sw: prefix members of SwAccessibleContext · 8c7928b6
      Michael Stahl yazdı
      Change-Id: Ie5cb2d9819fcb4b22b596a0ba407043d9d80db7d
      8c7928b6
    • Michael Stahl's avatar
      sw: deploy some asserts · 5ce7572e
      Michael Stahl yazdı
      Change-Id: I7bb6820c2ad46f6822dc1f153ae25fd55a1f674b
      5ce7572e
    • Michael Stahl's avatar
      sw: simplify and remove special case in SwHTMLParser::AddParSpace() · bcf42665
      Michael Stahl yazdı
      Change-Id: Ia64935bcc957cc5730f8cd67ec374c548a46b531
      bcf42665
    • Michael Stahl's avatar
      sw: fix SwAccessibleParagraph crash on delete · 104ed86c
      Michael Stahl yazdı
      It happens that SwAccessibleParagraph::getCharacterBounds() is called
      from ATK with a clearly invalid pPortionData member; the SwTxtNode has
      no text but there are portions.
      
      This is because after a deletion both a POS_CHANGED and a
      INVALID_CONTENT event are created for the same SwAccessibleParagraph,
      and they are merged into one POS_CHANGED event by
      SwAccessibleMap::AppendEvent(), but
      SwAccessibleContext::InvalidatePosOrSize() returns early if the
      paragraph happens to not be visible, skipping the invalidation.
      
      (regression from 76c549eb, which
       removed a Dispose() call; not sure if the Dispose() is needed here)
      
      Change-Id: I985e9a439ee6c7024963eace876186f2247b9e03
      104ed86c
    • Michael Stahl's avatar
      remove some @author tags from suspiciously unidiomatic code · deb50a2a
      Michael Stahl yazdı
      Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
      deb50a2a
    • Caolán McNamara's avatar
      gtk3: honour the control region height if it is larger · a57309fe
      Caolán McNamara yazdı
      Change-Id: I99a5a597dbc14521b27f9149411199d23b907c1e
      a57309fe
    • Lionel Elie Mamane's avatar
      tdf#90614 oups... I was too eager in replacing getAny() with makeAny() · 062c3afd
      Lionel Elie Mamane yazdı
      also handle the SQLNULL case
      
      Change-Id: Ie7fffd6b46ed8b3dfa7231928f55743f71d2ea98
      062c3afd
    • Caolán McNamara's avatar
      gtk3: get the right height for Combo boxes · ed3c6958
      Caolán McNamara yazdı
      Change-Id: Ib856952572104d224cd731237bf7c33d028e6544
      ed3c6958
    • Markus Mohrhard's avatar
      add test for tdf#88848 · 3aec78ed
      Markus Mohrhard yazdı
      Change-Id: I1ad26038db7ee386d7d6dc333e29845753ab8ec3
      3aec78ed
    • Markus Mohrhard's avatar
      support manualLayout for legends OOXML export, tdf#88848 · 0afab16d
      Markus Mohrhard yazdı
      Change-Id: If7ac2a2294e20617fd8b599597085658051f5515
      0afab16d
    • Miklos Vajna's avatar
      writerfilter: remove remaining doctok bits from TablePropertiesHandler · 8166244e
      Miklos Vajna yazdı
      Change-Id: I61d1907a8c3a53c526992cc615478ee57a097fb6
      Reviewed-on: https://gerrit.libreoffice.org/15528Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      Tested-by: 's avatarJenkins <ci@libreoffice.org>
      8166244e
    • Yousuf Philips's avatar
      Add missing info of page number statusbar field in writer · b1143c0e
      Yousuf Philips yazdı
      Change-Id: I98ad97629f8984a24fc4ed9e6238e391c8bfa008
      Reviewed-on: https://gerrit.libreoffice.org/15525Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
      b1143c0e
    • Adolfo Jayme Barrientos's avatar
      tdf#90252 Add missing Asian slide layout icons in new Tango style · 8e18b142
      Adolfo Jayme Barrientos yazdı
      Change-Id: I998dd54a4c45c48d39df297211610206816099a8
      8e18b142
    • Markus Mohrhard's avatar
      add test for plotArea manualLayout, tdf#90851 · 967b8c33
      Markus Mohrhard yazdı
      Change-Id: I18ac4e702a7ef4a2d9dbb4ba7d0ece1e69c7e379
      967b8c33
    • Markus Mohrhard's avatar
      and in the chart tests · 8ccb2c0e
      Markus Mohrhard yazdı
      Change-Id: I1ed69bb1c09982e8d0964a700da9b22b66af82f8
      8ccb2c0e
    • Markus Mohrhard's avatar
      do the same in the source file · 8536af34
      Markus Mohrhard yazdı
      Change-Id: I087d5da6280d889e1e155559edf9c70c5c5ffaba
      8536af34