1. 26 Ock, 2016 16 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:nullptr · f94a7768
      Stephan Bergmann yazdı
      Change-Id: Ic8e7a7c0f6f40521dfb20ebf4ef11f2776c0cde8
      f94a7768
    • Stephan Bergmann's avatar
      -Werror,-Winconsistent-missing-override · c55c469e
      Stephan Bergmann yazdı
      Change-Id: I254c7a4b6f822c71b3ad5150cf674d25defbf1ed
      c55c469e
    • Stephan Bergmann's avatar
      Replace salhelper::SingletonRef with rtl::Static · 7d9ac365
      Stephan Bergmann yazdı
      When destroying the static vcl::CommandInfoProvider aProvider from
      vcl::CommandInfoProvider::Instance (vcl/source/helper/commandinfoprovider.cxx)
      during exit, it releases its mxCachedGlobalAcceleratorConfiguration reference on
      GlobalAcceleratorConfiguration
      (framework/source/accelerators/globalacceleratorconfiguration.cxx), which may
      get destroyed, whose base class framework::XCUBasedAcceleratorConfiguration
      (framework/source/inc/accelerators/acceleratorconfiguration.hxx) has a
      salhelper::SingletonRef<framework::KeyMapping> member, whose destructor
      (include/salhelper/singletonref.hxx) uses
      salhelper::SingletonRef<framework::KeyMapping>::SingletonLockInit::operator ()'s
      static osl::Mutex aInstance.
      
      If, during construction, the instantiation of
      salhelper::SingletonRef<framework::KeyMapping>::SingletonLockInit::operator ()'s
      static osl::Mutex aInstance finishes before the instantiation of
      vcl::CommandInfoProvider::Instance's static vcl::CommandInfoProvider aProvider,
      the corresponding atexit cleanup actions will be recorded in the right order,
      causing the above chain of calls to find the static Mutex still alive when used
      from within the static CommandInfoProvider's destruction.
      
      However, vcl::CommandInfoProvider's mxCachedGlobalAcceleratorConfiguration is
      only set to css::ui::GlobalAcceleratorConfiguration::create in
      vcl::CommandInfoProvider::GetGlobalAcceleratorConfiguration, so the
      instantiation of the static Mutex instance can finish after the instantiation of
      the static CommandInfoProvider instance, recording the atexit cleanup actions in
      the wrong order, causing the static Mutex to be used after destruction.
      
      This occasionally caused PythonTest_sfx2_python to hang during exit for me on
      Linux, where trying to lock a destroyed pthread mutex can apparently deadlock.
      
      rtl::Static does away with the need to do anything in the destructor, at the
      expense of always keeping the instance alive until exit (and not being able to
      recreate an already destroyed instance during exit, but code that would require
      that behavior would probably already be broken to begin with), so the order of
      creation of the CommandInfoProvider and GlobalAcceleratorConfiguration instances
      becomes less of a concern.
      
      Change-Id: Id6e3860ad9e5b7045980a0b9bf9eaef2e24129bb
      7d9ac365
    • Caolán McNamara's avatar
      Related: tdf#93054 gtk3: implement enough dnd to be dragged into... · 0b354d18
      Caolán McNamara yazdı
      from another application, e.g. text from gedit or a standalone
      image (view image) from firefox
      
      Change-Id: I68b82217eb2513cedc096f5ff653fb7c75b48052
      0b354d18
    • Miklos Vajna's avatar
      tdf#76142 libxmlsec: extend SHA-256 support in the NSS backend · 93fdb8dc
      Miklos Vajna yazdı
      With this, the xmlSecTransformIdListFindByHref() call in
      xmlSecTransformNodeRead() recognizes the
      http://www.w3.org/2001/04/xmldsig-more#rsa-sha256 string as a valid
      signature method as well. Previously SHA-256 was recognized as a digest
      method only.
      
      Change-Id: Ib20ab97dd5bc86dff761f0c58a87afdde112e1e8
      93fdb8dc
    • Miklos Vajna's avatar
      tdf#95376 DOCX import: fix incorrectly indented tab stops · 3915bf2d
      Miklos Vajna yazdı
      Regression from commit f4badd9a
      (tdf#92454 DOCX import: allow overriding para prop from num style in
      para style, 2015-09-22), the problem was yet another priority
      mishandling in the maze of various styles and indentation handling.
      
      In the tdf#92454 bugdoc, both a numbering-from-paragraph-style and a
      paragraph-style defined indentation, and Word preferred the numbering,
      while Writer preferred the paragraph style, that's why the import-time
      conversion was added.
      
      However, it turns out there is a 3rd source that's still not direct
      indentation formatting: a direct numbering. So the correct priority is:
      
      direct-ind > ind-from-num > ind-from-parastyle > ind-from-num-from-parastyle
      
      Which means in this case the indentation should not be set directly: the
      two conflicting value (ind-from-num and ind-from-parastyle) will be
      resolved correctly by Writer core.
      
      Given that we always first get the para style info, and only then the
      numbering, we just need to undo the conversion added for the other bug
      if we see a direct numbering, then both the old bugdoc and this new one
      will be handled properly.
      
      Change-Id: I09cc84605d5df6159da985ad069d46b580a53358
      3915bf2d
    • Christian Lohmaier's avatar
      Updated core · 09e46424
      Christian Lohmaier yazdı
      Project: help  184121fb7abffe19012e3a64187281f0332a4b20
      
      lists cannot be nested directly - use hackaround using switch instead
      
      Change-Id: I9a39112dbaca103ddb6b2783b5a142b280fbba8b
      09e46424
    • Tor Lillqvist's avatar
      Put getBufferSwapCounter() in OpenGLWindow instead · 32d98b25
      Tor Lillqvist yazdı
      <vcl/openglwin.hxx> is a more light-weight include file and including
      that causes less trouble on the various platforms.
      
      Change-Id: I5c9baa171278d291468ef45a47d9fdbc64326957
      32d98b25
    • Tor Lillqvist's avatar
      Add API to get the number of OpenGL buffer swaps, including through UNO · 2c552883
      Tor Lillqvist yazdı
      Change-Id: Iff29ac615ad4b6516790b1cbbde0215a3cd0efe6
      2c552883
    • Xisco Fauli's avatar
      SVGIO: Fix issue when font size is in percentage and ... · 7c151f39
      Xisco Fauli yazdı
      ... there's no parent style set
      
      Sample:
      <?xml version="1.0" encoding="UTF-8"?>
      <svg height="600" width="400"
      xmlns="http://www.w3.org/2000/svg"
      xmlns:xlink="http://www.w3.org/1999/xlink"
      font-size="100%">
      <text x="5" y="15">Sample 1</text>
      </svg>
      
      Change-Id: Iec88c148475bf8a610286414083e9801faaf8d78
      Reviewed-on: https://gerrit.libreoffice.org/21553Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      7c151f39
    • Stephan Bergmann's avatar
      loplugin:defaultparams · 3bd5a251
      Stephan Bergmann yazdı
      Change-Id: I592b8f678288c1229e66abb98f6bb5f865f177a0
      3bd5a251
    • Stephan Bergmann's avatar
      loplugin:defaultparams · 5614bcb6
      Stephan Bergmann yazdı
      Change-Id: I4c80f7055ccb9979bfb89cf9139561287d9659a4
      5614bcb6
    • Tor Lillqvist's avatar
      Bin some unneeded 'using' and includes · 526b0a56
      Tor Lillqvist yazdı
      Change-Id: Ia91b3837ce39ae48e8c660274a08415ee4f9e5c7
      526b0a56
    • Tor Lillqvist's avatar
      Bin leftover cruft · 478e2ad4
      Tor Lillqvist yazdı
      Change-Id: I15a4237a1ab6d7c180b52c3f8d2834c0e034b7db
      478e2ad4
    • Noel Grandin's avatar
      fix windows build · 6b232aee
      Noel Grandin yazdı
      after commit c43fdd74
      "vcl: GF_VERT is *only* for Windows implementations"
      
      Change-Id: I8f500c0e9accc781a57ab4057eea9d077f418696
      6b232aee
    • Giuseppe Castagno's avatar
      Add initial cppunit test to webdav, 'local' only, neon version · 1f9f1fe3
      Giuseppe Castagno yazdı
      This is a 'local' test, meaning it can be done without a
      WebDAV server.
      
      It's the first one, so very trivial...
      
      Change-Id: Idf660c7482c86251be02536106f079ac6bdef4b4
      Reviewed-on: https://gerrit.libreoffice.org/21658Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarMarkus Mohrhard <markus.mohrhard@googlemail.com>
      1f9f1fe3
  2. 25 Ock, 2016 24 kayıt (commit)