Change-Id: I0192a431f79a46fa17b214fb9c978ec0215f061c
Reviewed-on: https://gerrit.libreoffice.org/53123Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Iec4fa3afb1e90ec36f792ea65b8c57b11cff98b3
Reviewed-on: https://gerrit.libreoffice.org/53094Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib654539cca64efe479cf3c9b8b585ab17019edeb
Reviewed-on: https://gerrit.libreoffice.org/53117Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

There is only a few files now where HIDs are set from code
so no need to include helpids.h into the widely used sc.hrc

Change-Id: Id7c9ef7fdf299c580f597e4c27ba8bece3d99f5d
Reviewed-on: https://gerrit.libreoffice.org/53076Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

not only when we let the *user* set it in the "Advanced Settings" dialog.

There are two notions:
1) Does the driver/datasource support a property
2) Do we show the user any UI in "Advanced Settings" to change that
   property.

Notion 2 is called a _Feature_, notion 1 a _property_.

Database creation was saving properties only in case 2; the right
test is obviously case 1.

Change-Id: Ie740c9eb6768ae5f412a49119201e9211a9cd07d
Reviewed-on: https://gerrit.libreoffice.org/53121Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Id865c864d175e31de49b8eb62df8b6ca144fd50c
Reviewed-on: https://gerrit.libreoffice.org/53104Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

By switching to HtmlWriter instead of manually constructing HTML
elements / attributes.

Also fix a validity problem for ReqIF (transitional XHTML still allows
that, so not depending on mbXHTML here).

Change-Id: I4f3fef781fdbb4c72824701ad6d380cece8e6f81
Reviewed-on: https://gerrit.libreoffice.org/53120Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I4247b86cdbe332bd6c529b075174e3657fbfa9e1
Reviewed-on: https://gerrit.libreoffice.org/53090Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Change-Id: Ic12eebe62de5132dce26ec46c62501f90200b909
Reviewed-on: https://gerrit.libreoffice.org/52180Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I20ea4b43c1cbf5a79a1d52c0c8c27018b003411b
Reviewed-on: https://gerrit.libreoffice.org/53101Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

During the gla11y work, the dependency of UIA rules on the .ui files
got lost, this adds it so that modifying a .ui file triggers checking
accessibility with gla11y.

Change-Id: I62103ca1783c2f532d7647384c1add1b557b37a1
Reviewed-on: https://gerrit.libreoffice.org/53116Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

...which f247f08e "Upgrade to ICU 61.1" had
removed completely, in error.

Change-Id: I7239011561851333cac58e54e4e7d590b8529dbc

At least in sw unit tests, AddToRecentDocumentList is apparently called
too early so the variable isn't set yet.

It's much better to check IsHeadlessMode anyway because that is set in
more situations, and if you run soffice --headless you probably don't
want the corresponding files to show up in Explorer's Recently list.

Change-Id: I8ada3659d05c94d072ba30859090e835a595e9ea
Reviewed-on: https://gerrit.libreoffice.org/53100Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I0eb57c1c2e4fe53906ecf9da1d4841bbc250c4e5

this story started in
    commit  433fc221 (patch)
    sal_uIntPtr->sal_Int32 in MultiSelection
which caused a regression, reported in tdf#116981.
I attempted to fix it in
    commit 235d61890512894e27f4f81e38a325eee3c67b30
    Date:   Fri Apr 13 17:14:59 2018 +0200
    tdf#116981 Base when deleting table column
and
    commit 0973e1f4
    Date:   Mon Apr 16 08:28:16 2018 +0200
    follow on for tdf#116981

But my analysis was wrong.

To recap, and get it right:

Before all this, MultiSelection stored it's values internally as
sal_uIntPtr, but returned them as long in FirstSelected(),
NextSelected(),and SFX_ENDOFSELECTION was defined to be ULONG_MAX.
On 64-bit Linux, sal_uIntPtr is typedefed to sal_uInt64, and ULONG_MAX
is 2^64, which means that previously, the SFX_ENDOFSELECTION value was
being converted from 2^64 to -1 when it was returned, which was why
these loops worked.

So convert SFX_ENDOFSELECTION to -1 to match how how the external code
wants it to be (and the code frequently uses -1 instead of
SFX_ENDOFSELECTION or BROWSER_ENDOFSELECTION)

The modification to MultiSelection::Select is necessary because
previously, nCurMin and nCurMax would be == ULONG_MAX,
and we would, somewhat unintuitively, end up in the
    // expand on left side?
    if( nTmpMax < nCurMin )
part of the logic, which would do the right thing, even if a little
weirdly.

Change-Id: I7c830b0392add394d8c294247f75a2ffe8017c24
Reviewed-on: https://gerrit.libreoffice.org/53022Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I86cc48d74f0572a7ba18beabbaf307bcaa069d38
Reviewed-on: https://gerrit.libreoffice.org/53087Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I4766fc874026f218b33e66944b98562d1ec614d3
Reviewed-on: https://gerrit.libreoffice.org/53088Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

On Windows 10, Explorer spends ridiculous amounts of CPU with updating
its recent documents view while tests are running.

Change-Id: I170306a392900fc4b911950e36f13f1af0e405ac
Reviewed-on: https://gerrit.libreoffice.org/53058Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I0cc3104cfccebe5d7e3fcafdb71d73a9d8d5e3d8

Change-Id: I89c1c3d13d85decc72576744de2a16d20471d29d
Reviewed-on: https://gerrit.libreoffice.org/53064Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: Ie95fbc1586e11396271fb43e6117f39f4f61cb0e
Reviewed-on: https://gerrit.libreoffice.org/53086Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

https://github.com/google/oss-fuzz/issues/1335

Change-Id: I7681413d5e45e1e2f1ff62a077a067b11e42b4bb
Reviewed-on: https://gerrit.libreoffice.org/53082Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Rather than the hardcoded HTML_DFLT_IMG_WIDTH / HTML_DFLT_IMG_HEIGHT
defines.

Change-Id: I4ed2207ce3fdcd247054941d91eb67a679fb370c
Reviewed-on: https://gerrit.libreoffice.org/53081Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

The header fails to compile without C++11 with recent Clang, and although
configure currently passes the check because the existence of the header
is considered to be enough, it still prints a distracting error message
about the compile check failing.

Change-Id: Icf037114b73122f193629e17a8e2b0e2bca3a990

Change-Id: Ia4733366338ceda7af4ee26914be38798b8c7e16
Reviewed-on: https://gerrit.libreoffice.org/53079Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Idd581cb73d0d32d808177f86beaf50dcc6bf53c1
Reviewed-on: https://gerrit.libreoffice.org/53053Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

The page header and footer panels were completely missing labelling

The "Custom" label is actually used a a resource, suppress the labelling
warning for it.

Change-Id: I3ca6b1984fab23478a11e916f26702592a5ee991
Reviewed-on: https://gerrit.libreoffice.org/52948Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

The page style panel was completely missing labelling.

The "Custom" label is actually used a a resource, suppress the labelling
warning for it.

Change-Id: I741ddea4a1608f0d7084dda79af2ab59a6fc5812
Reviewed-on: https://gerrit.libreoffice.org/52947Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

The page format panel was completely missing labelling.

The "Custom" label is actually used a a resource, suppress the labelling
warning for it.

Change-Id: I1c026f7a743b5da45f244d2527ab2b66165ccd4a
Reviewed-on: https://gerrit.libreoffice.org/52946Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

this helps chart sidebar to identify them by name when switching
between different kinds of fill types. Also prep work for tdf#113688

Change-Id: I7cb148562cfa50704f27fa3273d93941eb01a7ab
Reviewed-on: https://gerrit.libreoffice.org/52961Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I03688ec1d869720b4a042602ff1da15727174592
Reviewed-on: https://gerrit.libreoffice.org/53046Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

There was a minor bug in the compat flag, leading
to a regression from commit 8d62b79f

Change-Id: I1e468e665a583ef15b6e474c3adb32f1dcf98f46
Reviewed-on: https://gerrit.libreoffice.org/52674Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Found by searching for the header names and the localization functions:
git grep -l -e \<sfx2/sfxresid.hxx\> -e \<sfx2/strings.hrc\> | xargs grep -c -e SfxResId -e GetResString | grep :0$ | grep -v /pch

Change-Id: If0571ae4029b5fb2699cdd6ea768d3cd240bdce3
Reviewed-on: https://gerrit.libreoffice.org/53073Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Found by searching for the header names and the localization function:
git grep -l -e \<editeng/eerdll.hxx\> -e \<editeng/editrids.hrc\> | xargs grep -c EditResId | grep :0$ | grep -v /pch

Change-Id: Ic542ceee09352cb52dcdc9780d4cb1890e02f383
Reviewed-on: https://gerrit.libreoffice.org/53062Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

In Windows, filesystem redirectors can map WebDAV resources to UNC
paths, or to drive-based "local" paths; so a WebDAV URI of the form
"http://WebDADServer/root/directory/File.ext" may be accessed using
"\\WebDADServer\root\directory\File.ext" or "Z:\directory\File.ext".

When using these paths, failure to create a lockfile aside the opened
document should not be considered an error; so this patch checks for
this.

Regression from commit 6ca3b364.

Change-Id: I1de55b66447dc91d22b6d2b5b121de96bf32e4ee
Reviewed-on: https://gerrit.libreoffice.org/53070Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Idff219e1c8f18adaa0f445a5469650c7793cae3a
Reviewed-on: https://gerrit.libreoffice.org/53066Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Project: help  23665d6b04829ac2b949c88de261c6f7b2de8baa

Remove unused sourceMappingURL

Caused

  Source map error: TypeError: NetworkError when attempting to fetch resource.
  Resource URL: file:///data/sbergman/lo-clang/core/instdir/help/fuse.js
  Source Map URL: fuse.js.map

when loading

  <file:///.../instdir/help/index.html?swriter/.uno:HelpIndex?Language=en-US&System=UNIX&Version=6.1>

in the browser.

Change-Id: I5d318fe8c358cedbb961113561edea3b6d4a2ce1
Reviewed-on: https://gerrit.libreoffice.org/53077Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ibba26b0eb3d85f2da3caafa1b8cc60357de297d5

Change-Id: I7f75c835339b61ba9e545c13d7e5bb208c12df4c
Reviewed-on: https://gerrit.libreoffice.org/53069Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I77a49d55dd49b0fd41f5335ac30a5484ac130250
Reviewed-on: https://gerrit.libreoffice.org/53050Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>