- 09 May, 2019 16 kayıt (commit)
-
-
Miklos Vajna yazdı
For one, it seems this was the intention already since commit 85c70f37 (CWS-TOOLING: integrate CWS aw063, 2009-03-04): "suppress AntiAliasing for pure horizontal or vertical lines". For another, this fixes the TileCacheTests::testTileWireIDHandling() testcase in online.git, which assumes that the indicators at the corners of the Writer body frame (paragraph marks hidden / default case) can be painted multiple times, producing pixel-by-pixel matching results. But in reality AA breaks that assumption, and we know these indicators are never diagonal lines. Change-Id: Ib74f823165799991296b64cee58ec106dbdcedcf Reviewed-on: https://gerrit.libreoffice.org/72000Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Jan-Marek Glogowski yazdı
2nd attempt to fix the bug described in commit 00221089 ("Qt5 IM allow committing empty strings") and various siblings of it. This also reverts it. What I see is calls with "all-empty" events (preedit, commit and replacementLength() == 0; no QInputMethodEvent::Attribute), some from QIBusPlatformInputContext::updatePreeditText. There are various Writer document edit states with (selected) text, undo, cursor position and focus changes to other windows via Ctrl+Tab, which will result in inputMethodEvent calls totally in contrast to the expected text state, all somehow always related to all-empty events. They currently result in wrongly deleted selected text, change of selection, cursor movement or general change of text from old preedit. Most time on focus out / window change, some times at first meta-key press after focus in. This patch tries hard not to corrupt Writers edit state with these all-empty events. No idea if this is some bug on LO's qt5 side or expected, but KDE kate and VCL gtk3 and gen work fine, so I assume Qt's behaviour is correct. FWIW gtk3 also does some extended IM handling with focus, so probably this is the Qt equivalent of it. But then I couldn't find some eqivalent code in Qt's source code. I actually expected an even more complex solution (if this really fixes all cases). Works for a multitude of tests I tried to come up with, but is quite probably not the final fix to this, as qt5 current doesn't handle replacementStart() and replacementLength() at all. Also never saw a call to Qt5Frame::EndExtTextInput. Change-Id: I4210e0588041cfb4d80dbdfdb937e430a5f7cbfb Reviewed-on: https://gerrit.libreoffice.org/71988 Tested-by: Jenkins Reviewed-by:
Jan-Marek Glogowski <glogow@fbihome.de>
-
Justin Luth yazdı
Similar to bug 105625, the cursor should be considered outside of a fieldmark when it is at the start. A delete at the start would normally delete the entire form field, but in this case the section is supposed to be protected, so deleting should be forbidden. This atStart situation is already looked for when the document is not protected. However, when the section is already protected, then a different code path is followed, and there the start position was ignored and thus became an editable part of the page, allowing the user to easily delete the field by mistake. LO6.2's commit 63ec2e8d accurately identfied that this is in a protected section, and so exposed this missing scenario. Related idea: Also added a unit test to ensure that Protect_Form keeps protecting the formfields as well. A test document in the bug report, containing a combobox and checkbox, confirms that this fix is good for all three types of fieldmarks. Change-Id: Ida08163f3376e55c620d6670da160832e79cd252 Reviewed-on: https://gerrit.libreoffice.org/71927 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org>
-
Jens Carl yazdı
Synchronize sub menu Tools > Macros by adding "Edit Macros" across the different applications menus. Change-Id: I16185034955d889afe8a508a3522bb0a63f29545 Reviewed-on: https://gerrit.libreoffice.org/71827Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com> Tested-by:
andreas_kainz <kainz.a@gmail.com>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I89c77656ea4021cb16bd122cb1dd1cd803390c3d Reviewed-on: https://gerrit.libreoffice.org/71765 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Change-Id: Ibe4ef82cf719afd008f1be23ed4a0e953c61d73f Reviewed-on: https://gerrit.libreoffice.org/72010 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I2b5827c3f6fd7630655d4658844792462f80767e Reviewed-on: https://gerrit.libreoffice.org/72016 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Arkadiy Illarionov yazdı
Use range-based loops Change-Id: I4d3be75bb83c74267b9dec6f1dcdc105c292be9d Reviewed-on: https://gerrit.libreoffice.org/72011 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0 Reviewed-on: https://gerrit.libreoffice.org/71941 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: If7f51a657606da8aea4bcf01f13468c6ac2086a8 Reviewed-on: https://gerrit.libreoffice.org/71901 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...in preparation for another change using a top-level namespace ucb Change-Id: I3a92d64806bc570bdfd4fe06e672cb6ce2049e7e Reviewed-on: https://gerrit.libreoffice.org/71987 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Andrea Gelmini yazdı
Change-Id: I0c594c232a3004c83a33f0948593850dd924caad Reviewed-on: https://gerrit.libreoffice.org/72020Reviewed-by:
-
Tomaž Vajngerl yazdı
This is intended to replace the ImplPixelFormat in macOS and OpenGL backends, which are duplicated. It'll also come in handy for other situations in the future. Also ImplPixelFormat4 (4-bit Palette) in the macOS backend doesn't work and never has worked correctly (bug at writing). This fact was discovered while testing the ScanlineTranformer, which was based on the ImplPixelFormat* code. Change-Id: I96a172bd61c2cc116ab3e8b9f47f23f945243e96 Reviewed-on: https://gerrit.libreoffice.org/71992 Tested-by: Jenkins Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com>
-
Adrien Ollier yazdı
Change-Id: I4b4fc85024d64f94197bd0fd25ed8ba0ada004ba Signed-off-by:
Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/71807 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I88a32792c19a8d16c400dd2a189c4941149ff941 Reviewed-on: https://gerrit.libreoffice.org/72019 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
Andrea Gelmini yazdı
Change-Id: I77133378411c573dd1075d40c7e113b305b3dbba Reviewed-on: https://gerrit.libreoffice.org/72017 Tested-by: Jenkins Reviewed-by:
-
- 08 May, 2019 24 kayıt (commit)
-
-
Stephan Bergmann yazdı
...after 7764439f "WidgetDefinition: add 'action' state for the PushButton" introduced code that downcasts that suspicious ImplControlValue to a PushButtonValue Change-Id: I3ed24cc4a862d53ad5b6e95b4707bab7947ce7ba Reviewed-on: https://gerrit.libreoffice.org/71998Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: Idfefe7598df0b2e382be84aa5bfc8b60201768a7 Reviewed-on: https://gerrit.libreoffice.org/71991 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
e.g fdo58094-1.mml since... commit 13894996 Date: Sat May 4 21:46:31 2019 +0200 handle empty Rectangle better in starmath Change-Id: I01d11352b8bc9f6dcf6d6565fa41b84d549f620f Reviewed-on: https://gerrit.libreoffice.org/71963 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: I66db4b9f800eb2e3e0b81d4e8f9c2b7f742d23cf Reviewed-on: https://gerrit.libreoffice.org/71953 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ia29abf667b1d010692e89b3b8c23614a4b345669 Reviewed-on: https://gerrit.libreoffice.org/71962 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
As seen in sw/source/core/inc/layact.hxx Change-Id: Icc4281cd57b0cd8310a1044f6106691a5d1cd3c4 Reviewed-on: https://gerrit.libreoffice.org/71884 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I1c10010eb7fd33a03f477af0cba03ae74859b174 Reviewed-on: https://gerrit.libreoffice.org/71959 Tested-by: Jenkins Reviewed-by:
-
Rasmus Jonsson yazdı
Rearrange objects in code to correspond to actual layout & conform to rest of file. Change-Id: I9c86000f335c2d5305286b42b9cd434e922f07c6 Reviewed-on: https://gerrit.libreoffice.org/70340 Tested-by: Jenkins Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Rasmus Jonsson yazdı
+ rearrange code to correspond to actual layout in dialog Change-Id: I4a83f230e1d523a5d03121338de0466e9a61852e Reviewed-on: https://gerrit.libreoffice.org/70608 Tested-by: Jenkins Reviewed-by:
-
Rasmus Jonsson yazdı
Remove warning suppressions. Create svx.false for false warnings. Rearrange objects in code to correspond to their actual position on the screen. Add new label for part entry box. Change-Id: I2a7293024427e65cca2ea754fac4fe1bc7d6d0bd Reviewed-on: https://gerrit.libreoffice.org/70338 Tested-by: Jenkins Reviewed-by:
-
Luboš Luňák yazdı
Change-Id: I059393357c3b0d91e30c16df066fb6dd8ba28ab9
-
Samuel Mehrbrodt yazdı
Change-Id: Ic2093aaea6e71559ba49e248f9afd5d86bcb0b67 Reviewed-on: https://gerrit.libreoffice.org/71949Reviewed-by:
-
Muhammet Kara yazdı
Change-Id: Ieaa50a2eba17145180ddd5d2bfc77add4801c43a Reviewed-on: https://gerrit.libreoffice.org/71929 Tested-by: Jenkins Reviewed-by:
Muhammet Kara <muhammet.kara@collabora.com>
-
Stephan Bergmann yazdı
__cxa_demangle uses malloc/free for memory management, see <http://itanium-cxx-abi.github.io/cxx-abi/abi.html#demangler> Change-Id: I57f8465d1c70fbef4537068fd3aefc52295e1c63 Reviewed-on: https://gerrit.libreoffice.org/71942Reviewed-by:
-
Eike Rathke yazdı
Change-Id: I25327cfcafc9e1f2e88b388677853c638dd9b0e6 Reviewed-on: https://gerrit.libreoffice.org/71946Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by: Jenkins
-
Noel Grandin yazdı
Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503 Reviewed-on: https://gerrit.libreoffice.org/71853 Tested-by: Jenkins Reviewed-by:
Regina Henschel <rb.henschel@t-online.de> Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Samuel Mehrbrodt yazdı
Change-Id: I6213bd2b10746416a5e0bc9029c49b0b09a8b0a4 Reviewed-on: https://gerrit.libreoffice.org/71947 Tested-by: Jenkins Reviewed-by:
-
Julien Nabet yazdı
Change-Id: Ia7e47e8398a0022a281de2b8866e779d471909b0 Reviewed-on: https://gerrit.libreoffice.org/71951Reviewed-by:
-
László Németh yazdı
by disabling their in-row splitting using loop control. Change-Id: Ibd93213fa0ce45458ce188de20da982e4abc17c5 Reviewed-on: https://gerrit.libreoffice.org/71920 Tested-by: Jenkins Reviewed-by:
László Németh <nemeth@numbertext.org>
-
Stephan Bergmann yazdı
Change-Id: I344300807b0bfce0b779b2d64337dad96eee86c9 Reviewed-on: https://gerrit.libreoffice.org/71945Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: Iea5bd392f82e26e3c60ca332ae4bea942888e236 Reviewed-on: https://gerrit.libreoffice.org/71928 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I7abab185624c5a6a6e28334dd680fafece7abfab Reviewed-on: https://gerrit.libreoffice.org/71940 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Change-Id: Iba7c216f28700e8899d76942a4a0a8b77ed3c549 Reviewed-on: https://gerrit.libreoffice.org/71930 Tested-by: Jenkins Reviewed-by:
-
Jens Carl yazdı
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: I356a875e1364f3d16f562f3cfa0b41e0939e43d5 Reviewed-on: https://gerrit.libreoffice.org/71923 Tested-by: Jenkins Reviewed-by:
-
