when calling getXXX() methods of a simple result set.

Change-Id: I9e018385bb73468ea520b03275232c0982cbcba0
Reviewed-on: https://gerrit.libreoffice.org/60095
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

In Excel hidden drawing objects aren't printed. When not
hidden, printing is controlled by a separate 'Print object'
setting.

Only rely visibility setting for now, but properly:
visible means also printed, hidden means not printed.
Ie. import visible property also as printable, and only
output visible property in XLS(X) formats.

For the future, in XLSX format printability is controlled by
attribute 'fPrintsWithSheet' of element 'clientData', don't
know about XLS, there fUsefPrint/fPrint bits don't appear to
be used anymore (see note in tdf#119639).

Change-Id: I728107b30056f7bf073f2fefddece1bef1eb2e7a
Reviewed-on: https://gerrit.libreoffice.org/59915
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Idf3906894510d671c75c32a787ad315945b2c339
Reviewed-on: https://gerrit.libreoffice.org/60137
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

writer, format page is complete

Change-Id: I09f6e4354461c4374cdb0d0e0754dfee35415b45
Reviewed-on: https://gerrit.libreoffice.org/60058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I437988b238af961c6a3ac61ed4e93ea8206f6001
Reviewed-on: https://gerrit.libreoffice.org/60123
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I7213ee2ca55ddc1a11c4f411d3b72f1b2382f7e7

Create NodeContext for all child nodes at beginning and
check if they are valid, either it has a valid target or
it contains valid nodes, so that we only export valid
node later.

Change-Id: I660d99011eb57ddc79f727455fce0be8876e8b17
Reviewed-on: https://gerrit.libreoffice.org/59892
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

PowerPointImport_getSupportedServiceNames() was copy&pasted from
oox::core::FilterBase::getSupportedServiceNames(), so it can go away entirely.

Change-Id: Ia6352cea1c2d65ba94cae66b500de951d82f455a
Reviewed-on: https://gerrit.libreoffice.org/60124Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I4d6d04873d69d2ff1e5409372b353e0bb9a5d68d
Reviewed-on: https://gerrit.libreoffice.org/60120Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I855097279cd091c1e8bd665bb0b48ce9279a9ca8
Reviewed-on: https://gerrit.libreoffice.org/60121Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

* Update helpcontent2 from branch 'master'
  - Mute L10n in some regexp definitions and examples
    
    Change-Id: I614575fd63d08e05ffdf7c74a9f73a4c3021cf08
    Reviewed-on: https://gerrit.libreoffice.org/60105
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Fix image dimensions expression in style
    
    Change-Id: I1803f18aa0512e5b618daa64efff6487c583fb76
    Reviewed-on: https://gerrit.libreoffice.org/60106
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Fix icon sizes
    
    SVG images must have width/height set.
    
    Change-Id: Ia881ad81614d949f1d01764f3e750c066651d631
    Reviewed-on: https://gerrit.libreoffice.org/60107
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Remove dup bookmarks
    
    Change-Id: If88b54807649c5046d7f513eb533156687417e93
    Reviewed-on: https://gerrit.libreoffice.org/60108
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Ibe0dfdfabf6f56498564406441a9c505e93dd9a6
Reviewed-on: https://gerrit.libreoffice.org/60112
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifb0f6fbda69c0696f55a6430120e4ec2e1eb2754
Reviewed-on: https://gerrit.libreoffice.org/60096
Tested-by: Jenkins
Reviewed-by: Marco A.G.Pinto <marcoagpinto@sapo.pt>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I4ec951ddbc0a5ad4718bb44731eb2b4a0f718afc
Reviewed-on: https://gerrit.libreoffice.org/60061
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb34571c19c5ac939fbf5aed2ab66ee18e298dc
Thank you Drew Jensen for the bibisect!

Change-Id: I9550f61709e8582a52554f578ef043c6551f09f0
Reviewed-on: https://gerrit.libreoffice.org/60117Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I6213706ace039492429349c2459923b0e9a5d758
Reviewed-on: https://gerrit.libreoffice.org/60127
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Target is to less modify the given PolyPolygons to
allow better buffer/reuse. To do so, multiple steps
need to be taken to make the creation of cairo_path_t
correct and effective.

Adapted AddPolygonToPath to no longer add a fixed
PixelOffxet of (0.5, 0.5) for LineDrawing. Moved that
at all places to set the needed linear transformation.
Some places which know to work in DeviceCoordinates got
directly adapted. The creation of geometry for polygon
paints that use line and fill no longer offsets by that
values for fill now (which should be better)

Adapted AddPolygonPath to use the closed information from
the given Polygon geometry - this is used in Win Gdiplus
for years and shoud be safe

Adapted AddPolygonPath to do correct PixelSnap when
a ObjectToDevice transformation is used. This requires
to have the ObjectToDevice transformation in the method
and using it and it's inverse

Adapted AddPolygonPath to support PixelSnapHairline which
now needs to be supported in the VCL-layer. Adapted the
BufferedData stuff accordingly (and saw that the old
solution for this snap was not used - sigh)

Corrected ::drawLine to correctly do PixelSnap if needed,
version before would have lost it

Change-Id: I5e8f71f7439b21f58561da5770b9054236a33235
Reviewed-on: https://gerrit.libreoffice.org/60083
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: Iba910b17ca84e423e15b270fe109a2552d16cfba
Reviewed-on: https://gerrit.libreoffice.org/60116
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9799c1b239a23fc0f497132ddf29f69c73b1529f
Reviewed-on: https://gerrit.libreoffice.org/60115
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8ff5c031ddd6cf6546c6e4eee60cbe9f60d4fb5f
Reviewed-on: https://gerrit.libreoffice.org/60114
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0eb3f09b5ca82ce4810aafbb7d5d53f1faa00e3f
Reviewed-on: https://gerrit.libreoffice.org/60111
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iaf26d9f3b32fd2c60bd94517e1dc12589ecab766
Reviewed-on: https://gerrit.libreoffice.org/60122
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I5660fe6ddc745894c1e36176f4aa38ad568f09ba
Reviewed-on: https://gerrit.libreoffice.org/60119
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

After b9757f5c "loplugin:useuniqueptr in
vcl/svdata" ASan/UBSan builds started to fail (like
<https://ci.libreoffice.org//job/lo_ubsan/1025/>) at the end of
PythonTest_dbaccess_python (and probably other PythonTests), when during exit
the static utl::ConfigManager instance already happens to be destroyed by the
time the static ImplSVData's mpSettingsConfigItem is destroyed (which would
normally be cleared during DeInitVCL, if PythonTests would call that, and which
in the past had thus simply been leaked in PythonTests when that
mpSettingsConfigItem was a plain pointer instead of std::unique_ptr).

So ensure that PythonTests that initialize VCL also call DeInitVCL, via a new
private_deinitTestEnvironment, complementing the existing
private_initTestEnvironment.

However, while private_initTestEnvironment is called once (typically via
UnoInProcess.setUp, which internally makes sure to only call it once) as soon as
the first executed test needs it, private_deinitTestEnvironment must be called
once after the lasts test needing it has executed.  The only way that I found to
do that is to override unittest.TextTestResult's stopTestRun method, which is
called once after all tests have been executed.  Hence a new test runner setup
in unotest/source/python/org/libreoffice/unittest.py that is now called from
solenv/gbuild/PythonTest.mk.

That revealed a few places in PythonTests that didn't yet close/delete documents
that they had opened, which has now been added.

One remaining problem then is that classes like SwXTextDocument and friends call
Application::GetSolarMutex from their dtors, via sw::UnoImplPtrDeleter (a "Smart
pointer class ensuring that the pointed object is deleted with a locked
SolarMutex", sw/inc/unobaseclass.hxx).  That means that any PyUNO proxies to
such C++ objects that remain alive after private_deinitTestEnvironment will
cause issues at exit, when Python does a final garbage collection of those
objects.  The ultimate fix will be to remove that unhelpful UnoImplPtrDeleter
and its locking of SolarMutex from the dtors of UNO objects; until then, the
Python code is now sprinkled with some HACKs to make sure all those PyUNO
proxies are released in a timely fashion (see the comment in
unotest/source/python/org/libreoffice/unittest.py for details).  (Also, it would
probably help if UnoInProcess didn't keep a local self.xDoc around referencing
(just) the last result of calling one of its open* methods, confusingly making
it the responsibility of UnoInProcess to close that one document while making it
the responsibility of the test code making the other UnoInProcess.open* calls to
close any other documents.)

Change-Id: Ief27c81e2b763e9be20cbf3234b68924315f13be
Reviewed-on: https://gerrit.libreoffice.org/60100
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Considering rColInfo.nNullable != ColumnValue::NO_NULLS is ok to approve row
isn't sufficient in the case the field is "Input required" in form.

Change-Id: I27c57fe8ce5afac97eb0650f93703333c85f1421
Reviewed-on: https://gerrit.libreoffice.org/60109
Tested-by: Jenkins
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

Change-Id: I280f070bf974ac2f4a889f4c98a80a87092c013a
Reviewed-on: https://gerrit.libreoffice.org/60118
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

* Update helpcontent2 from branch 'master'
  - Mark XML Source as experimental feature
    
    ... since commit 65722772
    
    Change-Id: I80d97004a9cd4dc9e6600e6bab64a43c5be91633
    Reviewed-on: https://gerrit.libreoffice.org/59706
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

* Update helpcontent2 from branch 'master'
  - Mention custom format codes for Calc's TEXT() function
    
    Change-Id: I29271e2f555cbc231b616e75b43b37775143feae
    Reviewed-on: https://gerrit.libreoffice.org/59984Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: Ib2c183f5edb94e68f43f92edd83cb8d3ae5b40e1
Reviewed-on: https://gerrit.libreoffice.org/60103
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

* Update helpcontent2 from branch 'master'
  - Move bookmark out of list
    
    Change-Id: Ib1d844ed88a7389e1eeeb9f2279266745ba6acec
    Reviewed-on: https://gerrit.libreoffice.org/60099
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Moves the scale factor into the LogicalFontInstance and uses the
Glyphs font fallback level to use the correct font and scale.

Probably the glyphs should be using a rtl::Reference to the
LogcalFontInstance instead of the fallback level. I don't know if
glyphs are evicted from the cache, if the fallback changes. There
is now an assert and all places will use 1.0 as the default
scaling factor, so LO should at least not crash.

Change-Id: I9dd4fc3a5b5924fc379b48a7f71c9eed26b4779d
Reviewed-on: https://gerrit.libreoffice.org/60091
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: Ia43dbfd6313935bec90ac88018011eacca0c0eaf
Reviewed-on: https://gerrit.libreoffice.org/60090
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

which necesitated changing the API and hence the call sites

Change-Id: Id417a235bf9b2bf1a3d152dc6600c0635486cafa
Reviewed-on: https://gerrit.libreoffice.org/60086
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - tdf#117551 Change icons to SVG equivalent
    
    Change-Id: I5d174b434429485d270ba7b6e9147a3bc2b84828
    Reviewed-on: https://gerrit.libreoffice.org/60056
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Show how beautiful are our icons
    
    On hovering icons, enlarge them.
    
    Next step: change icons to SVG (tdf#117551)
    
    Change-Id: Ib43e3b54ed27352a8ca785c57dce9314adc00e4d
    Reviewed-on: https://gerrit.libreoffice.org/60053
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Number of GenericSalLayout::LayoutText() calls during Writer startup: 2603 ->
1616 (18 -> 1 layouts / included number).

Change-Id: I9a1a1131707bb6bc31683bbf609319f4bc22de92
Reviewed-on: https://gerrit.libreoffice.org/60087Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Commands renamed to Before/After according Writer

Change-Id: I4af6fa134a70ff83a717bd53bb0531fd3f647300
Reviewed-on: https://gerrit.libreoffice.org/60081
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>