Kayıtlar (commit) · ec02714d6cd5be67d03e333efddb42ab572cae77 · LibreOffice / core

24 Ock, 2018 14 kayıt (commit)

loplugin:unused-returns in drawinglayer..svx · ec02714d

Noel Grandin Ock 23, 2018 yazdı

Change-Id: I033a78cc7fe7d8e5086f1c855c4aa371cc98dc7c
Reviewed-on: https://gerrit.libreoffice.org/48400Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ec02714d

loplugin:constparams · 945a1196

Noel Grandin Ock 23, 2018 yazdı

Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504
Reviewed-on: https://gerrit.libreoffice.org/48392Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

945a1196

loplugin:useuniqueptr in GroupData_Impl · 7b7c388f

Noel Grandin Ock 16, 2018 yazdı

Change-Id: Icddaf78a58b74338ac763c12c8ac06f464986cac
Reviewed-on: https://gerrit.libreoffice.org/48371Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

7b7c388f

Silence upcoming GCC 8 -Werror=parentheses in external/boost · b3b22ee3

Stephan Bergmann Ock 23, 2018 yazdı

...reporting such delights as

> [CXX] sal/cppunittester/cppunittester.cxx
> In file included from workdir/UnpackedTarball/boost/boost/mpl/aux_/na_assert.hpp:23,
[...]
>                  from external/boost/include/boost/algorithm/string.hpp:25,
>                  from sal/cppunittester/cppunittester.cxx:60:
> workdir/UnpackedTarball/boost/boost/mpl/assert.hpp:188:21: error: unnecessary parentheses in declaration of ‘assert_arg’ [-Werror=parentheses]
>  failed ************ (Pred::************
>                      ^

where boost/mpl/assert.hpp contains

> template< typename Pred >
> failed ************ (Pred::************
>       assert_arg( void (*)(Pred), typename assert_arg_pred<Pred>::type )
>     );

Change-Id: I6976b2cc23f1d309d27d3fde9098b10c9d877599
Reviewed-on: https://gerrit.libreoffice.org/48386Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

b3b22ee3

loplugin:unused-returns in vcl · de8f6b25

Noel Grandin Ock 22, 2018 yazdı

Change-Id: I507320900a47f604d17ed7d402d531a7cbdf744e
Reviewed-on: https://gerrit.libreoffice.org/48331Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

de8f6b25

USHRT_MAX -> SAL_MAX_UINT16 · 182a3c7e

Stephan Bergmann Ock 23, 2018 yazdı

...presumably forgotten when the following casts of nTmp in the SetBaseHeight
etc. calls were changed from USHORT to sal_uInt16 in
7f33ed41 "removetooltypes01: #i112600# Remove
tools types from sw"

Change-Id: I75809e677835910b09b366f755361a667d097402
Reviewed-on: https://gerrit.libreoffice.org/48442Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

182a3c7e

This presumably always wanted to check for SAL_MAX_UINT16, not USHRT_MAX · 58401e6c

Stephan Bergmann Ock 23, 2018 yazdı

The check against USHRT_MAX was introduced together with a following

  nLen2 = static_cast<UINT16>(nLen);

in 73f043c4 "#96155# #i1858# merge branch and
remove warnings" (and that UINT16 meanwhile replaced with sal_uInt16).

Change-Id: I61346e4ffc90a4f8a97c2d3f822d619faa5b0008
Reviewed-on: https://gerrit.libreoffice.org/48441Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

58401e6c

Remove presumably dead nLen < USHRT_MAX check · da67b0be

Stephan Bergmann Ock 23, 2018 yazdı

The original code of 7b0b5cdf "initial import"
read

+        long nLen = (    (nNextPieceCp < nBehindTextCp)
+                        ? nNextPieceCp
+                        : nBehindTextCp
+                    )
+                    - nAktStartCp;
+
+        if( 0 >= nLen ) break;
+
+        if( nLen > USHRT_MAX - 1 )
+            nLen = USHRT_MAX - 1;
+
+        if( bIsUnicode )
+            rStr.Append( WW8Read_xstz( rStrm, (USHORT)nLen, FALSE ) );
+        else
+        {
+            ByteString aByteStr;    // Alloc methode automatically sets Zero at the end
+            sal_Char*  pByteData = aByteStr.AllocBuffer( nLen );
+
+            sal_Size nWasRead = rStrm.Read( pByteData, nLen );
+            if( nWasRead != nLen )
+                aByteStr.ReleaseBufferAccess( nWasRead );
+
+            rStr += String( aByteStr, eEnc );
+        }
+        nTotalRead  += nLen;
+        nAktStartCp += nLen;
+        if( nTotalRead != rStr.Len() ) break;

casting nLen to USHORT in the call to WW8Read_xstz, while the current code looks
like it should work fine for larger nLen.

Change-Id: Ie3a0d654ef45421cbbe8e823259e8dfd27bd27e2
Reviewed-on: https://gerrit.libreoffice.org/48437Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

da67b0be

tdf#115093 : Do not reuse singleref tokens... · ff166845

Dennis Francis Ock 23, 2018 yazdı

...in formula group computation if the formula contains
only a single reference besides any ocOpen/ocClose pairs
wrapping it as the sole content.

In such a case the "result" formula token
returned by ScInterpreter::GetResultToken() is the same
as the original singleref token, so for each row of the
formulagroup, we need to use a separate singleref token.

Also added a unit test in sc/qa/unit/parallelism.cxx

Change-Id: I6032efc5be9b51ca1e9daf9bdd19997a949d2f43
Reviewed-on: https://gerrit.libreoffice.org/48449Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

ff166845

USHRT_MAX -> SAL_MAX_UINT16 · f8aca037

Stephan Bergmann Ock 23, 2018 yazdı

...presumably forgotten when changing SwEditShell::InsertDDETable parameters
from USHORT to sal_uInt16 in 7f33ed41
"removetooltypes01: #i112600# Remove tools types from sw"

Change-Id: I28ad46bdfb6c95a7d2e0bcbf2ef8eef29217baa5
Reviewed-on: https://gerrit.libreoffice.org/48436Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

f8aca037

Reuse WW8TabBandDesc::setcelldefaults · e8efbffc

Stephan Bergmann Ock 23, 2018 yazdı

Change-Id: Icdf57d962ae7b3e24cbed6aba4b05fa2136b3761
Reviewed-on: https://gerrit.libreoffice.org/48433Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

e8efbffc

Globally disable -Wcast-function-type new with upcoming GCC 8 · ce99754e

Stephan Bergmann Ock 23, 2018 yazdı

...which unhelpfully even warns on reinterpret_cast, so causes failures like

> [CXX] sal/osl/unx/signal.cxx
> sal/osl/unx/signal.cxx: In function ‘bool onInitSignal()’:
> sal/osl/unx/signal.cxx:267:50: error: cast between incompatible function types from ‘void (*)(int, siginfo_t*, void*)’ to ‘{anonymous}::Handler1’ {aka ‘void (*)(int)’} [-Werror=cast-function-type]
>                                  oact.sa_sigaction);
>                                                   ^

And since all incompatible (but deliberate) casts between function types across
our code base should already be written as reinterpret_cast, we shouldn't lose
much by just disabling this new warning globally.

Change-Id: If15e9606e8fdc676b61012e31d7369653951ceca
Reviewed-on: https://gerrit.libreoffice.org/48431Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

ce99754e

Use std::unique_ptr in ImplCalcToTopData · fa1caba2

Mike Kaganski Ock 23, 2018 yazdı

Change-Id: Ie43c633283be45e72259be5eedd253e403e9f664
Reviewed-on: https://gerrit.libreoffice.org/48377Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

fa1caba2

Remove redundant variable · 6fc9d4a4

Mike Kaganski Ock 23, 2018 yazdı

Change-Id: I062ea13827d7d9744b0965b305877633485015fa
Reviewed-on: https://gerrit.libreoffice.org/48405Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

6fc9d4a4

23 Ock, 2018 26 kayıt (commit)

-Werror=ignored-qualifiers (upcoming GCC 8) · 77a53528

Stephan Bergmann Ock 23, 2018 yazdı

Change-Id: Ibcbfd951d2a7c7862fbc7e6b17c89344ae5bf930
Reviewed-on: https://gerrit.libreoffice.org/48399Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

77a53528

configure: if WiLangId.vbs isn't found but is required, error out · 81a1882d
Michael Stahl Ock 23, 2018 yazdı
```
Change-Id: I8a145c1024a522a17c6ac2bf961cb4f07f3e7be9
```
81a1882d
configure: find WiLangId.vbs where SDK 10.0.16299.0 hides it · 112c931f
Michael Stahl Ock 23, 2018 yazdı
```
Change-Id: I71d27f3f97e257b4e45261004088ce3435f82090
```
112c931f

svx::frame::Style::operator< does not implement strict weak order · dba57e8d

Michael Stahl Ock 23, 2018 yazdı

... at least since other single line styles than SOLID and DASHED
were added some years ago.

This causes an assertion from MSVC std::max in CppunitTest_sw_odfexport.

Change-Id: I2e0833b3d5c5afab259108be1c8782c4c4d26978

dba57e8d

WW8PLCFxSaveAll/WW8_SHD default ctors already zero-initialize their members · 3dfc300a

Stephan Bergmann Ock 23, 2018 yazdı

Change-Id: I690e6e812d52344faef93b2856ce0f4a22509d2c
Reviewed-on: https://gerrit.libreoffice.org/48396Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

3dfc300a

Point default ctor already zero-initializes the members · de694ba2

Stephan Bergmann Ock 23, 2018 yazdı

Change-Id: I9cb59c77a420c975933070eea691cda52b066b0b
Reviewed-on: https://gerrit.libreoffice.org/48397Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

de694ba2

AnimationNode default ctor already zero-initializes the members · 6b75c472

Stephan Bergmann Ock 23, 2018 yazdı

Change-Id: I9725189846a38860550c651b2428296564824ba8
Reviewed-on: https://gerrit.libreoffice.org/48394Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

6b75c472

Use a more conventional way of clearing ScRange variables · d1016591

Stephan Bergmann Ock 23, 2018 yazdı

...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of type
‘class ScRange’ with no trivial copy-assignment")

Change-Id: I2178697082b1c284d26cedaa64c73b92d9e6aecb
Reviewed-on: https://gerrit.libreoffice.org/48393Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

d1016591

Silence upcoming GCC 8 -Werror=sizeof-pointer-memaccess · a886fbfb

Stephan Bergmann Ock 23, 2018 yazdı

...("error: argument to ‘sizeof’ in ‘char* strncpy(char*, const char*, size_t)’
call is the same expression as the source; did you mean to use the size of the
destination?") in a place where the use of strncpy instead of strcpy (introduced
with 9276f7d5 "fdo#32263") doesn't help prevent
any buffer overflows anyway (the target's size already having been checked to be
sufficiently large).

Change-Id: I70773538f4092f1306fb00f1fa7f9138e06894e5
Reviewed-on: https://gerrit.libreoffice.org/48391Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

a886fbfb

Introduce SbxValues::clear · ad9871a5

Stephan Bergmann Ock 23, 2018 yazdı

...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of non-
trivial type ‘struct SbxValues’")

Change-Id: Icf610e692b81030bfd6f2f940c43ee8bf6f1d4e0
Reviewed-on: https://gerrit.libreoffice.org/48389Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

ad9871a5

Adapt to svtools/inc/langtab.hrc · 42907261

Eike Rathke Ock 23, 2018 yazdı

svtools/source/misc/langtab.src is dead since a while.

Change-Id: I373f715d337a47f6ea1e935a7a50565f0e6b3ba2

42907261

offapi: Add properties FormulaResultType2 and CellContentType · cceaece1

Jens Carl Ock 23, 2018 yazdı

Add two new properties to SheetCell.idl "FormulaResultType2" and
"CellContentType", because the "FormulaResultType" is returning the
wrong value (com::sun::star::table::CellContentType instead of
com::sun::star::sheet::FormulaResult). Also documeted the curiosity.

Change-Id: Icc6538e155ba27fb9d097d8790ac9b4b230c1446
Reviewed-on: https://gerrit.libreoffice.org/48367Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

cceaece1

Remove unused TypeCheck::SubstTemplateTypeParmType · 65910960

Stephan Bergmann Ock 23, 2018 yazdı

...introduced unused with 91b4e453 "new
loplugin: pointerbool"

Change-Id: I3af0ce878f1f2742223d66bcdade4e9c144162cd
Reviewed-on: https://gerrit.libreoffice.org/48387Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

65910960

Fix typos · 843b26a6

Andrea Gelmini Ock 22, 2018 yazdı

Change-Id: I05a1234d7bcbae6f4851abd34ff7acec5853f5f5
Reviewed-on: https://gerrit.libreoffice.org/48329Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

843b26a6

Fix typos · 508e973b

Andrea Gelmini Ock 23, 2018 yazdı

Change-Id: I17e617d89d1b5ad92c5c8218958e86ca722b13e2
Reviewed-on: https://gerrit.libreoffice.org/48435Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

508e973b

Removed duplicated include · 5b9d0d4a

Andrea Gelmini Ock 23, 2018 yazdı

Change-Id: I20d4304013e12035e522fd1b1e0c201d49961114
Reviewed-on: https://gerrit.libreoffice.org/48434Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

5b9d0d4a

ofz: better loop detect · ebfcf40d

Caolán McNamara Ock 23, 2018 yazdı

Change-Id: I7c33d2a64a6b4968e8a83f53f5c893eb5ba268b7
Reviewed-on: https://gerrit.libreoffice.org/48415Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

ebfcf40d

ofz: Direct leak · c36547d1

Caolán McNamara Ock 23, 2018 yazdı

Change-Id: Ide16aad0cadd393ce28425ed54c5e77f93d61317
Reviewed-on: https://gerrit.libreoffice.org/48412Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

c36547d1

Various loplugin in --enable-gtk3-kde5 code · 8b6c9009
Stephan Bergmann Ock 23, 2018 yazdı
```
Change-Id: I5d5bb6b57a9e9ed2c66d304c18fe7ef233aae072
```
8b6c9009

Remove dead code from SfxFilter ctor · b07e38b2

Stephan Bergmann Ock 22, 2018 yazdı

In fd069bee "initial import" the code was:

+void SfxFilter::InitMembers_Impl()
+{
+    String aExts = GetWildcard()();
+    String aShort, aLong;
+    String aRet;
+    sal_uInt16 nMaxLength =
+#if defined( WIN ) || defined( OS2 )
+        3
+#else
+        USHRT_MAX
+#endif
+        ;
+    String aTest;
+    sal_uInt16 nPos = 0;
+    while( ( aRet = aExts.GetToken( nPos++, ';' ) ).Len() )
+    {
+        aTest = aRet;
+        aTest.SearchAndReplace( DEFINE_CONST_UNICODE( "*." ), String() );
+        if( aTest.Len() <= nMaxLength )
+        {
+            if( aShort.Len() ) aShort += ';';
+            aShort += aRet;
+        }
+        else
+        {
+            if( aLong.Len() ) aLong += ';';
+            aLong += aRet;
+        }
+    }
+    if( aShort.Len() && aLong.Len() )
+    {
+        aShort += ';';
+        aShort += aLong;
+    }
+    aWildCard = aShort;
+
+    nVersion = SOFFICE_FILEFORMAT_NOW;
+    bPlugDataSearched = 0;
+    pPlugData = 0;
+
+    aName = pContainer->GetName();
+    aName += DEFINE_CONST_UNICODE( ": " );
+    aName += aFilterName;
+
+    aUIName = aFilterName;
+}

where USHRT_MAX apparently effectively meant "arbitrarily large".  But when
b7c59605 "INTEGRATION: CWS sfxcleanup" removed
the WIN/OS2 special case it didn't remove all the other code that was now
effectively useless.

Change-Id: I883759f13e0267a189ad176c2ffcc1c78680b0a5
Reviewed-on: https://gerrit.libreoffice.org/48336Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

b07e38b2

tdf#91362: Use document paper size for printing slides. · 57991f88

Vasily Melenchuk Ara 12, 2017 yazdı

By default for priniting slides we use not default A4, but size provided
in slide properties.

Additinally renamed IsPageSize() -> IsPaperSize(): it is less ambiguous.

Change-Id: Iaf38dedb32b14cd6fbdd2ad355ecf3208e32663e
Reviewed-on: https://gerrit.libreoffice.org/46407Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

57991f88

Various loplugin in --enable-gtk3-kde5 code · c73f88de
Stephan Bergmann Ock 23, 2018 yazdı
```
Change-Id: I006e7fddcb58edb597867e0dd6f2b81ddac3457e
```
c73f88de

tdf#69254: Tweak mapping from CoreText weight to our FontWeight a bit · 407546e7

Tor Lillqvist Ock 23, 2018 yazdı

Make the mapping of light weights more likely to hit different enum
values for slightly different weights.

We want to be able to distinguish between for instance Overpass Light
(with weight -0.4) and Overpass ExtraLight (with weight -0.5).

Change-Id: If83fbce68149b267a49ef9bcb6624d8790de7c56
Reviewed-on: https://gerrit.libreoffice.org/48409Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

407546e7

Various loplugin in --enable-gtk3-kde5 code · e3ee0653
Stephan Bergmann Ock 23, 2018 yazdı
```
Change-Id: Ic12464f01950a5037bb6819a2722aba5a7e3e2e6
```
e3ee0653

Silence -Werror,-Wundef in external/boost · 862d2fc5

Stephan Bergmann Ock 23, 2018 yazdı

> [CXX] vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx
> In file included from vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx:20:
> In file included from vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.hxx:30:
> In file included from vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.hxx:29:
> In file included from workdir/UnpackedTarball/boost/boost/process/child.hpp:22:
> In file included from workdir/UnpackedTarball/boost/boost/process/detail/execute_impl.hpp:24:
> workdir/UnpackedTarball/boost/boost/process/detail/posix/executor.hpp:446:5: error: 'BOOST_POSIX_HAS_VFORK' is not defined, evaluates to 0 [-Werror,-Wundef]
> #if BOOST_POSIX_HAS_VFORK
>     ^

under --enable-gtk3-kde5

Change-Id: Ib4648d1337a493c35b35897dc71c5e971c6eb214

862d2fc5

Add unit tests for rtl::math's inverse hyperbolic functions · f16fdfa5

Takeshi Abe Ara 09, 2017 yazdı

based on i#97605's test cases.

Change-Id: Id7e57914553ba8801a624f667979badc191108e5
Reviewed-on: https://gerrit.libreoffice.org/46152Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

f16fdfa5