Individually, these don't make much difference, but they add up
to a halving the time to save on my machine.

EmbeddedObjectContainer shows a lot of work in HasEmbeddedObject and
GetEmbeddedObjectName, so add a reverse map there.

Change-Id: Ib758668dbb045e6ceb2611bd86aa2af4fbfb9917
Reviewed-on: https://gerrit.libreoffice.org/70309
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1413e1872b1f2cd29256b33cdc7ac7ae09faf46c
Reviewed-on: https://gerrit.libreoffice.org/70394
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia5b4b50e919964b0746a68b008c9f7a86240c3a6
Reviewed-on: https://gerrit.libreoffice.org/70398
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie541b51ebd0e14c2bd6429e9bfcd9532e02c2b50
Reviewed-on: https://gerrit.libreoffice.org/70396
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I7b9802f224b497004df8cce7abd2bb8e52c79128
Reviewed-on: https://gerrit.libreoffice.org/70395
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia24441d3671102fdeeb797547396c25ee2a6ffd3
Reviewed-on: https://gerrit.libreoffice.org/70382
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I27b3746140a362bc5f33e9a1daba9a0d0f897d63
Reviewed-on: https://gerrit.libreoffice.org/70357
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Also use scope where possible. This allows to limit guard scope at
language level; visualises the scope clearly; and helps avoiding
errors like fixed in commit 61e4437c.

Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41
Reviewed-on: https://gerrit.libreoffice.org/70376
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Hopefully I don't miss useful side-effects

Change-Id: Ie129e9de6110cdd679db5dfea0227115b5056367
Reviewed-on: https://gerrit.libreoffice.org/70378Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I46b23af4c98c96642b48741918a1f2bdbe10d444
Reviewed-on: https://gerrit.libreoffice.org/69318
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I3f3ab91c10f3077d61a8fd0c351be75cf2e63963
Reviewed-on: https://gerrit.libreoffice.org/70375
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie7469f32f08c7acf5a972dec12fa75604aa8336d
Reviewed-on: https://gerrit.libreoffice.org/70368
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Call me pedantic.

Change-Id: I96b8b7ef511508da0df75589475eaf13d639a7c9
Reviewed-on: https://gerrit.libreoffice.org/70365
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: Ic406cfe794c45db921b1074e5913db3d2c6e6e89
Reviewed-on: https://gerrit.libreoffice.org/70363
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

V522 There might be dereferencing of a potential null pointer.

Change-Id: I680f1628133216de6336ac5ffa846447ffd55a41
Reviewed-on: https://gerrit.libreoffice.org/70352
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I8cc01420d0235a8d1686881eca1ad9cc4a67ebe0
Reviewed-on: https://gerrit.libreoffice.org/70362
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4c5f628052ab7a6940b5b7a7e7eaefa0e2038940
Reviewed-on: https://gerrit.libreoffice.org/70356
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I88752cab3d9b49db11088947903dfaf80c6d8150
Reviewed-on: https://gerrit.libreoffice.org/70358
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I27f9b30f76b6bbd255a346c00d64e2499e7f3b5e
Reviewed-on: https://gerrit.libreoffice.org/70360
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I88a8fb94cb1e7653d63a77bdb63d1303cc848704
Reviewed-on: https://gerrit.libreoffice.org/70361
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Word relates the position to the unrotated shape in legacy doc
format. Writer uses the rotated shape. The patch corrects the
difference on import and export.

Change-Id: I25537123656e62d6ffae5118ee8d621a4b5c5be0
Reviewed-on: https://gerrit.libreoffice.org/70152
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

Change-Id: I708f222e408223cfaeaac56f87d68375f1d0503f
Reviewed-on: https://gerrit.libreoffice.org/69237
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I0222e6675f63797f870746fd34a29702ad190311
Reviewed-on: https://gerrit.libreoffice.org/69240
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I76eaf140b153199b62606ac3336d712a64205dcc
Reviewed-on: https://gerrit.libreoffice.org/69246
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: Id57a1771c897c69b05d02a359f22e5fb2b1f5a31
Reviewed-on: https://gerrit.libreoffice.org/69239
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

Change-Id: I4713b15061e831e1dfeccf8d59e46c0aa2ac4a18
Reviewed-on: https://gerrit.libreoffice.org/70351Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: I00df0022a20e83d76484d7c6e7b903ecd3c54aa0
Reviewed-on: https://gerrit.libreoffice.org/70347
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

* Update helpcontent2 from branch 'master'
  - Revert "Create XSLT replacement table for missing icons"
    
    This reverts commit 61f44912beec99f6211399ce567274aa369f817d.
    
    Change-Id: Icd69ccd4f487a82426a00169728ec62bbff6d0b6
    Reviewed-on: https://gerrit.libreoffice.org/70350
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

These are always defined when WINVER >= 0x0400; and we have it set to 0x0601
in solenv/gbuild/platform/windows.mk.

Change-Id: Ia1f6fa5589562fa710b4da3d288182d3f8a15e6b
Reviewed-on: https://gerrit.libreoffice.org/70348
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Idf66a9e49471d6651c03deecc4fb2f9a722f512c
Reviewed-on: https://gerrit.libreoffice.org/70325
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Without that, Request::waitProcessMessages might wait indefinitely for
Application::Yield() to return; while the latter would wait for a message
in GetMessage. If there's no visible LO window, the message might never
arrive by itself.
Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: Ie2622053a8d4467eb1cbd579d8496cb5ddef08aa
Reviewed-on: https://gerrit.libreoffice.org/70346Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72
Reviewed-on: https://gerrit.libreoffice.org/70314
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3dc1c0e63bd90735c20a65b1af25b243e5a5eee5
Reviewed-on: https://gerrit.libreoffice.org/70341
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4eacbe8ad2025a54c13f4c0fa06e30e5ab59b721
Reviewed-on: https://gerrit.libreoffice.org/70344
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

since...

commit 7282014e
Date:   Fri Feb 1 15:15:16 2019 +0100

    tdf#50916 Makes numbers of columns dynamic.

Change-Id: I7588e34a9a52cde0d38dd9c1f15e6bbdb3601241
Reviewed-on: https://gerrit.libreoffice.org/70345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

on export to .ods

Thread 1:

5  0x00007f758fde4969 in raise () from /lib64/libc.so.6
6  0x00007f758fde5f98 in abort () from /lib64/libc.so.6
7  0x00007f758f485afd in __gnu_debug::_Error_formatter::_M_error (
   this=0x7f7588872860 <__gnu_debug::_Error_formatter::_M_at(char const*, unsigned int)::__formatter>)
   at ../../../.././libstdc++-v3/src/c++11/debug.cc:1069
8  0x00007f7587b42922 in __gnu_debug::_Safe_iterator<std::__detail::_Node_iterator<ImpGraphic*, true, false>, std::__debug::unordered_set<ImpGraphic*, std::hash<ImpGraphic*>, std::equal_to<ImpGraphic*>, std::allocator<ImpGraphic*> > >::operator++ (
   this=0x7f755a58e440) at /srv/crashtestdata/gccbuild/gcc8/include/c++/8.2.0/debug/safe_iterator.h:295
9  0x00007f7587b415d5 in vcl::graphic::Manager::registerGraphic (this=0x5fe9860,
   pImpGraphic=std::shared_ptr<ImpGraphic> (use count 1, weak count 0) = {...})
   at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:123
10 0x00007f7587b418e2 in vcl::graphic::Manager::newInstance (this=0x5fe9860)
   at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:156
11 0x00007f758798c406 in Graphic::Graphic (this=0x7f755a58e6d0)
   at /home/buildslave/source/libo-core/vcl/source/gdi/graph.cxx:187
12 0x00007f758799c85a in ImpGraphic::loadPrepared (this=0x80d2500)
   at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1540
13 0x00007f758799c999 in ImpGraphic::ImplSwapIn (this=0x80d2500)
   at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1561
14 0x00007f758799c813 in ImpGraphic::ensureAvailable (this=0x80d2500)

and a bunch of other threads looking like they've just come from the same
family of methods

Change-Id: Ic13d3c7cb2fb4adaa2a0a6b8845fc2156d53005e
Reviewed-on: https://gerrit.libreoffice.org/70271
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - Add info on convert-to filter names
    
    command line --convert-to option miss description of the internal
    names of the filters.
    
    The xhp file is generated by the python script based on the
    filter xcd's.
    
    P2:
    fix typo,
    Fix <filename>,
    Put modules in upercase.
    
    P3:
    reduce L10n workload with <embedvar>
    
    P4:
    Make xmllint happy again
    
    Change-Id: I455491b1f6a141688308d768b2822f051566ae53
    Reviewed-on: https://gerrit.libreoffice.org/70273
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - Create XSLT replacement table for missing icons
    
    Missing UI icons have a replacement table in
    /core/icon-themes/colibre/links.txt
    
    Help must also use this replacement table when Help
    pages have missing icons. The previous approach was a manual
    creation of a XSLT for the replacement.
    
    The patch moves the replacement table creation inside the
    Custom makefile, making it automatic and carrying changes
    of the original links.txt source.
    
    Change-Id: I7f834fa03bbd85f329efbec43e5c51cc86d51586
    Reviewed-on: https://gerrit.libreoffice.org/70080
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I9904cf43548fc04e339b1592280efc326a0f6ad1
Reviewed-on: https://gerrit.libreoffice.org/70330Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I7fa59ba667a35b4f2fbfa284cf5257218428259a
Reviewed-on: https://gerrit.libreoffice.org/70331
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>