- 07 Şub, 2018 16 kayıt (commit)
-
-
Caolán McNamara yazdı
a failed position returns false, but stays at the failed position, so next time its called without moving it then it returns true store what we return for a given position for reuse if the position doesn't change Change-Id: I404c65ac89eb6f5c867f62a62028b87effdbcbf8 Reviewed-on: https://gerrit.libreoffice.org/49308Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I9c4510cb91e2572a3ab2b62497dc4dd9fd1119c8 Reviewed-on: https://gerrit.libreoffice.org/49319Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Noel Grandin yazdı
extracts code from the innermost part of fairly hot loops And add a GetIndexFromData method to make the call sites a little easier to read. Change-Id: I4ce5c5a687ecdb6982562a0aafce8513d86f9107 Reviewed-on: https://gerrit.libreoffice.org/49337Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Caolán McNamara yazdı
it just takes a c++ ref, so a temp is an unsuitable arg Change-Id: I40490e94d977df91b985bc4ae458b68ee85d5dfe Reviewed-on: https://gerrit.libreoffice.org/49321Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Noel Grandin yazdı
Change-Id: Iad96df43c9c7ae6d5fd4f3aa9c2c5c721711da30 Reviewed-on: https://gerrit.libreoffice.org/49331Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Idd1eb8263d679efed0f0be88fb05963fe44f8668 Reviewed-on: https://gerrit.libreoffice.org/49328Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Stephan Bergmann yazdı
Change-Id: Ie8c2389e8e0801b092abcfef751325cdf369b98d
-
Stephan Bergmann yazdı
The dependency of Library_vcl on qt5 libraries (via vcl/qt5/Qt5Font.cxx) is there ever since b66a7cbd "QT5 first stab on implementing CommonSalLayout", but no idea whether that is by design or is a hack that should eventually be cleaned up. Change-Id: I4cec702709b37069987ec68c035628b5172b3543
-
Stephan Bergmann yazdı
Change-Id: I345055bf56828fc597d14c654d4819e87630da2c
-
Miklos Vajna yazdı
Change-Id: I42f0218a46c67062ea6eb0845d978f2630793ec0 Reviewed-on: https://gerrit.libreoffice.org/49304Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
Noel Grandin yazdı
Change-Id: I23cc319707132c28725acdb8be0bea275025b9e5 Reviewed-on: https://gerrit.libreoffice.org/49332Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I8b48642a3a6ab4d94c1b58f8dae3589e703612b1 Reviewed-on: https://gerrit.libreoffice.org/49329Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Tor Lillqvist yazdı
Change-Id: I379770f93799668e44beab03fb64ceddffabe85a Reviewed-on: https://gerrit.libreoffice.org/49326Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
-
Mike Kaganski yazdı
Unit test included Change-Id: I8e3338d7df431bd016caa4e06e684fbd189127c4 Reviewed-on: https://gerrit.libreoffice.org/49324Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
-
Julien Nabet yazdı
Change-Id: I1a06e105ca9f1151afca236c83e3e0c9d2679c6f Reviewed-on: https://gerrit.libreoffice.org/49318Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Takeshi Abe yazdı
Change-Id: Ia85f66d3490471d7e0c2ce8a1947051be129acf9 Reviewed-on: https://gerrit.libreoffice.org/49276Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
-
- 06 Şub, 2018 24 kayıt (commit)
-
-
andreas_kainz yazdı
Revert "Revert "tdf#98141 add svg file for all app icons in all sizes"" This reverts commit 6ec4b1d0. Change-Id: I4c18c0fa3089824a18d25d7450b8dd52e410d514 Reviewed-on: https://gerrit.libreoffice.org/49136Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Caolán McNamara yazdı
Change-Id: Ib1d39e6c80a579752aedd1ca0b41595192cfbbfc Reviewed-on: https://gerrit.libreoffice.org/49303Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Miklos Vajna yazdı
Commit 4a0f506f (framework: disable layout manager in hidden frames, 2018-01-17) added support for bypassing the framework layout manager for doc conversion purposes, but the Hidden flag has the meaning that the doc is only initially hidden, it may be visible later, so reusing Hidden broke mail merge. Introduce a dedicated HiddenForConversion flag, clients interested in improved performance can opt in for that, and this way behavior for Hidden is not changing. Change-Id: If7537197900f8819f714b164c9e056b4ae69286d Reviewed-on: https://gerrit.libreoffice.org/49302Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
Kohei Yoshida yazdı
This is subject to the infamous Excel to Calc cell border mapping fiasco. The mapping is not perfect and there is certainly room for improvement. Change-Id: Ie224c8e08e6c0b8f13311460acbd371bd65a145f Reviewed-on: https://gerrit.libreoffice.org/49266Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
-
Julien Nabet yazdı
Change-Id: Ieda300cf8b4ace3ac619c57abfba2ab2e56e4084 Reviewed-on: https://gerrit.libreoffice.org/49296Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Julien Nabet yazdı
Change-Id: I59305b415858ee1a826f03d9925624239cf7e582 Reviewed-on: https://gerrit.libreoffice.org/49291Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Julien Nabet yazdı
Change-Id: Ib8445ed268f84d850169cc54113119308045e9df Reviewed-on: https://gerrit.libreoffice.org/49295Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Julien Nabet yazdı
Change-Id: I14358ba06a4a7eb7ad01b0e7cc73455daec917a2 Reviewed-on: https://gerrit.libreoffice.org/49293Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Julien Nabet yazdı
Change-Id: I416746df2b2f120b264fab85f6a9570c5f176ddf Reviewed-on: https://gerrit.libreoffice.org/49290Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Bartosz Kosiorek yazdı
Change-Id: Iaa1307123d97a740bdaf90647e8adff224211851 Reviewed-on: https://gerrit.libreoffice.org/49263Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
-
Manfred Blume yazdı
Regression from 18765b9f Change-Id: Ic4205777077e4e3d93bdddf743c51abba8950eaf Reviewed-on: https://gerrit.libreoffice.org/49031Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Noel Grandin yazdı
Change-Id: I94369455a965a1382d52e7f99cf1ec1f8af98d07 Reviewed-on: https://gerrit.libreoffice.org/49277Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Markus Mohrhard yazdı
Change-Id: I48cb6f67150aa5aeab97a1aa1c381188c0db9358 Reviewed-on: https://gerrit.libreoffice.org/49287Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
-
Stephan Bergmann yazdı
Observed with UBSan with `soffice --base`, "Finish", "Save", "Tables", "Create Table in Design View...": > include/tools/gen.hxx:485:37: runtime error: signed integer overflow: 288 + 9223372036854775803 cannot be represented in type 'long' > #0 0x7fe2d7f827dd in tools::Rectangle::Rectangle(Point const&, Size const&) include/tools/gen.hxx:485:37 > #1 0x7fe2d7f73833 in BrowseBox::ImplFieldRectPixel(long, unsigned short) const svtools/source/brwbox/brwbox1.cxx:2039:12 > #2 0x7fe2d7f57d46 in BrowseBox::GetFieldRectPixel(long, unsigned short, bool) const svtools/source/brwbox/brwbox1.cxx:1977:29 > #3 0x7fe2d7f42bdb in BrowseBox::GetFieldRect(unsigned short) const svtools/source/brwbox/brwbox1.cxx:2068:12 > #4 0x7fe2d7f4502b in BrowseBox::SetColumnWidth(unsigned short, unsigned long) svtools/source/brwbox/brwbox1.cxx:542:19 > #5 0x7fe2d7f48d18 in BrowseBox::AutoSizeLastColumn() svtools/source/brwbox/brwbox1.cxx:633:9 > #6 0x7fe2d7fd299c in BrowseBox::Resize() svtools/source/brwbox/brwbox2.cxx:537:5 > #7 0x7fe2d807ee7a in svt::EditBrowseBox::Resize() svtools/source/brwbox/editbrowsebox.cxx:1095:20 > #8 0x7fe2cdbe5711 in vcl::Window::ImplCallResize() vcl/source/window/event.cxx:522:5 > #9 0x7fe2ce1c8f71 in vcl::Window::Show(bool, ShowFlags) vcl/source/window/window.cxx:2261:13 > #10 0x7fe25d27b58f in dbaui::OTableDesignView::initialize() dbaccess/source/ui/tabledesign/TableDesignView.cxx:199:22 > #11 0x7fe25d23403b in dbaui::OTableController::impl_initialize() dbaccess/source/ui/tabledesign/TableController.cxx:519:20 > #12 0x7fe25c3dd649 in dbaui::OGenericUnoController::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) dbaccess/source/ui/browser/genericcontroller.cxx:270:9 > #13 0x7fe25c3361cd in DBContentLoader::load(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XLoadEventListener> const&) dbaccess/source/ui/browser/dbloader.cxx:270:19 > #14 0x7fe28521412a in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1101:23 > #15 0x7fe285209e0a in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:375:20 > #16 0x7fe28520738b in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:161:14 > #17 0x7fe285332ba8 in (anonymous namespace)::Frame::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/frame.cxx:589:12 > #18 0x7fe285349f7d in non-virtual thunk to (anonymous namespace)::Frame::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/frame.cxx > #19 0x7fe25cba4dae in dbaui::DatabaseObjectView::doDispatch(comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:140:41 > #20 0x7fe25cba3514 in dbaui::DatabaseObjectView::doCreateView(com::sun::star::uno::Any const&, rtl::OUString const&, comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:97:16 > #21 0x7fe25cba667c in dbaui::TableDesigner::doCreateView(com::sun::star::uno::Any const&, rtl::OUString const&, comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:233:40 > #22 0x7fe25cba2fec in dbaui::DatabaseObjectView::createNew(com::sun::star::uno::Reference<com::sun::star::sdbc::XDataSource> const&, comphelper::NamedValueCollection const&) dbaccess/source/ui/misc/databaseobjectview.cxx:79:16 > #23 0x7fe25c07bdfe in dbaui::OApplicationController::newElement(dbaui::ElementType, comphelper::NamedValueCollection const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent>&) dbaccess/source/ui/app/AppController.cxx:1968:40 > #24 0x7fe25c076546 in dbaui::OApplicationController::Execute(unsigned short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) dbaccess/source/ui/app/AppController.cxx:1223:25 > #25 0x7fe25c3ef474 in dbaui::OGenericUnoController::executeChecked(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) dbaccess/source/ui/browser/genericcontroller.cxx:1061:13 > #26 0x7fe25c1dd91a in dbaui::OCreationList::onSelected(SvTreeListEntry const*) const dbaccess/source/ui/app/AppDetailView.cxx:309:81 > #27 0x7fe25c1e0de9 in dbaui::OCreationList::MouseButtonUp(MouseEvent const&) dbaccess/source/ui/app/AppDetailView.cxx:275:9 > #28 0x7fe2ce263026 in ImplHandleMouseEvent(VclPtr<vcl::Window> const&, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) vcl/source/window/winproc.cxx:711:25 > #29 0x7fe2ce298c14 in ImplHandleSalMouseButtonUp(vcl::Window*, SalMouseEvent const*) vcl/source/window/winproc.cxx:1994:12 > #30 0x7fe2ce27c59c in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) vcl/source/window/winproc.cxx:2329:20 > #31 0x7fe29bebd05a in SalFrame::CallCallback(SalEvent, void const*) const vcl/inc/salframe.hxx:275:29 > #32 0x7fe29be5cfad in GtkSalFrame::CallCallbackExc(SalEvent, void const*) const vcl/unx/gtk3/gtk3gtkframe.cxx:4318:16 > #33 0x7fe29be755ac in GtkSalFrame::signalButton(_GtkWidget*, _GdkEventButton*, void*) vcl/unx/gtk3/gtk3gtkframe.cxx:2620:16 > #34 0x7fe29b2a4a7a (/lib64/libgtk-3.so.0+0x233a7a) > #35 0x7fe2f60c373c in g_closure_invoke (/lib64/libgobject-2.0.so.0+0xf73c) > #36 0x7fe2f60d64dd (/lib64/libgobject-2.0.so.0+0x224dd) > #37 0x7fe2f60de69e in g_signal_emit_valist (/lib64/libgobject-2.0.so.0+0x2a69e) > #38 0x7fe2f60df66e in g_signal_emit (/lib64/libgobject-2.0.so.0+0x2b66e) > #39 0x7fe29b3efcd3 (/lib64/libgtk-3.so.0+0x37ecd3) > #40 0x7fe29b2a1a4d (/lib64/libgtk-3.so.0+0x230a4d) > #41 0x7fe29b2a3b6f in gtk_main_do_event (/lib64/libgtk-3.so.0+0x232b6f) > #42 0x7fe29adb1304 (/lib64/libgdk-3.so.0+0x37304) > #43 0x7fe29ae0ddf1 (/lib64/libgdk-3.so.0+0x93df1) > #44 0x7fe2f5deab76 in g_main_context_dispatch (/lib64/libglib-2.0.so.0+0x4ab76) > #45 0x7fe2f5deaf1f (/lib64/libglib-2.0.so.0+0x4af1f) > #46 0x7fe2f5deafab in g_main_context_iteration (/lib64/libglib-2.0.so.0+0x4afab) > #47 0x7fe29bcbdbca in GtkSalData::Yield(bool, bool) vcl/unx/gtk3/gtk3gtkdata.cxx:459:31 > #48 0x7fe29bccd0d2 in GtkInstance::DoYield(bool, bool) vcl/unx/gtk3/../gtk/gtkinst.cxx:410:29 > #49 0x7fe2cf6a65e3 in ImplYield(bool, bool) vcl/source/app/svapp.cxx:469:48 > #50 0x7fe2cf68ef1b in Application::Yield() vcl/source/app/svapp.cxx:534:5 > #51 0x7fe2cf68eda3 in Application::Execute() vcl/source/app/svapp.cxx:449:9 > #52 0x7fe2f7e1eef8 in desktop::Desktop::Main() desktop/source/app/app.cxx:1622:17 > #53 0x7fe2cf6d8687 in ImplSVMain() vcl/source/app/svmain.cxx:194:35 > #54 0x7fe2cf6e1f7f in SVMain() vcl/source/app/svmain.cxx:232:16 > #55 0x7fe2f7f466b4 in soffice_main desktop/source/app/sofficemain.cxx:166:12 > #56 0x42a83c in sal_main desktop/source/app/main.c:48:15 > #57 0x42a816 in main desktop/source/app/main.c:47:1 > #58 0x7fe2f67a6009 in __libc_start_main (/lib64/libc.so.6+0x21009) > #59 0x402e69 in _start (instdir/program/soffice.bin+0x402e69) Change-Id: I6a92a87b481396955cfc1f21bf88e2f0ad9cea9f Reviewed-on: https://gerrit.libreoffice.org/49279Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Andrea Gelmini yazdı
Change-Id: Ifb3aa4f79b9accc34b2010b762e596fadae9fd09 Reviewed-on: https://gerrit.libreoffice.org/49297Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
-
Julien Nabet yazdı
Change-Id: I957fb399fd1dc630c9a6bdcffe530921eaf66e2d Reviewed-on: https://gerrit.libreoffice.org/49278Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Michael Stahl yazdı
Change-Id: I7b0febee10a98809073f0bfd023d39d32684a566
-
Noel Grandin yazdı
just use a std::vector<std::pair<Point,PolyFlags>> Change-Id: I85de832af9095a33bda1620781c3b231a345e07c Reviewed-on: https://gerrit.libreoffice.org/49275Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I48f52056dcf17a568266be49f7422fa05be974db Reviewed-on: https://gerrit.libreoffice.org/49274Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Michael Stahl yazdı
Change-Id: Ibd308d94c7cd92ab5e2590554b54517d2ef898fe
-
Noel Grandin yazdı
Change-Id: Ie16963e2b3b9d85d5640f03daa487dbe231af4a1 Reviewed-on: https://gerrit.libreoffice.org/49272Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Julien Nabet yazdı
So let's replace all " with " in the retrieved html Change-Id: I4a90ecc51e7ce6d1e080e6c1b17b82fe9a29d65e Reviewed-on: https://gerrit.libreoffice.org/49179Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Bartosz Kosiorek yazdı
Functions SUMIFS, AVERAGEIFS, COUNTIFS, MINIFS, MAXIFS were not supported External references. The root cause issue, was using PopMatrix() method for: svExternalSingleRef and svExternalDoubleRef. PopMatrix() method only supports svMatrix, and in other cases returns FormulaError::IllegalParameter error. To resolve that issue, the method GetMatrix() was used. It is properly support svMatrix, svExternalSingleRef and svExternalDoubleRef. Change-Id: I3e30ca50069264a6d990b16ec668e6d0df51c6e6 Reviewed-on: https://gerrit.libreoffice.org/49264Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
-
Jim Raykowski yazdı
Change-Id: I5b20fd1bf97fed1d6c787ea27100244b86e56524 Reviewed-on: https://gerrit.libreoffice.org/49262Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-