Change-Id: If2315987d2447b1a44f3e62384f03d2621be7106
Reviewed-on: https://gerrit.libreoffice.org/53455Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>

Change-Id: I771150d447f0e7799f511cf28c71f6adcde64f5d
Reviewed-on: https://gerrit.libreoffice.org/53420Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I727171251964eaf7a14595abaaa2d08fb783258c
Reviewed-on: https://gerrit.libreoffice.org/53419Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Call SalLayout::GetNextGlyphs with one glyph at a time while collecting
glyphs to draw, which allows us to simplify the code a bit and helps
simplify my next patch.

Change-Id: I5c9ddb7469301d8fbc6a15695c01af7b0879685a
Reviewed-on: https://gerrit.libreoffice.org/53384Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

as we have files with spaces now. E.g.
grep: /data/rene/git/LibreOffice/master/debian/tmp/usr/lib/libreoffice/help/media/icon-themes/svx/res/symphony/enlarge: No such file or directory
grep: font.png: No such file or directory
happens otherwise.

Change-Id: I13f8cab2aac751f7a0c2f673b5e958ed08657d52

Found by searching for the header names and the localization functions:
git grep -l -e \<svx/dialmgr.hxx\> -e \<svx/strings.hrc\> -e svdglob.hxx |
xargs grep -c -e SvxResId  -e SvxResLocale -e ImpGetResStr | grep :0$ | grep -v /pch

Change-Id: I45c979589165086288030031e713d536005a9833
Reviewed-on: https://gerrit.libreoffice.org/53241Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Also check for not needed forward declarations.

Change-Id: I92759f3f40d9458fd192665b39b87a78d8b97e5a
Reviewed-on: https://gerrit.libreoffice.org/53418Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

after
    commit bbf134a2
    Date:   Tue Apr 24 13:36:34 2018 +0200
    SvTabListBox::SetTabs, pass count explicit

Change-Id: Iea41aa1c4708b6486ba9a306d3b9d02846e23d7a

Defining backend separately allows e.g. creating ADMX templates with
easy-to-use UI, where user defines only LDAP names for the setting, and
doesn't need to type the LO configuration backend name.

Change-Id: I64f23043c94a5a4e0ba7281d0f711a427d694126
Reviewed-on: https://gerrit.libreoffice.org/53413Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I0a20e7d3816714e42d6863fff27734dd08ae24ae
Reviewed-on: https://gerrit.libreoffice.org/53357Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This reverts commit eeefb8c4.

this was pushed in error

after
    commit dbb1dbe7
	Date:   Mon Apr 23 15:23:08 2018 +0200
    loplugin:useuniqueptr in X11SalData

Change-Id: I6398fd79b9190654258d60628952aa89dcd5898c

Change-Id: I408f9193680ea73c61fcfb2bd1e860152219702c

passing count as first element in array, dodgy.

Change-Id: I49905b554b3b4d6cc3fa419a36389cd2e5ded463

Change-Id: Ic6f1a018b4d0016af5a19052ef46ea87c7923acb
Reviewed-on: https://gerrit.libreoffice.org/53416Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I827e997391834d10a617b7c5be8ceafc19e97219
Reviewed-on: https://gerrit.libreoffice.org/53343Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idad3c18c57e4ae4121505a0bd9761f8569685e33
Reviewed-on: https://gerrit.libreoffice.org/53358Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idb210207112994e1247c35e0dce1c6cd2f80f371
Reviewed-on: https://gerrit.libreoffice.org/53365Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

regression from
	commit 5d0e485e
	use actual UNO enums in reportdesign..svtools

Also make some of the "template<> set" property helpers only fire on
actual property change

Change-Id: I930fd255d287c3c7e5b064823fd1e8d4b665eae0
Reviewed-on: https://gerrit.libreoffice.org/53412Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic9853c967cdc36b1bf919a4914b04bf6752f0834
Reviewed-on: https://gerrit.libreoffice.org/53374Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I61a6d5cc5690a2899986ec831655e480a1f414d1
Reviewed-on: https://gerrit.libreoffice.org/53360Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7c70f9c590dd63cca1dce16ce184fc7e14922de2
Reviewed-on: https://gerrit.libreoffice.org/53353Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Using nested install is bad because (1) MS advises against it (though it
most possibly doesn't relate to our specific case, when we install the
vc redist exe package in UI part, so actually only a single MSI session
is active at any time); (2) because it adds some extra interactions
(user sees something "unrelated" being installed, which raises concerns;
additional admin authentication required); and (3) because it runs in
InstallUISequence, thus only installing the UCRT when doing interactive
installation (unattended installs, including GPO, need to install UCRT
separately).

This patch aims to incorporate the original UCRT MSU (Windows Update)
packages (https://support.microsoft.com/en-us/help/2999226) available as
a zip archive from
https://www.microsoft.com/en-us/download/details.aspx?id=48234
- the same as used in VC redists for VS 2015 and 2017. This obsoletes
the separate installation of the redist; since we also have the redist
as merge module in our MSI, that is enough (and removes redundancy).
The MSUs are installed using wusa.exe in a custom action (deferred,
non-impersonating).

As a small bonus, embedding MSUs instead of redist EXE allows us to
shrink the size of installer a little (~10 MB).

As deferred custom actions cannot access current installer database,
we workaround this by using initial immediate impersonating action to
extract the binaries into a temporary location. To ensure that the file
gets removed upon completion (both successful and failed), we use an
additional cleanup action.

Commit 61b1d631 is effectively reverted.

Change-Id: I1529356fdcc67ff24b232c01ddf8bb3a31bb00bd
Reviewed-on: https://gerrit.libreoffice.org/52923Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

they are then aggregated to the other and passed to the function

Change-Id: I158a747de9c22d50716fc066074a593b4928d6bf
Reviewed-on: https://gerrit.libreoffice.org/53424Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I6e7af6e6178f3820a73bae6008d8046161a0d8a5
Reviewed-on: https://gerrit.libreoffice.org/53425Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

... since otherwise gbuild doesn't understand it and (e.g.) make odk.clean fails

Change-Id: Ie6098bcf1ff99ee1a5df5fd5219d3b3c82075f71

Change-Id: Ib84ee30c21a0b9ac09d80cf4aa8898ad5d1d12e5
Reviewed-on: https://gerrit.libreoffice.org/53367Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ia8a541b3d1e1f27c493ba371d970bfff3a893ae2

GooString became const...

Change-Id: Icc95be2e8603a4e22c6a9ac2008986bacd0bfba5

... since archs with the "Zero VM" take loooong otherwise and eventually
gets killed after 150 minutes of "inactivity" (no output)

Change-Id: If421378920c791fdc5d165cc452bdd40e136c8d1

We assume the SolarMutex is always taken when doing GL calls, but
putting DBG_TESTSOLARMUTEX() into WinOpenGLContext::makeCurrent()
pointed out two places in the persona code where this invariant wasn't
hold, fix those.

Opening the dialog and downloading previews of one category, then
clicking on an other button to download previews of an other category no
longer results in a crash while calling glBindFramebuffer() with this.

Change-Id: Ib8148a709f89c2dc44da102e2023cc61ba890744
Reviewed-on: https://gerrit.libreoffice.org/53414Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

and text is nullptr, seeing as an end G_MAXINT translates to str len,
assume the same for start

Change-Id: I76b8bb0e66694129d36bbe08a6d55fc434f3434f
Reviewed-on: https://gerrit.libreoffice.org/53376Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

All labels located in the L10N module receive their german counterpart.
Thanks to Gisbert Friege.

Change-Id: I472b0b86f1e7745c09f6ec4960c9846cacbdfd09

Change-Id: I33cab261f107ed29e36d0093a87ffc3a2de21a54
Reviewed-on: https://gerrit.libreoffice.org/53361Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  395b1815dc3f2f21302e3858357c6cf16a449ab2

Formatting in help text, further corrections.

Change-Id: I7950ef7267129d111bb5c63fc9b962fd80e13131
Reviewed-on: https://gerrit.libreoffice.org/53385Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Project: help  8763bde02f185447ab6133d8107be090bb4fc012

Review some outdated text in the Access2Base help page

Change-Id: I61c4b9f4b66750eab2e5724add50865719b13576
Reviewed-on: https://gerrit.libreoffice.org/53382Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I15a0626bcbeaea8e74455526bf485c8eb617e74e
Reviewed-on: https://gerrit.libreoffice.org/53359Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6f933b54c11a4939870c3a788a4928f2d6f12850
Reviewed-on: https://gerrit.libreoffice.org/53349Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: translations  e3802bb90081c3cc63ca8ec9726772d8e42299b0

Updated Slovenian translation

Change-Id: I999a9807259234ebfd080b070035ea5bcbc4b170