Change-Id: I4296d1cf5058be359ffed46745673cf26eba3375
Reviewed-on: https://gerrit.libreoffice.org/30479Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

It was only assigned to. Some follow-up simplification.

Change-Id: I3b522064e946667d3a4c8fb82ee40bd0d44dd569

Change-Id: I952dd39559cff18dc7850b62915405954eac2fd7

No need to have a comment saying 'write signatures' when calling a
function that is called WriteSignature(). (Actually, the function name
is slightly misleading, as it says 'signature' in singular while what
it actually does is write multiple signatures, if present.)

Also drop some leftover comments that were related to code that was
commented out already in 2004 or 2007 and removed completely in 2010.

Change-Id: I7a53b3eabb81fc03c66e746f78267be4c1751b0f

Change-Id: I88204bca60dd1e299b040c52bc87e500cbfaa930
Reviewed-on: https://gerrit.libreoffice.org/30519Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8b49b74622bf4d671d640e4cd06dc2da348ee222
Reviewed-on: https://gerrit.libreoffice.org/30478Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I07a9d7fe837c18e66b4a2a57186f1f9b0d44daee

Change-Id: I710f8ba31b6f780e3fb1d174d9ea21f270f55264

Change-Id: Ibca8ceedd8c01b4d12ccd9c29838f545fc234347

With eea709f6 "poppler: build against
libjpeg" the poppler internal JPEG code is no longer used.

Change-Id: I018a53a495ec505af92bb9b1c1a0c42e0a4f35b8

keep the move window to monitor code, so under X, gnome#773857 isn't
a problem

when gnome#772525 fix is available this presumably will then work under
wayland

Change-Id: I50cfe7ede8a4f1404c26d174ef3c5bb920eb5044

Change-Id: Icc0ead769fa0a052f7d4dfbc825c96dbb513b33f

Change-Id: I572b83949c7e643536b7d62567760546509e4d9f
Reviewed-on: https://gerrit.libreoffice.org/30514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Commit d9dca1ee (tdf#102308 sw: improve
redline timestamp precision) improved the manage changes dialog to show
seconds of the redline timestamps, do the same with tooltips, when the
mouse is hovered over a redline portion.

Change-Id: I6ec42db49cb93d8bce0cdee02e37d871f8e7e2ce
Reviewed-on: https://gerrit.libreoffice.org/30515Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

This partially reverts commit 8e8a88ec
"loplugin:unusedfields".

Change-Id: Id95a46374ed2b35e05dc32a8759e5db01829f050

All the catch blocks for classes derivved from uno::Exception
contained the same single statement as the catch block for
uno::Exception itself.

Change-Id: Ic33b432416abfda7557862d25237dc7221585327

The timestamp isn't extracted yet, but the digest match is already
checked correctly and the certificate is exposed.

Change-Id: Ieca002a5c4ca0b96f4dc397c460adb7f88f5ffc7
Reviewed-on: https://gerrit.libreoffice.org/30499Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I4ebdca6a7d09a228122842a79b217ac2611a7c06

Regression from 4f1dca50

Change-Id: I7b7f3594499cd049ae59064da244e3f82dff7757
Reviewed-on: https://gerrit.libreoffice.org/28617Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Change-Id: Ie5efebfe4df73adca51638c85ba52e7901eac139
Reviewed-on: https://gerrit.libreoffice.org/30182Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

This reverts commit fa80dae9.

because current Clang master complains with

/home/noel/libo3/svl/source/items/itemset.cxx:189:26: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]
        va_start( pArgs, nNull );
                         ^
/home/noel/libo3/svl/source/items/itemset.cxx:176:89: note: parameter of type 'sal_uInt16' (aka 'unsigned short') is declared here
SfxItemSet::SfxItemSet(SfxItemPool& rPool, sal_uInt16 nWh1, sal_uInt16 nWh2, sal_uInt16 nNull, ...)

Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30511Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ief4a9dfc0e0a2dad04c3ac9f1840b823fd9357de
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30507Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Which IDs are always sal_uInt16 and likely passed from defines

Change-Id: I134358289ccd338ef1ff6ba963e25a524e790f4e
Reviewed-on: https://gerrit.libreoffice.org/30498Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1b88d98e00415e9c32a48486912d577a00fbfbda
Reviewed-on: https://gerrit.libreoffice.org/30486Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If34bc1d5ea0e0153991d4891b88550e471b4ec07
Reviewed-on: https://gerrit.libreoffice.org/30489Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7267ffb4ad5c874d6c836a8d6ab823d63f8e2610
Reviewed-on: https://gerrit.libreoffice.org/30488Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found by the singlevalfields loplugin.

Dead as least as far back as
  commit 93a7b558
  Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com>
  Date:   Fri Nov 27 21:16:24 2009 +0100
  [CWS autorecovery] merged SfxTopFrame into SfxFrame
  SfxTopFrame was the only class deriving from the abstract class SfxFrame, so both
  can effectively be treated as one class.

Arguably when that commit was done, SfxFrame should also have been renamed
to SfxTopFrame, since that it was it now seems to be.

Expanding the nullptr value off that field means that:
    SfxFrame::GetTopFrame
       always return this
    SfxFrame::IsParent
       always returns false
    SfxViewFrame::GetTopFrame
       is now the same as SfxViewFrame::GetFrame
    SfxViewFrame::GetParentViewFrame
       now returns null

Change-Id: Iac088fa485c3d7299d1553845ced2f5ced3c85f2
Reviewed-on: https://gerrit.libreoffice.org/30485Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If64c3a1dbb27e85e2562cca78b608250b7e90c6d
Reviewed-on: https://gerrit.libreoffice.org/30480Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: Iaf873fc8b5ca673d5e829be33074dffd8680ae03
Reviewed-on: https://gerrit.libreoffice.org/30452Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

This reverts commit 39501668.

Change-Id: Ie22a99885a23d44a9870fcd286bee4ccf10c53ac
Reviewed-on: https://gerrit.libreoffice.org/30505Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

It has been commented out since creation in 2004.

Change-Id: I25ff3ff953430ecbb84fecd3228e662a9c3e1276

poppler uses both windows.h and jpeg headers, so runs into the conflict
between Win32 definitions of boolean, INT16, INT32, and jpeg's.

Tweak jpeg-turbo headers so it uses the Win32 definitions.

Change-Id: I2dc2b35a8d08d521c95494e528c1e47ccbfc390a

The Y sign should be reversed to match VCL, apparently it was either
unused on macOS before CommonSalLayout or it was wrong all along.

This was the source of CppunitTest_svgio failure on macOS with
CommonSalLayout.

Change-Id: I3108aab7b6780c912e86e5591ca0f41ea437137b

Change-Id: I37e614f6dfa0778cb126a6de282921a15417af1c

Change-Id: Id7e968170a038d9316503ee796cfd6a99e9fc3ae

Change-Id: I5f9c8011a43e2b15b9b2f58772f6f08ad103f4aa

Albert Astals Cid points out that --disable-libjpeg causes poppler to
use internal JPEG code instead, which is not actively maintained.

Add LIBJPEG_CFLAGS / LIBJPEG_LIBS to config_host.mk and patch poppler to
respect LIBJPEG_LIBS.

Change-Id: Id19a62a9bd9dc41fee5e8e43e2798e515aacc299
Reviewed-on: https://gerrit.libreoffice.org/30496Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Iaaa3363f315eb88f3be48e29bb82917695c3cfe0

Change-Id: Ia414b02c52f73724df6829431d090a18e76baa68