Change-Id: Idd0cdd38718c3822db4d4b94ca2315a416bc27bb
Reviewed-on: https://gerrit.libreoffice.org/50997Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

part of making BitmapWriteAccess an internal feature of vcl

Change-Id: Iee94f47e120d82a23e57342952d04e9b2792cd1a
Reviewed-on: https://gerrit.libreoffice.org/50999Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

mainly by using for-range loops
but also by simplifying some simple algo

Change-Id: If04cd78e62f80f9575e24f3d50ff1e427454da79
Reviewed-on: https://gerrit.libreoffice.org/51019Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Project: help  ee1caf534c5b421dfc2157d8421f6dcc051ca5e3

This is what was actually meant since commit 32e04637f0; mea culpa

Change-Id: I8ee78ace54a124b3cf6412d2f9e41267eadfa9b4

Change-Id: Id08ee261ae06673809fcf8581e2490ecd957891f
Reviewed-on: https://gerrit.libreoffice.org/51011Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ie68ccfa8d802bb284da8bb4af69882f4b66a3dac
Reviewed-on: https://gerrit.libreoffice.org/51010Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I559f25ee99f7b8b49545390479cbb06d3c601d3c
Reviewed-on: https://gerrit.libreoffice.org/50982Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

at least Linux-rpm_deb-x86@71-TDF tinderbox was having a hiccup:

> /tinderbox/buildslave/build/workdir/CxxObject/sd/source/ui/func/fuinsert.o: In function `weld::DialogController::run()':
> /tinderbox/buildslave/source/libo-master/include/vcl/weld.hxx:551: undefined reference to `weld::MessageDialogController::getDialog()'

Change-Id: Ib05808a7a283b5aad7329a82c0de3125db4f8506
Reviewed-on: https://gerrit.libreoffice.org/51018Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I59f1f2e83ecec5b2f7aa57255a52c99794d27596
Reviewed-on: https://gerrit.libreoffice.org/51002Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

These were no longer used in the code.
This should help me in identifying obsolete and missing HIDs in helpcontent.

Found by this somewhat sophisticated method:

for mod in  $(find -name helpids.h) ; do
echo $mod;
for i in $(grep ^#define "$mod" | cut -d " " -f2 ) ; do
if [ $(git grep -c "$i" $(echo "$mod" | cut -d "/" -f 2 ) | wc -l) -eq 1 ] ; then
echo "$i";
fi ;
done
done

Change-Id: Iaf8179322419ce51175bc5a42fedec0add8c5241
Reviewed-on: https://gerrit.libreoffice.org/50680Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ia900636d4013ab2a9c893c8246391db867fe1543
Reviewed-on: https://gerrit.libreoffice.org/51017Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I239a6024131a0e659d1723085af3cb7fb64b17cc
Reviewed-on: https://gerrit.libreoffice.org/51013Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

solved unused parameter referer in case of !HAVE_FEATURE_DESKTOP

Change-Id: I64e2707ad87822ba784ed40c45801c6d101e6386

Change-Id: I33813be65bcb44c11a35bc97d963057418a28d9e
Reviewed-on: https://gerrit.libreoffice.org/50984Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

At least in ReqIF mode, where <img> is not part of the allowed subset.
(Freeware validator for that subset is at
<https://reqif.academy/library/software/consequent-command-line/>.)

Change-Id: Iecc2645c5fbd35cc52096a25a797df0594b47d4f
Reviewed-on: https://gerrit.libreoffice.org/51009Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Project: help  0ddb36aafd052ca3a10c4a873f6a7b5ccf0f9c82

Drop undefined navigator property

Change-Id: I42a37211bfc6d6e3b91061593f252feb6c38a8b6
Reviewed-on: https://gerrit.libreoffice.org/50782Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  3f82ba1d59d3bf4aa5e347f8dfb76f79ffd68bb0

tdf#72038 Improve number format recognition help

Change-Id: I403d2021114f432d85dd2915ca8722c04acb50a3
Reviewed-on: https://gerrit.libreoffice.org/50976Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

...so standard libraries in debug mode can catch out-of-bounds element acces

Change-Id: I519795f5fcb51f243312e5d0247998eff6ceb151
Reviewed-on: https://gerrit.libreoffice.org/51008Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I73e9a29abd5d767b31850e9a6b1f2b8d757ee928
Reviewed-on: https://gerrit.libreoffice.org/51000Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I044bb3afa1e134dd851dd30f639b475400f4ceea
Reviewed-on: https://gerrit.libreoffice.org/51006Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ia3d90d521e03ed59312d1603b2cf5e5680b00781
Reviewed-on: https://gerrit.libreoffice.org/51005Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

The previous scheme was:

<object data="..." type="...">
    <object data="..." type="image/png">alternate text</object>
</object>

Support also the case when the inner <object> is standalone, like:

<object data="..." type="image/png">alternate text</object>

Change-Id: I2dec2770ee3c1c538bcf26f6ff12c6e8f5969563
Reviewed-on: https://gerrit.libreoffice.org/51003Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

since...

commit db42098d
Date:   Fri Feb 9 10:47:48 2018 +0200

    use VirtualDevice in ColorFieldControl

    as part of moving use of BitmapWriteAccess inside of vcl/

Change-Id: Id2edd8a7f0246ff710a19ae65ddde776429dabce
Reviewed-on: https://gerrit.libreoffice.org/50994Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

<a> missed the namespace prefix, </a> did not.

Change-Id: I8f50249170c6323d35bbeb856e10a2c93038cdbf
Reviewed-on: https://gerrit.libreoffice.org/50993Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ifa6c871a134cf89bfba71b1049a115cf7c953c42
Reviewed-on: https://gerrit.libreoffice.org/50936Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib15218f1f3bc2867ca0e8daa50a2d4edad4a9d87

Change-Id: I39b055760320abb2575958d525b4db3185a11d4a
Reviewed-on: https://gerrit.libreoffice.org/50990Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I054b02bf860fc3062fd6043e7abf30322e07a9ee
Reviewed-on: https://gerrit.libreoffice.org/50991Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I6c4ea78e8d80b85edc872019c68841705860806c

Tell in the SAL_WARN what apartment mode the thread is in.

It's a bit unclear to me why the code insists on calling this
o2u_attachCurrentThread() function even in cases where it perhaps
should know that it is in the main thread, which has been initialised
as STA by the CoInitialize() in InitSalData().

Change-Id: Ia69e67f8b17ee153d3bcf8ae450d5f413dea2e1a
Reviewed-on: https://gerrit.libreoffice.org/50985Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I12a0b386917af64f489706ab960f11559ac6122a
Reviewed-on: https://gerrit.libreoffice.org/50988Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id09932212f348952fe9fb141dec1b5b13d727a54
Reviewed-on: https://gerrit.libreoffice.org/50989Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

It makes sense to disable a filter, as a temporary security measure,
when there is a 0-day vulnerability in it.

E.g., when 0-day found in AbiWord filter, this config snippet disables it:
<item oor:path="/org.openoffice.TypeDetection.Filter">
    <node oor:name="Filters">
        <node oor:name="AbiWord">
            <prop oor:name="Enabled" oor:finalized="true">
                <value>false</value>
            </prop>
        </node>
    </node>
</item>

Change-Id: I8b84250c7e4aac3555877d23f58ed13a2210ebfc
Reviewed-on: https://gerrit.libreoffice.org/50961Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I0cfa88efe03e8018513e2cce49ab9db63fe976d0

Change-Id: I4b2d6e243d65d83d32452a3720fa3d94a76b1dfe
Reviewed-on: https://gerrit.libreoffice.org/50946Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Thanks to Antti Levomäki and Christian Jalio from Forcepoint.

Change-Id: I0aac834a60224b33e5d33d08abd7fb056ef9d52a
Reviewed-on: https://gerrit.libreoffice.org/50973Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Thanks to Antti Levomäki and Christian Jalio from Forcepoint.

Change-Id: I3098c5d32d8f97dff4c620e054acde1ba1b6adf3
Reviewed-on: https://gerrit.libreoffice.org/50972Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib900a6ee0f3da6cc5b516ec5f6e2fa57d10e37d0
Reviewed-on: https://gerrit.libreoffice.org/50945Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifba65af4820f6a24984f6b3f5ca4f8ecb7acaa6a
Reviewed-on: https://gerrit.libreoffice.org/50983Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I752a2f036791720d12fb04b95f53d4127d605c7e
Reviewed-on: https://gerrit.libreoffice.org/50979Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>