1. 13 Kas, 2018 18 kayıt (commit)
    • Noel Grandin's avatar
      loplugin singlevalfields improvement · e3290499
      Noel Grandin yazdı
      checking for casting to void* turns out to mask useful stuff, so
      remove that and just deal with a few extra false+
      
      Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668
      Reviewed-on: https://gerrit.libreoffice.org/63145
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      e3290499
    • Noel Grandin's avatar
      loplugin:singlevalfields in sfx2 · 8709c643
      Noel Grandin yazdı
      Change-Id: I91c092783facc22b6e580631252e7b2dbd80d511
      Reviewed-on: https://gerrit.libreoffice.org/63323
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      8709c643
    • Samuel Mehrbrodt's avatar
      tdf#118568 Use custom image for signing signature line · ba439096
      Samuel Mehrbrodt yazdı
      Change-Id: Ib3c4d2301bf5e68b7c02590a8947ea3a502e7087
      Reviewed-on: https://gerrit.libreoffice.org/63325
      Tested-by: Jenkins
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      ba439096
    • Samuel Mehrbrodt's avatar
      Use shared methods instead of duplicated code · bad21966
      Samuel Mehrbrodt yazdı
      Change-Id: I42836dcd1ef3f95d90e6e8897efff9cab7cc23fd
      Reviewed-on: https://gerrit.libreoffice.org/63276
      Tested-by: Jenkins
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      bad21966
    • Ashod Nakashian's avatar
      LOK: desktop: use correct size when initializing LibreOfficeKitDocument · 6a23a02b
      Ashod Nakashian yazdı
      Change-Id: I0aecc459cf448c03dd8c17a486cc66f541f6868d
      Reviewed-on: https://gerrit.libreoffice.org/63322
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan Holesovsky <kendy@collabora.com>
      6a23a02b
    • Noel Grandin's avatar
      loplugin:singlevalfields in svx · f6b3b696
      Noel Grandin yazdı
      Change-Id: I94d21bb868c54638b843c6abaab370a05ec3471e
      Reviewed-on: https://gerrit.libreoffice.org/63317
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      f6b3b696
    • Andrea Gelmini's avatar
      Update git submodules · 21b0bd63
      Andrea Gelmini yazdı
      * Update helpcontent2 from branch 'master'
        - Fix typo
          
          Change-Id: I134a2c8cfa704a1c79527b6ffeadfe65a2833f85
          Reviewed-on: https://gerrit.libreoffice.org/63319
          Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
          
      21b0bd63
    • Jean-Pierre Ledure's avatar
      Access2Base - tdf#121342 Increase number of recordsets · 6f0dc433
      Jean-Pierre Ledure yazdı
      RecordsetMax attribute of Database object is increased by 1
      at each Recordset opening.
      It is reset to zero at each database opening.
      While the database remains open it is increased without limit.
      Make it a Long type i.o. an Integer one.
      
      Change-Id: Ifc9854cddc1917e4336c0c0c5aa1048623de2a49
      6f0dc433
    • Gabor Kelemen's avatar
      find-unneeded-includes: sort the output · ae245cdd
      Gabor Kelemen yazdı
      Default IWYU output is sorted alphabetically by filename
      
      A more friendly way to present f-u-i information would be
      to sort by line numbers: so that a developer can go through the removal
      proposals in the editor top to bottom, without too much cursor positioning
      in the list of 100 header lines to delete 20 of them.
      
      The result is not perfect, because numbers in text are not naturally sorted:
      line 205 will be listed between 20 and 21; but that's a really rare occasion
      
      Change-Id: I8011321a299a76f5a32469a9d77eb8fcc4521034
      Reviewed-on: https://gerrit.libreoffice.org/63144
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      ae245cdd
    • Miklos Vajna's avatar
      tdf#121203 DOCX import: fix loss of free-form text in date control · 3583f7a1
      Miklos Vajna yazdı
      Date SDT from DOCX is imported as date control since commit
      3ec2d26d (bnc#779630 initial DOCX import
      of w:sdt's w:date, 2013-04-30).
      
      One detail I missed there is our date control is strict: it doesn't
      allow free-form text. However, DOCX date SDT has an optional ISO date,
      but the actual value can be free-form text. This means that importing
      free-form text without an ISO date is lost on import.
      
      Fix the data loss by restricting the creation of the date control: only
      do this if we recognize the date format or in case we have an ISO date.
      Otherwise just show the free-form text to avoid data loss.
      
      Change-Id: I8125bdc749954a6a1c496de74b6682744adb7680
      Reviewed-on: https://gerrit.libreoffice.org/63311
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      3583f7a1
    • Noel Grandin's avatar
      loplugin:singlevalfields in svtools · 630b5db9
      Noel Grandin yazdı
      Change-Id: I6bb8a875f18df3cb7054fa65285eb3cafc1648ac
      Reviewed-on: https://gerrit.libreoffice.org/63316
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      630b5db9
    • Stephan Bergmann's avatar
      tdf#121337: Fail on GIO error in GIO UCP getPropertyValue · ca030879
      Stephan Bergmann yazdı
      Change-Id: I10ffe50be56ed99539f59f043a710863652d2394
      ca030879
    • Samuel Mehrbrodt's avatar
      Related tdf#118581 Use subject name, not issuer name for signature line · b7d0b49f
      Samuel Mehrbrodt yazdı
      And map the gpg user also the the subject name
      
      Change-Id: I1db7b93b6bfc82304924d6ef90db18ff4f97e13c
      Reviewed-on: https://gerrit.libreoffice.org/63278
      Tested-by: Jenkins
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      b7d0b49f
    • Stephan Bergmann's avatar
      Clamp equation values when exporting to binary MS format · 4bf2b136
      Stephan Bergmann yazdı
      CppunitTest_sw_ooxmlexport failed under
      -fsanitize=implicit-signed-integer-truncation when writing 100000 (from the
      triangle equation in oox/source/drawingml/customshapes/oox-drawingml-cs-presets)
      as a 16-bit value (see below), and as discussed at FreeNode #libreoffice-dev:
      
      Nov 12 09:12:32 <vmiklos> sberg: ah, that's custom shape equation, read from
       ooxml but then written to ms binary format; i'm not sure if there is a better
       option there other than just clamping the value.
      Nov 12 09:14:33 <vmiklos> sberg: i would expect that information is 1) used in
       general when writing drawingml+vml markup for a shape (where the vml fallback
       is not read by LO nor by MSO) and 2) i don't expect that our poor vml export
       actually reads those equations. so the vml export builds on top of the binary
       export, but at the end probably that information (equations) is not read by
       anyone
      
      (At least for CppunitTest_sw_ooxmlexport, equation.nPara[1] never needed such
      clamping, just nPara[0] and nPara[2].)
      
      > filter/source/msfilter/escherex.cxx:2929:50: runtime error: implicit conversion from type 'sal_Int32' (aka 'int') of value 100000 (32-bit, signed) to type 'sal_Int16' (aka 'short') changed the value to -31072 (16-bit, signed)
      >  #0 in EscherPropertyContainer::CreateCustomShapeProperties(MSO_SPT, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at filter/source/msfilter/escherex.cxx:2929:50 (instdir/program/libmsfilterlo.so +0x54f1e6)
      >  #1 in ImplEESdrWriter::ImplWriteShape(ImplEESdrObject&, EscherSolverContainer&, bool) at filter/source/msfilter/eschesdo.cxx:283:26 (instdir/program/libmsfilterlo.so +0x67a775)
      >  #2 in ImplEESdrWriter::ImplWriteTheShape(ImplEESdrObject&, bool) at filter/source/msfilter/eschesdo.cxx:932:12 (instdir/program/libmsfilterlo.so +0x69059d)
      >  #3 in EscherEx::AddSdrObject(SdrObject const&, bool) at filter/source/msfilter/eschesdo.cxx:951:35 (instdir/program/libmsfilterlo.so +0x691064)
      >  #4 in oox::vml::VMLExport::AddSdrObject(SdrObject const&, short, short, short, short, bool) at oox/source/export/vmlexport.cxx:1425:15 (instdir/program/libooxlo.so +0x2ab3157)
      >  #5 in DocxSdrExport::writeVMLDrawing(SdrObject const*, SwFrameFormat const&) at sw/source/filter/ww8/docxsdrexport.cxx:772:38 (instdir/program/libmswordlo.so +0x168bfb2)
      >  #6 in DocxSdrExport::writeDMLAndVMLDrawing(SdrObject const*, SwFrameFormat const&, int) at sw/source/filter/ww8/docxsdrexport.cxx:975:9 (instdir/program/libmswordlo.so +0x16938f5)
      >  #7 in DocxAttributeOutput::OutputFlyFrame_Impl(ww8::Frame const&, Point const&) at sw/source/filter/ww8/docxattributeoutput.cxx:5357:57 (instdir/program/libmswordlo.so +0x1371a67)
      >  #8 in AttributeOutputBase::OutputFlyFrame(ww8::Frame const&) at sw/source/filter/ww8/wrtw8nds.cxx:3173:5 (instdir/program/libmswordlo.so +0x1befe5a)
      >  #9 in SwWW8AttrIter::OutFlys(int) at sw/source/filter/ww8/wrtw8nds.cxx:667:41 (instdir/program/libmswordlo.so +0x1beeb70)
      >  #10 in MSWordExportBase::OutputTextNode(SwTextNode&) at sw/source/filter/ww8/wrtw8nds.cxx:2275:42 (instdir/program/libmswordlo.so +0x1c32e4d)
      >  #11 in MSWordExportBase::OutputContentNode(SwContentNode&) at sw/source/filter/ww8/wrtw8nds.cxx:3237:13 (instdir/program/libmswordlo.so +0x1c5c7e4)
      >  #12 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2725:13 (instdir/program/libmswordlo.so +0x1efcdc2)
      >  #13 in DocxExport::WriteMainText() at sw/source/filter/ww8/docxexport.cxx:1453:5 (instdir/program/libmswordlo.so +0x1607d1f)
      >  #14 in DocxExport::ExportDocument_Impl() at sw/source/filter/ww8/docxexport.cxx:514:5 (instdir/program/libmswordlo.so +0x1604baf)
      >  #15 in MSWordExportBase::ExportDocument(bool) at sw/source/filter/ww8/wrtww8.cxx:3206:19 (instdir/program/libmswordlo.so +0x1f3f022)
      >  #16 in DocxExportFilter::exportDocument() at sw/source/filter/ww8/docxexportfilter.cxx:86:17 (instdir/program/libmswordlo.so +0x166b5e3)
      >  #17 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at oox/source/core/filterbase.cxx:489:55 (instdir/program/libooxlo.so +0x1bc3880)
      >  #18 in WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/WriterFilter.cxx:144:23 (instdir/program/libwriterfilterlo.so +0x1a250bf)
      >  #19 in SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2441:25 (instdir/program/libsfxlo.so +0x38d1352)
      >  #20 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1535:19 (instdir/program/libsfxlo.so +0x38c1818)
      >  #21 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&) at sfx2/source/doc/objstor.cxx:2848:39 (instdir/program/libsfxlo.so +0x38f0e90)
      >  #22 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objstor.cxx:2705:9 (instdir/program/libsfxlo.so +0x38ea470)
      >  #23 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objserv.cxx:308:19 (instdir/program/libsfxlo.so +0x38667e3)
      >  #24 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:2969:46 (instdir/program/libsfxlo.so +0x3a3c48e)
      >  #25 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1639:13 (instdir/program/libsfxlo.so +0x3a425d5)
      >  #26 in SwModelTestBase::reload(char const*, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:797:20 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlexport.so +0x364711)
      >  #27 in SwModelTestBase::executeImportExportImportTest(char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:283:9 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlexport.so +0x362d08)
      >  #28 in testTextboxTable::Import_Export_Import() at sw/qa/extras/ooxmlexport/ooxmlexport.cxx:559:1 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlexport.so +0x43c8dd)
      [...]
      
      Change-Id: I21d028af121691d51b053c1bf9e49c656be62b77
      Reviewed-on: https://gerrit.libreoffice.org/63309
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      4bf2b136
    • Stephan Bergmann's avatar
      Silence -fsanitize=implicit-signed-integer-truncation · f4f3e791
      Stephan Bergmann yazdı
      ...as happens during CppunitTest_sw_ooxmlimport2:
      
      > filter/source/graphicfilter/itiff/itiff.cxx:866:29: runtime error: implicit conversion from type 'int' of value 498 (32-bit, signed) to type 'sal_uInt8' (aka 'unsigned char') changed the value to 242 (8-bit, unsigned)
      >  #0 in TIFFReader::ConvertScanline(int) at filter/source/graphicfilter/itiff/itiff.cxx:866:29 (instdir/program/libgielo.so +0x294419)
      >  #1 in TIFFReader::ReadMap() at filter/source/graphicfilter/itiff/itiff.cxx:695:19 (instdir/program/libgielo.so +0x292291)
      >  #2 in TIFFReader::ReadTIFF(SvStream&, Graphic&) at filter/source/graphicfilter/itiff/itiff.cxx:1597:32 (instdir/program/libgielo.so +0x2ac5c5)
      >  #3 in itiGraphicImport at filter/source/graphicfilter/itiff/itiff.cxx:1673:28 (instdir/program/libgielo.so +0x2af1ed)
      >  #4 in GraphicFilter::ImportGraphic(Graphic&, rtl::OUString const&, SvStream&, unsigned short, unsigned short*, GraphicFilterImportFlags, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>*, WmfExternal const*) at vcl/source/filter/graphicfilter.cxx:2031:22 (instdir/program/libvcllo.so +0x684e246)
      >  #5 in GraphicFilter::ImportGraphic(Graphic&, rtl::OUString const&, SvStream&, unsigned short, unsigned short*, GraphicFilterImportFlags, WmfExternal const*) at vcl/source/filter/graphicfilter.cxx:1281:12 (instdir/program/libvcllo.so +0x6845817)
      >  #6 in (anonymous namespace)::GraphicProvider::queryGraphic(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at vcl/source/graphic/UnoGraphicProvider.cxx:418:33 (instdir/program/libvcllo.so +0x623ca3a)
      >  #7 in non-virtual thunk to (anonymous namespace)::GraphicProvider::queryGraphic(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at vcl/source/graphic/UnoGraphicProvider.cxx (instdir/program/libvcllo.so +0x62407e2)
      >  #8 in oox::GraphicHelper::importGraphic(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, WmfExternal const*) const at oox/source/helper/graphichelper.cxx:263:39 (instdir/program/libooxlo.so +0x2b33a1f)
      >  #9 in oox::GraphicHelper::importEmbeddedGraphic(rtl::OUString const&, WmfExternal const*) const at oox/source/helper/graphichelper.cxx:351:24 (instdir/program/libooxlo.so +0x2b370da)
      >  #10 in oox::drawingml::BlipContext::BlipContext(oox::core::ContextHandler2Helper const&, oox::AttributeList const&, oox::drawingml::BlipFillProperties&) at oox/source/drawingml/misccontexts.cxx:154:72 (instdir/program/libooxlo.so +0x23c35e0)
      >  #11 in oox::drawingml::BlipFillContext::onCreateContext(int, oox::AttributeList const&) at oox/source/drawingml/misccontexts.cxx:237:24 (instdir/program/libooxlo.so +0x23c6da4)
      >  #12 in non-virtual thunk to oox::drawingml::BlipFillContext::onCreateContext(int, oox::AttributeList const&) at oox/source/drawingml/misccontexts.cxx (instdir/program/libooxlo.so +0x23c8638)
      >  #13 in oox::core::ContextHandler2Helper::implCreateChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at oox/source/core/contexthandler2.cxx:94:34 (instdir/program/libooxlo.so +0x1b877e4)
      >  #14 in oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at oox/source/core/contexthandler2.cxx:191:12 (instdir/program/libooxlo.so +0x1b8a37c)
      >  #15 in non-virtual thunk to oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at oox/source/core/contexthandler2.cxx (instdir/program/libooxlo.so +0x1b8a3c8)
      >  #16 in writerfilter::ooxml::OOXMLFastContextHandlerWrapper::lcl_createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1908:31 (instdir/program/libwriterfilterlo.so +0x1ade3d6)
      >  #17 in writerfilter::ooxml::OOXMLFastContextHandler::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:208:21 (instdir/program/libwriterfilterlo.so +0x1aa7c37)
      >  #18 in non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx (instdir/program/libwriterfilterlo.so +0x1aa7ed8)
      >  #19 in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) at sax/source/fastparser/fastparser.cxx:439:44 (instdir/program/libexpwraplo.so +0x24df0c)
      >  #20 in sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:1254:21 (instdir/program/libexpwraplo.so +0x24943f)
      >  #21 in (anonymous namespace)::call_callbackStartElement(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:310:18 (instdir/program/libexpwraplo.so +0x240f8e)
      >  #22 in xmlParseStartTag2 at workdir/UnpackedTarball/libxml2/parser.c:9583:6 (instdir/program/libxml2.so.2 +0x6f8f90)
      >  #23 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11342:14 (instdir/program/libxml2.so.2 +0x73005c)
      >  #24 in xmlParseChunk__internal_alias at workdir/UnpackedTarball/libxml2/parser.c:12244:13 (instdir/program/libxml2.so.2 +0x7241ea)
      >  #25 in sax_fastparser::FastSaxParserImpl::parse() at sax/source/fastparser/fastparser.cxx:1061:21 (instdir/program/libexpwraplo.so +0x23e2e4)
      >  #26 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:870:9 (instdir/program/libexpwraplo.so +0x237beb)
      >  #27 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:1377:13 (instdir/program/libexpwraplo.so +0x2528ab)
      >  #28 in writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:503:22 (instdir/program/libwriterfilterlo.so +0x1a69417)
      >  #29 in WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/WriterFilter.cxx:186:24 (instdir/program/libwriterfilterlo.so +0x1a25e0b)
      >  #30 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sfx2/source/doc/objstor.cxx:2251:34 (instdir/program/libsfxlo.so +0x38dc7ff)
      >  #31 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:772:23 (instdir/program/libsfxlo.so +0x38a5979)
      >  #32 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1795:36 (instdir/program/libsfxlo.so +0x3a47e1e)
      >  #33 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:688:28 (instdir/program/libsfxlo.so +0x40c92b0)
      >  #34 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1149:37 (instdir/program/libfwklo.so +0x1521191)
      >  #35 in framework::LoadEnv::startLoading() at framework/source/loadenv/loadenv.cxx:383:20 (instdir/program/libfwklo.so +0x1511b76)
      >  #36 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:169:14 (instdir/program/libfwklo.so +0x150d828)
      >  #37 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:619:12 (instdir/program/libfwklo.so +0x167057e)
      >  #38 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx (instdir/program/libfwklo.so +0x167078a)
      >  #39 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:50:60 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x8f176)
      >  #40 in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:762:23 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlimport2.so +0x1256b1)
      >  #41 in SwModelTestBase::load(rtl::OUString const&, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:717:16 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlimport2.so +0x123fd6)
      >  #42 in SwModelTestBase::executeImportTest(char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:264:13 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlimport2.so +0x1236bf)
      >  #43 in testTdf115094::Import() at sw/qa/extras/ooxmlimport/ooxmlimport2.cxx:226:1 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlimport2.so +0x18e87d)
      [...]
      
      Change-Id: I04bf52ac9ee45d5bfefe2a406d9c601112baeef9
      Reviewed-on: https://gerrit.libreoffice.org/63307
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      f4f3e791
    • Jens Carl's avatar
      tdf#45904 Remove obsolete _XNamed tests · d30d050c
      Jens Carl yazdı
      The _XNamed tests are already written in C++ since commit
      1b973485 for ScDataPilotTableObj.
      
      Change-Id: I877b548678d40916b406ddffdd4f209bfe4c4a8e
      Reviewed-on: https://gerrit.libreoffice.org/63314
      Tested-by: Jenkins
      Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      d30d050c
    • Rizal Muttaqin's avatar
      elementary: Fix non insert table, fix 3D pie chart · 426b57fd
      Rizal Muttaqin yazdı
      Change-Id: I877b548678d40916b406ddffdd4f209bfe4c4a8d
      Reviewed-on: https://gerrit.libreoffice.org/63315
      Tested-by: Jenkins
      Reviewed-by: 's avatarRizal Muttaqin <riz_17_oke@yahoo.co.id>
      426b57fd
    • Rizal Muttaqin's avatar
      elementary & KJ: Add Draw's right clik/context menu icons · 8666a6fb
      Rizal Muttaqin yazdı
      Change-Id: Id3a3241af83f769fc60f67e01c9129d6f4b5c2ad
      Reviewed-on: https://gerrit.libreoffice.org/63282
      Tested-by: Jenkins
      Reviewed-by: 's avatarRizal Muttaqin <riz_17_oke@yahoo.co.id>
      8666a6fb
  2. 12 Kas, 2018 22 kayıt (commit)
    • Christian Lohmaier's avatar
      Update git submodules · 401e6cde
      Christian Lohmaier yazdı
      * Update translations from branch 'master'
        - update translations for master
          
          and force-fix errors using pocheck
          
          Change-Id: I6b444d20d156df4126666efaeb30a0902054362b
          
      401e6cde
    • Stephan Bergmann's avatar
      Silence -fsanitize=implicit-signed-integer-truncation · 32d846dc
      Stephan Bergmann yazdı
      ...as happens during CppunitTest_sc_logical_functions_test (see below), by not
      relying on wrap-around of
      
        nStackBase = sp - pCur->GetParamCount();
      
      during underflow.  (Though I have no idea whether the excited "underflow?!?"
      comment means that underflow is indeed expected and harmless, or rather
      indicates a severe problem elsewhere; at least, it does happen during
      CppunitTest_sc_logical_functions_test as shown below).
      
      > sc/source/core/tool/interpr4.cxx:3965:34: runtime error: implicit conversion from type 'int' of value -2 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65534 (16-bit, unsigned)
      >  #0 in ScInterpreter::Interpret() at sc/source/core/tool/interpr4.cxx:3965:34 (instdir/program/libsclo.so +0xab8f35e)
      >  #1 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) at sc/source/core/data/formulacell.cxx:1866:23 (instdir/program/libsclo.so +0x9bce713)
      >  #2 in ScFormulaCell::Interpret() at sc/source/core/data/formulacell.cxx:1577:13 (instdir/program/libsclo.so +0x9bc4611)
      >  #3 in ScFormulaCell::MaybeInterpret() at sc/source/core/data/formulacell.cxx:2673:9 (instdir/program/libsclo.so +0x9bb04f0)
      >  #4 in ScFormulaCell::GetErrCode() at sc/source/core/data/formulacell.cxx:2912:5 (instdir/program/libsclo.so +0x9beab05)
      >  #5 in ScCellFormat::GetString(ScRefCellValue&, unsigned int, rtl::OUString&, Color**, SvNumberFormatter&, ScDocument const*, bool, bool, bool) at sc/source/core/tool/cellform.cxx:79:59 (instdir/program/libsclo.so +0xa42272b)
      >  #6 in ScColumn::UpdateScriptType(sc::CellTextAttr&, int, mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > >&) at sc/source/core/data/column3.cxx:534:5 (instdir/program/libsclo.so +0x8b81f94)
      >  #7 in ScColumn::GetRangeScriptType(mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<51, sc::CellTextAttr> >, mdds::detail::mtv::event_func>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > >&, int, int, mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > > const&) at sc/source/core/data/column2.cxx:2010:17 (instdir/program/libsclo.so +0x8aa4973)
      >  #8 in (anonymous namespace)::FindEditCellsHandler::operator()(unsigned long, ScFormulaCell const*) at sc/source/core/data/column.cxx:3036:46 (instdir/program/libsclo.so +0x8873d9b)
      >  #9 in std::pair<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::const_iterator, unsigned long> sc::CheckElem<mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>, (anonymous namespace)::FindEditCellsHandler>(mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent> const&, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::const_iterator const&, unsigned long, unsigned long, (anonymous namespace)::FindEditCellsHandler&) at sc/inc/mtvfunctions.hxx:139:13 (instdir/program/libsclo.so +0x8872c89)
      >  #10 in std::pair<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::const_iterator, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::size_type> sc::FindElement2<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>, (anonymous namespace)::FindEditCellsHandler, (anonymous namespace)::FindEditCellsHandler>(mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent> const&, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::size_type, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::size_type, (anonymous namespace)::FindEditCellsHandler&, (anonymous namespace)::FindEditCellsHandler&) at sc/inc/mtvfunctions.hxx:464:37 (instdir/program/libsclo.so +0x88710f5)
      >  #11 in std::pair<mdds::detail::mtv::const_iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::const_iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> >, mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > > >, unsigned long> sc::FindFormulaEditText<(anonymous namespace)::FindEditCellsHandler>(mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent> const&, int, int, (anonymous namespace)::FindEditCellsHandler&) at sc/inc/mtvcellfunc.hxx:139:12 (instdir/program/libsclo.so +0x8827df0)
      >  #12 in ScColumn::HasEditCells(int, int, int&) at sc/source/core/data/column.cxx:3510:9 (instdir/program/libsclo.so +0x88275b3)
      >  #13 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, unsigned short, int) at sc/source/core/data/column2.cxx:823:38 (instdir/program/libsclo.so +0x8aa0056)
      >  #14 in (anonymous namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:115:20 (instdir/program/libsclo.so +0x9fb52dd)
      >  #15 in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, ScProgress*, unsigned long) at sc/source/core/data/table1.cxx:474:5 (instdir/program/libsclo.so +0x9fb4073)
      >  #16 in ScDocRowHeightUpdater::update() at sc/source/core/data/dociter.cxx:2576:33 (instdir/program/libsclo.so +0x8f17a78)
      >  #17 in ScXMLImport::endDocument() at sc/source/filter/xml/xmlimprt.cxx:1806:22 (instdir/program/libsclo.so +0xbd59796)
      >  #18 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:876:36 (instdir/program/libexpwraplo.so +0x237ebc)
      >  #19 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:1377:13 (instdir/program/libexpwraplo.so +0x2528ab)
      >  #20 in SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&) at xmloff/source/core/xmlimp.cxx:484:15 (instdir/program/libxolo.so +0x261ef9d)
      >  #21 in filter::odfflatxml::OdfFlatXml::importer(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XDocumentHandler> const&, com::sun::star::uno::Sequence<rtl::OUString> const&) at filter/source/odfflatxml/OdfFlatXml.cxx:151:26 (instdir/program/libodfflatxmllo.so +0x218fa)
      >  #22 in XmlFilterAdaptor::importImpl(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:180:26 (instdir/program/libxmlfalo.so +0x3ee1f)
      >  #23 in XmlFilterAdaptor::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:316:67 (instdir/program/libxmlfalo.so +0x44f0a)
      >  #24 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sfx2/source/doc/objstor.cxx:2251:34 (instdir/program/libsfxlo.so +0x38d597f)
      >  #25 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:772:23 (instdir/program/libsfxlo.so +0x389eaf9)
      >  #26 in ScBootstrapFixture::load(bool, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned long, rtl::OUString const*) at sc/qa/unit/helper/qahelper.cxx:582:21 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x869b5)
      >  #27 in ScBootstrapFixture::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned long, rtl::OUString const*) at sc/qa/unit/helper/qahelper.cxx:597:12 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x86fa6)
      >  #28 in FunctionsTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sc/qa/unit/functions_test.cxx:35:51 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0xe4e95)
      >  #29 in non-virtual thunk to FunctionsTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sc/qa/unit/functions_test.cxx (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0xe59db)
      >  #30 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x7526d)
      >  #31 in LogicalFunctionsTest::testLogicalFormulasFODS() at sc/qa/unit/functions_logical.cxx:19:5 (workdir/LinkTarget/CppunitTest/libtest_sc_logical_functions_test.so +0x1fd60)
      [...]
      
      Change-Id: Icccfb37c33885d72bff1003b3a8f8505850eb184
      Reviewed-on: https://gerrit.libreoffice.org/63302
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      32d846dc
    • László Németh's avatar
      bump hunspell to 1.7 · a20a2d7e
      László Németh yazdı
      Change-Id: Ia8d1f4831e651b3a8d5115f78e5a5239b56c71c4
      Reviewed-on: https://gerrit.libreoffice.org/63015
      Tested-by: Jenkins
      Reviewed-by: 's avatarLászló Németh <nemeth@numbertext.org>
      a20a2d7e
    • Olivier Hallot's avatar
      Update git submodules · c4ebcb21
      Olivier Hallot yazdı
      * Update helpcontent2 from branch 'master'
        - Fix Help contents, after translators review (3)
          
          Change-Id: Ic43e0c195ec61c8cbdd69494cde41790333c2e94
          Reviewed-on: https://gerrit.libreoffice.org/63312
          Tested-by: Jenkins
      Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          
      c4ebcb21
    • Olivier Hallot's avatar
      Update git submodules · 16398d11
      Olivier Hallot yazdı
      * Update helpcontent2 from branch 'master'
        - Fix Contents, after translators review (2)
          
          Change-Id: Ia1038fbfc054efa457fae5d28d1a2e737dba1d45
          Reviewed-on: https://gerrit.libreoffice.org/63308
          Tested-by: Jenkins
      Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          
      16398d11
    • Olivier Hallot's avatar
      Update git submodules · ed4b3df4
      Olivier Hallot yazdı
      * Update helpcontent2 from branch 'master'
        - Fix contents, after translators review.
          
          Change-Id: I142b6ec74d06d1153675c50079ebda6273e44414
          Reviewed-on: https://gerrit.libreoffice.org/63305
          Tested-by: Jenkins
      Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          
      ed4b3df4
    • Katarina Behrens's avatar
      tdf#119856: thread-proof creating frames and setting menus · 927f58bd
      Katarina Behrens yazdı
      This finally enables opening a new frame and setting its menu from
      an extension, but it is still far from stable, loads of threading
      landmines like this all over the code
      
      Change-Id: Icf4b67796b0669425ecb7c2c142c21e184024534
      Reviewed-on: https://gerrit.libreoffice.org/62737
      Tested-by: Jenkins
      Reviewed-by: 's avatarThorsten Behrens <Thorsten.Behrens@CIB.de>
      927f58bd
    • Katarina Behrens's avatar
      tdf#119856: thread-proof kde5 fpicker execute() and getFiles() · 8fb0881a
      Katarina Behrens yazdı
      so they can be called from extensions
      
      Change-Id: I58b4ee25ef9a58a8d051ffd542119984973095f0
      Reviewed-on: https://gerrit.libreoffice.org/62728
      Tested-by: Jenkins
      Reviewed-by: 's avatarThorsten Behrens <Thorsten.Behrens@CIB.de>
      8fb0881a
    • andreas kainz's avatar
      NB Tabbed draw: Typefix InsertLayer with CapturePoint · 77b5271d
      andreas kainz yazdı
      Change-Id: Ic2e3bfc7986f16fee02d356df3cf0e9fa55ab5a6
      Reviewed-on: https://gerrit.libreoffice.org/63294
      Tested-by: Jenkins
      Reviewed-by: 's avatarandreas_kainz <kainz.a@gmail.com>
      77b5271d
    • andreas kainz's avatar
      NB Tabbed Impress: fix context menu for 3DObject · c740ee1e
      andreas kainz yazdı
      Change-Id: I0b78f3c4ad3c180ddae51cf8d163f6649c42ea67
      Reviewed-on: https://gerrit.libreoffice.org/63296
      Tested-by: Jenkins
      Reviewed-by: 's avatarandreas_kainz <kainz.a@gmail.com>
      c740ee1e
    • Mike Kaganski's avatar
      Update git submodules · fc3b21d9
      Mike Kaganski yazdı
      * Update helpcontent2 from branch 'master'
        - Add usage info about user data
          
          Change-Id: Ib9ba84836dd13e5858eeae4bd24a6e10f7b89319
          Reviewed-on: https://gerrit.libreoffice.org/62938
          Tested-by: Jenkins
      Reviewed-by: 's avatarSophia Schröder <sophia.schroeder@libreoffice.org>
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
          
      fc3b21d9
    • Stephan Bergmann's avatar
      Silence -fsanitize=implicit-signed-integer-truncation · a1f23b1f
      Stephan Bergmann yazdı
      ...as happens during CppunitTest_sw_ww8export (see below), by keeping
      nTableOffset of signed type.
      
      It is beneficial to introduce InsInt16 (internally doing the cast to sal_uInt16)
      instead of casting nTableOffset to sal_uInt16 at the call site, so that
      -fsanitize=implicit-signed-integer-truncation can still warn about bad
      nTableOffset values outside the sal_Int16 range being passed to InsInt16.
      
      > sw/source/filter/ww8/wrtww8.cxx:2392:34: runtime error: implicit conversion from type 'int' of value 67140 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 1604 (16-bit, unsigned)
      >  #0 in WW8AttributeOutput::TableDefinition(std::shared_ptr<ww8::WW8TableNodeInfoInner>) at sw/source/filter/ww8/wrtww8.cxx:2392:34 (instdir/program/libmswordlo.so +0x1f12f98)
      >  #1 in WW8AttributeOutput::TableInfoRow(std::shared_ptr<ww8::WW8TableNodeInfoInner>) at sw/source/filter/ww8/wrtww8.cxx:2058:13 (instdir/program/libmswordlo.so +0x1f06ccf)
      >  #2 in WW8AttributeOutput::EndParagraph(std::shared_ptr<ww8::WW8TableNodeInfoInner>) at sw/source/filter/ww8/ww8atr.cxx:998:13 (instdir/program/libmswordlo.so +0x208fe56)
      >  #3 in MSWordExportBase::OutputTextNode(SwTextNode&) at sw/source/filter/ww8/wrtw8nds.cxx:2966:22 (instdir/program/libmswordlo.so +0x1c4d259)
      >  #4 in MSWordExportBase::OutputContentNode(SwContentNode&) at sw/source/filter/ww8/wrtw8nds.cxx:3237:13 (instdir/program/libmswordlo.so +0x1c5a3b4)
      >  #5 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2725:13 (instdir/program/libmswordlo.so +0x1efa992)
      >  #6 in WW8Export::WriteMainText() at sw/source/filter/ww8/wrtww8.cxx:2845:5 (instdir/program/libmswordlo.so +0x1f2101e)
      >  #7 in WW8Export::StoreDoc1() at sw/source/filter/ww8/wrtww8.cxx:3005:5 (instdir/program/libmswordlo.so +0x1f31acf)
      >  #8 in WW8Export::ExportDocument_Impl() at sw/source/filter/ww8/wrtww8.cxx:3367:5 (instdir/program/libmswordlo.so +0x1f46dd2)
      >  #9 in MSWordExportBase::ExportDocument(bool) at sw/source/filter/ww8/wrtww8.cxx:3206:19 (instdir/program/libmswordlo.so +0x1f3cbf2)
      >  #10 in SwWW8Writer::WriteStorage() at sw/source/filter/ww8/wrtww8.cxx:3545:23 (instdir/program/libmswordlo.so +0x1f50966)
      >  #11 in StgWriter::Write(SwPaM&, SotStorage&, rtl::OUString const*) at sw/source/filter/writer/writer.cxx:511:20 (instdir/program/libswlo.so +0xcc770c4)
      >  #12 in Writer::Write(SwPaM&, SvStream&, rtl::OUString const*) at sw/source/filter/writer/writer.cxx:254:23 (instdir/program/libswlo.so +0xcc6cc1f)
      >  #13 in Writer::Write(SwPaM&, SfxMedium&, rtl::OUString const*) at sw/source/filter/writer/writer.cxx:289:12 (instdir/program/libswlo.so +0xcc6e1cc)
      >  #14 in SwWW8Writer::Write(SwPaM&, SfxMedium&, rtl::OUString const*) at sw/source/filter/ww8/wrtww8.cxx:3562:31 (instdir/program/libmswordlo.so +0x1f513ff)
      >  #15 in SwWriter::Write(tools::SvRef<Writer> const&, rtl::OUString const*) at sw/source/filter/basflt/shellio.cxx:851:28 (instdir/program/libswlo.so +0xc56906f)
      >  #16 in SwDocShell::ConvertTo(SfxMedium&) at sw/source/uibase/app/docsh.cxx:813:27 (instdir/program/libswlo.so +0xd038645)
      >  #17 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1537:19 (instdir/program/libsfxlo.so +0x38c0383)
      >  #18 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&) at sfx2/source/doc/objstor.cxx:2848:39 (instdir/program/libsfxlo.so +0x38ef860)
      >  #19 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objstor.cxx:2705:9 (instdir/program/libsfxlo.so +0x38e8e40)
      >  #20 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objserv.cxx:308:19 (instdir/program/libsfxlo.so +0x38651b3)
      >  #21 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:2969:46 (instdir/program/libsfxlo.so +0x3a3ae5e)
      >  #22 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1639:13 (instdir/program/libsfxlo.so +0x3a40fa5)
      >  #23 in SwModelTestBase::reload(char const*, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:797:20 (workdir/LinkTarget/CppunitTest/libtest_sw_ww8export.so +0x3b3fb1)
      >  #24 in SwModelTestBase::executeImportExportImportTest(char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:283:9 (workdir/LinkTarget/CppunitTest/libtest_sw_ww8export.so +0x3b25a8)
      >  #25 in testN760294::Import_Export_Import() at sw/qa/extras/ww8export/ww8export.cxx:133:1 (workdir/LinkTarget/CppunitTest/libtest_sw_ww8export.so +0x3c556d)
      [...]
      
      Change-Id: I673a96e9f7d2d1bdf40de20f3810c4986c338c93
      Reviewed-on: https://gerrit.libreoffice.org/63301
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      a1f23b1f
    • Takeshi Abe's avatar
      Mythes -> MyThes · eef0f6cd
      Takeshi Abe yazdı
      as seen in its README.
      
      Change-Id: I0fef39484967e9de8dc7076fb3b7a2d0e55c801f
      Reviewed-on: https://gerrit.libreoffice.org/63147
      Tested-by: Jenkins
      Reviewed-by: 's avatarAndras Timar <andras.timar@collabora.com>
      eef0f6cd
    • Bjoern Michaelsen's avatar
      tdf#120115: Dont crash on Footnote/Table undo/redo · e9bf0102
      Bjoern Michaelsen yazdı
      brown paperbag commit:
      
      - for one, we only want to use the anchor format when we dont have
        another one, not the other way around
      - also we want to update the anchor format (not the char format) when it
        tells us so.
      - finally, keep the selected Char and AnchorFormat in Sync between
        SwEndnoteInfo and the underlying DocumentStylePoolManager
      
      Change-Id: Ic599dc1290c4e30d1746e5eefe6fed27b0ccdfe9
      Reviewed-on: https://gerrit.libreoffice.org/63249
      Tested-by: Jenkins
      Tested-by: 's avatarXisco Faulí <xiscofauli@libreoffice.org>
      Reviewed-by: 's avatarBjörn Michaelsen <bjoern.michaelsen@libreoffice.org>
      e9bf0102
    • Stephan Bergmann's avatar
      Missing test dependency · 9c4a7dfe
      Stephan Bergmann yazdı
      Change-Id: I8ce7fab21cf2e6c47c955201eee87e8890b3a47a
      Reviewed-on: https://gerrit.libreoffice.org/63300
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      9c4a7dfe
    • Andrea Gelmini's avatar
      Fix typos · 69b46d7a
      Andrea Gelmini yazdı
      Change-Id: Ibb94b2b16afbcca84dd55ae51fde6fd27afede3a
      Reviewed-on: https://gerrit.libreoffice.org/63297
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      69b46d7a
    • Mike Kaganski's avatar
      tdf#120677: restore treatment of blanks in SwTextGuess::Guess · 4bb28ad2
      Mike Kaganski yazdı
      Before commit 0be3db28, all non-breakable
      spaces were converted to plain spaces in SwTextSlot::SwTextSlot (see
      pInf->SetText call there). The mentioned commit has changed that to allow
      differentiating non-breakable spaces from other types of spaces (related
      to the fix of tdf#115067). This broke following processing of the NBSPs
      when they don't fit to line, causing infinite layout loop leading to OOM.
      
      This allows to restore old behavior to not call the break iterator for
      NBSP by explicitly checking for it.
      
      Change-Id: I36ab06abb66bbe65a5fc542c41e816a9f20a2dcf
      Reviewed-on: https://gerrit.libreoffice.org/63290
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      4bb28ad2
    • Zdeněk Crhonek's avatar
      uitest Writer - Table properties dialog · e4d8c97e
      Zdeněk Crhonek yazdı
      Change-Id: I1706c19c9636ba43f5b64a0691c108b1b76293c2
      Reviewed-on: https://gerrit.libreoffice.org/63299
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      e4d8c97e
    • Tor Lillqvist's avatar
      We need share/liblangtag, too · 4122e029
      Tor Lillqvist yazdı
      Otherwise i18nlantag works weirdly.
      
      Change-Id: Ic5bf2007e586e6bb53a9e89782c2b05f73e348e3
      4122e029
    • Zdeněk Crhonek's avatar
      uitest cleaning 01 · eb9a2231
      Zdeněk Crhonek yazdı
      Change-Id: Iae30d2bef4bba232d5e5a042d1c736e36496ce1c
      Reviewed-on: https://gerrit.libreoffice.org/63298
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      eb9a2231
    • Mike Kaganski's avatar
      tdf#120703 PVS: V560 Properly compare current to cDecimalSepAlt · bc63974e
      Mike Kaganski yazdı
      V560 A part of conditional expression is always false: current == cDecimalSep.
      
      Assuming a copypaste error in commit 21052ba2.
      Compare to a similar case below (line 817).
      
      Change-Id: Iebd84aa8df3e37b9a5e4fdc7ce7a25a0704a260f
      Reviewed-on: https://gerrit.libreoffice.org/63269
      Tested-by: Jenkins
      Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
      bc63974e
    • Noel Grandin's avatar
      fix missing "else" in transliterateBullet · 5b8b72cb
      Noel Grandin yazdı
      ever since
      
          commit f1830339
          Date:   Tue Apr 8 15:07:08 2003 +0000
          INTEGRATION: CWS calc06 (1.2.44); FILE MERGED
      
      not it will make much difference to the logic
      
      found by experimental loplugin:indentation
      
      Change-Id: I2d724ababa1664a87f2822ed8b59f3e3cd50e5e4
      Reviewed-on: https://gerrit.libreoffice.org/63287
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      5b8b72cb