Change-Id: I74a4a126116638aa33193f267e2f86a3c364fbae

Change-Id: I5a0a9cfdac0444beb049bf9e883ffced25500950

Change-Id: I3a5786650e0724f6b6015153df7275851471626c

Change-Id: I1fe77d041a281b14d6af15f25bd06ac78420c608

Change-Id: I39c942e2ce35283761e3b8daa1ae41986a170ca8

Change-Id: I729af592a74aff7c40a5ae5311d8c5aff2ddee04

Change-Id: I09892b8e17aacf32db51764d8fd766603a8542e1

Change-Id: Idcbf27362e13d9f8a71db17c38e93b24fb1fbfc0

Change-Id: I0c2cf72d7e4f736e2e2c3b8b5def920ee79747fe

Change-Id: Iabdc2f4e0b7af49650e07a9035a425f96cd035c7

to the same type

Change-Id: I4d125b7669a89b96785cb60f967352dce5e2e720

Change-Id: I27ddcc842f109eb3defbae425babbb9d98e83c04

Change-Id: I561e8f7ff472d7d2578e30145024405e74088ffc

Change-Id: Iecf7d7de7693432d99dd7d38ad2034a7dbfd4e48

... needed since we accept A:A entire column notation without the need
of a row number being specified.

Change-Id: I84f6a39e213a4b554e0188e73b4acb34c7a98460

Change-Id: If934445fc597015198486445c9d33ad2994d6fee

...and reduction of variable scope

Change-Id: I1fa14c04646bf9faf35de9e54969589be64ea006

...ever since cc316b39 "Port of Lotus Word Pro
filter, by Fong Lin and Noel Power"

Change-Id: Ia060ac0fb631d076fefb168ee96d8d2054634fca

...since previous commit

Change-Id: I439c8d66a826624a3131b56d96ff3fdd030abb28

...ever since cc316b39 "Port of Lotus Word Pro
filter, by Fong Lin and Noel Power"

Change-Id: Ia7eb16a63c53a43f6c57e26aa629f7c9cf7ef089

Although $include <i18nutils/unicode.hxx> compiles on Linux,
it doesn't compile on the Mac without this.

Change-Id: I56eae77b1c293b2348ca1fd7b38b543ea713557d
Reviewed-on: https://gerrit.libreoffice.org/19355Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

...where the "bOk = false" from the leading "if" is always overwritten in the
following check of "bOk = sTableRange == _sUpdateTableName".  The code had been
effectively like that ever since it got introduced with
4ae41a46 "INTEGRATION: CWS dba30," but it looks
broken.  I assume the two checks of "sTableRange == _sUpdateTableName" for
pNode->GetChild(0) and pNode->GetChild(2) shall only be done if the leading "if"
is not hit.  (And one remaining uncertainty is if really only one of those
"sTableRange == _sUpdateTableName" checks needs to be true or if both should be
true for bOk to be true.)

Change-Id: I453690d65326ed67d7a074d4e4783a743a60d454

In 8b9e4e39 "initial import" the assignment to
bCheck was in a for loop that used bCheck in its condition,

  sal_Int32 nPos = m_nStartPos+1;
  for(; aIter != m_pMatrix->end() && bCheck;)
  {
      if(!aIter->isValid())
          ...
      m_pCacheSet->fillValueRow(*aIter++,nPos++);
      bCheck = m_pCacheSet->next();
  }

that loop was then replaced with

  sal_Int32 nPos = m_nStartPos;
  bCheck = fill(aIter,m_pMatrix->end(),nPos,bCheck);

(without further use of bCheck) in 2facbebb
"MWS_SRX644: migrate branch mws_srx644 -> HEAD" (and the braces around

  {
      ORowSetMatrix::iterator aIter(aEnd);
      sal_Int32 nPos = m_nStartPos + 1;
      bCheck = fill(aIter, m_pMatrix->end(), nPos, bCheck);
  }

introduced in 1234d599 "ORowSetCache: overhaul
internals," presumably to limit the scope of that aIter introduced there).

Change-Id: I1cf4a22fbd1b76d524251a82c3ab4e6ca7a9eca1

Change-Id: I5e28e76a084ecdbd60d1599114bb75d7775865d3

Change-Id: I8a2fcaad5806ef204cdac0f6eaac615d50d6d9e8

Given that sd doesn't support find-all yet, this works for normal find
only at the moment (so it may report multiple rectangles, but always a
single match).

Change-Id: I47bd0d0161b9d1dc843bb503f5521f311fc158c4

This gives sd access to the selection rectangles as well (as opposed
only to the document model positions of selections).

Change-Id: Icb903e91f9e868573403b360bbe839705ddf2916

Change-Id: I53ee3002db38cc7d79cd431fc6254fde5427b751
Reviewed-on: https://gerrit.libreoffice.org/19136Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ie0e8aa9928f59f97cdee5c082694f9af474e1473

Change-Id: I75e12841ad6cbf6e15529a3ce2fc75472c846cd2

...so remove these remnants from a time when developers got away with ignoring
warnings and tools/solar.h was considered the center of the universe

Change-Id: I526c6b44fafb98e8400f2ab122dbb7e2bfbb3480

Change-Id: Ic5befe71c9cb4ffa37b3298b269bcd7ef713b937

... setting a control's background color has no effect (until input
field text is changed?)

Could be observed in the pivot table dialog's source range edit when an
invalid range was entered.

Change-Id: Iafb2a9016ac6bd4c020273911d62dd7423ee0458

Change-Id: I0549579f49eb6de8b8460fcf8c70c399294e507d

use case is a desire to enable viewing and setting rounded rectangle radiuses
to an exact known value

Change-Id: I7e6a4db0699076950adf5869a61825159766c46a

Change-Id: I7460e993851335db108a02afe2c147ee57736b0a

Change-Id: I7bede0cb520f446582d01bc0e5f583ddf4655ce0
Reviewed-on: https://gerrit.libreoffice.org/19178Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

...from b630f9a3 "tdf#94386: Unit test stub -
emulates the steps to trigger the bug."

Change-Id: Id845ed86920614c592f891d85e6ee3d1673056f8

(found by clang-analyzer-deadcode.DeadStores)

Change-Id: I27ff1222295a151a7616ed380439b87d27866899

Change-Id: I07745fc47f5d7908c35045e83cb230d4e91a813a